Subject: Re: bug#26343: [PATCH] gnu: audacity: Update to 2.1.3.

From: Marius Bakke <[email-masked]>
Date: Mon, 03 Apr 2017 14:40:10 +0200

Kei Kebreau <[email-masked]> writes:

> Marius Bakke <[email-masked]> writes:
>
>>>      (build-system gnu-build-system)
>>>      (inputs
>>>       ;; TODO: Add portSMF and libwidgetextra once they're packaged.  In-tree
>>> @@ -73,7 +79,10 @@
>>>         ("lilv" ,lilv)
>>>         ("portaudio" ,portaudio)))
>>>      (native-inputs
>>> -     `(("gettext" ,gettext-minimal)     ;for msgfmt
>>> +     `(("autoconf" ,autoconf)
>>> +       ("automake" ,automake)
>>> +       ("gettext" ,gettext-minimal)     ;for msgfmt
>>> +       ("libtool" ,libtool)
>>>         ("pkg-config" ,pkg-config)
>>>         ("python" ,python-2)
>>>         ("which" ,which)))
>>> @@ -90,6 +99,12 @@
>>>            (string-append "ID3TAG_LIBS=-L" libid3tag "/lib -lid3tag -lz")
>>>            (string-append "LIBMAD_CFLAGS=-I" libmad "/include")
>>>            (string-append "LIBMAD_LIBS=-L" libmad "/lib -lmad")))
>>> +       #:phases
>>> +       (modify-phases %standard-phases
>>> +         ;; Ensure the usage of system libraries.
>>> +         (add-before 'configure 'autoreconf
>>> +           (lambda _
>>> +             (zero? (system* "autoreconf" "-vfi")))))
>>
>> Can you clarify how autoreconf ensures usage of system libraries?
>> Usually it just re-generates configure scripts and Makefiles from
>> templates, but should not make any functional difference.
>
> FFmpeg is not detected if autoreconf doesn't run for some reason. With
> this phase, everything is detected like normal.

Oh. Please mention that in the comment then. Thank you! :)