GNU bug report logs - #26339
[PATCH 00/18] wip: Support non grub bootloaders.

Previous Next

Full log

Message #555 received at 26339 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 26339 <at> debbugs.gnu.org
Subject: Re: bug#26339: [PATCH] tests: Add syslinux gpt test.
Date: Mon, 12 Jun 2017 22:29:57 +0200

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> * gnu/tests/install.scm (%test-installed-syslinux-os): New exported
>   variable.
>   (%minimal-syslinux-os, %minimal-syslinux-os-source): New variables.
>   (%syslinux-gpt-installation-script): New variable.
> * gnu/system/install.scm (installation-os)[packages]: Add syslinux.

Awesome!  It’s really helpful, a good way to avoid bitrot.

> --- a/gnu/system/install.scm
> +++ b/gnu/system/install.scm
> @@ -343,6 +343,7 @@ Use Alt-F2 for documentation.
>      (packages (cons* (canonical-package glibc) ;for 'tzselect' & co.
>                       parted gptfdisk ddrescue
>                       grub                  ;mostly so xrefs to its manual work
> +                     syslinux

I don’t think we should provide ‘syslinux’ in the installation image.
The image is already fat enough.

> +(define-os-with-source (%minimal-syslinux-os
> +                        %minimal-syslinux-os-source)

I think you can’t really avoid duplication because
‘define-os-with-source’ needs to see the full source.  You could remove
the unnecessary bits like ‘users’ though.

> +(define %syslinux-gpt-installation-script
> +  ;; Shell script of a simple installation.
> +  ;; As syslinux 6.0.3 does not handle 64bits ext4 partitions,
> +  ;; we make sure to pass -O '^64bit' to mkfs.

Really?  Woow.

> +(define %test-installed-syslinux-os
> +  (system-test
> +   (name "installed-syslinux-os")
> +   (description
> +    "...")

Please expound a bit.  :-)

Otherwise LGTM, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.