GNU bug report logs - #26339
[PATCH 00/18] wip: Support non grub bootloaders.

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 26339 <at> debbugs.gnu.org
Subject: bug#26339: [PATCH v4 4/7] scripts: system: Adapt "reconfigure" to new bootloader API.
Date: Sun, 14 May 2017 15:31:20 +0200

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> * guix/scripts/system.scm (install-grub*): Rename to install-bootloader. Use
>   keys to pass arguments. Pass a new argument, "installer.drv" which is
>   a script in store dealing with bootloader-specific install actions.
>   Also call "install-boot-config" to install the bootloader config file.
 ^^
Extra space.

> (install-bootloader-derivation): New procedure. It returns a derivation that
> builds a file containing "install-procedure" gexp.
> (perform-action): Build install-proc derivation and call install-bootloader
> with the resulting file. Stop adding GRUB to PATH as bootloaders are called in
> install-proc with direct store paths.

[...]

> +(define* (install-bootloader installer.drv

Please avoid dots in identifiers.

Otherwise LGTM!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.