GNU bug report logs - #26339
[PATCH 00/18] wip: Support non grub bootloaders.

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 26339 <at> debbugs.gnu.org
Subject: bug#26339: [PATCH v4 2/7] bootloader: Adapt vm to new bootloader API.
Date: Sun, 14 May 2017 15:28:47 +0200

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> * gnu/build/install.scm (install-boot-config): New procedure.
>   (install-grub): Move to (gnu bootloader grub).
> * gnu/build/vm.scm (register-bootcfg-root): Rename register-grub.cfg-root and
>   adjust accordingly.
>   (initialize-hard-disk): Takes a bootloader-package, bootcfg, bootcfg-location and
>   bootloader-installer procedure. Adjust accordingly.
> * gnu/system/vm.scm (qemu-image): Adjust to initialize-hard-disk.
>   (system-disk-image, system-qemu-image, system-qemu-image/shared-store):
>   Adjust to qemu-image.

[...]

> --- a/gnu/system/vm.scm
> +++ b/gnu/system/vm.scm
> @@ -46,6 +46,7 @@
>                  #:select (%guile-static-stripped))
>    #:use-module (gnu packages admin)
>  
> +  #:use-module (gnu bootloader)
>    #:use-module (gnu system shadow)
>    #:use-module (gnu system pam)
>    #:use-module (gnu system linux-initrd)
> @@ -176,8 +177,9 @@ made available under the /xchg CIFS share."
>                       (disk-image-format "qcow2")
>                       (file-system-type "ext4")
>                       file-system-label
> -                     os-derivation
> -                     grub-configuration
> +                     os.drv
> +                     bootcfg.drv
> +                     bootloader

I suggest avoiding dots in identifiers (RnRS Scheme does not allow it
because it can conflict with the dot notation for pairs.)  Use a hyphen
instead.

Apart from that, if the system tests are happy after this change, fine
with me too!

Thank you,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.