GNU bug report logs - #26339
[PATCH 00/18] wip: Support non grub bootloaders.

Previous Next

Full log

View this message in rfc822 format

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 26339 <at> debbugs.gnu.org
Subject: bug#26339: [PATCH v3 6/9] scripts: system: Adapt "reconfigure" to new bootloader API.
Date: Mon, 08 May 2017 18:21:28 +0200

Hi,

> Hi Mathieu,
>
>> +(define* (install-bootloader install-procedure
>> +                             #:key
>> +                             bootcfg bootcfg-location
>> +                             device target)
>
> Maybe "installer" instead of "install-procedure"?  It's not that important but it reads better I think...
>

Ok for installer.

> Hmm, importing (guix build utils) twice (on different sides, I guess)?  Could use a comment...

Actually it's something pretty common, grep "guix build utils" in
gnu/services for example.

>
>> +       (install-proc
>> +        (let ((procedure (bootloader-configuration-installer
>> +                          (operating-system-bootloader os)))
>> +              (target    (or target "/")))
>> +          (install-bootloader-derivation procedure bootloader device target)))
>
> Here, I'd use "bootloader-installer" instead of "install-proc" - because this specific procedure could install lots of things - it's the main entry point in a sense.

Ok for install-proc -> bootloader-installer.
       
>
> Otherwise LGTM!  I also think the general approach is good.

Nice !

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.