GNU bug report logs - #26339
[PATCH 00/18] wip: Support non grub bootloaders.

Previous Next

Full log

Message #298 received at 26339 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 26339 <at> debbugs.gnu.org
Subject: Re: bug#26339: [PATCH v3 7/9] scripts: system: Adapt "init" to new
 bootloader API.
Date: Sun, 7 May 2017 23:08:29 +0200

On Sat,  6 May 2017 17:41:52 +0200
Mathieu Othacehe <m.othacehe <at> gmail.com> wrote:

> --- a/guix/scripts/system.scm
> +++ b/guix/scripts/system.scm
> @@ -178,12 +178,14 @@ TARGET, and register them."
>  
>  (define* (install os-drv target
>                    #:key (log-port (current-output-port))
> -                  grub? grub.cfg device)
> -  "Copy the closure of GRUB.CFG, which includes the output of OS-DRV, to
> +                  installer install-bootloader?

"bootloader-installer.drv" instead of "installer"?

>[reinstall-bootloader]
> -       (install-proc
> +       (installer
>          (let ((procedure (bootloader-configuration-installer
>                            (operating-system-bootloader os)))
>                (target    (or target "/")))

"installer.drv" instead of "installer", and "installer" instead of "procedure".  Also, deja vu.  Patch 6/9 also includes something of this part.

Otherwise LGTM!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.