GNU bug report logs - #26339
[PATCH 00/18] wip: Support non grub bootloaders.

Previous Next

Full log

Message #268 received at 26339 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 26339 <at> debbugs.gnu.org
Subject: Re: bug#26339: [PATCH v3 1/9] system: Add extlinux support.
Date: Sun, 7 May 2017 18:41:05 +0200

Hi Mathieu,

>guix/scripts/system.scm (profile-grub-entries): 
>Rename system->grub-entry to system->boot-parameters and adjust accordingly.

Not really - because I did this part already :)

That part of the commit message is outdated.

> +       (bootloader (let ((bootloader (bootloader-configuration-bootloader
> +                                      (operating-system-bootloader os))))
> +                     (if bootloader
> +                         (package->derivation bootloader)
> +                         (return #f))))
[...]

> +                      (if (and bootloader? bootloader)

Hmm, is it possible to (usefully) check monadic values that way?

> +          (when (and bootloader? bootloader)

Likewise.

Otherwise LGTM!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.