GNU bug report logs - #26339
[PATCH 00/18] wip: Support non grub bootloaders.

Previous Next

Package: guix-patches;

Reported by: Mathieu Othacehe <m.othacehe <at> gmail.com>

Date: Sun, 2 Apr 2017 13:51:01 UTC

Severity: important

Tags: patch

Done: Mathieu Othacehe <m.othacehe <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 26339 <at> debbugs.gnu.org
Subject: bug#26339: [PATCH v2 10/12] scripts: system: Adapt "init" to new bootloader API.
Date: Sun, 23 Apr 2017 18:34:25 +0200

> "installer" instead of "install-proc" ?

Ok for "installer".

>> +      (maybe-copy
>> +       (derivation->output-path bootcfg))
>
> Does derivation->output-path change anything?

Well I guess yes, because maybe-copy is expecting a path and not a
derivation.

>
>>+                      #:bootloader? bootloader?
>
> What about the bootloader? :)
>
> "install-bootloader?" ?

Ok for install-bootloader? :)

>
>>+                      #:install-proc
>
> #:bootloader-installer ?

Seems ok to me.

>
> Otherwise LGTM!

Thanks, I'll publish a rebased version, maybe when your own bootloader
serie will be pushed !

Mathieu
This bug report was last modified 7 years and 209 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.