GNU bug report logs - #26339
[PATCH 00/18] wip: Support non grub bootloaders.

Previous Next

Full log

Message #110 received at 26339 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 26339 <at> debbugs.gnu.org
Subject: Re: bug#26339: [PATCH 02/18] system: Add extlinux support.
Date: Sat, 15 Apr 2017 18:03:12 +0200

> +            bootloader-configuration-file-location

In my opinion in UNIX such a thing is called a "file name", so how about

    bootloader-configururation-file-name

?

> +            bootloader-configuration-file-procedure

How about

  bootloader-configuration-file-generator

Or

  bootloader-configuration-file-generation-procedure


?

> +            bootloader-configuration-install-procedure

How about

  bootloader-configuration-installer

or

  bootloader-configuration-installation-procedure 

?

> +    (match-lambda
> +      (($ <boot-parameters> label _ _ _ kernel kernel-arguments initrd)
> +       #~(format port "LABEL ~a
> +  MENU LABEL ~a
> +  KERNEL ~a
> +  FDTDIR ~a/lib/dtbs
> +  INITRD ~a
> +  APPEND ~a
> +~%"
> +                 #$label #$label
> +                 #$kernel #$kernel #$initrd
> +                 (string-join (list #$@kernel-arguments))))))

I think it would be better to use the field accessor procedures.

> +                    (* 10 timeout))

Magical conversion? Could use a comment...

Remainder of the patch LGTM.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.