Subject: bug#26339: [PATCH v2 10/12] scripts: system: Adapt "init" to new bootloader API.

From: Danny Milosavljevic <[email-masked]>
Date: Sun, 23 Apr 2017 10:39:29 +0200

> +                  install-proc bootloader?

"installer" instead of "install-proc" ?

> +                  bootcfg bootcfg-location

bootloader-configuration ?
bootloader-configuration-file-name ?

Or is that too verbose ? Hmm...

>      (mbegin %store-monad
> -      ;; Copy the closure of GRUB.CFG, which includes OS-DIR, GRUB's
> -      ;; background image and so on.
> -      (maybe-copy grub.cfg)
> +      ;; Copy the closure of BOOTCFG, which includes OS-DIR,
> +      ;; eventual background image and so on.
> +      (maybe-copy
> +       (derivation->output-path bootcfg))

Does derivation->output-path change anything?

>+                      #:bootloader? bootloader?

What about the bootloader? :)

"install-bootloader?" ?

>+                      #:install-proc

#:bootloader-installer ?

Otherwise LGTM!