GNU bug report logs - #26328
26.0.50; checkdoc action for join lines drops final "

Previous Next

Full log

View this message in rfc822 format

From: Noam Postavsky <npostavs <at> gmail.com>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Marco Wahl <marcowahlsoft <at> gmail.com>, 26328 <at> debbugs.gnu.org
Subject: bug#26328: 26.0.50; checkdoc action for join lines drops final "
Date: Fri, 16 Aug 2019 09:42:39 -0400

Alex Branham <alex.branham <at> gmail.com> writes:

> On Thu 15 Aug 2019 at 20:11, Noam Postavsky <npostavs <at> gmail.com> wrote:
>
>> Note that the checkdoc-autofix-ask-replace is already replacing the
>> newline with a space (which is kind of a strange behaviour, IMO, but
>> that's how it is currently), so I'm not sure it makes much sense to call
>> delete-indentation after.
>
> Ah, indeed. Starting with this buffer:
>
> (defun foo ()
>   "bla bla
>     bla."
>   )
>
> (defun foo ()
>   "Bla bla
>     bla bla.  More words
>     bla bla bla.")
>
> If we just remove the call to delete-indentation we wind up with:
>
> (defun foo ()
>   "Bla bla bla."
>   )
>
> (defun foo ()
>   "Bla bla bla bla.
> More words bla bla bla.")
>
> So perhaps the we just remove that bit? Updated patch attached.

> +		   (when (checkdoc-autofix-ask-replace
> +		          p (1+ p)
> +		          "1st line not a complete sentence.  Join these lines? "
> +		          " " t)
> +		     (setq msg nil)))))

This is like Lars' suggestion, and using this I get

(defun foo ()
  "Bla bla bla bla.  More words
    bla bla bla.")

for the second case which is incorrect, I think.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.