GNU bug report logs - #26328
26.0.50; checkdoc action for join lines drops final "

Previous Next

Full log

Message #31 received at 26328 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Marco Wahl <marcowahlsoft <at> gmail.com>,
 26328 <at> debbugs.gnu.org
Subject: Re: bug#26328: 26.0.50; checkdoc action for join lines drops final "
Date: Thu, 15 Aug 2019 20:11:19 -0400

Alex Branham <alex.branham <at> gmail.com> writes:

> How about we just use delete-indentation along with the
> already-calculate position p that we just asked the user about? Patch
> attached.

> +		   (when (checkdoc-autofix-ask-replace
> +		          p (1+ p)
> +		          "1st line not a complete sentence.  Join these lines? "
> +		          " " t)
> +		     ;; They said yes.  We have more fill work to do...
> +		     (delete-indentation nil p (1+ p))
> +		     (setq msg nil)))))

Note that the checkdoc-autofix-ask-replace is already replacing the
newline with a space (which is kind of a strange behaviour, IMO, but
that's how it is currently), so I'm not sure it makes much sense to call
delete-indentation after.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.