From unknown Mon Jun 23 20:15:30 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#26328 <26328@debbugs.gnu.org> To: bug#26328 <26328@debbugs.gnu.org> Subject: Status: 26.0.50; checkdoc action for join lines drops final " Reply-To: bug#26328 <26328@debbugs.gnu.org> Date: Tue, 24 Jun 2025 03:15:30 +0000 retitle 26328 26.0.50; checkdoc action for join lines drops final " reassign 26328 emacs submitter 26328 Marco Wahl severity 26328 normal tag 26328 patch confirmed fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 04:52:16 2017 Received: (at submit) by debbugs.gnu.org; 1 Apr 2017 08:52:16 +0000 Received: from localhost ([127.0.0.1]:55044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuElc-0005lD-8H for submit@debbugs.gnu.org; Sat, 01 Apr 2017 04:52:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuEla-0005l0-I6 for submit@debbugs.gnu.org; Sat, 01 Apr 2017 04:52:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cuElT-0008JC-7P for submit@debbugs.gnu.org; Sat, 01 Apr 2017 04:52:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60762) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cuElT-0008J8-40 for submit@debbugs.gnu.org; Sat, 01 Apr 2017 04:52:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cuElQ-0000ga-FK for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2017 04:52:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cuElM-0008E3-Hc for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2017 04:52:04 -0400 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:38419) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cuElM-0008Bd-6o for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2017 04:52:00 -0400 Received: by mail-wm0-x232.google.com with SMTP id t189so14790986wmt.1 for ; Sat, 01 Apr 2017 01:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=VqIE8qYn79iWl/T1SMP0BLxAzyotfxcoKb37esL2qHM=; b=Eq2T47548sdPhOu33CcN+HtFNffL8JOvUoNTy5ckVxFPNjAjIbC062dtplxPFIAK4p 5hJNmtmgjw/yUfrklNEwv/7aIIuJX0itIk8TarZNQ4Gv9JG0AMdNjVyIvSc+Jn1jzbbT upQR4lEFnabT/3+S+aVwF7XIGslybX6RWt6Dg8F1IW3HvXb2kenmZw82dG5FC7lXXyG6 j9J77/eqICJUgkZtY39nFosw72X0qtEgOc8Bfrx5FrgFufZe+gnxUr94Y/y3gRkIS4b8 q23FwgyGnIpbqrlPSRHAx24c21M7S5nH4zR16+eklUrnXzZ+z9Pd0IL7HS9SoCZ0LtBw jgHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=VqIE8qYn79iWl/T1SMP0BLxAzyotfxcoKb37esL2qHM=; b=pF9T2ZaXNZnh+TyZHfbP+Fax4l1yovZlR8aXCPFi6kcQ7WOwKm8U+PWSnVcQYb+b+x WqoCjRg/uqfGVETiVVvrNyWBiZ6bWWgme+3K0JFURxxLfr7+uSCSBJW0Ab5qPH20teyT H1T8RkEISlzkHi0XBdQFlifH8CM4N+/xkwRWjdYIToktSULMuWTrt8CN5AXNXjaJdYis RleMLOl2jXolNQv2NgjvDQO/USAMjyLLHnItFXSSdt2KL30ISrks3915iC2QGZBdwF0P /1nNVhP3yUbsP53ip/VEZTA9LuF7yLiUpjvaKvKW4gCtiSEC//tS2cnS4aSRz4w2I5KT njMA== X-Gm-Message-State: AFeK/H2QM37O9dw3gGBjUSWCdL7FUwBtmLsMHeeIlTqcAD/JiPN3sUt2 3lOI7itCLGnyOeBP X-Received: by 10.28.10.70 with SMTP id 67mr1577869wmk.131.1491036717400; Sat, 01 Apr 2017 01:51:57 -0700 (PDT) Received: from tm6592 (dslb-188-110-138-240.188.110.pools.vodafone-ip.de. [188.110.138.240]) by smtp.gmail.com with ESMTPSA id k128sm5934224wmf.16.2017.04.01.01.51.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Apr 2017 01:51:56 -0700 (PDT) From: Marco Wahl To: bug-gnu-emacs@gnu.org Subject: 26.0.50; checkdoc action for join lines drops final " Date: Sat, 01 Apr 2017 10:51:54 +0200 Message-ID: <84y3vkqzmd.fsf@tm6592> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Checkdoc drops the final " when the action to join the lines has been choosen. E.g. have checkdoc enabled and eval (defun foo () "bla bla bla." ) Suggestion for a fix: modified lisp/emacs-lisp/checkdoc.el @@ -1520,7 +1520,7 @@ checkdoc-this-string-valid-engine ;; They said yes. We have more fill work to do... (goto-char (match-beginning 1)) (delete-region (point) (match-end 1)) - (insert "\n") + (insert "\"") (setq msg nil)))))) (if msg (checkdoc-create-error msg s (save-excursion In GNU Emacs 26.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.22.10) of 2017-03-29 built on tm6592 Repository revision: d707ba846902128572f420241897cbb966363ede Windowing system distributor 'The X.Org Foundation', version 11.0.11903000 System Description: Arch Linux Recent messages: Opening nndoc server on /home/b/Mail/archive/kusen...done Opening nndoc server on /home/b/Mail/archive/todo...done Opening nndoc server on /home/b/Mail/archive/vwiki...done Reading active file via nndraft...done Reading active file from gnorbthing via nnir...done Checking new news...done Mark saved where search started Saving file /home/b/.newsrc-dribble... Wrote /home/b/.newsrc-dribble [2 times] (Saved .newsrc-dribble) Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 LIBSYSTEMD Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Magit Minor modes in effect: beacon-mode: t moz-controller-global-mode: t moz-controller-mode: t zen-reward-mode: t nyan-mode: t global-company-mode: t company-mode: t diff-auto-refine-mode: t magit-auto-revert-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t global-lentic-mode: t lentic-mode: t ido-hacks-mode: t ido-everywhere: t on-screen-global-mode: t wrap-region-global-mode: t wrap-region-mode: t keyfreq-autosave-mode: t keyfreq-mode: t dired-async-mode: t override-global-mode: t shell-dirtrack-mode: t timeclock-mode-line-display: t show-paren-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t display-time-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Load-path shadows: Error during checking Features: (shadow bbdb-message mailalias emacsbug shr-color color flow-fill lyrics follow paredit mc-cycle-cursors mc-mark-more mc-edit-lines caps-lock eieio-opt speedbar sb-image ezimage dframe gnus-dired sh-script smie executable zone zone-nyan esxml ace-window url-cache mm-archive smiley gnus-cite gnus-bcklg mail-extr gnus-async gnus-kill qp gnus-ml nndraft nnmh nndoc utf-7 network-stream starttls nnfolder bbdb-gnus nnnil gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-cache gnus-demon nntp smtpmail sendmail cal-move bookmark tabify misearch multi-isearch company-emoji company-emoji-list org-archive epa-file password-store hl-line cal-iso org-duration beacon checkdoc view page-ext erc-dcc battery cal-china lunar cal-islam cal-hebrew holidays hol-loaddefs bbdb-anniv appt diary-lib diary-loaddefs emacsshot rope-read-mode org-timer org-clock disp-table org-velocity dabbrev org-learn org-invoice org-elisp-symbol org-depend org-w3m org-rmail org-mhe org-irc org-inlinetask org-info org-habit org-gnus org-eww org-docview doc-view jka-compr image-mode org-ctags org-crypt org-bibtex bibtex org-bbdb exwm-randr xcb-randr exwm-config exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types jl-encrypt maxima maxima-font-lock moz-controller moz org-section-numbers org-structure-as-dirs-and-files org-bullets carry-region cursor-color-mode ariadne-marks mw-mark txr-mode auto-complete auxies-eww hacks auxies-rest org-supplements little-helpers bbdb-mua bbdb-com gnorb-bbdb bbdb bbdb-site timezone bbdb-loaddefs emms-librefm-stream emms-librefm-scrobbler emms-playlist-limit emms-volume emms-volume-amixer emms-i18n emms-history emms-score emms-stream-info emms-metaplaylist-mode emms-bookmarks emms-cue emms-mode-line-icon emms-browser sort emms-playlist-sort emms-last-played emms-player-xine emms-player-mpd tq emms-playing-time emms-lyrics emms-url emms-streams emms-show-all emms-tag-editor emms-mark emms-mode-line emms-cache emms-info-ogginfo emms-info-mp3info emms-info later-do emms-playlist-mode emms-player-vlc emms-player-mplayer emms-player-simple emms-source-playlist emms-source-file locate emms-setup emms emms-compat org-protocol slime-fancy slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree slime-scratch slime-presentations bridge slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl elp slime-parse slime gud apropos compile arc-mode archive-mode hyperspec slime-autoloads refine git-timemachine elmacro emr-c emr-elisp emr-lisp list-utils emr-iedit which-func imenu emr-prog emr popup git-auto-commit-mode nyan-mode sotlisp skeleton gnuplot info-look helm helm-source helm-multi-match helm-lib aurel url-http url-auth url-gw nsm bui bui-list bui-info bui-entry bui-core bui-history bui-button bui-utils cus-edit json map rase solar cal-dst gnorb gnorb-org gnorb-registry gnus-registry registry gnorb-gnus gnorb-utils org-agenda org-capture org-attach vc-git org-id gnus-art mm-uu mml2015 mm-view mml-smime smime dig nngnorb nnir gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source tls gnutls utf7 netrc gnus-spec gnus-int gnus-range gnus-win nnoo smartparens lispy hydra lv swiper ivy ivy-overlay ffap iedit iedit-lib multiple-cursors-core rect lispy-inline semantic/db eieio-base semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff edebug help-fns radix-tree lispy-tags key-chord company-oddmuse company-keywords company-etags etags xref project company-gtags company-dabbrev-code company-dabbrev company-files company-capf company-cmake company-xcode company-clang company-semantic company-eclim company-template company-css company-nxml company-bbdb company magit-obsolete magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-branch magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode diff-mode magit-core magit-autorevert autorevert filenotify magit-process magit-margin magit-mode magit-git crm magit-section magit-popup git-commit magit-utils log-edit message rfc822 mml mml-sec epa epg mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp tramp-sh server lentic-mode lentic-doc lentic-ox lentic-org lentic-chunk rx ox-texinfo ox-org ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-md ox-icalendar ox-html table ox-beamer ox-latex ox-ascii ox-publish ox eww puny mm-url gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr url-queue url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap shr svg dom browse-url lentic eieio-compat f s m-buffer-at m-buffer m-buffer-macro ido-hacks ido expand-region text-mode-expansions cc-mode-expansions the-org-mode-expansions er-basic-expansions expand-region-core expand-region-custom browse-kill-ring derived form-feed page-break-lines on-screen wrap-region keyfreq stumpwm-mode dired-narrow delsel dired-hacks-utils dash chronos notifications dbus xml ace-link avy camcorder dired-async dired-aux dired dired-loaddefs async use-package diminish bind-key finder-inf tex-site edmacro kmacro screenshot-autoloads info package epg-config url-handlers url-parse url-vars org-element avl-tree org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline easy-mmode org-version ob-octave ob-makefile ob-forth ob-R ob-haskell ob-maxima ob-java ob-plantuml ob-sqlite ob-sql ob-screen ob-J ob-io ob-shell ob-clojure ob-scheme ob-gnuplot ob-dot ob-ditaa ob-lisp ob-css ob-js ob-org ob-ledger ob-latex ob-calc calc-store calc-trail calc-ext calc calc-loaddefs calc-macs ob-C cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs cl ob-python ob-awk ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint tramp tramp-compat tramp-loaddefs trampver ucs-normalize shell parse-time advice ob-core ob-eval org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs ert find-func seq ewoc debug .emacs-custom timeclock paren avoid erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete time-date pcomplete comint ansi-color ring erc-track erc-match erc-button wid-edit erc-fill erc-stamp erc-netsplit erc-goodies erc erc-backend erc-compat format-spec auth-source cl-seq eieio byte-opt subr-x bytecomp byte-compile cl-extra help-mode easymenu cconv eieio-core cl-macs gv eieio-loaddefs password-cache thingatpt pp time desktop frameset cl-loaddefs pcase cl-lib cus-start cus-load mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1440895 235974) (symbols 48 95512 781) (miscs 40 64313 17720) (strings 32 370256 43439) (string-bytes 1 10722939) (vectors 16 155457) (vector-slots 8 3364869 113444) (floats 8 2015 3714) (intervals 56 19659 5441) (buffers 976 113)) -- Marco Wahl -- Freelancer https://marcowahl.github.io From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 06:51:29 2019 Received: (at 26328) by debbugs.gnu.org; 26 Jul 2019 10:51:29 +0000 Received: from localhost ([127.0.0.1]:40941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqxov-00055V-Bd for submit@debbugs.gnu.org; Fri, 26 Jul 2019 06:51:29 -0400 Received: from quimby.gnus.org ([80.91.231.51]:59522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqxot-00055K-KL for 26328@debbugs.gnu.org; Fri, 26 Jul 2019 06:51:28 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqxop-0005bB-F6; Fri, 26 Jul 2019 12:51:25 +0200 From: Lars Ingebrigtsen To: Marco Wahl Subject: Re: bug#26328: 26.0.50; checkdoc action for join lines drops final " References: <84y3vkqzmd.fsf@tm6592> Date: Fri, 26 Jul 2019 12:51:23 +0200 In-Reply-To: <84y3vkqzmd.fsf@tm6592> (Marco Wahl's message of "Sat, 01 Apr 2017 10:51:54 +0200") Message-ID: <878sslnk5w.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Marco Wahl writes: > Checkdoc drops the final " when the action to join the lines has been > choosen. > > E.g. have checkdoc enabled and eval > > (defun foo () > "bla bla > bla." > ) > > Suggestion for a fix: > > modifi [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26328 Cc: 26328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Marco Wahl writes: > Checkdoc drops the final " when the action to join the lines has been > choosen. > > E.g. have checkdoc enabled and eval > > (defun foo () > "bla bla > bla." > ) > > Suggestion for a fix: > > modified lisp/emacs-lisp/checkdoc.el > @@ -1520,7 +1520,7 @@ checkdoc-this-string-valid-engine > ;; They said yes. We have more fill work to do... > (goto-char (match-beginning 1)) > (delete-region (point) (match-end 1)) > - (insert "\n") > + (insert "\"") > (setq msg nil)))))) > (if msg > (checkdoc-create-error msg s (save-excursion The " at the end of the doc string is removed by that `delete-region', so it's all a bit confusing. The following patch also fixes the problem in this example, but I'm not quite sure what the code is attempting to do here. Anybody familiar with this code? diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index 830743f5f8..7ac557711a 100644 --- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -1498,12 +1498,7 @@ checkdoc-this-string-valid-engine p (1+ p) "1st line not a complete sentence. Join these lines? " " " t) - (progn - ;; They said yes. We have more fill work to do... - (goto-char (match-beginning 1)) - (delete-region (point) (match-end 1)) - (insert "\n") - (setq msg nil)))))) + (setq msg nil))))) (if msg (checkdoc-create-error msg s (save-excursion (goto-char s) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 06:51:33 2019 Received: (at control) by debbugs.gnu.org; 26 Jul 2019 10:51:34 +0000 Received: from localhost ([127.0.0.1]:40944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqxoz-00055m-Lu for submit@debbugs.gnu.org; Fri, 26 Jul 2019 06:51:33 -0400 Received: from quimby.gnus.org ([80.91.231.51]:59538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqxox-00055e-P2 for control@debbugs.gnu.org; Fri, 26 Jul 2019 06:51:32 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqxov-0005bI-5Y for control@debbugs.gnu.org; Fri, 26 Jul 2019 12:51:31 +0200 Date: Fri, 26 Jul 2019 12:51:28 +0200 Message-Id: <877e85nk5r.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #26328 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 26328 + confirmed quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 26328 + confirmed quit From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 06:51:39 2019 Received: (at control) by debbugs.gnu.org; 26 Jul 2019 10:51:39 +0000 Received: from localhost ([127.0.0.1]:40947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqxp4-000564-W0 for submit@debbugs.gnu.org; Fri, 26 Jul 2019 06:51:39 -0400 Received: from quimby.gnus.org ([80.91.231.51]:59550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqxp1-00055u-FG for control@debbugs.gnu.org; Fri, 26 Jul 2019 06:51:35 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqxoy-0005bN-Rg for control@debbugs.gnu.org; Fri, 26 Jul 2019 12:51:34 +0200 Date: Fri, 26 Jul 2019 12:51:32 +0200 Message-Id: <875znpnk5n.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #26328 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 26328 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 26328 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 28 10:06:02 2019 Received: (at 26328) by debbugs.gnu.org; 28 Jul 2019 14:06:02 +0000 Received: from localhost ([127.0.0.1]:46926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrjoH-0007YM-IQ for submit@debbugs.gnu.org; Sun, 28 Jul 2019 10:06:01 -0400 Received: from mail-io1-f43.google.com ([209.85.166.43]:44360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrjoG-0007Y5-5s for 26328@debbugs.gnu.org; Sun, 28 Jul 2019 10:06:00 -0400 Received: by mail-io1-f43.google.com with SMTP id s7so114357537iob.11 for <26328@debbugs.gnu.org>; Sun, 28 Jul 2019 07:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=LweKmrTtSkmnucwTu3ybDQRN0hobgV4BfmQapm7S700=; b=IakVAGZBWlOtp14ysWjq78MLCdzoroZaVHZBeuSKyFdeicCvrymQnBottXqihHArDC rTwwguY2+7iEMWzmb2xF1MhczYcpXI8R5D7ksV81M8cxbQobutMKHUzmC+zMwSTi6Ldb uNZTP4V4vfGnpkyCWCTQuFO/B9OOi3zawyjCQKexUFbisDZo/iEaRHnyhdmdQJusZ8/c Fz6HZkQAtxkwljepXmhnn6S6pu4oCll/GGBbVfzPEPUguuOg/fd/VB5VdCtMqyZ6eP25 dK7Fxp2FkmFw7j9J0DMpGUEB/yDtZFFBKY4tn8F1txoepH6TtTYWC031lzdUpks4c4kL YBqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LweKmrTtSkmnucwTu3ybDQRN0hobgV4BfmQapm7S700=; b=r6PLO94EX6LFhlLqlX/ilMA6pdI8cVEVlpSQWuAkhDffrJoNBll/8gCpyN112OLTyz NeOBYPTP+BJHpM4eovIHi23EFfwk1Rx+JbAlkFiWuIvX6Gfu1ZUsKwwiOZmWiOLnzHVZ KIM9MrLSr6ssLiWcs7608/xmgFlMkWzutnm16xwFjr6m6haCfJqB6a/UFL0c+0tFk+Z8 cIPpISAEhg6vdzul6QUUCkYMKt26yK6zJhampYabbQImnBVogolg0Y6T3xvtrT7WHntA vjioaiCn3guym7HWqXDOqJatMpX7NtKVfNu+G9ivJJLrh9bXbTxpe6IDgio9tqXZRDKi bUjw== X-Gm-Message-State: APjAAAWCwHQMJYcp82N6LMQyKvZHXk0qIqEGo4PR0i/q+Wgv3oll58vQ uAaNsh4v9A4amfQogZi2g5MjHDpV X-Google-Smtp-Source: APXvYqzYLiD/6zJxS6jTL9EHNHo07UhJlaNLKatmXo0qcQcUxhH8QvQ7dByi/j+AgiZfyWer6PmOLg== X-Received: by 2002:a02:b883:: with SMTP id p3mr35493958jam.79.1564322754493; Sun, 28 Jul 2019 07:05:54 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id x22sm44121782iob.84.2019.07.28.07.05.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Jul 2019 07:05:53 -0700 (PDT) From: Noam Postavsky To: Lars Ingebrigtsen Subject: Re: bug#26328: 26.0.50; checkdoc action for join lines drops final " References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> Date: Sun, 28 Jul 2019 10:05:53 -0400 In-Reply-To: <878sslnk5w.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Fri, 26 Jul 2019 12:51:23 +0200") Message-ID: <8736iquuda.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26328 Cc: Marco Wahl , 26328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Suggestion for a fix: >> >> modified lisp/emacs-lisp/checkdoc.el >> @@ -1520,7 +1520,7 @@ checkdoc-this-string-valid-engine >> ;; They said yes. We have more fill work to do... >> (goto-char (match-beginning 1)) >> (delete-region (point) (match-end 1)) >> - (insert "\n") >> + (insert "\"") >> (setq msg nil)))))) >> (if msg >> (checkdoc-create-error msg s (save-excursion > > The " at the end of the doc string is removed by that `delete-region', > so it's all a bit confusing. The following patch also fixes the problem > in this example, but I'm not quite sure what the code is attempting to > do here. > > Anybody familiar with this code? > > diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el > index 830743f5f8..7ac557711a 100644 > --- a/lisp/emacs-lisp/checkdoc.el > +++ b/lisp/emacs-lisp/checkdoc.el > @@ -1498,12 +1498,7 @@ checkdoc-this-string-valid-engine > p (1+ p) > "1st line not a complete sentence. Join these lines? " > " " t) > - (progn > - ;; They said yes. We have more fill work to do... > - (goto-char (match-beginning 1)) > - (delete-region (point) (match-end 1)) > - (insert "\n") > - (setq msg nil)))))) > + (setq msg nil))))) > (if msg > (checkdoc-create-error msg s (save-excursion > (goto-char s) AFAICT, both proposed patches will do the wrong thing for this case: (defun foo () "Bla bla bla bla. More words bla bla bla.") From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 29 07:09:13 2019 Received: (at 26328) by debbugs.gnu.org; 29 Jul 2019 11:09:13 +0000 Received: from localhost ([127.0.0.1]:47724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hs3Wj-0000lN-CG for submit@debbugs.gnu.org; Mon, 29 Jul 2019 07:09:13 -0400 Received: from quimby.gnus.org ([80.91.231.51]:41678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hs3Wf-0000lD-DZ for 26328@debbugs.gnu.org; Mon, 29 Jul 2019 07:09:09 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hs3Wb-0001IK-86; Mon, 29 Jul 2019 13:09:07 +0200 From: Lars Ingebrigtsen To: Noam Postavsky Subject: Re: bug#26328: 26.0.50; checkdoc action for join lines drops final " References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> <8736iquuda.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUPAw4MAQvPflDhpE/C akRNKh+mUjQiDRXZl1F4AAACY0lEQVQ4jW2UTXPbIBCG0XRUrvK0rs9dEfUOcXrtUKJz0gni2moQ uUqdKPz9votsx5PpyrJhH/aDXbCodv+VRpwGa95E5pPiAiS0C975HdgtQlSHuaqqawCdFMsCz81O illeADw8hrCUQX7I+QyaWUiEKECewwA0Wc4zrw3ZQ9ssVbNWnK70J5l8Og8f2eLJkXLOERG+3CYL wCE6u82G5OIJ/AHYY6LKzJJyV+ALFKT6J2UJgw7cKvpRADGwDBQ+EdO2gNZoglaxIZ5EZMx3gM/G GFZRhCv8qLHdwCcARfDXRxeVtTpegagUYiAIeKvNGxi1dSMRYjlrWI4b0KaEJqVh2Z7BBx5oRW2J bUfN5Cg20JqO9K3lHDjKGyCs1iqlyMWxJ4u/cKSVNZRcSvAWrflZwEt728K5uY28FeUitWoDtkOF rLlDvl1yrm/pjm4YOFcsuMhustRZZHIP8Apj6sikLkFG6pCiLSDCPlkzsiMGZHrHoOaFKXK+LqKQ CNin6QK4CZq4SZA+PRew1B7HAP3qhxHHxN5kHwD2YbfzaRqs0T6RSz7+FjJIHJ9HXIIU/GiO9UBd eHUPALA4LAyq9Zf5eoiUxOBmIUIGwDEfaNm35tthxJaf2MIz8BUU9y8o6UfsdCD3LOqJweAHW5qg bUkW8YeJg3sUAp0tjeT+uj6VDTar97x11DWyDjJND6JcHBZ/EZ4JIRqB+yVEgcjzWiRWowi4aMH7 2oc6nIEMqwwAYfarn0N9McQlzABzEB7VO1tkuA9rLhbZr7Cty2I8HNlznDXAJ1g4rS//OTPf/ODz Rf4BHtj7VtrH1nkAAAAASUVORK5CYII= Date: Mon, 29 Jul 2019 13:09:05 +0200 In-Reply-To: <8736iquuda.fsf@gmail.com> (Noam Postavsky's message of "Sun, 28 Jul 2019 10:05:53 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Noam Postavsky writes: > AFAICT, both proposed patches will do the wrong thing for this case: > > (defun foo () > "Bla bla > bla bla. More words > bla bla bla.") Yup. It's rather unclear what that code is attempting to do... Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26328 Cc: Marco Wahl , 26328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > AFAICT, both proposed patches will do the wrong thing for this case: > > (defun foo () > "Bla bla > bla bla. More words > bla bla bla.") Yup. It's rather unclear what that code is attempting to do... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 21:15:54 2019 Received: (at control) by debbugs.gnu.org; 31 Jul 2019 01:15:54 +0000 Received: from localhost ([127.0.0.1]:51405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsdDd-0003xp-Mc for submit@debbugs.gnu.org; Tue, 30 Jul 2019 21:15:53 -0400 Received: from mail-io1-f53.google.com ([209.85.166.53]:46519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsdDa-0003xa-WE for control@debbugs.gnu.org; Tue, 30 Jul 2019 21:15:51 -0400 Received: by mail-io1-f53.google.com with SMTP id i10so19253052iol.13 for ; Tue, 30 Jul 2019 18:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=5cN8XmUjPi/mineMqs5TYpBPWfPe1hjRI9CPbqfiLzA=; b=sunIxfRV4vykGi1qGTmHrO60hdp6ZNhG+ryCI8bVPLh0Z6TIlX4TQmhmYO/UProYxh M19SUQXSHElr9ZlA1fLabecqobF/1Y5OkKuEzjQoqGAAZ6za5Ddc6hJkZM+oxyMp2xOF EnUt1vrMrzn4TC/82/IRx8RCuR7ZIPVYsAnOumtHBBqz2HWBNl8nljau6i5PwYXIWc9p cmoQQELDU6jewFtaxpAwu12C/CTjtUDLdXnRw3hp29MONcds0dxMaiH842O3Dgbe0Tmt rqJaiLWSKmLiAPRIZfljJn8UpiG8EmrTIeURUIV9GAU7BKCsoCP/k76GribN4xuZngw4 uZEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=5cN8XmUjPi/mineMqs5TYpBPWfPe1hjRI9CPbqfiLzA=; b=oTe/3EmV/QO05kmgsPzjTzJwNfxCmzK24XedadA7GxTe9c8byvpiTRMUYVy+a8a6N2 cNuSFEXw6hURq/+BzBCj4YOuCgWbwmgiueC5R1/jO5Y6+49CffKUqsAaIXFXafegIGyn ecv/5OCafvlbKTWOhsECEcxn/o4Pm1cwhdUHFvIZhzqI5VtqseEVviw731bPPDSMLdxW SmQ/1FARU+RoL/NIBuG/irkVNdT7kmKXRtX9RVjdY9vImdkV0vZuDP73vYqfgSboxsCT mBeRg917WV//TL/NBD5VvLgrb+er/1My4/ol8Mp/vpK2/mfnhmTL2bkYS+fo8XKGsFgh 87fA== X-Gm-Message-State: APjAAAX85ArVQapchtnXziHPa9qXbmRbMopdT+G+5sHi5Pjmm9r50kye 88w0//UOzy+vcCDmh5M3n6UxEVLj X-Google-Smtp-Source: APXvYqxP3UpSDe1796bGKNgNqDbCFl0sakdjiSg42jBvlDlpNutJf9TZByigxXOtym6bkonUTrd9Eg== X-Received: by 2002:a02:b395:: with SMTP id p21mr7272888jan.31.1564535745145; Tue, 30 Jul 2019 18:15:45 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id c23sm55964570iod.11.2019.07.30.18.15.43 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Jul 2019 18:15:44 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #26328 Date: Tue, 30 Jul 2019 21:15:43 -0400 Message-ID: <87v9vjt35s.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) # proposed patches are not correct tags 26328 - patch quit From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 15 19:13:19 2019 Received: (at 26328) by debbugs.gnu.org; 15 Aug 2019 23:13:19 +0000 Received: from localhost ([127.0.0.1]:52640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyOvm-0005n2-TN for submit@debbugs.gnu.org; Thu, 15 Aug 2019 19:13:19 -0400 Received: from mail-oi1-f169.google.com ([209.85.167.169]:33217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyOvl-0005ml-8o; Thu, 15 Aug 2019 19:13:17 -0400 Received: by mail-oi1-f169.google.com with SMTP id u15so3526035oiv.0; Thu, 15 Aug 2019 16:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4Rc36SmmWVTtNqwsCL7223IjHy2+DatTyD3opToChDY=; b=lAAbCFS8SrsEkrnI+DCaU73ltHQBi0ftJV71gW3fKIjLG466cSgTFv97NPaIo0zAkX qgnYg8+rxCQmho+SAHEHF8jggcmnYwtqE9jw85/BkqOhRvdbEAzB7yyZkySR6sx6zlPp MW8E1NnHeCFTEhP5gocjD+EjBL4SLpg6M8rhGPo7EDsygWnX7f9kgNRLXSA0kKeGORhH Mj8rClMjcvCTGFjMzfqGp379+9+L6auZ/Zz71NgKjSEeZUt48cvPRyHUh0j7EL4lqPhx p46HARsdufQ0LVEnCVmmFQKuQfyPOHPLj/eTj3wlGMqxfbLz5fsRYZiHyrIBQpiFhmpP sYtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=4Rc36SmmWVTtNqwsCL7223IjHy2+DatTyD3opToChDY=; b=PiAsW0GtDvdPSc1dsjDHnYuRGvsEF3OQMK31ETgxibG4tfLh6ljhdE2/lVND9d7ZOw z7znT1GIxUbW1Eb7Zsec3rzgjrfWt1y5+9w001b5kS/HHqKXw6hCW0FlMHd52ulh+sfG McAHyFHJiyLpx8WsFrfmPLU9tg34JO4s5r0EC+7KxIvyfRJMgwYVFS59P1mrvsMWYn4Z qcSmKVPV1t5UOLx2jqgzmRtNiNdqfQ9yUkcS2TVLdRB0JQkemRdvfeda0BGp5rRLD3r/ oYWSFMKcYw0gitWjTx1zEnupBpVUZsjyzTnohUghb3qhKZBrnHFSHn3EFrhKewr6c6XG Hzqw== X-Gm-Message-State: APjAAAVvrElzTvPWdoCVgp7gq+bY+H99LICqSEcuTMm5uNpXJqJG5tOj 9Dv821N1bxkf0HwsEmvIs0UyAmDKwBU= X-Google-Smtp-Source: APXvYqyrWqhz9KTqowdEjD+TpeskUH9qIdMrbQZHHOs7tiBcxtXfRYICmXSvV+J3hW02yxRd+60Sew== X-Received: by 2002:aca:4d4b:: with SMTP id a72mr2980975oib.87.1565910791373; Thu, 15 Aug 2019 16:13:11 -0700 (PDT) Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id k25sm839746oig.50.2019.08.15.16.13.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2019 16:13:10 -0700 (PDT) From: Alex Branham To: Lars Ingebrigtsen Subject: Re: bug#26328: 26.0.50; checkdoc action for join lines drops final " References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> <8736iquuda.fsf@gmail.com> Date: Thu, 15 Aug 2019 18:13:09 -0500 In-Reply-To: (Lars Ingebrigtsen's message of "Mon, 29 Jul 2019 13:09:05 +0200") Message-ID: <877e7eowe2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26328 Cc: Marco Wahl , Noam Postavsky , 26328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 26328 + patch quit On Mon 29 Jul 2019 at 13:09, Lars Ingebrigtsen wrote: > Noam Postavsky writes: > >> AFAICT, both proposed patches will do the wrong thing for this case: >> >> (defun foo () >> "Bla bla >> bla bla. More words >> bla bla bla.") > > Yup. It's rather unclear what that code is attempting to do... How about we just use delete-indentation along with the already-calculate position p that we just asked the user about? Patch attached. Thanks, Alex --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-checkdoc-incorrectly-joining-lines.patch >From 41c09cedd36cea604bd6a1ea20dafdc44ce31da0 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Thu, 15 Aug 2019 18:04:33 -0500 Subject: [PATCH] Fix checkdoc incorrectly joining lines * lisp/emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine): Use delete-indentation rather than delete-region. Bug#26328 --- lisp/emacs-lisp/checkdoc.el | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index 830743f5f8..9e7291ba21 100644 --- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -1494,16 +1494,13 @@ checkdoc-this-string-valid-engine (if (and (re-search-forward "[.!?:\"]\\([ \t\n]+\\|\"\\)" (line-end-position) t) (< (current-column) numc)) - (if (checkdoc-autofix-ask-replace - p (1+ p) - "1st line not a complete sentence. Join these lines? " - " " t) - (progn - ;; They said yes. We have more fill work to do... - (goto-char (match-beginning 1)) - (delete-region (point) (match-end 1)) - (insert "\n") - (setq msg nil)))))) + (when (checkdoc-autofix-ask-replace + p (1+ p) + "1st line not a complete sentence. Join these lines? " + " " t) + ;; They said yes. We have more fill work to do... + (delete-indentation nil p (1+ p)) + (setq msg nil))))) (if msg (checkdoc-create-error msg s (save-excursion (goto-char s) -- 2.22.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 15 19:18:38 2019 Received: (at 26328) by debbugs.gnu.org; 15 Aug 2019 23:18:38 +0000 Received: from localhost ([127.0.0.1]:52654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyP0w-000817-AD for submit@debbugs.gnu.org; Thu, 15 Aug 2019 19:18:38 -0400 Received: from quimby.gnus.org ([80.91.231.51]:48990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyP0v-00080z-2k for 26328@debbugs.gnu.org; Thu, 15 Aug 2019 19:18:37 -0400 Received: from [50.225.213.182] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyP0r-0007yo-8x; Fri, 16 Aug 2019 01:18:35 +0200 From: Lars Ingebrigtsen To: Alex Branham Subject: Re: bug#26328: 26.0.50; checkdoc action for join lines drops final " References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> <8736iquuda.fsf@gmail.com> <877e7eowe2.fsf@gmail.com> Date: Thu, 15 Aug 2019 16:18:30 -0700 In-Reply-To: <877e7eowe2.fsf@gmail.com> (Alex Branham's message of "Thu, 15 Aug 2019 18:13:09 -0500") Message-ID: <87wofet3uh.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alex Branham writes: >>> AFAICT, both proposed patches will do the wrong thing for this case: >>> >>> (defun foo () >>> "Bla bla >>> bla bla. More words >>> bla bla bla.") [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26328 Cc: Marco Wahl , Noam Postavsky , 26328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Branham writes: >>> AFAICT, both proposed patches will do the wrong thing for this case: >>> >>> (defun foo () >>> "Bla bla >>> bla bla. More words >>> bla bla bla.") [...] > + (when (checkdoc-autofix-ask-replace > + p (1+ p) > + "1st line not a complete sentence. Join these lines? " > + " " t) > + ;; They said yes. We have more fill work to do... > + (delete-indentation nil p (1+ p)) > + (setq msg nil))))) This looks like the right thing for the original use case, but will it fix the example above? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 15 20:11:27 2019 Received: (at 26328) by debbugs.gnu.org; 16 Aug 2019 00:11:28 +0000 Received: from localhost ([127.0.0.1]:52715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyPq3-00030T-N7 for submit@debbugs.gnu.org; Thu, 15 Aug 2019 20:11:27 -0400 Received: from mail-io1-f44.google.com ([209.85.166.44]:43939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyPq2-00030D-Jk for 26328@debbugs.gnu.org; Thu, 15 Aug 2019 20:11:27 -0400 Received: by mail-io1-f44.google.com with SMTP id 18so2824983ioe.10 for <26328@debbugs.gnu.org>; Thu, 15 Aug 2019 17:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=sq+6bPUVVVvm55t40Vaxb9sawiT5nA/iPjtNh4OzHIQ=; b=chDr3bnDeQwoX0aSiXqh3G5hzz9dOT9LsdPjojLSn33T2rhEX5IPA5A5G0fnO+W2l0 PElnKSn+9GjDmj6qFSQpJJcCDttg//ZhALkf7H8ID8pgD9SLZJzYzippUUpR2U7XMaJ7 GMTmI6KKlxfKUOg8aQEV3lXGkvnw/3/O9x/O01s6Eg4vEp3N0MANXzDiJ9B1G8s8DACl 6VlI2/Q5527anXoJMKhpYp70GVR0IcX5cydw/85bP9Qal/ivYIxjqiwWfRG/VUVEcsqW OGjSAdV5XL5McAIj6bnes4cmKGAlwhQ1UDanJoT6hGeexcK3Ybj5KhryxmcoSDe8sCJ3 61AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=sq+6bPUVVVvm55t40Vaxb9sawiT5nA/iPjtNh4OzHIQ=; b=Ta3y1zKmsPpH5bA1a7vIj3nYBiNn0zWTCyES6C6pu3h1DkKlJa/H6H4C639jx0HdNX KU9Vw+cDivncvzKUPc4myfxLhcBp5ogWvt7XIMW9+MfDQ4kYLJs+Y6MspMzAWEeYSuHU 8w4kYVSp2bDJ327eVrcyWKdq1LZmKTJJCXjD08x2taqNF/JbpnHqDLM7c5SqoBzfxkTK oqmHnm6IrO/mYybqGY4w3lUdbw32lVy+3N2hVcfJKKE3tSRXpB6xTWGFJFVQhy+XcQUW nK6qdVp53tm1pM9uAoP+3w5+bLN618RmApfNBPFvHn39P2caCfpGSWK6uYRRbduTwv8Y ZufA== X-Gm-Message-State: APjAAAURF7ek7k/mOI2Fvyp+TSXaEqsBwMypardJBuTR7vG3UNtyY475 6ZVkLq9SWHN5a9pyqe+rOiX1acic X-Google-Smtp-Source: APXvYqx4M/GIVzYlyUQZLei2Th6D3gVC21WQMHEShGYJq9bFxF7XVoecsLRK5EtJ1DpHOqqNzYDNKQ== X-Received: by 2002:a5d:8411:: with SMTP id i17mr5055064ion.83.1565914281049; Thu, 15 Aug 2019 17:11:21 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id t2sm9917312iod.81.2019.08.15.17.11.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Aug 2019 17:11:20 -0700 (PDT) From: Noam Postavsky To: Alex Branham Subject: Re: bug#26328: 26.0.50; checkdoc action for join lines drops final " References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> <8736iquuda.fsf@gmail.com> <877e7eowe2.fsf@gmail.com> Date: Thu, 15 Aug 2019 20:11:19 -0400 In-Reply-To: <877e7eowe2.fsf@gmail.com> (Alex Branham's message of "Thu, 15 Aug 2019 18:13:09 -0500") Message-ID: <87r25motp4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26328 Cc: Lars Ingebrigtsen , Marco Wahl , 26328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Branham writes: > How about we just use delete-indentation along with the > already-calculate position p that we just asked the user about? Patch > attached. > + (when (checkdoc-autofix-ask-replace > + p (1+ p) > + "1st line not a complete sentence. Join these lines? " > + " " t) > + ;; They said yes. We have more fill work to do... > + (delete-indentation nil p (1+ p)) > + (setq msg nil))))) Note that the checkdoc-autofix-ask-replace is already replacing the newline with a space (which is kind of a strange behaviour, IMO, but that's how it is currently), so I'm not sure it makes much sense to call delete-indentation after. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 09:24:36 2019 Received: (at 26328) by debbugs.gnu.org; 16 Aug 2019 13:24:36 +0000 Received: from localhost ([127.0.0.1]:53299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hycDc-0001EJ-1C for submit@debbugs.gnu.org; Fri, 16 Aug 2019 09:24:36 -0400 Received: from mail-ot1-f51.google.com ([209.85.210.51]:42171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hycDZ-0001E3-MR for 26328@debbugs.gnu.org; Fri, 16 Aug 2019 09:24:34 -0400 Received: by mail-ot1-f51.google.com with SMTP id j7so9552188ota.9 for <26328@debbugs.gnu.org>; Fri, 16 Aug 2019 06:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7hAPv0k1IxiturYfiEmfb1WacLHh30/e46wCS2Vjw2k=; b=gG4T8f0PO5eADFAyR5p/g+fPZ6IaqJrUqe3E79mOmCmZJPbZXpa/nvyYptnT80MYQR QCz/+tBiQb9q8IG5PQXeUNH8f3M6m8ZeHRqq86gyE5khudNbE12gVxPxCmcruVtNSmP6 7qmIAySn9OjF1kSFOWs9yEXL28v8BqoCRBW7X9fA7TW3U9kkVEoAyi8W+sXgWLjUDrw+ T/qcWG0fzAI2D7KZeAhTtlmWoGmpsqGXCTVJoaEg+sxDw9ZeT0s/FJqVIkuuS8nwcCwJ RQR1eLKQ3JlckDZHK/jbcHr4vhyYzNKwH76XIXevWyHHT9AOBuxCj7M6MQapoqpdiU8R CQcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7hAPv0k1IxiturYfiEmfb1WacLHh30/e46wCS2Vjw2k=; b=VW1sMm9ASisxOvN+TUp1hyS5qKJ3DX8uHjJkJI9yxNYp6KbYPYH3pRP+YQieLvSMQH 6grY1DMJW6A55FSAF474SpCZ/AG212+/xyIzzDVCLt0exsw0NYYoWtL2jGfxx4iFPEeN D+jp57n0sfPJXGvzAn5R+cuwwzEBWE3vZZPj28G3SA79KLXVXaad1L70m1i9laJ3OCyd 4qb50MdNuOxoyfeuSkerdu6rE0xjABYjxHQtjPbfmR6B8hJ1/ItppFgtI5qJeprY9iad 3aecj6RrYQxybLyAdTgJKLjZaaUolxX8Lf8m+nz3M1ddfg78q0ROvytY3fnftASch2Eh xCfQ== X-Gm-Message-State: APjAAAW1BrG9eqqDpp3ylVn0akZl0TbvhAI7n24qiksHkXQIfkQHAad3 DQxKFSG1YZ6qMZqwHGPiWrju3r4BjZA= X-Google-Smtp-Source: APXvYqwa1JP5ujG6KGd7CKI02lQ05R9tCnkcKOygDgWjWm1YeXCY2yDy7QdjdiMFBYEugZVukc9ebA== X-Received: by 2002:a9d:4e0d:: with SMTP id p13mr504412otf.161.1565961867785; Fri, 16 Aug 2019 06:24:27 -0700 (PDT) Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id j6sm2000707otq.16.2019.08.16.06.24.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 06:24:26 -0700 (PDT) From: Alex Branham To: Noam Postavsky Subject: Re: bug#26328: 26.0.50; checkdoc action for join lines drops final " References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> <8736iquuda.fsf@gmail.com> <877e7eowe2.fsf@gmail.com> <87r25motp4.fsf@gmail.com> Date: Fri, 16 Aug 2019 08:24:25 -0500 In-Reply-To: <87r25motp4.fsf@gmail.com> (Noam Postavsky's message of "Thu, 15 Aug 2019 20:11:19 -0400") Message-ID: <874l2hdz06.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26328 Cc: Lars Ingebrigtsen , Marco Wahl , 26328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On Thu 15 Aug 2019 at 20:11, Noam Postavsky wrote: > Alex Branham writes: > > Note that the checkdoc-autofix-ask-replace is already replacing the > newline with a space (which is kind of a strange behaviour, IMO, but > that's how it is currently), so I'm not sure it makes much sense to call > delete-indentation after. Ah, indeed. Starting with this buffer: (defun foo () "bla bla bla." ) (defun foo () "Bla bla bla bla. More words bla bla bla.") If we just remove the call to delete-indentation we wind up with: (defun foo () "Bla bla bla." ) (defun foo () "Bla bla bla bla. More words bla bla bla.") So perhaps the we just remove that bit? Updated patch attached. Alex --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Avoid-deleting-closing-quotation-mark-in-checkdoc.patch >From b2f2ef1731c28d0f541c7778dd7a49774f59ddb7 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Fri, 16 Aug 2019 08:22:23 -0500 Subject: [PATCH] Avoid deleting closing quotation mark in checkdoc * lisp/emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine): Remove calls to delete-region (bug#26328). --- lisp/emacs-lisp/checkdoc.el | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index 830743f5f8..3c69975021 100644 --- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -1494,16 +1494,11 @@ checkdoc-this-string-valid-engine (if (and (re-search-forward "[.!?:\"]\\([ \t\n]+\\|\"\\)" (line-end-position) t) (< (current-column) numc)) - (if (checkdoc-autofix-ask-replace - p (1+ p) - "1st line not a complete sentence. Join these lines? " - " " t) - (progn - ;; They said yes. We have more fill work to do... - (goto-char (match-beginning 1)) - (delete-region (point) (match-end 1)) - (insert "\n") - (setq msg nil)))))) + (when (checkdoc-autofix-ask-replace + p (1+ p) + "1st line not a complete sentence. Join these lines? " + " " t) + (setq msg nil))))) (if msg (checkdoc-create-error msg s (save-excursion (goto-char s) -- 2.22.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 09:42:49 2019 Received: (at 26328) by debbugs.gnu.org; 16 Aug 2019 13:42:49 +0000 Received: from localhost ([127.0.0.1]:53310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hycVE-0001hB-TG for submit@debbugs.gnu.org; Fri, 16 Aug 2019 09:42:49 -0400 Received: from mail-io1-f44.google.com ([209.85.166.44]:43621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hycVC-0001gv-S8 for 26328@debbugs.gnu.org; Fri, 16 Aug 2019 09:42:47 -0400 Received: by mail-io1-f44.google.com with SMTP id 18so6236669ioe.10 for <26328@debbugs.gnu.org>; Fri, 16 Aug 2019 06:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GsxXmXWxlFyLh5vu5SR7ybVOYxqI4TulXqwyvwBWjhA=; b=jAmq6IXaGGVvnX60lXHAc250/zPwrAMfsEe5+7M/HjXn6PmDGzhNxxWnU8GcCC9DTB icCrxDzAZhXqONqQs/vejkN3aHAY+4PP/LRAlCNx1L/EzlsYfpEZAtRobEJQgTZvIht8 d2DMj/oST9RP9e/oW0GinO7SxhI7WPp+ZyjTj8GIkuou+QlDmdtOg0IOfWjteuTse+jl fTW68FNg6TPrB9s2Flgd4ZcWRqP6nZZyzj13ycuohDQVB1NAEzY6J8p7ddINCUgTO2cD Th5KWTIBtf2yj9dFHI1ypowvXFI9jSrl/SbJg5kzyS8YpKYCnoV4YVlIWOAVgxdEhyOJ 93OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=GsxXmXWxlFyLh5vu5SR7ybVOYxqI4TulXqwyvwBWjhA=; b=XevOfY4/Jr6CNT3OWSKWpYoY+q7SAsamwJ+axcKLrpHum0zlRm+k4Ca2nUbkQYcZBX LgUshD19npcpdE+lKC9JTVUXdoNFlfvso7QFN+mMCv62f//ToJdyUbZ/5Cx84c1+qDRG 6h1qw87nG0NFRhd90u6pEtdpWoQriQ5EuybMmxBFcrPydWtr1Eip3Cf6Kmimb9t/+85N Ba118Vh+z6S9Vo5u1YlpoWn/VyGoq5Dr7lgxRZ3Tfw/M+EFjMsiC9a7gn5BqepRbHpq3 wzP7k7dJJNTm2E6FRXnLdGfkAMHaJYvJQ6IpbDro9mZJQKQ++fOylDgb+//LHJzzrOGP n+yA== X-Gm-Message-State: APjAAAXVSLHbPLBXxo0PtzPFRlWh8s9Z+YtF28VE4UDsTdzsFOy4Cl1v Sa15pYF8gXn7/8BJf3K4LYJzUNUl X-Google-Smtp-Source: APXvYqwOfZ4EnG8qgY1giTadvAiQQiI0MJUIhExLOqqSGIF6uVkk0AQyjEaLM2cf7dXCh3U+tz0z9w== X-Received: by 2002:a5d:8352:: with SMTP id q18mr10601459ior.154.1565962961148; Fri, 16 Aug 2019 06:42:41 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id v13sm8555415iol.60.2019.08.16.06.42.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Aug 2019 06:42:40 -0700 (PDT) From: Noam Postavsky To: Alex Branham Subject: Re: bug#26328: 26.0.50; checkdoc action for join lines drops final " References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> <8736iquuda.fsf@gmail.com> <877e7eowe2.fsf@gmail.com> <87r25motp4.fsf@gmail.com> <874l2hdz06.fsf@gmail.com> Date: Fri, 16 Aug 2019 09:42:39 -0400 In-Reply-To: <874l2hdz06.fsf@gmail.com> (Alex Branham's message of "Fri, 16 Aug 2019 08:24:25 -0500") Message-ID: <858srtkz00.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26328 Cc: Lars Ingebrigtsen , Marco Wahl , 26328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Branham writes: > On Thu 15 Aug 2019 at 20:11, Noam Postavsky wrote: > >> Note that the checkdoc-autofix-ask-replace is already replacing the >> newline with a space (which is kind of a strange behaviour, IMO, but >> that's how it is currently), so I'm not sure it makes much sense to call >> delete-indentation after. > > Ah, indeed. Starting with this buffer: > > (defun foo () > "bla bla > bla." > ) > > (defun foo () > "Bla bla > bla bla. More words > bla bla bla.") > > If we just remove the call to delete-indentation we wind up with: > > (defun foo () > "Bla bla bla." > ) > > (defun foo () > "Bla bla bla bla. > More words bla bla bla.") > > So perhaps the we just remove that bit? Updated patch attached. > + (when (checkdoc-autofix-ask-replace > + p (1+ p) > + "1st line not a complete sentence. Join these lines? " > + " " t) > + (setq msg nil))))) This is like Lars' suggestion, and using this I get (defun foo () "Bla bla bla bla. More words bla bla bla.") for the second case which is incorrect, I think. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 09:55:33 2019 Received: (at 26328) by debbugs.gnu.org; 16 Aug 2019 13:55:33 +0000 Received: from localhost ([127.0.0.1]:54662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hychY-0002O1-O2 for submit@debbugs.gnu.org; Fri, 16 Aug 2019 09:55:33 -0400 Received: from mail-ot1-f53.google.com ([209.85.210.53]:38425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hychW-0002JA-FC for 26328@debbugs.gnu.org; Fri, 16 Aug 2019 09:55:31 -0400 Received: by mail-ot1-f53.google.com with SMTP id r20so9683664ota.5 for <26328@debbugs.gnu.org>; Fri, 16 Aug 2019 06:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Qq7ZtuDugwxT5H0R6JAhxrBeaLjsAkUVfvRVEGdLuxg=; b=GuJrZqtHEl7hIy8i4pTMS1MOGhtTtc2kN3YkUbGDGIuwzKsycqRiJub5ZLxjaotj/4 ISzxCUNgbW0VY3V8m31Q0HsOGY94qGmakBqr+8GkvP7rp+2F2VgRjEnfHqUa01WCXiMG XragJXGPs+3O0dcLWtLvIE2O1qbqi6x5tARP3LYk+QtPnful3SxH0GSM2RINxSGJw44c r2juAZlTr3+fwkJUSv1OhHbP0w5etSuvf+Bs84wWMmTmfzyq4NxdOkTvOjqiogfyPQ0q 2z64bQDclST0vRaN7ZILq58ii+ex8cPDgVFsBfmJVGFuV5Qv2DTMWpkdynuk57Khgg4I 2etQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Qq7ZtuDugwxT5H0R6JAhxrBeaLjsAkUVfvRVEGdLuxg=; b=Im84+Kvqd4zFtjLfyEiX9fJQBccoJdG0EPPh8e0iMIs8Qhv7nI+oV83XH3xPEzqw0M K11oFpIKw6x0C+X0MVkIsMSi9dui9wcb7Z/H5j2OwjE3JCStrZ/biRbrLhqlvIX/1Dkk 9T4c716iwKByW9XZIZY54KHUb+mWbrs07JqazAGe57AzfxUAwe9V9XW1Lh6+UTF0qnxa LagRXFWrCwNFymZFjxfnJ6YwdNnO6XTM63mI3K0wxvE+TEyEyehhz2prrJwovo1icYI1 cfvLEZqR0TYRwT/9aLGG96/IJxOv64LXpW48iRzLpW2B0CTinNOldI/qYNuHC4vovGqs ACLg== X-Gm-Message-State: APjAAAUuqu13y/KVnQW5wVx1H+fUgS5Ls9A0Y7iNMrP/LG1047b2F7JX d0CaXNpQ881MXpfRfcj65VINet0KlQE= X-Google-Smtp-Source: APXvYqzLYgtFcu0HMM1uW/pFOiWkOf9MN7/peaMrkuPavZTkofpUI+oITBonNuUGJnMa3Lv3KJn6Ow== X-Received: by 2002:a05:6830:16ce:: with SMTP id l14mr7190061otr.169.1565963724487; Fri, 16 Aug 2019 06:55:24 -0700 (PDT) Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id u5sm2325215ote.27.2019.08.16.06.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 06:55:23 -0700 (PDT) From: Alex Branham To: Noam Postavsky Subject: Re: bug#26328: 26.0.50; checkdoc action for join lines drops final " References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> <8736iquuda.fsf@gmail.com> <877e7eowe2.fsf@gmail.com> <87r25motp4.fsf@gmail.com> <874l2hdz06.fsf@gmail.com> <858srtkz00.fsf@gmail.com> Date: Fri, 16 Aug 2019 08:55:22 -0500 In-Reply-To: <858srtkz00.fsf@gmail.com> (Noam Postavsky's message of "Fri, 16 Aug 2019 09:42:39 -0400") Message-ID: <87ftm15i5x.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26328 Cc: Lars Ingebrigtsen , Marco Wahl , 26328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri 16 Aug 2019 at 09:42, Noam Postavsky wrote: > Alex Branham writes: > This is like Lars' suggestion, and using this I get > > (defun foo () > "Bla bla bla bla. More words > bla bla bla.") > > for the second case which is incorrect, I think. Right, which is caught later in checkdoc and fixed. I don't think asking users to push "f" twice is a big deal. An alternative could be to join the lines, then insert a newline after the end of the sentence, then run fill-pararaph? Alex From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 10:02:02 2019 Received: (at 26328) by debbugs.gnu.org; 16 Aug 2019 14:02:02 +0000 Received: from localhost ([127.0.0.1]:54671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hycnp-0002YD-Tp for submit@debbugs.gnu.org; Fri, 16 Aug 2019 10:02:02 -0400 Received: from mail-io1-f53.google.com ([209.85.166.53]:38527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hycnn-0002Xt-CS for 26328@debbugs.gnu.org; Fri, 16 Aug 2019 10:02:00 -0400 Received: by mail-io1-f53.google.com with SMTP id j6so6346635ioa.5 for <26328@debbugs.gnu.org>; Fri, 16 Aug 2019 07:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ErX7o9/vgaCgQ3YTZVj06kUorBPF6N4AQ///1Xx7wUo=; b=g7U42xRjVTzObzgxE52HVmTWqhNV4Atnaj6vs2WnRBNUgNoOo+1rAtsLu6yLhWvfBL gNLGFeyxrlnzoePXpCy/QKyik/XyvZolASqXskKT4mpsyMdoqjMOiKa0ayqjjKRLpexm ep7IHvaFEKMKYzN3qJ2EVfzlJWVD1qkJciMetiXwi/q81UzRuqbzbddZze2yRjYNVlrW OHKYFvoX2h4mxKD//ndkzwZm7moxHnwwfTle2yluGJesWZLo7vOWLddI61VGX/7kR5ph yLqdR1o8ndm3TWbdreA6BKRJ+K2aiN/ytRwmkRU6Z/iEkS1T1Nd78cVOvr4JVPJq3Z3a /P7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ErX7o9/vgaCgQ3YTZVj06kUorBPF6N4AQ///1Xx7wUo=; b=a29OHTywv0H0y0FhjegMkjapRi1RbA9EgxO0DrbcmEqsfVSQKxpB/i+v85DXy+CJ0E /GR9yiTqtkChsXC2lz8cVFllahnm1veyWzAOLCMykKVvbEOhTpCP/QlBv2eEDdGXOEmj KSpdMTNOQ0gp/2dgwp+zn0G7Uu/INygx2aqFnSSj/7QIj92oW9llszERfm54d8FRqqUn H3SbnzjxTVA09JP/Zspd1JmG4+YoifrAAC7UIT/FEzOGNNZCfV+tWX1XhC8mSEXIdSo/ BqfMftSpeNqS5WgsT/U5ZDV294OVw75r7dQU7QktV3NSemZL9lW7+rKsE2d2w39JWjGr ddRg== X-Gm-Message-State: APjAAAWfUj/Xhg4Ql4vwVELCsWaKAa6097g3EzBQAGRIlbB4APxgz2ME +Yy1Bj6qKHdTbMLnNa20ZSHp/IGu X-Google-Smtp-Source: APXvYqyGKA+QBF+uvrcFDHs8NdsO8nC3U9xru/65jB9p9rI2KFLj6TvkjMTueBe/CQjVnSC5/uc5rg== X-Received: by 2002:a05:6638:691:: with SMTP id i17mr11106683jab.70.1565964113461; Fri, 16 Aug 2019 07:01:53 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id v12sm1018113ios.16.2019.08.16.07.01.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Aug 2019 07:01:53 -0700 (PDT) From: Noam Postavsky To: Alex Branham Subject: Re: bug#26328: 26.0.50; checkdoc action for join lines drops final " References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> <8736iquuda.fsf@gmail.com> <877e7eowe2.fsf@gmail.com> <87r25motp4.fsf@gmail.com> <874l2hdz06.fsf@gmail.com> <858srtkz00.fsf@gmail.com> <87ftm15i5x.fsf@gmail.com> Date: Fri, 16 Aug 2019 10:01:52 -0400 In-Reply-To: <87ftm15i5x.fsf@gmail.com> (Alex Branham's message of "Fri, 16 Aug 2019 08:55:22 -0500") Message-ID: <855zmxky3z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 26328 Cc: Lars Ingebrigtsen , Marco Wahl , 26328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Alex Branham writes: > On Fri 16 Aug 2019 at 09:42, Noam Postavsky wrote: > >> This is like Lars' suggestion, and using this I get >> >> (defun foo () >> "Bla bla bla bla. More words >> bla bla bla.") >> >> for the second case which is incorrect, I think. > > Right, which is caught later in checkdoc and fixed. I don't think asking > users to push "f" twice is a big deal. Ah, I was just calling M-x checkdoc-defun, which leaves it at the above. If users of checkdoc think it's okay to do it like that, then it's fine by me. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 16:54:36 2019 Received: (at 26328) by debbugs.gnu.org; 16 Aug 2019 20:54:36 +0000 Received: from localhost ([127.0.0.1]:54982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjF6-0002T3-Hm for submit@debbugs.gnu.org; Fri, 16 Aug 2019 16:54:36 -0400 Received: from quimby.gnus.org ([80.91.231.51]:37770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjF4-0002Sw-Pm for 26328@debbugs.gnu.org; Fri, 16 Aug 2019 16:54:35 -0400 Received: from [50.225.213.182] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyjF1-0000hC-2O; Fri, 16 Aug 2019 22:54:33 +0200 From: Lars Ingebrigtsen To: Alex Branham Subject: Re: bug#26328: 26.0.50; checkdoc action for join lines drops final " References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> <8736iquuda.fsf@gmail.com> <877e7eowe2.fsf@gmail.com> <87r25motp4.fsf@gmail.com> <874l2hdz06.fsf@gmail.com> Date: Fri, 16 Aug 2019 13:54:26 -0700 In-Reply-To: <874l2hdz06.fsf@gmail.com> (Alex Branham's message of "Fri, 16 Aug 2019 08:24:25 -0500") Message-ID: <87blwoq1a5.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alex Branham writes: > Remove calls to delete-region (bug#26328). Given the two test cases, this makes checkdoc work for me, and I'm applying the patch. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26328 Cc: Marco Wahl , Noam Postavsky , 26328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Branham writes: > Remove calls to delete-region (bug#26328). Given the two test cases, this makes checkdoc work for me, and I'm applying the patch. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 16:56:07 2019 Received: (at control) by debbugs.gnu.org; 16 Aug 2019 20:56:07 +0000 Received: from localhost ([127.0.0.1]:54995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjGZ-0002WY-D9 for submit@debbugs.gnu.org; Fri, 16 Aug 2019 16:56:07 -0400 Received: from quimby.gnus.org ([80.91.231.51]:37792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjGX-0002WQ-DM for control@debbugs.gnu.org; Fri, 16 Aug 2019 16:56:05 -0400 Received: from [50.225.213.182] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyjGT-0000hS-Q5 for control@debbugs.gnu.org; Fri, 16 Aug 2019 22:56:04 +0200 Date: Fri, 16 Aug 2019 13:55:58 -0700 Message-Id: <87a7c8q17l.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #26328 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 26328 fixed close 26328 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 26328 fixed close 26328 27.1 quit From unknown Mon Jun 23 20:15:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 14 Sep 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator