From unknown Sun Aug 17 01:23:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#26317 <26317@debbugs.gnu.org> To: bug#26317 <26317@debbugs.gnu.org> Subject: Status: 26.0.50; Small incompatibility in ibuffer.el (ibuffer-compile-format) Reply-To: bug#26317 <26317@debbugs.gnu.org> Date: Sun, 17 Aug 2025 08:23:41 +0000 retitle 26317 26.0.50; Small incompatibility in ibuffer.el (ibuffer-compile= -format) reassign 26317 emacs submitter 26317 John Mastro severity 26317 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 30 19:08:34 2017 Received: (at submit) by debbugs.gnu.org; 30 Mar 2017 23:08:34 +0000 Received: from localhost ([127.0.0.1]:53285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctjBA-0001fz-Di for submit@debbugs.gnu.org; Thu, 30 Mar 2017 19:08:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctjB8-0001fl-76 for submit@debbugs.gnu.org; Thu, 30 Mar 2017 19:08:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctjB2-0003X2-0X for submit@debbugs.gnu.org; Thu, 30 Mar 2017 19:08:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35502) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ctjB1-0003Wt-T6 for submit@debbugs.gnu.org; Thu, 30 Mar 2017 19:08:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctjB0-000524-PJ for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2017 19:08:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctjAz-0003Vb-LM for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2017 19:08:22 -0400 Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:34903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctjAz-0003VM-H0 for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2017 19:08:21 -0400 Received: by mail-qk0-x22a.google.com with SMTP id r142so53854015qke.2 for ; Thu, 30 Mar 2017 16:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=5c5N4Dz+a45mOsCa2el4BMX3Ai/t1VRDyiW7JsmFp5s=; b=KvoUfkXkCBCMXdWCjjouoCJ7jE7jBdUVNGjXFUalm/YAz5P5Rfs4NptlnNuEDHEW1T zKFA+NevvaxFNNE012D1buage8LoFffNXamugYmzZm4vD37PPxqK9a6xLvD6KfMVtoMr c1OyKUNLRfoM+5x24rTcHGoa+QX2DT0ebOyxFdfDZpUAxVxeLE/DX8Q8ZPoRLs2OXTkM pSDyCW5Y2KAcMiKjrLWSY56mIo7T6hthOEqjiulNdL0T5+cxR3R/FktnxWj5e71irLVu OyFgdykCWuFN7V2OI2u1eWkqo5HqHe9yHkFeBIX7kxA3f5IAbiZG7nMC2QUxxSZ59k+I 4l9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=5c5N4Dz+a45mOsCa2el4BMX3Ai/t1VRDyiW7JsmFp5s=; b=E+OXjSciIeswPpbYC7iOAqibCmnjnFL5QerWayN2lHoPe7xBsNOcGGFC3812akW+AM csIWw/D4VkACdGwAVmxx3sUHUwqSpaS2rD3KSKGMK5V6X0P81s005qNJHE8oofYxV0zv lf/bwa+mBOpz+Hl54i8mcvAD/IKigp+cPO3RCbgrR04hKT12uphCUfXKTS/hUj/GYDv2 GHRQ+VIfTN7TDnQb+lbkTaWPKiq3Ea+t4LE9K7t+z0rEkzIicKN7co32HkLJmsbz+Jsb W3XGdmJOhy45rc3be87FVfKFA4i+yvEpXy6mT7L0ce7mJ1heF2pkt+Zx1Q1S5ukpNs/k lbXw== X-Gm-Message-State: AFeK/H3R6LDhHbzbbAt1z3j9mK0onXBoucN2usp/iJmeVvoJceOU+kAW6rGNxUh0jDpKbVcruWQhBH1Sb1LCMg== X-Received: by 10.55.165.205 with SMTP id o196mr2250336qke.20.1490915300374; Thu, 30 Mar 2017 16:08:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.49.162 with HTTP; Thu, 30 Mar 2017 16:07:59 -0700 (PDT) From: John Mastro Date: Thu, 30 Mar 2017 16:07:59 -0700 Message-ID: Subject: 26.0.50; Small incompatibility in ibuffer.el (ibuffer-compile-format) To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) In commit 7e2a8b1, ibuffer.el was change to use `string-width' in a couple places where it previously used `length'. The result is that custom columns which can return nil, which worked in Emacs 25, will now cause an error. To reproduce, run `emacs -Q', yank the following into *scratch*, and evaluate it: (require 'ibuffer) (define-ibuffer-column my-column (:name "X") (and (equal (buffer-name) "*scratch*") "Y")) (setq ibuffer-formats '((mark modified read-only " " (name 18 18 :left :elide) " " (my-column 5 5 :left) " " filename-and-process))) (ibuffer) It works in Emacs 25, but in Emacs 26 an error is signaled: Debugger entered--Lisp error: (wrong-type-argument stringp nil) string-width(nil) I came across this because I use the `ibuffer-vc' package, which defines a column (`vc-status') whose implementation returns nil for some buffers (by default, non-file-visiting buffers and buffers visiting remote files). I will follow up with a patch in a separate email (so I can include the bug number in the commit message). John From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 30 19:15:44 2017 Received: (at 26317) by debbugs.gnu.org; 30 Mar 2017 23:15:44 +0000 Received: from localhost ([127.0.0.1]:53291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctjI8-0001qd-K1 for submit@debbugs.gnu.org; Thu, 30 Mar 2017 19:15:44 -0400 Received: from mail-qt0-f181.google.com ([209.85.216.181]:35444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctjI7-0001qQ-GP for 26317@debbugs.gnu.org; Thu, 30 Mar 2017 19:15:43 -0400 Received: by mail-qt0-f181.google.com with SMTP id x35so52547322qtc.2 for <26317@debbugs.gnu.org>; Thu, 30 Mar 2017 16:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=3YGqJFd6V4DvkQObcc3hAk98xTDkyWRiQL4zx2XEMv8=; b=czFflLn7JNrLk/zXMIwMzVZwbTX4jW3ycG0RVtxvrwnfIkqke31UPFPpqgSf69qNML D7pz76C2jtXZFdlsXWpm5HrY9SUzEJ9Bwrhzq2GaCVkcKX33z32hjnnGqYphyRmwapDT UPtAsy39hIrNPYbQgl7iD4X8OCd+uFpCry95lEnE9vOAO8vvQWYO4OeMvznoD85XBeb7 jyGmrQd753zz/VoRg5ZxXrQR+cIJRd7o/jlQwKAIMrBajoCEPrDaS8CM1wnjLPC6IZH7 /TUYFjExcyZDyoB8wT+O0wdryTZm22sZn74Y9ShY50YgeuMMJM2tpxIlOoixta4IbMif ry0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=3YGqJFd6V4DvkQObcc3hAk98xTDkyWRiQL4zx2XEMv8=; b=YoOLUw1Zyecfeaz9idKqnAgXsenbl61BsGb9J+Q9+GFczlA8s+agqxvmEYX1SVjYxB zfdyat/sl+SXdNhqqIo05YiBPOx/XeJOfGCa6NQlxl8Lx4E1hsNaq8+dSElj/G4WCISR hERfwJGDkO2o/38df5QPcjzzuh33DUrzjeer2sNmahR8kbWDQgFToEWfxzIdlsYPhHv+ AapA/eAMV4+S0s+2wQF+4JmYOkqcSwXXejgFKg0dSWJFaGq+LjMpvSeL5wQ6A8NWA++y jCqVZ+51mHHE7CB4LwsUfajO3pPXvIcXKPH7QCogdv9gLPYma/KZVZVsMbBnBM3own+x EJuw== X-Gm-Message-State: AFeK/H3KAumaLeM1KUd53jv15H0ZqILEwpY4V6jkc/nkO8zBlJ3mCWPSz4QseOq1K3MwSsiBfBdSXKgQagf/mg== X-Received: by 10.237.63.89 with SMTP id q25mr2238523qtf.253.1490915737616; Thu, 30 Mar 2017 16:15:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.49.162 with HTTP; Thu, 30 Mar 2017 16:15:16 -0700 (PDT) In-Reply-To: References: From: John Mastro Date: Thu, 30 Mar 2017 16:15:16 -0700 Message-ID: Subject: Re: bug#26317: 26.0.50; Small incompatibility in ibuffer.el (ibuffer-compile-format) To: 26317@debbugs.gnu.org Content-Type: multipart/mixed; boundary=001a1146eb8aee68d7054bfade3a X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 26317 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --001a1146eb8aee68d7054bfade3a Content-Type: text/plain; charset=UTF-8 John Mastro wrote: > In commit 7e2a8b1, ibuffer.el was change to use `string-width' in a couple > places where it previously used `length'. The result is that custom columns > which can return nil, which worked in Emacs 25, will now cause an error. I've attached a patch that fixes this. Rather than touching the calls to `string-width' directly, it translates nil to the empty string. Either way restores compatibility with Emacs 25, but translating nil to the empty string seems preferable in that it saves later code from caring. Even though it's a tiny change, I'm not a regular contributor or particularly familiar with ibuffer's implementation, so any review is appreciated. My copyright assignment is on file. John --001a1146eb8aee68d7054bfade3a Content-Type: application/octet-stream; name="0001-Fix-a-small-incompatibility-in-ibuffer.patch" Content-Disposition: attachment; filename="0001-Fix-a-small-incompatibility-in-ibuffer.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j0x0pvil0 RnJvbSA4MWMwM2IzZjM3Mjc0ZWYyMjQ3OTAzNDY3Y2NiYjdjODk3MGZmOTc2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2huIE1hc3RybyA8am9obi5iLm1hc3Ryb0BnbWFpbC5jb20+ CkRhdGU6IFRodSwgMzAgTWFyIDIwMTcgMTY6MDE6NDEgLTA3MDAKU3ViamVjdDogW1BBVENIXSBG aXggYSBzbWFsbCBpbmNvbXBhdGliaWxpdHkgaW4gaWJ1ZmZlcgoKVHJhbnNsYXRlIG5pbCB2YWx1 ZXMgZnJvbSBjb2x1bW4gZnVuY3Rpb25zIHRvIHRoZSBlbXB0eSBzdHJpbmcsIHNvIHRoYXQKc3Vi c2VxdWVudCBjYWxscyB0byBzdHJpbmctd2lkdGggZG9uJ3Qgc2lnbmFsIGFuIGVycm9yIChCdWcj MjYzMTcpLgoqIGxpc3AvaWJ1ZmZlci5lbCAoaWJ1ZmZlci1jb21waWxlLWZvcm1hdCk6IElmIGEg Y29sdW1uIGZ1bmN0aW9uIHJldHVybnMKbmlsLCB0cmVhdCBpdCBsaWtlIHRoZSBlbXB0eSBzdHJp bmcuCi0tLQogbGlzcC9pYnVmZmVyLmVsIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9pYnVmZmVyLmVsIGIvbGlz cC9pYnVmZmVyLmVsCmluZGV4IDY2OTE2YjIuLmM4M2MyMTMgMTAwNjQ0Ci0tLSBhL2xpc3AvaWJ1 ZmZlci5lbAorKysgYi9saXNwL2lidWZmZXIuZWwKQEAgLTE2ODksNyArMTY4OSw3IEBAIGlidWZm ZXItY29tcGlsZS1mb3JtYXQKIAkJICAgIDs7IGdlbmVyYXRlIGEgY2FsbCB0byB0aGUgY29sdW1u IGZ1bmN0aW9uLgogCQkgICAgKGlidWZmZXItYWlmIChhc3NxIHN5bSBpYnVmZmVyLWlubGluZS1j b2x1bW5zKQogCQkJKG50aCAxIGl0KQotCQkgICAgICBgKCxzeW0gYnVmZmVyIG1hcmspKSkKKwkJ ICAgICAgYChvciAoLHN5bSBidWZmZXIgbWFyaykgIiIpKSkKIAkJICAgOzsgWW91J3JlIG5vdCBl eHBlY3RlZCB0byB1bmRlcnN0YW5kIHRoaXMuICBIZWxsLCBJCiAJCSAgIDs7IGRvbid0IGV2ZW4g dW5kZXJzdGFuZCBpdCwgYW5kIEkgd3JvdGUgaXQgZml2ZQogCQkgICA7OyBtaW51dGVzIGFnby4K LS0gCjIuMTAuMgoK --001a1146eb8aee68d7054bfade3a-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 30 20:25:16 2017 Received: (at 26317-done) by debbugs.gnu.org; 31 Mar 2017 00:25:16 +0000 Received: from localhost ([127.0.0.1]:53332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctkNQ-0003xE-7f for submit@debbugs.gnu.org; Thu, 30 Mar 2017 20:25:16 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:36723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctkNN-0003x0-IH for 26317-done@debbugs.gnu.org; Thu, 30 Mar 2017 20:25:13 -0400 Received: by mail-qk0-f172.google.com with SMTP id p22so54618411qka.3 for <26317-done@debbugs.gnu.org>; Thu, 30 Mar 2017 17:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OHHxSa0jdkghL4UKxGVoMeQLuE+odyzbgimRLOFqyTA=; b=bWYJJfqGeENqwNVUBM8zNZnp+XvjbfaoLV+ana5tSDYN9V5e38H78vsFOzxIhBMQwi BOJr7WxAd48b/lVyOfPufVVKZ9+8Pv0qLVU8B7JqnazGAmf1KQh9pXGCoWPboETRtP0V 9TRdYg4T9gjN47JRxP4vk2RvG+PgyeE6rGE70o2X+zRQbRbITDanpzXk3qhhNKgI+fcS S1WihkKxVRAM/tFs+YC4kDoWDCxeWn1b3ITl2wwv8YqC9YQQ9n16GOVrIF99JTyFs4GQ uMSJsMYIV7t0RjLL3zMU9mChBBZdohVKQV//tmSbFKxMRHZ7uOLozNk6nP1ASZgSkTJg r6ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OHHxSa0jdkghL4UKxGVoMeQLuE+odyzbgimRLOFqyTA=; b=RhjbH2Sq9wA+1MtzUylTYDe7IT9WwznppKuROMtWTtvqMjXI+6SyH/ZDQDIRSmY+2/ s+k/9gAqifoyOnXnK1ot4yeGNDjogF4qBWAyjhATkHbsoFPWuY1Zh9SKUk9hFVbsuqvU s0Yxgy9kmzh643xx8VjCci4Iclc0weqSZNuyo/YFl6PuEonMJDE7xXo5/IaZVCRVXhAr g4OsdDd/yaHXMfDBDtW4uJqm91C/Y8Uij98zgyrkmXM0E4NfCS4lTV4tloGjE0AOHEvQ 5ccBQmLBIKj/4IpxZyFwCRx6FayOkwbHm4A1V8DbWhxu4gGKlfCqGlR0u8Rc2OQKb9AO Urxw== X-Gm-Message-State: AFeK/H3o0ITmsyxhnIIIAkByNjtTKF3EAzKMiM9C/mZKQk7F0Edenjbo5tQExNHRqN0c5osx X-Received: by 10.55.64.73 with SMTP id n70mr177471qka.25.1490919908083; Thu, 30 Mar 2017 17:25:08 -0700 (PDT) Received: from holos.localdomain (pool-173-67-40-97.bltmmd.fios.verizon.net. [173.67.40.97]) by smtp.gmail.com with ESMTPSA id n77sm86747qkn.6.2017.03.30.17.25.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Mar 2017 17:25:07 -0700 (PDT) Received: by holos.localdomain (Postfix, from userid 1000) id 6E1956611B; Thu, 30 Mar 2017 20:25:06 -0400 (EDT) From: Mark Oteiza To: John Mastro Subject: Re: bug#26317: 26.0.50; Small incompatibility in ibuffer.el (ibuffer-compile-format) References: Date: Thu, 30 Mar 2017 20:25:06 -0400 In-Reply-To: (John Mastro's message of "Thu, 30 Mar 2017 16:15:16 -0700") Message-ID: <8737dumgwt.fsf@holos> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26317-done Cc: 26317-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) John Mastro writes: > John Mastro wrote: >> In commit 7e2a8b1, ibuffer.el was change to use `string-width' in a couple >> places where it previously used `length'. The result is that custom columns >> which can return nil, which worked in Emacs 25, will now cause an error. > > I've attached a patch that fixes this. Rather than touching the calls to > `string-width' directly, it translates nil to the empty string. Either > way restores compatibility with Emacs 25, but translating nil to the > empty string seems preferable in that it saves later code from caring. > > Even though it's a tiny change, I'm not a regular contributor or > particularly familiar with ibuffer's implementation, so any review is > appreciated. My copyright assignment is on file. LGTM. Sorry for breaking it, and thanks for the fix! Applied as eeaa707. From unknown Sun Aug 17 01:23:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 28 Apr 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator