Subject: bug#26314: [PATCH] substitute: Send ‘User-Agent’ header.

From: [email-masked] (Ludovic Courtès)
Date: Fri, 31 Mar 2017 10:12:35 +0200

Heya!

Tobias Geerinckx-Rice <[email-masked]> skribis:

> * guix/scripts/substitute.scm (narinfo-request): Pass ‘User-Agent’ #:headers
> to ‘build-request’.
> ---
>
> Guix,
>
> This makes the User-Agent sent to substitute servers consistent.
>
> Currently, ‘http-fetch’ (used to download .nars) sets it to ‘GNU Guile’,
> while http-multiple-get (used to download .narinfos) leaves it empty.

Sounds good to me.

Did the lack of ‘User-Agent’ cause you any problems?

> (This brings the number of scattered '"GNU Guile"' user-agent settings
>  in Guix to 5, but moving it to %guix-default-http-user-agent does not
>  strike me as a meaningful improvement.)

Agreed.  :-)

Go for it!

Ludo’.