GNU bug report logs - #26312
[PATCH] gnu: Add cifs-utils.

Previous Next

Full log

Message #8 received at 26312 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: post <at> thomasdanckaert.be, 26312 <at> debbugs.gnu.org
Subject: Re: bug#26312: [PATCH] gnu: Add cifs-utils.
Date: Thu, 30 Mar 2017 22:19:54 +0200

[Message part 1 (text/plain, inline)]

Thomas,

I don't have any Samba shares to test this on, but will try my hand at
this reviewing business anyway.

On 30/03/17 17:48, Thomas Danckaert wrote:
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'autoreconf
> +           (lambda _ ; install.sh is missing from release tarball
> +             (zero? (system* "autoreconf" "-i"))))

If it's a one-time oversight, best leave a note for the next update:

            ;; The 6.7 tarball is missing ‘install.sh’. Create it.

(Your shorter in-line form is fine too; I just think active comments are
more clear.)

I noticed that the ‘--enable-systemd’ configure flag is enabled by
default, but it seems to be well-behaved on systems without a running
systemd.

> +    (synopsis "User-space utilities for CIFS (Samba) mounts")
> +    (description "@code{cifs-utils} is a set of user-space tools used
> +by the in-kernel CIFS filesystem.")

If this package is as Linux-specific at it seems, I'd explicitly mention
that in both the synopsis and description.

Aside: GNU uses ‘file system’, not ‘filesystem’, because GNU is rad. How
about expanding the acronym at the same time? E.g.:

  ‘the @{Common Internet File System} (CIFS) implementation built into
   the Linux kernel’.

Bonus points for replacing the horrid word ‘implementation’ :-)

Thanks!

T G-R

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.