GNU bug report logs - #26300
[PATCH] gnu: milkytracker: Update to 1.0.0.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#26300: closed ([PATCH] gnu: milkytracker: Update to 1.0.0.)
Date: Thu, 30 Mar 2017 16:03:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 30 Mar 2017 12:02:23 -0400
with message-id <87r31eu50w.fsf <at> openmailbox.org>
and subject line Re: bug#26300: [PATCH] gnu: milkytracker: Update to 1.0.0.
has caused the debbugs.gnu.org bug report #26300,
regarding [PATCH] gnu: milkytracker: Update to 1.0.0.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
26300: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26300
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kei Kebreau <kei <at> openmailbox.org>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kei <at> openmailbox.org>
Subject: [PATCH] gnu: milkytracker: Update to 1.0.0.
Date: Wed, 29 Mar 2017 10:52:50 -0400

* gnu/packages/music.scm (milkytracker): Update to 1.0.0.
[source]: Change uri; add file-name.
[build-system]: Change from gnu-build-system to cmake-build-system.
[arguments]: Remove #:make-flags; disable tests (which are no longer
present).
[inputs]: Change sdl to sdl2.
---
 gnu/packages/music.scm | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 2f70945c6..f1914fefe 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5,7 +5,7 @@
 ;;; Copyright © 2016 Al McElrath <hello <at> yrns.org>
 ;;; Copyright © 2016, 2017 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2016 Leo Famulari <leo <at> famulari.name>
-;;; Copyright © 2016 Kei Kebreau <kei <at> openmailbox.org>
+;;; Copyright © 2016, 2017 Kei Kebreau <kei <at> openmailbox.org>
 ;;; Copyright © 2016 John J. Foerch <jjfoerch <at> earthlink.net>
 ;;; Copyright © 2016 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2017 ng0 <contact.ng0 <at> cryptolab.net>
@@ -2132,21 +2132,22 @@ of tools for manipulating and accessing your music.")
 (define-public milkytracker
   (package
     (name "milkytracker")
-    (version "0.90.86")
+    (version "1.0.0")
     (source (origin
               (method url-fetch)
-              (uri (string-append "http://milkytracker.titandemo.org/files/"
-                                  name "-" version ".tar.bz2"))
+              (uri (string-append "https://github.com/milkytracker/"
+                                  "MilkyTracker/archive/v" version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
               (sha256
                (base32
-                "1v9vp8vi24lkagfpr92c128whvakwgrm9pq2zf6ijpl5sh7014zb"))))
-    (build-system gnu-build-system)
+                "1p1jd4h274jvcvl05l01v9bj19zhq4sjag92v1zawyi93ib85abz"))))
+    (build-system cmake-build-system)
     (arguments
-     `(#:make-flags '("CXXFLAGS=-lasound")))
+     '(#:tests? #f)) ; no check target
     (inputs
      `(("alsa-lib" ,alsa-lib)
        ("jack" ,jack-1)
-       ("sdl" ,sdl)
+       ("sdl" ,sdl2)
        ("zlib" ,zlib)))
     (native-inputs
      `(("pkg-config" ,pkg-config)))
@@ -2157,6 +2158,9 @@ the popular DOS program Fasttracker II, with special playback modes available
 for improved Amiga ProTracker 2/3 compatibility.")
     (home-page "http://milkytracker.titandemo.org/")
     ;; 'src/milkyplay' is under Modified BSD, the rest is under GPL3 or later.
+    ;; Also, songs installed in share/milkytracker/songs are licensed under the
+    ;; Creative Commons Attribution-Noncommericial-Share Alike 3.0 Unported
+    ;; License.
     (license (list license:bsd-3 license:gpl3+))))
 
 (define-public schismtracker
-- 
2.12.0

[Message part 3 (message/rfc822, inline)]

From: Kei Kebreau <kei <at> openmailbox.org>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 26300-done <at> debbugs.gnu.org
Subject: Re: bug#26300: [PATCH] gnu: milkytracker: Update to 1.0.0.
Date: Thu, 30 Mar 2017 12:02:23 -0400

[Message part 4 (text/plain, inline)]

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Kei Kebreau <kei <at> openmailbox.org> writes:
>
>> * gnu/packages/music.scm (milkytracker): Update to 1.0.0.
>> [source]: Change uri; add file-name; add snippet to remove non-FSDG
>> compliant data.
>> [build-system]: Change from gnu-build-system to cmake-build-system.
>> [arguments]: Remove #:make-flags; disable tests (which are no longer
>> present).
>> [inputs]: Change sdl to sdl2.
>> ---
>
> Excellent.  Please push!

Pushed as e3b2e943b871b26f178cc97a16c9f0cbf595a22a. Thanks for clearing
up the licensing issue.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.