Subject: Re: bug#26300: [PATCH] gnu: milkytracker: Update to 1.0.0.

From: ng0 <[email-masked]>
Date: Wed, 29 Mar 2017 15:04:19 +0000

Kei Kebreau transcribed 2.7K bytes:
> * gnu/packages/music.scm (milkytracker): Update to 1.0.0.
> [source]: Change uri; add file-name.
> [build-system]: Change from gnu-build-system to cmake-build-system.
> [arguments]: Remove #:make-flags; disable tests (which are no longer
> present).
> [inputs]: Change sdl to sdl2.
> ---
>  gnu/packages/music.scm | 20 ++++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 2f70945c6..f1914fefe 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -5,7 +5,7 @@
>  ;;; Copyright © 2016 Al McElrath <[email-masked]>
>  ;;; Copyright © 2016, 2017 Efraim Flashner <[email-masked]>
>  ;;; Copyright © 2016 Leo Famulari <[email-masked]>
> -;;; Copyright © 2016 Kei Kebreau <[email-masked]>
> +;;; Copyright © 2016, 2017 Kei Kebreau <[email-masked]>
>  ;;; Copyright © 2016 John J. Foerch <[email-masked]>
>  ;;; Copyright © 2016 Alex Griffin <[email-masked]>
>  ;;; Copyright © 2017 ng0 <[email-masked]>
> @@ -2132,21 +2132,22 @@ of tools for manipulating and accessing your music.")
>  (define-public milkytracker
>    (package
>      (name "milkytracker")
> -    (version "0.90.86")
> +    (version "1.0.0")
>      (source (origin
>                (method url-fetch)
> -              (uri (string-append "http://milkytracker.titandemo.org/files/"
> -                                  name "-" version ".tar.bz2"))
> +              (uri (string-append "https://github.com/milkytracker/"
> +                                  "MilkyTracker/archive/v" version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
>                (sha256
>                 (base32
> -                "1v9vp8vi24lkagfpr92c128whvakwgrm9pq2zf6ijpl5sh7014zb"))))
> -    (build-system gnu-build-system)
> +                "1p1jd4h274jvcvl05l01v9bj19zhq4sjag92v1zawyi93ib85abz"))))
> +    (build-system cmake-build-system)
>      (arguments
> -     `(#:make-flags '("CXXFLAGS=-lasound")))
> +     '(#:tests? #f)) ; no check target
>      (inputs
>       `(("alsa-lib" ,alsa-lib)
>         ("jack" ,jack-1)
> -       ("sdl" ,sdl)
> +       ("sdl" ,sdl2)
>         ("zlib" ,zlib)))
>      (native-inputs
>       `(("pkg-config" ,pkg-config)))
> @@ -2157,6 +2158,9 @@ the popular DOS program Fasttracker II, with special playback modes available
>  for improved Amiga ProTracker 2/3 compatibility.")
>      (home-page "http://milkytracker.titandemo.org/")
>      ;; 'src/milkyplay' is under Modified BSD, the rest is under GPL3 or later.
> +    ;; Also, songs installed in share/milkytracker/songs are licensed under the
> +    ;; Creative Commons Attribution-Noncommericial-Share Alike 3.0 Unported
> +    ;; License.

Attribution-Noncommericial… doesn't that make them a candidate for
exclusion in systems like Guix?

>      (license (list license:bsd-3 license:gpl3+))))
>  
>  (define-public schismtracker
> -- 
> 2.12.0
> 
> 
> 
>