Subject: bug#26300: closed (Re: bug#26300: [PATCH] gnu: milkytracker: Update to 1.0.0.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 30 Mar 2017 16:03:02 +0000

Your bug report

#26300: [PATCH] gnu: milkytracker: Update to 1.0.0.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
26300: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26300
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#26300: [PATCH] gnu: milkytracker: Update to 1.0.0.
From: Kei Kebreau <[email-masked]>
To: Ricardo Wurmus <[email-masked]>
Cc: [email-masked]
Date: Thu, 30 Mar 2017 12:02:23 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Ricardo Wurmus <[email-masked]> writes:

> Kei Kebreau <[email-masked]> writes:
>
>> * gnu/packages/music.scm (milkytracker): Update to 1.0.0.
>> [source]: Change uri; add file-name; add snippet to remove non-FSDG
>> compliant data.
>> [build-system]: Change from gnu-build-system to cmake-build-system.
>> [arguments]: Remove #:make-flags; disable tests (which are no longer
>> present).
>> [inputs]: Change sdl to sdl2.
>> ---
>
> Excellent.  Please push!

Pushed as e3b2e943b871b26f178cc97a16c9f0cbf595a22a. Thanks for clearing
up the licensing issue.

Subject: [PATCH] gnu: milkytracker: Update to 1.0.0.
From: Kei Kebreau <[email-masked]>
To: [email-masked]
Cc: Kei Kebreau <[email-masked]>
Date: Wed, 29 Mar 2017 10:52:50 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/music.scm (milkytracker): Update to 1.0.0.
[source]: Change uri; add file-name.
[build-system]: Change from gnu-build-system to cmake-build-system.
[arguments]: Remove #:make-flags; disable tests (which are no longer
present).
[inputs]: Change sdl to sdl2.
---
 gnu/packages/music.scm | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 2f70945c6..f1914fefe 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5,7 +5,7 @@
 ;;; Copyright © 2016 Al McElrath <[email-masked]>
 ;;; Copyright © 2016, 2017 Efraim Flashner <[email-masked]>
 ;;; Copyright © 2016 Leo Famulari <[email-masked]>
-;;; Copyright © 2016 Kei Kebreau <[email-masked]>
+;;; Copyright © 2016, 2017 Kei Kebreau <[email-masked]>
 ;;; Copyright © 2016 John J. Foerch <[email-masked]>
 ;;; Copyright © 2016 Alex Griffin <[email-masked]>
 ;;; Copyright © 2017 ng0 <[email-masked]>
@@ -2132,21 +2132,22 @@ of tools for manipulating and accessing your music.")
 (define-public milkytracker
   (package
     (name "milkytracker")
-    (version "0.90.86")
+    (version "1.0.0")
     (source (origin
               (method url-fetch)
-              (uri (string-append "http://milkytracker.titandemo.org/files/"
-                                  name "-" version ".tar.bz2"))
+              (uri (string-append "https://github.com/milkytracker/"
+                                  "MilkyTracker/archive/v" version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
               (sha256
                (base32
-                "1v9vp8vi24lkagfpr92c128whvakwgrm9pq2zf6ijpl5sh7014zb"))))
-    (build-system gnu-build-system)
+                "1p1jd4h274jvcvl05l01v9bj19zhq4sjag92v1zawyi93ib85abz"))))
+    (build-system cmake-build-system)
     (arguments
-     `(#:make-flags '("CXXFLAGS=-lasound")))
+     '(#:tests? #f)) ; no check target
     (inputs
      `(("alsa-lib" ,alsa-lib)
        ("jack" ,jack-1)
-       ("sdl" ,sdl)
+       ("sdl" ,sdl2)
        ("zlib" ,zlib)))
     (native-inputs
      `(("pkg-config" ,pkg-config)))
@@ -2157,6 +2158,9 @@ the popular DOS program Fasttracker II, with special playback modes available
 for improved Amiga ProTracker 2/3 compatibility.")
     (home-page "http://milkytracker.titandemo.org/")
     ;; 'src/milkyplay' is under Modified BSD, the rest is under GPL3 or later.
+    ;; Also, songs installed in share/milkytracker/songs are licensed under the
+    ;; Creative Commons Attribution-Noncommericial-Share Alike 3.0 Unported
+    ;; License.
     (license (list license:bsd-3 license:gpl3+))))
 
 (define-public schismtracker
-- 
2.12.0