GNU bug report logs - #26268
[PATCH] gnu: Add emacs-idle-highlight.

Previous Next

Full log

View this message in rfc822 format

From: Catonano <catonano <at> gmail.com>
To: Vasile Dumitrascu <va511e <at> yahoo.com>
Cc: 26268 <at> debbugs.gnu.org
Subject: bug#26268: [PATCH] gnu: Add emacs-idle-highlight.
Date: Wed, 29 Mar 2017 13:40:04 +0200

[Message part 1 (text/plain, inline)]

Hi Vasile,

2017-03-28 22:12 GMT+02:00 Vasile Dumitrascu <va511e <at> yahoo.com>:

> * gnu/packages/emacs.scm (emacs-idle-highlight): New variable.
> ---
>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 1becc28dd..358748cbf 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -3962,3 +3962,26 @@ abbreviation and automatically expand it into
> function templates.")
>     (description "@code{emacs-memoize} is an Emacs library for
>  memoizing functions.")
>     (license license:unlicense)))
> +
> +(define-public emacs-idle-highlight
> +  (package
> +    (name "emacs-idle-highlight")
> +    (version "1.1.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/nonsequitur/idle-highlight-mode/archive/
> "
> +             version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0kdv10hrgqpskjh0zvpnzwlkn5bccnqxas62gkws6njln57bf8nl"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://www.emacswiki.org/emacs/IdleHighlight")
> +    (synopsis "Highlights all occurences of the word the point is on")
> +    (description
> +     "This Emacs package provides @code{idle-highlight-mode} that sets
> + an idle timer to highlight all occurences in the buffer of the word under
> + the point.")
> +    (license license:gpl3+))
>

After the correction with the github url, I installed this package and it
works. It beautifully highlights words occurrences

So, as far as I'm concerned, this can be merged.

As a side note, you sent some one more patch after this one and that
depends on this one so it can't be applied

After that you sent a couple more in the same way

This requires the reviewers to reconstruct the chain in order to apply the
patches.

For the future, it would be preferable if you would send a first message to
guix-patches to open a ticket and then reply to that first message with
your patches attached.

Alternatively, you can use this command line (suggested by Marius Bakke):

git format-patch -n origin/master --stdout > series.patch

in this way, ALL the patches in your branch will be contained in a single
file (series.patch)

You can send that single file to guix-patches

Thank you and welcome !

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.