GNU bug report logs - #26264
[PATCH 0/1] Use '@' to separate name, version in package-full-name

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: alex.sassmannshausen <at> gmail.com, 26264 <at> debbugs.gnu.org
Subject: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name
Date: Sun, 07 May 2017 17:37:33 +0200

Hello!

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

> From 43892525fc981533445e60a649425791cc315d0a Mon Sep 17 00:00:00 2001
> From: Tobias Geerinckx-Rice <me <at> tobias.gr>
> Date: Sat, 6 May 2017 14:32:12 +0200
> Subject: [PATCH 4/4] packages: Use "@" as a version separator.
>
> * guix/packages.scm (package-full-name): Use "@" instead of "-" to separate
> PACKAGE-NAME and PACKAGE-VERSION.
> ---
>  guix/packages.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index 44f2c32fb..802405102 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -385,8 +385,8 @@ object."
>  
>  
>  (define (package-full-name package)
> -  "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
> -  (string-append (package-name package) "-" (package-version package)))
> +  "Return the full name of PACKAGE--i.e., `NAME <at> VERSION'."
> +  (string-append (package-name package) "@" (package-version package)))

WDYT of making it:

  (define* (package-full-name package #:optional (separator "@"))
    …)

?

(I think I suggested it somewhere, but maybe not.  :-))

That would make the adjustments to places that need a hyphen slightly
shorter.

Thanks, and good luck with your new $DAYJOB!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.