From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 26 08:26:41 2017 Received: (at submit) by debbugs.gnu.org; 26 Mar 2017 12:26:41 +0000 Received: from localhost ([127.0.0.1]:45110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cs7Fo-0005IG-WF for submit@debbugs.gnu.org; Sun, 26 Mar 2017 08:26:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cs7Fm-0005Hx-Au for submit@debbugs.gnu.org; Sun, 26 Mar 2017 08:26:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cs7Fg-0001wg-51 for submit@debbugs.gnu.org; Sun, 26 Mar 2017 08:26:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59176) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cs7Fg-0001wY-1R for submit@debbugs.gnu.org; Sun, 26 Mar 2017 08:26:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cs7Fe-0005xB-RK for guix-patches@gnu.org; Sun, 26 Mar 2017 08:26:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cs7Fb-0001uk-Ob for guix-patches@gnu.org; Sun, 26 Mar 2017 08:26:30 -0400 Received: from mail-wr0-x22a.google.com ([2a00:1450:400c:c0c::22a]:36011) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cs7Fb-0001uA-Il for guix-patches@gnu.org; Sun, 26 Mar 2017 08:26:27 -0400 Received: by mail-wr0-x22a.google.com with SMTP id w11so8127954wrc.3 for ; Sun, 26 Mar 2017 05:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=G3UyxwTHTBoYsoOCHROmNSPheRtT9NcJ6swSV5hx0No=; b=kPzneMUROC+alWbUEhZhKDTkGRngufkDN2XgR78TQs5LelJuhDMZQH/a9tBWDnXUnF 1n23j2UX/xumq0f5qHy3kJ+zFZpUnJfiFbX7MNb6TSYDUUB0WUa2M1IpvNTDM+uadzo0 Idc3co+G5XMUDL3fcge9KV+bceVht1PBiJReg3j1Afjaz3VUfpsxeWQaKxeIjx+o0byI eiTT570LE5jztx8bgRuDeOWvMFHCvPj3C1PzxLetHyhi1cD5ofRkx5UcEzh1jAoBDrEU xkQNDdViY8TqlIKnF6AU+uc6DJBfftGNba/wzpV5FJTTLtrdsMSxh4LImN5I2JrP5Ej/ okQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=G3UyxwTHTBoYsoOCHROmNSPheRtT9NcJ6swSV5hx0No=; b=mUJEfE4s+J0eF/PAZP2KtHB5/k3NPBvOIbxZ4jAKNiQb15SurbCHfdv33A2KmEcBT3 IQHNVKcukqIwyuLB2piEKIxALwlpGxhDvHLTawl03wuDT2IQymvA0cBHwgvJkU15EYTS HQm8zpbmKz/0e+5nU835LTHitTX7QIu+nE3aHDyNGGNQqZc/5zzwfE5WO2jStTSDYyXw PgRijafUb+3jZvQyRHsTawlItatdOQ5BJz6h/XbS8Mwb1Qcwaq8Mak1vaN3uEmKVLGAv W6IgUrxIBOuUchcZhhz4V8KERnzbPvzy3o3buORg2WdDyWYEgaCxzH3ac7Ht4Nrz9Z1u qVdA== X-Gm-Message-State: AFeK/H1t3q4xd9J7OnMyOgO7b37jZf1s67BzadQQCgn2mmOPuEQgjVN0O22ts4DYK9wTGA== X-Received: by 10.223.157.14 with SMTP id k14mr5863081wre.28.1490531186259; Sun, 26 Mar 2017 05:26:26 -0700 (PDT) Received: from localhost.localdomain (192.71-65-87.adsl-dyn.isp.belgacom.be. [87.65.71.192]) by smtp.gmail.com with ESMTPSA id 35sm10692468wrn.9.2017.03.26.05.26.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Mar 2017 05:26:24 -0700 (PDT) From: Alex Sassmannshausen X-Google-Original-From: Alex Sassmannshausen To: guix-patches@gnu.org Subject: [PATCH 0/1] Use '@' to separate name, version in package-full-name Date: Sun, 26 Mar 2017 14:25:54 +0200 Message-Id: <20170326122555.22366-1-alex@pompo.co> X-Mailer: git-send-email 2.12.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Alex Sassmannshausen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello, Currently, when `guix refresh -l` is used, package names are emitted with a '-' separator. This means the output from guix refresh -l cannot be used to issue guix commands. This patch addresses the issue by adding an optional parameter `for-ui` to `package-full-name`, which, when passed, results in package names being emitted with the '@' separator. There are several other approaches that could be taken: * change the behaviour of package-full-name by default to use '@'. This would result in significant semantic changes in different places in Guix, where '-' is expected. * Don't use package-full-name in guix refresh -l's `list-dependents`. Instead just emit the package name, not the full name, or manually concatenate name '@' version. I prefer adding the optional parameter to full-name as `package-full-name` is used in different places for emitting UI package names, and we probably want to switch all of those to the '@' semantics over time. WDYT? Alex Alex Sassmannshausen (1): packages: Add optional `for-ui` param to `package-full-name`. guix/packages.scm | 9 +++++---- guix/scripts/refresh.scm | 6 +++--- tests/packages.scm | 4 ++++ 3 files changed, 12 insertions(+), 7 deletions(-) -- 2.12.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 26 10:56:13 2017 Received: (at 26264) by debbugs.gnu.org; 26 Mar 2017 14:56:13 +0000 Received: from localhost ([127.0.0.1]:46057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cs9aW-0007xg-Tt for submit@debbugs.gnu.org; Sun, 26 Mar 2017 10:56:13 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:41247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cs9aU-0007xS-Np for 26264@debbugs.gnu.org; Sun, 26 Mar 2017 10:56:11 -0400 Received: from mfilter16-d.gandi.net (mfilter16-d.gandi.net [217.70.178.144]) by relay5-d.mail.gandi.net (Postfix) with ESMTP id CB94241C080; Sun, 26 Mar 2017 16:56:08 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter16-d.gandi.net Received: from relay5-d.mail.gandi.net ([IPv6:::ffff:217.70.183.197]) by mfilter16-d.gandi.net (mfilter16-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id wOIwZ_jIEZH8; Sun, 26 Mar 2017 16:56:07 +0200 (CEST) X-Originating-IP: 84.196.237.164 Received: from [192.168.0.100] (d54C4EDA4.access.telenet.be [84.196.237.164]) (Authenticated sender: me@tobias.gr) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id D941941C088; Sun, 26 Mar 2017 16:56:06 +0200 (CEST) Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name To: alex.sassmannshausen@gmail.com, 26264@debbugs.gnu.org References: <20170326122555.22366-1-alex@pompo.co> From: Tobias Geerinckx-Rice Message-ID: <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> Date: Sun, 26 Mar 2017 16:57:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170326122555.22366-1-alex@pompo.co> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Mi3PMxv5sR01d1t959brKSS259M2fGXqM" X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 26264 Cc: alex@pompo.co X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Mi3PMxv5sR01d1t959brKSS259M2fGXqM Content-Type: multipart/mixed; boundary="Ag0QACcNx02OH5quFbC9KS7NAdmLpVEAT"; protected-headers="v1" From: Tobias Geerinckx-Rice To: alex.sassmannshausen@gmail.com, 26264@debbugs.gnu.org Cc: alex@pompo.co Message-ID: <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name References: <20170326122555.22366-1-alex@pompo.co> In-Reply-To: <20170326122555.22366-1-alex@pompo.co> --Ag0QACcNx02OH5quFbC9KS7NAdmLpVEAT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alex, (I'm tempted to CC bug #26239 to mirror this discussion there, but I'm not sure if debbugs would DTRT.) On 26/03/17 14:25, Alex Sassmannshausen wrote: > There are several other approaches that could be taken: >=20 > * change the behaviour of package-full-name by default to use '@'. This is the tabula-rasa (well, =CA=95=E3=83=8E=E2=80=A2=E1=B4=A5=E2=80=A2= =CA=94=E3=83=8E =EF=B8=B5 =E2=94=BB=E2=94=81=E2=94=BB) approach I took my= self. > This would result in significant semantic changes in different places > in Guix, where '-' is expected. Could you expand on what these are? My assumptions were: - This touches mainly (only? but then I don't use fancy things like emacs-guix) UI messages, or I missed it. - If someone's scripts do rely on parsing this kind of output, they're living on borrowed time, and will need to fix their scripts anyway. - =E2=80=98-=E2=80=99's been deprecated for quite a long while, and the= next core-updates cycle is a good time to purge the last remnants of it. Of course, this patch is about 2 cycles old by now... - If we're rebuilding the whole world for this we should get it right. These assumptions may well be wrong (hence the call for feedback). Thoughts? T G-R --Ag0QACcNx02OH5quFbC9KS7NAdmLpVEAT-- --Mi3PMxv5sR01d1t959brKSS259M2fGXqM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEqBAEBCgAUBQJY19bCDRxtZUB0b2JpYXMuZ3IACgkQkczbm0hUG5noYwf/RasI GYdv+b95k81Eqqe4KVsBMeZIca2cfz3vUoWTGzddLZTvvLw3bMYdU5iFpNKadHle xvfpAjyrRRtyrcH3wD+YJPfEcmZf96arKMriOhh00PUEDZz4ISbEXBnV4r6N2UIO /CPelt1d5A6UfKoYebrR6vuRrUw6xJQ1qUVDseEGIqiL8LwjkJM7NGFr9aPIoCXA vyRMgjmtFx+uwaVslTrZsDO0ZPvb2CNreXgDI9ZU6i4cPbkuiVzf0MlZjrjOxrnz SBEafyApHbF4UCEJVzWRQGqNMbLmrw4zU9jJ6Fs79CbsSyd3BW1NYnpn6Am1rXmV BQSBZ31x96sXD/uF1A== =Twlq -----END PGP SIGNATURE----- --Mi3PMxv5sR01d1t959brKSS259M2fGXqM-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 26 14:41:55 2017 Received: (at 26264) by debbugs.gnu.org; 26 Mar 2017 18:41:55 +0000 Received: from localhost ([127.0.0.1]:46162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csD6x-0004wq-3Y for submit@debbugs.gnu.org; Sun, 26 Mar 2017 14:41:55 -0400 Received: from mail-wr0-f172.google.com ([209.85.128.172]:35294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csD6v-0004wd-3q for 26264@debbugs.gnu.org; Sun, 26 Mar 2017 14:41:53 -0400 Received: by mail-wr0-f172.google.com with SMTP id u1so27059231wra.2 for <26264@debbugs.gnu.org>; Sun, 26 Mar 2017 11:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:reply-to:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=dbhtxvBNlLCRxY/H62iMlMUsDh81/zPL98lZAMnWM7E=; b=TAC6znTKxadPdYqKumPvZG8w/rQYZ7dPjl1rBizTG7tA8c0gPTZWSrnQ7cDukEiCP4 4asP2QvwI105Ve8D27Fo/lyds17UB4GM6JdXP08hsY8RXNuH7gzH68Hpaj00HQvg/QV2 OXqtL+2X4tH6lixFL0bVgVet66TkECtjF7y7lH6xsDuaLGHBQTgNXraxfZ8cEfCN6W6i 4ulWLzCZYq5rTNDo8JZXPRmE94WDY0A+cwZnCC005xNj7kg1UI4cfaor+iwYgnny9s4O +r92sRAF5YGkYak7MWDtNT9qoOHMnilRHpsKmlfO96CHn/DeqpoE4LMWSW0MtFY2+2U0 +hQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :reply-to:in-reply-to:date:message-id:mime-version :content-transfer-encoding; bh=dbhtxvBNlLCRxY/H62iMlMUsDh81/zPL98lZAMnWM7E=; b=s8fGb2y4zvsFjAiV1HFgOXfU+mBoCCQVloQLLNYFR4jYq5AGIAxkBpEvTs7ta9Zaji hMOKhGctRdiafGZwdiKPGDV96mxUyQBoSQ9/TcPzxaCPO2X65zF/QkEeMXWO84oyjVew t69pftNNe+aSE6FdFEGMURZZXz0e98qJu0wqiEawQ7LgW4Wi0+XwnyWSNMG4JY8fv0tF sD/2psevhR9kykvyxhO1Qof+FTDzQY6VoEUQquwTNlJXD63I/J3znE8ToUwr9F+ZHXGM M56CIVjew0cvqlMVvdYv2vQxaV5dmestij4oQ8vJkfuO6sCU+tNLDjbYg2L+AjTZwSA0 Bw9Q== X-Gm-Message-State: AFeK/H1+hB3LS3/Jvw5MEiobfzPlBwE6Ij5I8d1w1ifzHbH0eB+x1z+GB2zbsVN1HcEDDg== X-Received: by 10.28.146.207 with SMTP id u198mr6344528wmd.103.1490553707391; Sun, 26 Mar 2017 11:41:47 -0700 (PDT) Received: from new-host (192.71-65-87.adsl-dyn.isp.belgacom.be. [87.65.71.192]) by smtp.gmail.com with ESMTPSA id 191sm11317336wmv.25.2017.03.26.11.41.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 26 Mar 2017 11:41:46 -0700 (PDT) References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> User-agent: mu4e 0.9.18; emacs 25.1.1 From: Alex Sassmannshausen To: Tobias Geerinckx-Rice , Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name In-reply-to: <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> Date: Sun, 26 Mar 2017 20:41:40 +0200 Message-ID: <877f3bx4m3.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26264 Cc: 26264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: alex.sassmannshausen@gmail.com Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hey Tobias, Tobias Geerinckx-Rice writes: > Alex, > > (I'm tempted to CC bug #26239 to mirror this discussion there, but I'm > not sure if debbugs would DTRT.) Right — sorry, not sure what the best approach is for that! > > On 26/03/17 14:25, Alex Sassmannshausen wrote: >> There are several other approaches that could be taken: >> >> * change the behaviour of package-full-name by default to use '@'. > > This is the tabula-rasa (well, ʕノ•ᴥ•ʔノ ︵ ┻━┻) approach I took myself. > >> This would result in significant semantic changes in different places >> in Guix, where '-' is expected. > > Could you expand on what these are? The example I encountered which caused me to bail (after having adapted a few unit tests, e.g. in tests/profiles.scm, to expect the new name format), is at `gnu/packages/commencement.scm`, line 234 ff (in `gcc-boot0`): -----------------8<------------------>8---------------- ,@(map (lambda (lib) ;; Drop trailing letters, as gmp-6.0.0a unpacks ;; into gmp-6.0.0. `(symlink ,(string-trim-right (package-full-name lib) char-set:letter) ,(package-name lib))) (list gmp-6.0 mpfr mpc)))) -----------------8<------------------>8---------------- It seems `package-full-name` is here used to write symlinks. I'm afraid I don't understand the context well enough to ascertain what effect changing this to '@' based writing would have. > My assumptions were: > > - This touches mainly (only? but then I don't use fancy things > like emacs-guix) UI messages, or I missed it. Right, that's what I had hoped too. > - If someone's scripts do rely on parsing this kind of output, they're > living on borrowed time, and will need to fix their scripts anyway. Well… I guess it all depends on whether the function is intended for file-system or UI name generation, and whether file-system filenames should have a different format from UI names… > - ‘-’'s been deprecated for quite a long while, and the next > core-updates cycle is a good time to purge the last remnants of it. > Of course, this patch is about 2 cycles old by now... Right, agreed, in the UI context; don't know about filename schemes. > - If we're rebuilding the whole world for this we should get it right. Agreed. HTH, Alex From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 11:03:22 2017 Received: (at 26264) by debbugs.gnu.org; 28 Mar 2017 15:03:22 +0000 Received: from localhost ([127.0.0.1]:49461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csseX-0002bC-V0 for submit@debbugs.gnu.org; Tue, 28 Mar 2017 11:03:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csseU-0002av-Um for 26264@debbugs.gnu.org; Tue, 28 Mar 2017 11:03:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csseN-00054Z-5x for 26264@debbugs.gnu.org; Tue, 28 Mar 2017 11:03:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csseN-00054V-3F; Tue, 28 Mar 2017 11:03:11 -0400 Received: from [193.50.110.98] (port=54616 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1csseM-00018e-G4; Tue, 28 Mar 2017 11:03:10 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Alex Sassmannshausen Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 Germinal an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Tue, 28 Mar 2017 17:03:07 +0200 In-Reply-To: <877f3bx4m3.fsf@gmail.com> (Alex Sassmannshausen's message of "Sun, 26 Mar 2017 20:41:40 +0200") Message-ID: <87h92d30lw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26264 Cc: Tobias Geerinckx-Rice , 26264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello! Thanks for addressing this longstanding issue! For the record =E2=80=98package-full-name=E2=80=99 was briefly discussed at= the time: https://lists.gnu.org/archive/html/guix-devel/2016-01/msg00891.html I suppose we=E2=80=99ll have to grep for all uses in the code to see whether they rely on a hyphen for separation, including the web site (and prolly Emacs-Guix.) Alex Sassmannshausen skribis: > The example I encountered which caused me to bail (after having adapted > a few unit tests, e.g. in tests/profiles.scm, to expect the new name > format), is at `gnu/packages/commencement.scm`, line 234 ff (in > `gcc-boot0`): > -----------------8<------------------>8---------------- > ,@(map (lambda (lib) > ;; Drop trailing letters, as gmp-6.0.0a unpac= ks > ;; into gmp-6.0.0. > `(symlink ,(string-trim-right > (package-full-name lib) > char-set:letter) > ,(package-name lib))) > (list gmp-6.0 mpfr mpc)))) > -----------------8<------------------>8---------------- > > It seems `package-full-name` is here used to write symlinks. I'm afraid > I don't understand the context well enough to ascertain what effect > changing this to '@' based writing would have. This code definitely relies on =E2=80=98package-full-name=E2=80=99 using a = hyphen (it computes the name of the directory GMP etc. extract to.) >> - If someone's scripts do rely on parsing this kind of output, they're >> living on borrowed time, and will need to fix their scripts anyway. > > Well=E2=80=A6 I guess it all depends on whether the function is intended = for > file-system or UI name generation, and whether file-system filenames > should have a different format from UI names=E2=80=A6 Right, I think there have been uses beyond merely UI info, and these are those we need to find by grepping through the code. :-) >> - =E2=80=98-=E2=80=99's been deprecated for quite a long while, and th= e next >> core-updates cycle is a good time to purge the last remnants of it. >> Of course, this patch is about 2 cycles old by now... > > Right, agreed, in the UI context; don't know about filename schemes. +1! That can be done in a subsequent commit. >> - If we're rebuilding the whole world for this we should get it right. > > Agreed. This change should not trigger a full rebuild (the =E2=80=98package-full-na= me=E2=80=99 call in commencement.scm must be adjusted, but that=E2=80=99s fine.) So Alex (or Tobias?), the check list would be: 1. Make sure it=E2=80=99s a zero-rebuild change; if it=E2=80=99s not, it= =E2=80=99s a bug; 2. Grep =E2=80=98package-full-name=E2=80=99 through guix.git and guix-art= work.git and see if any use clearly requires a hyphen; 3. Change the uses in guix-artwork.git (the web site) that uses =E2=80=98package-full-name=E2=80=99 to compute anchors; 4. Make sure =E2=80=98make check=E2=80=99 passes. If we get a green light here, then we can go ahead! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 11:04:20 2017 Received: (at control) by debbugs.gnu.org; 28 Mar 2017 15:04:20 +0000 Received: from localhost ([127.0.0.1]:49465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cssfU-0002cr-Cc for submit@debbugs.gnu.org; Tue, 28 Mar 2017 11:04:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cssfS-0002cd-OS for control@debbugs.gnu.org; Tue, 28 Mar 2017 11:04:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cssfL-0005OP-G7 for control@debbugs.gnu.org; Tue, 28 Mar 2017 11:04:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cssfL-0005O6-DD for control@debbugs.gnu.org; Tue, 28 Mar 2017 11:04:11 -0400 Received: from [193.50.110.98] (port=54624 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cssfK-0003zt-81 for control@debbugs.gnu.org; Tue, 28 Mar 2017 11:04:10 -0400 Date: Tue, 28 Mar 2017 17:04:08 +0200 Message-Id: <87fuhx30k7.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #26265 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 26265 26264 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 11:04:37 2017 Received: (at control) by debbugs.gnu.org; 28 Mar 2017 15:04:37 +0000 Received: from localhost ([127.0.0.1]:49468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cssfl-0002dR-Li for submit@debbugs.gnu.org; Tue, 28 Mar 2017 11:04:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cssfk-0002dD-Ux for control@debbugs.gnu.org; Tue, 28 Mar 2017 11:04:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cssfd-0005T1-ES for control@debbugs.gnu.org; Tue, 28 Mar 2017 11:04:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cssfd-0005Sv-CA for control@debbugs.gnu.org; Tue, 28 Mar 2017 11:04:29 -0400 Received: from [193.50.110.98] (port=54630 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cssfc-0004lO-Qf for control@debbugs.gnu.org; Tue, 28 Mar 2017 11:04:29 -0400 Date: Tue, 28 Mar 2017 17:04:27 +0200 Message-Id: <87efxh30jo.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #26239 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 26239 26264 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 11:18:30 2017 Received: (at 26264) by debbugs.gnu.org; 28 Mar 2017 15:18:30 +0000 Received: from localhost ([127.0.0.1]:49505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csstB-0004l5-Ug for submit@debbugs.gnu.org; Tue, 28 Mar 2017 11:18:30 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:46445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csst9-0004kw-Eo for 26264@debbugs.gnu.org; Tue, 28 Mar 2017 11:18:28 -0400 Received: from mfilter15-d.gandi.net (mfilter15-d.gandi.net [217.70.178.143]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id 8DE31A80F1; Tue, 28 Mar 2017 17:18:26 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter15-d.gandi.net Received: from relay3-d.mail.gandi.net ([IPv6:::ffff:217.70.183.195]) by mfilter15-d.gandi.net (mfilter15-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id inCruux8L95J; Tue, 28 Mar 2017 17:18:24 +0200 (CEST) X-Originating-IP: 81.241.166.83 Received: from [192.168.1.24] (83.166-241-81.adsl-dyn.isp.belgacom.be [81.241.166.83]) (Authenticated sender: me@tobias.gr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 8CE3AA80CB; Tue, 28 Mar 2017 17:18:23 +0200 (CEST) Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name To: ludo@gnu.org, alex.sassmannshausen@gmail.com References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> From: Tobias Geerinckx-Rice Message-ID: <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> Date: Tue, 28 Mar 2017 17:19:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87h92d30lw.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QvPhgfV7DjOTmH78iFs18ojcoBlWr445a" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26264 Cc: 26264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QvPhgfV7DjOTmH78iFs18ojcoBlWr445a Content-Type: multipart/mixed; boundary="IOEtIS8h3dqQRsQdS2goxMcnKmNNLPADJ"; protected-headers="v1" From: Tobias Geerinckx-Rice To: ludo@gnu.org, alex.sassmannshausen@gmail.com Cc: 26264@debbugs.gnu.org Message-ID: <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> In-Reply-To: <87h92d30lw.fsf@gnu.org> --IOEtIS8h3dqQRsQdS2goxMcnKmNNLPADJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 28/03/17 17:03, Ludovic Court=C3=A8s wrote: > So Alex (or Tobias?) It's up to Alex. I wouldn't mind giving this a try, or not. Kind regards, T G-R --IOEtIS8h3dqQRsQdS2goxMcnKmNNLPADJ-- --QvPhgfV7DjOTmH78iFs18ojcoBlWr445a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAljafvsNHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmUYfB/wItEIvNpaV3ofrNeEKO1fny4xWPYO7toSR60fO eG7XFkOMPPN2+JEb32gspfrK/D15Tj47GSmPyCvg5vc6V9+er3B9pTQazPed6Dvr hKZ46dRQNaR+7W+x0nPKDtORB8MqFfcbG/tnZDHwYy7MIgfQEoFQXLBDsZpsTVhj Xd4pdzZxYKVdFwRQfw4ks+PghnlAZT58x/7oggkjmVn9wVC8z+zf3uQDFzgtzTLb LVMeqiY2PcABUDYyXUcTFodIuL0p/Excw2ABpeOcZQaPxKYoAWpgz4sMiyX3ueXD ulp0jnG2LyOJzFy0N5jTLsG+5gQmec7VwJdV8ucVB5+iHDAs =lUlH -----END PGP SIGNATURE----- --QvPhgfV7DjOTmH78iFs18ojcoBlWr445a-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 15:53:13 2017 Received: (at 26264) by debbugs.gnu.org; 28 Mar 2017 19:53:13 +0000 Received: from localhost ([127.0.0.1]:49660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csxB2-00037a-UP for submit@debbugs.gnu.org; Tue, 28 Mar 2017 15:53:13 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:42208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csxB1-00037S-90 for 26264@debbugs.gnu.org; Tue, 28 Mar 2017 15:53:12 -0400 Received: from mfilter42-d.gandi.net (mfilter42-d.gandi.net [217.70.178.172]) by relay7-d.mail.gandi.net (Postfix) with ESMTP id 522D373A; Tue, 28 Mar 2017 21:53:10 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter42-d.gandi.net Received: from relay7-d.mail.gandi.net ([IPv6:::ffff:217.70.183.200]) by mfilter42-d.gandi.net (mfilter42-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id yvQ5M9hP7B11; Tue, 28 Mar 2017 21:48:09 +0200 (CEST) X-Originating-IP: 81.82.199.35 Received: from [192.168.1.110] (d5152c723.static.telenet.be [81.82.199.35]) (Authenticated sender: me@tobias.gr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 95DA9CF3; Tue, 28 Mar 2017 21:48:08 +0200 (CEST) Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name To: ludo@gnu.org References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> <87o9wl1j3k.fsf@gnu.org> From: Tobias Geerinckx-Rice Message-ID: Date: Tue, 28 Mar 2017 21:49:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87o9wl1j3k.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="t1wTOoWxpsUOSqfhkbw9vSW4oFkVcorkm" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26264 Cc: 26264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --t1wTOoWxpsUOSqfhkbw9vSW4oFkVcorkm Content-Type: multipart/mixed; boundary="5rgrjJ3820uTWHhq5O0gSS8TdIaLnc8k6"; protected-headers="v1" From: Tobias Geerinckx-Rice To: ludo@gnu.org Cc: 26264@debbugs.gnu.org Message-ID: Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> <87o9wl1j3k.fsf@gnu.org> In-Reply-To: <87o9wl1j3k.fsf@gnu.org> --5rgrjJ3820uTWHhq5O0gSS8TdIaLnc8k6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 28/03/17 18:06, Ludovic Court=C3=A8s wrote: > There were 3 different numbers for the same thing (yours plus the two > opened by Alex), which is why I merged them. I know :-) I was just surprised that I didn't get notifications about that via e-mail. Kind regards, T G-R --5rgrjJ3820uTWHhq5O0gSS8TdIaLnc8k6-- --t1wTOoWxpsUOSqfhkbw9vSW4oFkVcorkm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAljavjQNHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmZI1CACWqYjlO172Ke6DYBk3grQ33Jn/qvo1F7o4ApbA 9qMEUl2wAvKe9UMub+Gbq31LbM1RhHMRC5oDmmH1+DXVQNBJZ/t63JCZFVGRlDI0 h8LacvUayAei7uBj4MeGAFfARkFdMtoK4ekQX4qQQe12i9n4T3/ZnpMLtmT94L9/ 4OAUyv2b9pfpm7NO/Bqq95yG224jHp09JDzRAtR/lYH6iP66W3cFrpaW8ayEBmBo Jwqw7HiBjdEjmJ1UIzMbuhoQ6QNF9Zo+9Xy/gX/Iey6CUrivAFfoWxn48Yin5fah XCUjSC8c4L4OuFYiujYKL5danRh7drZD1tGOsksbWkpTcyH7 =90Sp -----END PGP SIGNATURE----- --t1wTOoWxpsUOSqfhkbw9vSW4oFkVcorkm-- From unknown Mon Jun 23 14:57:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 26 Apr 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 14:28:54 2017 Received: (at control) by debbugs.gnu.org; 6 May 2017 18:28:55 +0000 Received: from localhost ([127.0.0.1]:58530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d74Rq-0003QG-MX for submit@debbugs.gnu.org; Sat, 06 May 2017 14:28:54 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:35736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d74Rp-0003Q8-LD for control@debbugs.gnu.org; Sat, 06 May 2017 14:28:53 -0400 Received: from mfilter16-d.gandi.net (mfilter16-d.gandi.net [217.70.178.144]) by relay2-d.mail.gandi.net (Postfix) with ESMTP id 038B9C5A46 for ; Sat, 6 May 2017 20:28:52 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter16-d.gandi.net Received: from relay2-d.mail.gandi.net ([IPv6:::ffff:217.70.183.194]) by mfilter16-d.gandi.net (mfilter16-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id qd1h5HaXOCZH for ; Sat, 6 May 2017 20:28:50 +0200 (CEST) X-Originating-IP: 84.196.237.164 Received: from [192.168.0.100] (d54c4eda4.access.telenet.be [84.196.237.164]) (Authenticated sender: me@tobias.gr) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 642FAC5A51 for ; Sat, 6 May 2017 20:28:50 +0200 (CEST) To: control@debbugs.gnu.org From: Tobias Geerinckx-Rice Message-ID: Date: Sat, 6 May 2017 20:30:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MIrGv8QqPqBblUMSNXt7kMfIn7lLpVoMD" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unarchive 26264 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.183.194 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [217.70.183.194 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 TVD_SPACE_RATIO No description available. 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unarchive 26264 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [217.70.183.194 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.183.194 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 TVD_SPACE_RATIO No description available. 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MIrGv8QqPqBblUMSNXt7kMfIn7lLpVoMD Content-Type: multipart/mixed; boundary="DEbTsHslwHaH8UMaJtJrvnHShKk5oGrLg"; protected-headers="v1" From: Tobias Geerinckx-Rice To: control@debbugs.gnu.org Message-ID: --DEbTsHslwHaH8UMaJtJrvnHShKk5oGrLg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable unarchive 26264 --DEbTsHslwHaH8UMaJtJrvnHShKk5oGrLg-- --MIrGv8QqPqBblUMSNXt7kMfIn7lLpVoMD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAlkOFjENHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmWpkCACsc70NL5OOwhAmkeXGZeNjXdmr4r+2FR6JEeuk +FjibIG0JXxOkOQfyaAeaMletbplyKNIss/TBqIcDCKZfL09LTc33fuFJF4WM0+r 99XVTSTOD8XtuPzJdWeSZKO5dVvsiuaOxF6AqWe/+EaUUQubSZIHn3d7EEvxOkeJ WvbaKYXI/YU/D9fLvdj3Eb+99nb+JNJG30u5JJw+G1J5OvyCwfxRb1h8ayQZXSih KUlcYUVuYiDH34HPD/wX3cOk6M8BDOZgz6FaEhM0ORxjyFkulCh/5v1m26m2bfap nJLt8zVNQMTNzdAEtFNdPyCcTvwaEGWcUtUDH2FQAzIo8RD+ =bcxL -----END PGP SIGNATURE----- --MIrGv8QqPqBblUMSNXt7kMfIn7lLpVoMD-- From unknown Mon Jun 23 14:57:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Sat, 06 May 2017 18:31:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 14:31:01 2017 Received: (at 26264) by debbugs.gnu.org; 6 May 2017 18:31:02 +0000 Received: from localhost ([127.0.0.1]:58538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d74Tt-0004M5-9v for submit@debbugs.gnu.org; Sat, 06 May 2017 14:31:01 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:50961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d74Tr-0004K0-GR for 26264@debbugs.gnu.org; Sat, 06 May 2017 14:31:00 -0400 Received: from mfilter15-d.gandi.net (mfilter15-d.gandi.net [217.70.178.143]) by relay9-d.mail.gandi.net (Postfix) with ESMTP id A7502406F2; Sat, 6 May 2017 20:30:58 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter15-d.gandi.net Received: from relay9-d.mail.gandi.net ([IPv6:::ffff:217.70.183.199]) by mfilter15-d.gandi.net (mfilter15-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id WEMUCD3V_20s; Sat, 6 May 2017 20:30:56 +0200 (CEST) X-Originating-IP: 84.196.237.164 Received: from [192.168.0.100] (d54c4eda4.access.telenet.be [84.196.237.164]) (Authenticated sender: me@tobias.gr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 78EF3406FC; Sat, 6 May 2017 20:30:56 +0200 (CEST) From: Tobias Geerinckx-Rice Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name To: ludo@gnu.org, alex.sassmannshausen@gmail.com References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> Message-ID: <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> Date: Sat, 6 May 2017 20:32:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CoT2HdjATo7gPB4USLglurN3bPKxnatdv" X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 26264 Cc: 26264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CoT2HdjATo7gPB4USLglurN3bPKxnatdv Content-Type: multipart/mixed; boundary="5DS8cntVJCTsNR9Fx1nsmnRJs9vpdxIHd"; protected-headers="v1" From: Tobias Geerinckx-Rice To: ludo@gnu.org, alex.sassmannshausen@gmail.com Cc: 26264@debbugs.gnu.org Message-ID: <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> In-Reply-To: <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> --5DS8cntVJCTsNR9Fx1nsmnRJs9vpdxIHd Content-Type: multipart/mixed; boundary="------------18E772816FBEEA32C902CC8C" This is a multi-part message in MIME format. --------------18E772816FBEEA32C902CC8C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Guix, On 28/03/17 17:19, Tobias Geerinckx-Rice wrote: > I wouldn't mind giving this a try, or not. More revenge from the pre-new-job-mailbag. I'm sticking to my original patch, and changed the problematic callers to not use =E2=80=98package-full-name=E2=80=99 at all. I don't think it's= the right abstraction in any of those cases. See the overly verbose commit messages= =2E Kind regards, T G-R --------------18E772816FBEEA32C902CC8C Content-Type: text/x-patch; name="0004-packages-Use-as-a-version-separator.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0004-packages-Use-as-a-version-separator.patch" =46rom 43892525fc981533445e60a649425791cc315d0a Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Sat, 6 May 2017 14:32:12 +0200 Subject: [PATCH 4/4] packages: Use "@" as a version separator. * guix/packages.scm (package-full-name): Use "@" instead of "-" to separa= te PACKAGE-NAME and PACKAGE-VERSION. --- guix/packages.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/guix/packages.scm b/guix/packages.scm index 44f2c32fb..802405102 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -385,8 +385,8 @@ object." =20 =20 (define (package-full-name package) - "Return the full name of PACKAGE--i.e., `NAME-VERSION'." - (string-append (package-name package) "-" (package-version package))) + "Return the full name of PACKAGE--i.e., `NAME@VERSION'." + (string-append (package-name package) "@" (package-version package))) =20 (define (%standard-patch-inputs) (let* ((canonical (module-ref (resolve-interface '(gnu packages base))= --=20 2.12.2 --------------18E772816FBEEA32C902CC8C Content-Type: text/x-patch; name="0003-profiles-Don-t-use-PACKAGE-FULL-NAME.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0003-profiles-Don-t-use-PACKAGE-FULL-NAME.patch" =46rom 0325e536cf557ff48d885948bf5fab8f59bfc444 Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Sat, 6 May 2017 14:32:06 +0200 Subject: [PATCH 3/4] profiles: Don't use PACKAGE-FULL-NAME. The non-hash parts of store paths aren't constructed according to PACKAGE-FULL-NAME rules. They just happened to match in the past. * tests/profile.scm ("profile-derivation, cross-compilation"): Use PACKAGE-NAME and PACKAGE-VERSION directly. --- tests/profiles.scm | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/profiles.scm b/tests/profiles.scm index d0b1e14a8..68e73c4ca 100644 --- a/tests/profiles.scm +++ b/tests/profiles.scm @@ -230,15 +230,18 @@ (and (string-suffix? name input) input))) (derivation-inputs drv)))) =20 + (define (package-store-suffix package) + (string-append (package-name package) "-" (package-version package= ))) + ;; The inputs for grep and sed should be cross-build derivations, bu= t that ;; for the glibc-utf8-locales should be a native build. (return (and (string=3D? (derivation-system drv) (%current-system)) - (string=3D? (find-input (package-full-name packages:gre= p)) + (string=3D? (find-input (package-store-suffix packages:= grep)) (derivation-file-name grep)) - (string=3D? (find-input (package-full-name packages:sed= )) + (string=3D? (find-input (package-store-suffix packages:= sed)) (derivation-file-name sed)) (string=3D? (find-input - (package-full-name packages:glibc-utf8-local= es)) + (package-store-suffix packages:glibc-utf8-lo= cales)) (derivation-file-name locales)))))) =20 (test-assert "package->manifest-entry defaults to \"out\"" --=20 2.12.2 --------------18E772816FBEEA32C902CC8C Content-Type: text/x-patch; name="0002-gnu-gcc-boot0-Don-t-use-PACKAGE-FULL-NAME.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0002-gnu-gcc-boot0-Don-t-use-PACKAGE-FULL-NAME.patch" =46rom f10c4fb9d269b85f9c388356a17c2b8b2fc54bd5 Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Sat, 6 May 2017 14:31:56 +0200 Subject: [PATCH 2/4] gnu: gcc-boot0: Don't use PACKAGE-FULL-NAME. Don't use Guix's naming conventions where a different one is expected. * gnu/packages/commencement.scm (gcc-boot0)[arguments]: Use PACKAGE-NAME and PACKAGE-VERSION directly. --- gnu/packages/commencement.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.sc= m index 92f6e6c2e..dd3261e37 100644 --- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -255,7 +255,8 @@ ;; Drop trailing letters, as gmp-6.0.0a unpa= cks ;; into gmp-6.0.0. `(symlink ,(string-trim-right - (package-full-name lib) + (string-append (package-name lib= ) "-" + (package-version = lib)) char-set:letter) ,(package-name lib))) (list gmp-6.0 mpfr mpc)))) --=20 2.12.2 --------------18E772816FBEEA32C902CC8C Content-Type: text/x-patch; name="0001-graph-Don-t-use-PACKAGE-FULL-NAME.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-graph-Don-t-use-PACKAGE-FULL-NAME.patch" =46rom c090e526e21a960f34f0f02f9904757952d5a36e Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Sat, 6 May 2017 14:31:48 +0200 Subject: [PATCH 1/4] graph: Don't use PACKAGE-FULL-NAME. Derivation files aren't named according to PACKAGE-FULL-NAME rules. We already forfeit any supposed abstraction by manually adding ".drv". * tests/graph.scm ("bag-emerged DAG"): Use PACKAGE-NAME and PACKAGE-VERSI= ON directly. --- tests/graph.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/graph.scm b/tests/graph.scm index 6431c482f..53475597a 100644 --- a/tests/graph.scm +++ b/tests/graph.scm @@ -130,7 +130,9 @@ edges." (map (lambda (destination) (list "p-0.drv" (string-append - (package-full-name destination) + (package-name destination) + "-" + (package-version destination) ".drv"))) implicit))))))) =20 --=20 2.12.2 --------------18E772816FBEEA32C902CC8C-- --5DS8cntVJCTsNR9Fx1nsmnRJs9vpdxIHd-- --CoT2HdjATo7gPB4USLglurN3bPKxnatdv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAlkOFq8NHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmYDxB/0ZmIHqYf3TIgbaIGSY2qEuy7i7nieB5bghMNlJ zirX/uCsjAkC5S/Gc+UaPPftJ9KO+Zb7HqsKp7pE9s8T3eX+92fNN9Pnrc2/psrg IQ8K5fTuo/doAApwug6mN4P9605tqfWFvDmg40bKUMiizWXJ97jnBs5Ah65fa0CP 5mgU8r/QyNGNG7jf3wmah4ya5pcZSRNBLJ863gsggdH9oOaNgzRaOFrPjg9UNFNv R8zPwjqbg2fFTPV5Iu1DHsb1dIWN3ws6sF0pGUCCZeiptJgDHtXM/tGNc/4/vVgA JO6hHoGrySvA0GHPpC1M2zLzeMYUpc94pqzMbQqNPLCi6o6d =+3RC -----END PGP SIGNATURE----- --CoT2HdjATo7gPB4USLglurN3bPKxnatdv-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 11:37:46 2017 Received: (at 26264) by debbugs.gnu.org; 7 May 2017 15:37:46 +0000 Received: from localhost ([127.0.0.1]:60496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7OFl-0000Fw-Oz for submit@debbugs.gnu.org; Sun, 07 May 2017 11:37:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7OFk-0000Fk-2q for 26264@debbugs.gnu.org; Sun, 07 May 2017 11:37:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7OFb-0000UF-PQ for 26264@debbugs.gnu.org; Sun, 07 May 2017 11:37:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7OFb-0000U9-MC; Sun, 07 May 2017 11:37:35 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:52376 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d7OFb-0005T0-1c; Sun, 07 May 2017 11:37:35 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Tobias Geerinckx-Rice Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 18 =?utf-8?Q?Flor=C3=A9al?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sun, 07 May 2017 17:37:33 +0200 In-Reply-To: <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> (Tobias Geerinckx-Rice's message of "Sat, 6 May 2017 20:32:14 +0200") Message-ID: <87bmr4ptj6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26264 Cc: alex.sassmannshausen@gmail.com, 26264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello! Tobias Geerinckx-Rice skribis: > From 43892525fc981533445e60a649425791cc315d0a Mon Sep 17 00:00:00 2001 > From: Tobias Geerinckx-Rice > Date: Sat, 6 May 2017 14:32:12 +0200 > Subject: [PATCH 4/4] packages: Use "@" as a version separator. > > * guix/packages.scm (package-full-name): Use "@" instead of "-" to separa= te > PACKAGE-NAME and PACKAGE-VERSION. > --- > guix/packages.scm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/guix/packages.scm b/guix/packages.scm > index 44f2c32fb..802405102 100644 > --- a/guix/packages.scm > +++ b/guix/packages.scm > @@ -385,8 +385,8 @@ object." >=20=20 >=20=20 > (define (package-full-name package) > - "Return the full name of PACKAGE--i.e., `NAME-VERSION'." > - (string-append (package-name package) "-" (package-version package))) > + "Return the full name of PACKAGE--i.e., `NAME@VERSION'." > + (string-append (package-name package) "@" (package-version package))) WDYT of making it: (define* (package-full-name package #:optional (separator "@")) =E2=80=A6) ? (I think I suggested it somewhere, but maybe not. :-)) That would make the adjustments to places that need a hyphen slightly shorter. Thanks, and good luck with your new $DAYJOB! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 17:12:15 2017 Received: (at 26264) by debbugs.gnu.org; 7 May 2017 21:12:15 +0000 Received: from localhost ([127.0.0.1]:60849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7TTS-0005KJ-Q6 for submit@debbugs.gnu.org; Sun, 07 May 2017 17:12:14 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:53161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7TTQ-0005K9-Ey for 26264@debbugs.gnu.org; Sun, 07 May 2017 17:12:13 -0400 Received: from mfilter15-d.gandi.net (mfilter15-d.gandi.net [217.70.178.143]) by relay7-d.mail.gandi.net (Postfix) with ESMTP id 932E6114C; Sun, 7 May 2017 23:12:11 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter15-d.gandi.net Received: from relay7-d.mail.gandi.net ([IPv6:::ffff:217.70.183.200]) by mfilter15-d.gandi.net (mfilter15-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id YLvRP7FHy1AZ; Sun, 7 May 2017 23:12:10 +0200 (CEST) X-Originating-IP: 87.67.124.5 Received: from [192.168.1.24] (5.124-67-87.adsl-dyn.isp.belgacom.be [87.67.124.5]) (Authenticated sender: me@tobias.gr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id C4C92D32; Sun, 7 May 2017 23:12:09 +0200 (CEST) Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name To: ludo@gnu.org References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> <87bmr4ptj6.fsf@gnu.org> From: Tobias Geerinckx-Rice Message-ID: <6a792b17-4e9f-c7ec-6934-8a04a9236bd1@tobias.gr> Date: Sun, 7 May 2017 23:13:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87bmr4ptj6.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="b1Lki3IThNs5wEJL5H5CmoEIXPKXFItVN" X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 26264 Cc: 26264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --b1Lki3IThNs5wEJL5H5CmoEIXPKXFItVN Content-Type: multipart/mixed; boundary="PPMteHPgS855mxD5X2huPg6whI57tHJ8M"; protected-headers="v1" From: Tobias Geerinckx-Rice To: ludo@gnu.org Cc: 26264@debbugs.gnu.org Message-ID: <6a792b17-4e9f-c7ec-6934-8a04a9236bd1@tobias.gr> Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> <87bmr4ptj6.fsf@gnu.org> In-Reply-To: <87bmr4ptj6.fsf@gnu.org> --PPMteHPgS855mxD5X2huPg6whI57tHJ8M Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludo', On 07/05/17 17:37, Ludovic Court=C3=A8s wrote: > WDYT of making it: > (define* (package-full-name package #:optional (separator "@")) > =E2=80=A6) > ? > (I think I suggested it somewhere, but maybe not. :-)) You did! I simply forgot to address it explicitly (=E2=80=98I'm sticking.= =2E.=E2=80=99). > That would make the adjustments to places that need a hyphen slightly > shorter. I considered it back when, but decided not to because it just felt... wrong. That's it. My intuitive, rambling reasoning: - All of the patched ex-callers are manually constructing some raw file or directory name. It includes the package's name and version in some way, but not really Guix's abstract concept of a =E2=80=98package-full-name=E2=80=99 atom. It just happened to be the sa= me string. - Making =E2=80=98separator=E2=80=99 configurable turns =E2=80=98package-= full-name=E2=80=99 into =E2=80=98package-name-version-join=E2=80=99. If one cares about the sep= arator, one also cares about the components, at which point one should just call string-join explicitly. Doing so isn't ugly, and is more clear. Does that make any sense? In the end, I care more about users' ability to finally copy & paste without confusing warnings than my perso'pinions on function naming. This bug has been open for long enough. > Thanks, and good luck with your new $DAYJOB! Thanks! It doesn't involve computers, so it won't last. Kind regards, T G-R --PPMteHPgS855mxD5X2huPg6whI57tHJ8M-- --b1Lki3IThNs5wEJL5H5CmoEIXPKXFItVN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAlkPjfkNHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmaoSB/9gyvLHcHctf5iqtQNQeSHwLDaajnNpukgxJ8v4 n1Qcdimyc8gWjWTesUWJNutl5708CcbqKVmTDy8719zzUbx86jUrHOhZaV1Rf99m /3O8bNyr8p5jGejJJFTBQsUsPfIA+sFHtaKEDZ2js2UBfX9ni+5MP5u6IpKy5LYH HHsUrtVoXVg4A4ybP4JaA3MUokru1tgCi5JgVjZ0H42cshKkXpihWcfkaovGExZw j7tjnoYChKLi3ag1sSnN2B2x6zVfqB1+TvRqeBdZd5jzz8oWkRfret9JareUWdNe kWeDteAuEu1RNZHRq2RlHDTuxOtj56yKcLaM2JzUhJt0WxNU =N+mT -----END PGP SIGNATURE----- --b1Lki3IThNs5wEJL5H5CmoEIXPKXFItVN-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 08 08:39:19 2017 Received: (at 26264) by debbugs.gnu.org; 8 May 2017 12:39:19 +0000 Received: from localhost ([127.0.0.1]:33037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7hwd-0003I5-BG for submit@debbugs.gnu.org; Mon, 08 May 2017 08:39:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7hwb-0003Ht-Bg for 26264@debbugs.gnu.org; Mon, 08 May 2017 08:39:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7hwS-0004Qw-3V for 26264@debbugs.gnu.org; Mon, 08 May 2017 08:39:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7hwS-0004Qm-0q; Mon, 08 May 2017 08:39:08 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:55540 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d7hwR-0000yF-5l; Mon, 08 May 2017 08:39:07 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Tobias Geerinckx-Rice Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> <87bmr4ptj6.fsf@gnu.org> <6a792b17-4e9f-c7ec-6934-8a04a9236bd1@tobias.gr> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 =?utf-8?Q?Flor=C3=A9al?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Mon, 08 May 2017 14:39:03 +0200 In-Reply-To: <6a792b17-4e9f-c7ec-6934-8a04a9236bd1@tobias.gr> (Tobias Geerinckx-Rice's message of "Sun, 7 May 2017 23:13:29 +0200") Message-ID: <87tw4vo74o.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26264 Cc: 26264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Heya! Tobias Geerinckx-Rice skribis: > On 07/05/17 17:37, Ludovic Court=C3=A8s wrote: >> WDYT of making it: >> (define* (package-full-name package #:optional (separator "@")) >> =E2=80=A6) >> ? >> (I think I suggested it somewhere, but maybe not. :-)) > > You did! I simply forgot to address it explicitly (=E2=80=98I'm sticking.= ..=E2=80=99). > >> That would make the adjustments to places that need a hyphen slightly >> shorter. > > I considered it back when, but decided not to because it just felt... > wrong. That's it. My intuitive, rambling reasoning: > > - All of the patched ex-callers are manually constructing some raw > file or directory name. It includes the package's name and version > in some way, but not really Guix's abstract concept of a > =E2=80=98package-full-name=E2=80=99 atom. It just happened to be the sa= me string. > > - Making =E2=80=98separator=E2=80=99 configurable turns =E2=80=98package-= full-name=E2=80=99 into > =E2=80=98package-name-version-join=E2=80=99. If one cares about the sep= arator, > one also cares about the components, at which point one should just > call string-join explicitly. Doing so isn't ugly, and is more clear. > > Does that make any sense? I does, I wondered about that too. So yeah, please push the patches, thanks! >> Thanks, and good luck with your new $DAYJOB! > > Thanks! It doesn't involve computers, so it won't last. Heheh. :-) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat May 20 05:28:55 2017 Received: (at 26264) by debbugs.gnu.org; 20 May 2017 09:28:55 +0000 Received: from localhost ([127.0.0.1]:55943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dC0gx-0002nO-C1 for submit@debbugs.gnu.org; Sat, 20 May 2017 05:28:55 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:37640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dC0gv-0002n4-9b for 26264@debbugs.gnu.org; Sat, 20 May 2017 05:28:54 -0400 Received: by mail-wm0-f42.google.com with SMTP id d127so103688634wmf.0 for <26264@debbugs.gnu.org>; Sat, 20 May 2017 02:28:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:message-id:reply-to :in-reply-to:date:mime-version; bh=9oOGtowvutqtIucjr6RXzKZe9KYFEygeAfM3kRW/QRo=; b=OMYcpHv+wtoO1t+C4AD7RTrO/IArjdWiQb+7wqCOUYiyrYM/Qo/x1CV9IHIZhkQ5wv XCng51jmo208p10umvtSOdsmM1QMlGx2SCrNjOdwCF2WgLTGHopt4uB6y8apGDgvsJsz aLQujvVS9R2o51PTw1lbsV2N5C7BIdKiIjSE2euR2b+FyDyY6MZC+EY+NauXUa7oDDrr XzzuhngmSoXiJXa04rVfEFlBZLBEm7bE5xOXKMsNhjB5fE8oGiyiOT7z4nt1noXt0Ow6 BH9so/slYPXIvedyxWKANJb+uLlc53dGprtWACgqROpolvbXfRVSBH1SftYaPAIKwE8I w/Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :message-id:reply-to:in-reply-to:date:mime-version; bh=9oOGtowvutqtIucjr6RXzKZe9KYFEygeAfM3kRW/QRo=; b=DZ3EWX0+ID/TA8XCsQOSXViSCKCqJnjGah+S6PYuAq0XbYPR1ugyvjz5kt72mHVCtI rI0DLhqhjZEFEd8Xuqoi/bMvCaN8KkPyYk1eo/2k6Iulg8S7kPR02KP+xLI8TL92dBJF Oe23fRqp2wbFmREP0VOLo9qoVdUxzkeHuhviD/G3Ne42BlzJB/NmJXDt5aSM48WoibBG spq7SMhoTlwwzfymk7mXPAwTVQgo9jyn8cBRdIYj8DiO+Xgfw8BwRVa8txbuI9BVONpM g/58W51k/iCGBUAhfIzpnMoZy9YxsWANF/7O3HTXE0KdQahiV+iqRKrLTWdoTlk0Co9/ 3Zag== X-Gm-Message-State: AODbwcAb7ckYgWlKZJU8UXzMjolVFqJA0WvzEA7UxL0CCrUzbIW7bShQ SPQAera+IFuhaw== X-Received: by 10.28.218.7 with SMTP id r7mr1123470wmg.127.1495272527536; Sat, 20 May 2017 02:28:47 -0700 (PDT) Received: from new-host ([109.131.46.35]) by smtp.gmail.com with ESMTPSA id 72sm27936510wmx.23.2017.05.20.02.28.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 20 May 2017 02:28:46 -0700 (PDT) References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Alex Sassmannshausen To: Tobias Geerinckx-Rice Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name Message-ID: <87zie727yb.fsf@gmail.com> In-reply-to: <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> Date: Sat, 20 May 2017 11:28:44 +0200 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26264 Cc: ludo@gnu.org, 26264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: alex.sassmannshausen@gmail.com Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Heya, Following on from Tobias patch I will also submit my revised patch. I'm afraid I've been sitting on it for a while. My patch takes the approach of refactoring ‘package-full-name‘ to accept an optional argument, ‘separator’, which defaults to ’@’ as proposed by Ludo. On the bright side, it seems both me and Tobias are touching the same files in our patches, and presumably have done some testing — so either patch should work nicely. I'm happy for either patch to be pushed. Best wishes, Alex --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=0001-Use-as-default-separator-in-package-full-name.patch Content-Description: Patch >From 44c356f50058a7d0c60523c1411150847ac66578 Mon Sep 17 00:00:00 2001 From: Alex Sassmannshausen Date: Mon, 10 Apr 2017 14:38:02 +0200 Subject: [PATCH] Use '@' as default separator in `package-full-name`. * guix/packages.scm (package-full-name): New optional argument, 'separator' defaulting to '@'. * gnu/packages/commencement.scm (gcc-boot0): Set use of '-' as `package-full-name` separator. * tests/graph.scm: Update tests to account for new `package-full-name`. * tests/profiles.scm: Update tests to account for new `package-full-name`. --- gnu/packages/commencement.scm | 2 +- guix/packages.scm | 7 ++++--- tests/graph.scm | 2 +- tests/profiles.scm | 7 ++++--- 4 files changed, 10 insertions(+), 8 deletions(-) diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index 1b41feac1..552358d67 100644 --- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -256,7 +256,7 @@ ;; Drop trailing letters, as gmp-6.0.0a unpacks ;; into gmp-6.0.0. `(symlink ,(string-trim-right - (package-full-name lib) + (package-full-name lib "-") char-set:letter) ,(package-name lib))) (list gmp-6.0 mpfr mpc)))) diff --git a/guix/packages.scm b/guix/packages.scm index 8ead95073..92b3f034c 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -385,9 +385,10 @@ object." package-cross-build-system-error?) -(define (package-full-name package) - "Return the full name of PACKAGE--i.e., `NAME-VERSION'." - (string-append (package-name package) "-" (package-version package))) +(define* (package-full-name package #:optional (separator "@")) + "Return the full name of PACKAGE, separated by SEPARATOR--i.e., +`NAME@VERSION' by default." + (string-append (package-name package) separator (package-version package))) (define (%standard-patch-inputs) (let* ((canonical (module-ref (resolve-interface '(gnu packages base)) diff --git a/tests/graph.scm b/tests/graph.scm index 6431c482f..a48fbfd51 100644 --- a/tests/graph.scm +++ b/tests/graph.scm @@ -130,7 +130,7 @@ edges." (map (lambda (destination) (list "p-0.drv" (string-append - (package-full-name destination) + (package-full-name destination "-") ".drv"))) implicit))))))) diff --git a/tests/profiles.scm b/tests/profiles.scm index 093422792..ea2111355 100644 --- a/tests/profiles.scm +++ b/tests/profiles.scm @@ -239,12 +239,13 @@ ;; The inputs for grep and sed should be cross-build derivations, but that ;; for the glibc-utf8-locales should be a native build. (return (and (string=? (derivation-system drv) (%current-system)) - (string=? (find-input (package-full-name packages:grep)) + (string=? (find-input (package-full-name packages:grep "-")) (derivation-file-name grep)) - (string=? (find-input (package-full-name packages:sed)) + (string=? (find-input (package-full-name packages:sed "-")) (derivation-file-name sed)) (string=? (find-input - (package-full-name packages:glibc-utf8-locales)) + (package-full-name packages:glibc-utf8-locales + "-")) (derivation-file-name locales)))))) (test-assert "package->manifest-entry defaults to \"out\"" -- 2.12.2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Tobias Geerinckx-Rice writes: > Guix, > > On 28/03/17 17:19, Tobias Geerinckx-Rice wrote: >> I wouldn't mind giving this a try, or not. > > More revenge from the pre-new-job-mailbag. > > I'm sticking to my original patch, and changed the problematic callers > to not use ‘package-full-name’ at all. I don't think it's the right > abstraction in any of those cases. See the overly verbose commit messages. > > Kind regards, > > T G-R > > From 43892525fc981533445e60a649425791cc315d0a Mon Sep 17 00:00:00 2001 > From: Tobias Geerinckx-Rice > Date: Sat, 6 May 2017 14:32:12 +0200 > Subject: [PATCH 4/4] packages: Use "@" as a version separator. > > * guix/packages.scm (package-full-name): Use "@" instead of "-" to separate > PACKAGE-NAME and PACKAGE-VERSION. > --- > guix/packages.scm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/guix/packages.scm b/guix/packages.scm > index 44f2c32fb..802405102 100644 > --- a/guix/packages.scm > +++ b/guix/packages.scm > @@ -385,8 +385,8 @@ object." > > > (define (package-full-name package) > - "Return the full name of PACKAGE--i.e., `NAME-VERSION'." > - (string-append (package-name package) "-" (package-version package))) > + "Return the full name of PACKAGE--i.e., `NAME@VERSION'." > + (string-append (package-name package) "@" (package-version package))) > > (define (%standard-patch-inputs) > (let* ((canonical (module-ref (resolve-interface '(gnu packages base)) > -- > 2.12.2 > > > From 0325e536cf557ff48d885948bf5fab8f59bfc444 Mon Sep 17 00:00:00 2001 > From: Tobias Geerinckx-Rice > Date: Sat, 6 May 2017 14:32:06 +0200 > Subject: [PATCH 3/4] profiles: Don't use PACKAGE-FULL-NAME. > > The non-hash parts of store paths aren't constructed according to > PACKAGE-FULL-NAME rules. They just happened to match in the past. > > * tests/profile.scm ("profile-derivation, cross-compilation"): Use > PACKAGE-NAME and PACKAGE-VERSION directly. > --- > tests/profiles.scm | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tests/profiles.scm b/tests/profiles.scm > index d0b1e14a8..68e73c4ca 100644 > --- a/tests/profiles.scm > +++ b/tests/profiles.scm > @@ -230,15 +230,18 @@ > (and (string-suffix? name input) input))) > (derivation-inputs drv)))) > > + (define (package-store-suffix package) > + (string-append (package-name package) "-" (package-version package))) > + > ;; The inputs for grep and sed should be cross-build derivations, but that > ;; for the glibc-utf8-locales should be a native build. > (return (and (string=? (derivation-system drv) (%current-system)) > - (string=? (find-input (package-full-name packages:grep)) > + (string=? (find-input (package-store-suffix packages:grep)) > (derivation-file-name grep)) > - (string=? (find-input (package-full-name packages:sed)) > + (string=? (find-input (package-store-suffix packages:sed)) > (derivation-file-name sed)) > (string=? (find-input > - (package-full-name packages:glibc-utf8-locales)) > + (package-store-suffix packages:glibc-utf8-locales)) > (derivation-file-name locales)))))) > > (test-assert "package->manifest-entry defaults to \"out\"" > -- > 2.12.2 > > > From f10c4fb9d269b85f9c388356a17c2b8b2fc54bd5 Mon Sep 17 00:00:00 2001 > From: Tobias Geerinckx-Rice > Date: Sat, 6 May 2017 14:31:56 +0200 > Subject: [PATCH 2/4] gnu: gcc-boot0: Don't use PACKAGE-FULL-NAME. > > Don't use Guix's naming conventions where a different one is expected. > > * gnu/packages/commencement.scm (gcc-boot0)[arguments]: Use PACKAGE-NAME > and PACKAGE-VERSION directly. > --- > gnu/packages/commencement.scm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm > index 92f6e6c2e..dd3261e37 100644 > --- a/gnu/packages/commencement.scm > +++ b/gnu/packages/commencement.scm > @@ -255,7 +255,8 @@ > ;; Drop trailing letters, as gmp-6.0.0a unpacks > ;; into gmp-6.0.0. > `(symlink ,(string-trim-right > - (package-full-name lib) > + (string-append (package-name lib) "-" > + (package-version lib)) > char-set:letter) > ,(package-name lib))) > (list gmp-6.0 mpfr mpc)))) > -- > 2.12.2 > > > From c090e526e21a960f34f0f02f9904757952d5a36e Mon Sep 17 00:00:00 2001 > From: Tobias Geerinckx-Rice > Date: Sat, 6 May 2017 14:31:48 +0200 > Subject: [PATCH 1/4] graph: Don't use PACKAGE-FULL-NAME. > > Derivation files aren't named according to PACKAGE-FULL-NAME rules. > We already forfeit any supposed abstraction by manually adding ".drv". > > * tests/graph.scm ("bag-emerged DAG"): Use PACKAGE-NAME and PACKAGE-VERSION > directly. > --- > tests/graph.scm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/graph.scm b/tests/graph.scm > index 6431c482f..53475597a 100644 > --- a/tests/graph.scm > +++ b/tests/graph.scm > @@ -130,7 +130,9 @@ edges." > (map (lambda (destination) > (list "p-0.drv" > (string-append > - (package-full-name destination) > + (package-name destination) > + "-" > + (package-version destination) > ".drv"))) > implicit))))))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 31 08:11:35 2017 Received: (at 26264) by debbugs.gnu.org; 31 May 2017 12:11:35 +0000 Received: from localhost ([127.0.0.1]:46280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dG2TO-0003jc-R6 for submit@debbugs.gnu.org; Wed, 31 May 2017 08:11:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dG2TM-0003jQ-FG for 26264@debbugs.gnu.org; Wed, 31 May 2017 08:11:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dG2TD-0001dc-Tl for 26264@debbugs.gnu.org; Wed, 31 May 2017 08:11:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dG2TD-0001dX-Qk; Wed, 31 May 2017 08:11:23 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:42722 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dG2TD-00042n-3H; Wed, 31 May 2017 08:11:23 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Alex Sassmannshausen Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> <87zie727yb.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 Prairial an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Wed, 31 May 2017 14:11:19 +0200 In-Reply-To: <87zie727yb.fsf@gmail.com> (Alex Sassmannshausen's message of "Sat, 20 May 2017 11:28:44 +0200") Message-ID: <87a85tfcpk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26264 Cc: Tobias Geerinckx-Rice , 26264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi! Alex Sassmannshausen skribis: > On the bright side, it seems both me and Tobias are touching the same > files in our patches, and presumably have done some testing =E2=80=94 so = either > patch should work nicely. > > I'm happy for either patch to be pushed. Same here. :-) Tobias, thoughts? ISTR Tobias wasn=E2=80=99t enthusiastic about the idea of an optional argument. Anyway we should push something now! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 18 07:04:21 2017 Received: (at control) by debbugs.gnu.org; 18 Jun 2017 11:04:21 +0000 Received: from localhost ([127.0.0.1]:54012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMY0D-0003GW-9F for submit@debbugs.gnu.org; Sun, 18 Jun 2017 07:04:21 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMY0B-0003GO-O9 for control@debbugs.gnu.org; Sun, 18 Jun 2017 07:04:20 -0400 Received: from localhost (port-92-200-37-134.dynamic.qsc.de [92.200.37.134]) by mx.zohomail.com with SMTPS id 1497783856040156.31904814731706; Sun, 18 Jun 2017 04:04:16 -0700 (PDT) Date: Sun, 18 Jun 2017 13:04:13 +0200 To: control@debbugs.gnu.org From: Ricardo Wurmus Subject: control message for bug #26239 X-ZohoMailClient: External X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 26239 [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [135.84.80.216 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [135.84.80.216 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.1 MISSING_MID Missing Message-Id: header X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" Message-Id: X-Spam-Score: 1.0 (+) close 26239 From unknown Mon Jun 23 14:57:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 16 Jul 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator