GNU bug report logs - #26262
[PATCH 1/2] gnu: Add speexdsp.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26262 in the body.
You can then email your comments to 26262 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: guix-patches <at> gnu.org
Cc: Marius Bakke <mbakke <at> fastmail.com>
Subject: [PATCH 1/2] gnu: Add speexdsp.
Date: Sun, 26 Mar 2017 10:14:47 +0200

* gnu/packages/xiph.scm (speexdsp): New variable. Export it.
---
 gnu/packages/xiph.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/xiph.scm b/gnu/packages/xiph.scm
index 5ad504604..6a979bb54 100644
--- a/gnu/packages/xiph.scm
+++ b/gnu/packages/xiph.scm
@@ -43,6 +43,7 @@
             libvorbis
             libtheora
             speex
+            speexdsp
             ao
             flac
             libkate
@@ -149,6 +150,26 @@ stereo encoding, and voice activity detection.")
     (license (license:non-copyleft "file://COPYING"
                                 "See COPYING in the distribution."))))
 
+(define speexdsp
+  (package
+    (name "speexdsp")
+    (version "1.2rc3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://downloads.xiph.org/releases/speex/"
+                                  "speexdsp-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1wcjyrnwlkayb20zdhp48y260rfyzg925qpjpljd5x9r01h8irja"))))
+    (build-system gnu-build-system)
+    (home-page "https://speex.org/")
+    (synopsis "Speex processing library")
+    (description
+     "SpeexDSP is a @dfn{DSP} (Digital Signal Processing) library based on
+work from the @code{speex} codec.")
+    (license (license:non-copyleft "file://COPYING"
+                                   "See COPYING in the distribution."))))
+
 (define ao
   (package
     (name "ao")
-- 
2.12.2

Message #8 received at 26262 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: 26262 <at> debbugs.gnu.org
Cc: Marius Bakke <mbakke <at> fastmail.com>
Subject: [PATCH 2/2] gnu: mumble: Fix build after speex update.
Date: Sun, 26 Mar 2017 10:16:57 +0200

* gnu/packages/telephony.scm (mumble)[inputs]: Add SPEEXDSP.
---
 gnu/packages/telephony.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index 87261825c..377ad6fed 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -411,6 +411,7 @@ address of one of the participants.")
        ("boost" ,boost)
        ("opus" ,opus)
        ("speex" ,speex)
+       ("speexdsp" ,speexdsp)
        ("speech-dispatcher" ,speech-dispatcher)
        ("libx11" ,libx11)
        ("libxi" ,libxi)
-- 
2.12.2

Message #11 received at 26262 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26262 <at> debbugs.gnu.org
Subject: Re: bug#26262: [PATCH 1/2] gnu: Add speexdsp.
Date: Sun, 26 Mar 2017 15:09:27 -0400

On Sun, Mar 26, 2017 at 10:14:47AM +0200, Marius Bakke wrote:
> * gnu/packages/xiph.scm (speexdsp): New variable. Export it.

> +    (license (license:non-copyleft "file://COPYING"
> +                                   "See COPYING in the distribution."))))

It's bsd-3, right?

Other than that, LGTM!

Message #14 received at 26262 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26262 <at> debbugs.gnu.org
Subject: Re: bug#26262: [PATCH 2/2] gnu: mumble: Fix build after speex update.
Date: Sun, 26 Mar 2017 15:09:35 -0400

On Sun, Mar 26, 2017 at 10:16:57AM +0200, Marius Bakke wrote:
> * gnu/packages/telephony.scm (mumble)[inputs]: Add SPEEXDSP.

LGTM

Message #19 received at 26262-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 26262-done <at> debbugs.gnu.org
Subject: Re: bug#26262: [PATCH 1/2] gnu: Add speexdsp.
Date: Sun, 26 Mar 2017 23:48:39 +0200

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Sun, Mar 26, 2017 at 10:14:47AM +0200, Marius Bakke wrote:
>> * gnu/packages/xiph.scm (speexdsp): New variable. Export it.
>
>> +    (license (license:non-copyleft "file://COPYING"
>> +                                   "See COPYING in the distribution."))))
>
> It's bsd-3, right?

It uses the BSD-3 template, except <copyright holder> is replaced with
"COPYRIGHT HOLDERS AND CONTRIBUTORS" in the first instance, and "THE
FOUNDATION OR CONTRIBUTORS" in the second.

IANAL etc, but the added wording may have some legal implications
outside what one might expect from this license. FWIW speex has the same
license and uses this form, so I pushed it as-is.

Thanks for checking!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.