GNU bug report logs - #26256
[PATCH 0/6] Add ceph + multipath-tools.

Previous Next

Package: guix-patches;

Reported by: Marius Bakke <mbakke <at> fastmail.com>

Date: Sat, 25 Mar 2017 20:28:01 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

Full log


Message #59 received at 26256 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, 26256 <at> debbugs.gnu.org
Subject: Re: bug#26256: [PATCH 5/6] gnu: Add userspace-rcu.
Date: Mon, 27 Mar 2017 22:08:25 +0200
[Message part 1 (text/plain, inline)]
Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> Marius,
>
> On 25/03/17 21:30, Marius Bakke wrote:
>> * gnu/packages/linux.scm (userspace-rcu): New variable.
>
> This already exists as liburcu in datastructures.scm (I needed it for
> the Knot DNS server), with two main differences:

Aaaah.. how did I miss that, thanks!

>> +    (native-inputs
>> +     `(("perl-test-harness" ,perl-test-harness))) ; for the 'prove' command
>
> Building liburcu with ‘perl’ or ‘perl-test-harness’ gives the same
> result (Files=3, Tests=78). I know nothing about Perl. Is there a reason
> to prefer ‘perl-test-harness’? It's about .5 MiB heavier.

I don't know either, I just searched around for the `prove` command and
found it was in "perl-test-harness". Apparently it's in "perl" too!

>> +    (license
>> +     ;; This library is distributed under LGPL2.1+, but includes some files
>> +     ;; covered by other licenses. The LICENSE file has full details.
>> +     (list license:lgpl2.1+
>> +           license:gpl3+                         ; most tests are gpl2+; tap.sh is gpl3+
>> +           license:bsd-2                         ; tests/utils/tap/tap.[ch]
>> +           license:expat                         ; urcu/uatomic/*
>> +           ;; A few files use different variants of the MIT/X11 license.
>> +           (license:x11-style "file://LICENSE"
>> +                              "See LICENSE in the distribution for details.")))))
>> +
>
> Wow. As usual you're a lot better at sniffing out licences than I am.

Ha, but at least you got it right (per the other discussion on this
thread) ;-)

> I also prefer your ‘synopsis’ to mine.

I can update the synopsis of the existing package, and add @code{}
wrappers to your arguably better description; as well as adding comments
about the other licenses. How does that sound? :)

PS: The PGP signature of this email is bad. If you are in fact Tobias,
please reply with a signed email stating "I will not use important
software from my host distro any longer" :-P
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 8 years and 115 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.