Subject: Re: bug#26256: [PATCH 4/6] gnu: fio: Enable rbd support.

From: [email-masked] (Ludovic Courtès)
Date: Tue, 28 Mar 2017 11:45:19 +0200

Marius Bakke <[email-masked]> skribis:

> Ludovic Courtès <[email-masked]> writes:
>
>> Marius Bakke <[email-masked]> skribis:
>>
>>> * gnu/packages/benchmark.scm (fio)[inputs]: Add ceph:lib.
>>
>> Would be worth checking how this affects the closure size.  It’s a
>> developer tool though, so I’d argue that it’s less of a problem if the
>> closure size is increased noticeably in this cases.
>
> ceph:lib increases fios closure size from 452.3 MiB to a good 738 MiB.
>
> However, by moving the fio auxiliary scripts to a separate output, I
> managed to get the baseline size down from 452.3 MiB to 75.3 MiB. See
> attached patch. WDYT?
>
> From b942036bef17a4eacfd7406a9a5130fd2255252d Mon Sep 17 00:00:00 2001
> From: Marius Bakke <[email-masked]>
> Date: Tue, 28 Mar 2017 00:08:36 +0200
> Subject: [PATCH] gnu: fio: Install python scripts in separate output.
>
> * gnu/packages/benchmark.scm (fio)[outputs]: New field.
> [arguments]: Rename 'wrap-python-scripts' to 'move-outputs'. Keep wrapper.

[...]

> +         (add-after 'install 'move-outputs
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out"))
> +                   (utils (string-append (assoc-ref outputs "utils") "/bin")))

Add a comment explaining that this saves X MiB on the closure.

> +    (outputs '("out" "utils"))

Maybe s/utils/bin/ if there aren’t any other binaries, otherwise LGTM!

Thank you!

Ludo’.