GNU bug report logs - #26249
26.0.50; vc-hg.el assumes wrong default ignore pattern syntax

Previous Next

Full log

Message #10 received at 26249-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Jim Blandy <jimb <at> red-bean.com>, 26249-done <at> debbugs.gnu.org
Subject: Re: bug#26249: 26.0.50; vc-hg.el assumes wrong default ignore pattern
 syntax
Date: Mon, 10 Apr 2017 05:53:35 +0300

Version: 26.1

On 25.03.2017 03:07, Jim Blandy wrote:

> The problem is that vc-hg--slurp-hgignore-1 believes that default-syntax 
> should be vc-hg--hgignore-add-glob, but the default syntax in an 
> .hgignore file is actually Python/Perl regular expressions. Changing the 
> default value to vc-hg--hgignore-add-pcre seems to fix the problem:
> 
> modified   lisp/vc/vc-hg.el
> @@ -826,7 +826,7 @@ vc-hg--hgignore-add-path
>        prefix)))
> 
>   (defun vc-hg--slurp-hgignore-1 (hgignore prefix)
> -  (let ((default-syntax 'vc-hg--hgignore-add-glob))
> +  (let ((default-syntax 'vc-hg--hgignore-add-pcre))
>       (with-temp-buffer
>         (let ((attr (file-attributes hgignore)))
>           (when attr (insert-file-contents hgignore))

Thanks! Applied.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.