From unknown Fri Aug 15 14:14:53 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#26242 <26242@debbugs.gnu.org> To: bug#26242 <26242@debbugs.gnu.org> Subject: Status: 25.1; `dired-shrink-to-fit' warning Reply-To: bug#26242 <26242@debbugs.gnu.org> Date: Fri, 15 Aug 2025 21:14:53 +0000 retitle 26242 25.1; `dired-shrink-to-fit' warning reassign 26242 emacs submitter 26242 Drew Adams severity 26242 wishlist tag 26242 notabug thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 24 14:10:14 2017 Received: (at submit) by debbugs.gnu.org; 24 Mar 2017 18:10:14 +0000 Received: from localhost ([127.0.0.1]:42727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crTfB-00084V-Mf for submit@debbugs.gnu.org; Fri, 24 Mar 2017 14:10:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crTf9-00084I-O7 for submit@debbugs.gnu.org; Fri, 24 Mar 2017 14:10:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crTf3-00036Z-3Z for submit@debbugs.gnu.org; Fri, 24 Mar 2017 14:10:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48521) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1crTf3-00036T-0V for submit@debbugs.gnu.org; Fri, 24 Mar 2017 14:10:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crTf1-0003eR-VA for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2017 14:10:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crTex-00034x-SB for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2017 14:10:03 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:33901) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1crTex-00034e-Js for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2017 14:09:59 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v2OI9vbj009766 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 24 Mar 2017 18:09:58 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v2OI9vUF023242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 24 Mar 2017 18:09:57 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v2OI9ucn006349 for ; Fri, 24 Mar 2017 18:09:57 GMT MIME-Version: 1.0 Message-ID: <0159673c-b125-422a-b192-09e16132afa9@default> Date: Fri, 24 Mar 2017 11:09:55 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.1; `dired-shrink-to-fit' warning X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) If code uses variable `dired-shrink-to-fit', this is the byte-compiler warning you get: Warning: =E2=80=98dired-shrink-to-fit=E2=80=99 is an obsolete variable (as = of 24.3); use the Customization interface to add a new rule to =E2=80=98display-buffer-alist=E2=80=99 where condition regexp is "^ \*Ma= rked Files\*$", action argument symbol is =E2=80=98window-height=E2=80=99 and its value is = nil. That is a _ridiculous_ warning. This simple variable was defined this way, for decades: (defvar dired-shrink-to-fit t ;; I see no reason ever to make this nil -- rms. ;; (> baud-rate search-slow-speed) "Non-nil means Dired shrinks the display buffer to fit the marked files."= ) IOW, the value should pretty much always be non-nil. What on Earth is the point of the convoluted recipe given in that warning? `dired-shrink-to-fit' was never a user option. It is not necessarily something that someone would set in their init file. It is just as likely (if it is likely at all - see RMS's comment) that it would be bound in some Lisp code. Why should we tell users to customize `display-buffer-alist', perhaps the most complex user option, and in such a way as to do the complicated things the warning suggests? What we should do is just restore the definition of `dired-shrink-to-fit' (perhaps even making it a constant with value `t'), or just replace occurrences of it with `t' and declare it obsolete but without such a silly warning that tells you to customize `display-buffer-alist'. In GNU Emacs 25.1.1 (x86_64-w64-mingw32) of 2016-11-15 built on LAPHROAIG Windowing system distributor 'Microsoft Corp.', version 6.1.7601 Configured using: 'configure --without-dbus --without-compress-install 'CFLAGS=3D-O2 -static -g3'' From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 11:08:28 2019 Received: (at 26242) by debbugs.gnu.org; 12 Jun 2019 15:08:28 +0000 Received: from localhost ([127.0.0.1]:33865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb4rT-0006IL-Lb for submit@debbugs.gnu.org; Wed, 12 Jun 2019 11:08:27 -0400 Received: from quimby.gnus.org ([80.91.231.51]:55306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb4rR-0006IB-A5 for 26242@debbugs.gnu.org; Wed, 12 Jun 2019 11:08:25 -0400 Received: from cm-84.212.204.8.getinternet.no ([84.212.204.8] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hb4rN-00073Y-AN; Wed, 12 Jun 2019 17:08:23 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#26242: 25.1; `dired-shrink-to-fit' warning References: <0159673c-b125-422a-b192-09e16132afa9@default> Date: Wed, 12 Jun 2019 17:08:20 +0200 In-Reply-To: <0159673c-b125-422a-b192-09e16132afa9@default> (Drew Adams's message of "Fri, 24 Mar 2017 11:09:55 -0700 (PDT)") Message-ID: <87imtavo2j.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Drew Adams writes: > If code uses variable `dired-shrink-to-fit', this is the byte-compiler > warning you get: > > Warning: ‘dired-shrink-to-fit’ is an obsolete variable (as of 24.3); use the Customization interface [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26242 Cc: 26242@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > If code uses variable `dired-shrink-to-fit', this is the byte-compiler > warning you get: > > Warning: =E2=80=98dired-shrink-to-fit=E2=80=99 is an obsolete variable (a= s of 24.3); use the Customization interface to add a new rule > to =E2=80=98display-buffer-alist=E2=80=99 where condition regexp is "^ \*= Marked Files\*$", > action argument symbol is =E2=80=98window-height=E2=80=99 and its value i= s nil. [...] > What on Earth is the point of the convoluted recipe given in that > warning? Because the variable is going away and if somebody had a customisation for that, it's nice to let them know how to change it. But it seems unlikely that anybody would change that variable, as both you and the comments point out. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 11:08:31 2019 Received: (at control) by debbugs.gnu.org; 12 Jun 2019 15:08:31 +0000 Received: from localhost ([127.0.0.1]:33868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb4rX-0006Ic-00 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 11:08:31 -0400 Received: from quimby.gnus.org ([80.91.231.51]:55320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb4rW-0006IV-06 for control@debbugs.gnu.org; Wed, 12 Jun 2019 11:08:30 -0400 Received: from cm-84.212.204.8.getinternet.no ([84.212.204.8] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hb4rT-00073f-Ey for control@debbugs.gnu.org; Wed, 12 Jun 2019 17:08:29 +0200 Date: Wed, 12 Jun 2019 17:08:27 +0200 Message-Id: <87h88uvo2c.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #26242 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 26242 notabug close 26242 Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 26242 notabug close 26242 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 11:22:14 2019 Received: (at 26242) by debbugs.gnu.org; 12 Jun 2019 15:22:14 +0000 Received: from localhost ([127.0.0.1]:33910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb54o-0000O3-98 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 11:22:14 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:51452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb54j-0000Nk-PE for 26242@debbugs.gnu.org; Wed, 12 Jun 2019 11:22:10 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5CFBiH3098117; Wed, 12 Jun 2019 15:22:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=KG9pu3uVTxFV6dGk/dyTjfvaB5BNNfcPeLcQ3YKwljo=; b=pu2yKQ2bJlfIDTxp+B6nrWYbf4B7etiUVwt9X6fGAHAf00rhKfN/TFDsRUtO6UmR4D22 cbDvSeWLYmuvLmnpiKLdntLZKvkJsAmmPFVwQjp2o9JH31tIM96OSRrQ1wc8pL9GnP/3 te2oYvxQDLNhXOp9yiHBfPukKw/RgBFJnElEMy/DADd2mQOOheCX3ZRoYVMKNKBVm0vk I0h5oyvqH8JO3Ff1Ua9jZLoVEdg+2Eoz0SEYvDjB2txy4CovwAxo+ovSMZtj+zxxoV6g 76dmPZQk4xvnYYx8MpfeYeIzlP/1r628zB5NH+d/HC8iRT/tBEDl94CoVdkuIMf74sDQ Iw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2t05nqv5uv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2019 15:22:03 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5CFKqmB195660; Wed, 12 Jun 2019 15:22:03 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2t1jpj3051-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2019 15:22:03 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5CFM2RP025219; Wed, 12 Jun 2019 15:22:02 GMT MIME-Version: 1.0 Message-ID: <21a73189-b234-410a-b93d-07129bfed981@default> Date: Wed, 12 Jun 2019 08:22:01 -0700 (PDT) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#26242: 25.1; `dired-shrink-to-fit' warning References: <0159673c-b125-422a-b192-09e16132afa9@default> <87imtavo2j.fsf@mouse.gnus.org> In-Reply-To: <87imtavo2j.fsf@mouse.gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9286 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120102 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9286 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120102 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26242 Cc: 26242@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > What on Earth is the point of the convoluted recipe given in that > > warning? >=20 > Because the variable is going away and if somebody had a customisation > for that, it's nice to let them know how to change it. But it seems > unlikely that anybody would change that variable, as both you and the > comments point out. No. That doesn't answer the question or respond to the bug report. That just says what the status quo is that the report reports should be fixed. This is what should be done, as already pointed out: What we should do is just restore the definition of `dired-shrink-to-fit' (perhaps even making it a constant with value `t'), or just replace occurrences of it with `t' and declare it obsolete but without such a silly warning that tells you to customize `display-buffer-alist'. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 11:33:55 2019 Received: (at 26242) by debbugs.gnu.org; 12 Jun 2019 15:33:55 +0000 Received: from localhost ([127.0.0.1]:33915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5G7-0002nw-G2 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 11:33:55 -0400 Received: from mail-io1-f49.google.com ([209.85.166.49]:42397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5G5-0002ng-CI for 26242@debbugs.gnu.org; Wed, 12 Jun 2019 11:33:53 -0400 Received: by mail-io1-f49.google.com with SMTP id u19so13285017ior.9 for <26242@debbugs.gnu.org>; Wed, 12 Jun 2019 08:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=10eYHc0uAfG1KJ7hRTubhepRrpkK0xuI+HU217jzAi8=; b=PCJA0zjWBCFqhPI2oSlJfyQ0ykGpJ1eHGL/A8e0Dt+6xkqopNmx1TgPqSSRfJvjqHh BFcWcGFpFzTKw+/BssIa6SId+8thZT48p/uXy8GeV0kPyJSzasNCRtI0GmjDsFIvgqeK aY8DpZbecqt2W+GYa6UgYooBXrbG7QfTpetSydTt+KBWKOjnp3vlipMfAwkLqG3k2HNb 7nav6t7w52O3JPuoqQMIZC3gASMCRTdejwgK8fu15cBq5YxA6mB6O7x/5Hrp6sd0nczz SzDAsIreWcUap5Bb4dlE5ZUPme602wbbPHYA+D93Zu6hwS437X3j/VGIjHxXlhKb6S7+ fxyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=10eYHc0uAfG1KJ7hRTubhepRrpkK0xuI+HU217jzAi8=; b=AiOr/pqh9mnJ7sIsv1hqVQ1jeRotNDl3U48gI2MrAk+NtRuTWXUPbyQv9LlinS4oqB Qw0R8/8h+XSMACLExg+uEP4szG5vmHT1B+a8txkITgl4MYWCPBgaAGJpiDKyYTUBS5Qf UpMlCdFKbH+kXArDi0moze8AeyIy8br7LWgDUANpZZ5NiLfK5s/YoJj5IByc6pGq/s2h UJ0pzjWizJn/4xgM6J7is7NRUzgrkQ0mU+nIZhKpMJwTBWYMI5nA2zNEmQYlayy/Osg1 h6cOtBS5IGF2CGzsJhELEeAOaRekalKFPTz2xSDO2e9sLRSj+KXnm9jVs5Hqd8UaI8JJ V3Cw== X-Gm-Message-State: APjAAAW2+d40mUZnMVMXBkjWhOZ8J97TcvcVx0tey95tnSulDqdA24V7 i/MBgqtoW1ixsrD+lQ5+cWqekVQY X-Google-Smtp-Source: APXvYqwY+i46UV/cOmzhOtklXF98/KA7JfkGtXCR8K28Toqn/6MX99myQTVAqFwSDlXbUu8CBC6Qzg== X-Received: by 2002:a5e:c00a:: with SMTP id u10mr2038273iol.24.1560353626387; Wed, 12 Jun 2019 08:33:46 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id 138sm82966itu.26.2019.06.12.08.33.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2019 08:33:45 -0700 (PDT) From: npostavs@gmail.com To: Drew Adams Subject: Re: bug#26242: 25.1; `dired-shrink-to-fit' warning References: <0159673c-b125-422a-b192-09e16132afa9@default> <87imtavo2j.fsf@mouse.gnus.org> <21a73189-b234-410a-b93d-07129bfed981@default> Date: Wed, 12 Jun 2019 11:33:45 -0400 In-Reply-To: <21a73189-b234-410a-b93d-07129bfed981@default> (Drew Adams's message of "Wed, 12 Jun 2019 08:22:01 -0700 (PDT)") Message-ID: <85wohqakdi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26242 Cc: Lars Ingebrigtsen , 26242@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > This is what should be done, as already pointed out: > > What we should do is just restore the definition > of `dired-shrink-to-fit' The definition of dired-shrink-to-fit was never changed, so what do you mean by "restore"? From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 11:41:09 2019 Received: (at 26242) by debbugs.gnu.org; 12 Jun 2019 15:41:09 +0000 Received: from localhost ([127.0.0.1]:33920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5N7-0002zG-97 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 11:41:09 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:43982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5N4-0002yc-02 for 26242@debbugs.gnu.org; Wed, 12 Jun 2019 11:41:08 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5CFXfwS130218; Wed, 12 Jun 2019 15:41:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=wuLWkjnJNochUcHLXRYwToCtoCnwrP1tRqeyJNbivp8=; b=VvXaenYUIF98fVrEpmraPT+HqF0qRxIO6ht8yp5roMDFJVQ/MzU6J4E6UikUS+CvXNp3 RJa4o4q0IsHrrcJKJv8pQa4xXCljPl3ybVsT3EMFibrw3xhXNmu5dZUEhHLl4VYehRQ3 HRCll396Cr4f9cQ/NT7KlTg+ZlDWvPHxvo1ibCRdUor12/twhwvwLJoavd/6C3tJUpQh eT0rSoyRaiiMIfdUwj6yrJEO3dEvsFMT11O+ou3artovaHf2/ywM/VZBh5Yac4cq8drI X3ypyobIGxGWoxPtjkhluQmBlJCPbGAA5uvoLd+XZcidTfxJ+wn4XU2jj7Ft9zoW9cBG BQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 2t02hevhby-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2019 15:40:59 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5CFdLNh165916; Wed, 12 Jun 2019 15:40:59 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2t024v1y70-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2019 15:40:59 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5CFevBt015380; Wed, 12 Jun 2019 15:40:58 GMT MIME-Version: 1.0 Message-ID: <81f3c127-0080-49c4-8f17-c78cfc022570@default> Date: Wed, 12 Jun 2019 08:40:56 -0700 (PDT) From: Drew Adams To: npostavs@gmail.com Subject: RE: bug#26242: 25.1; `dired-shrink-to-fit' warning References: <0159673c-b125-422a-b192-09e16132afa9@default> <87imtavo2j.fsf@mouse.gnus.org> <21a73189-b234-410a-b93d-07129bfed981@default> <85wohqakdi.fsf@gmail.com> In-Reply-To: <85wohqakdi.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9286 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=841 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120104 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9286 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=907 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120104 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26242 Cc: Lars Ingebrigtsen , 26242@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > This is what should be done, as already pointed out: > > > > What we should do is just restore the definition > > of `dired-shrink-to-fit' >=20 > The definition of dired-shrink-to-fit was never changed, so what do you > mean by "restore"? Don't remove the variable. >From Lars: > Because the variable is going away... Don't issue that byte-compiler warning, but instead do one or more of the things I suggested. Don't close the bug, saying there is nothing to change about the "fix" of adding the byte-comp warning. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 11:48:43 2019 Received: (at 26242) by debbugs.gnu.org; 12 Jun 2019 15:48:43 +0000 Received: from localhost ([127.0.0.1]:33929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5UR-0003BG-F1 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 11:48:43 -0400 Received: from mail-io1-f51.google.com ([209.85.166.51]:42112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5UP-0003Az-Q9 for 26242@debbugs.gnu.org; Wed, 12 Jun 2019 11:48:42 -0400 Received: by mail-io1-f51.google.com with SMTP id u19so13329845ior.9 for <26242@debbugs.gnu.org>; Wed, 12 Jun 2019 08:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=X+oXPfWw4e7LGZO6GUfCuB3BYeh01Mmhhfk9gQzjucg=; b=mb3d1bE6Xmpt1LJL9A6gxEvz1MAKskfdkvu7hlJ3GMJNI5boARINWH4Ct7FvUK8lF/ Zori5u/qkPnxO6AYYsT2Vs5LqGbUSkiMER3leMqtpXWTT2tHLjwr3HxnSkecPfwW9Izr 0tUZFDF7XN47bREzay2HBvqY6hh4l7PTxPz8oIx0CUrqd0k9mbNpNWzk3ipXdvJLF2ir 5Ogt8QzmSsGmQH3ptORQ9Mddwo9okkksJQpJ0fooRPkwDhTop3cHwJR8hjv191CtTOc6 fxrpRyUl525jFkyFghLEvcjiFtEZE4dmNs6hWca/OZAFlNyu95AqcYvfNs/75K8XBFl7 HJAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=X+oXPfWw4e7LGZO6GUfCuB3BYeh01Mmhhfk9gQzjucg=; b=QzQoSM1x0yO9ecBBrrO/zB96DfK+nyVen4nZ/urqFKF6vHYUo4LRJSupkzkIHLRSqz RM5mb989CUlC6JmvJmwwGuorf2h2rBF2vexMHsZZmyaoL76Jow3eIIz9kahYMNbggqsc 64CklYJxYMyfHkvfG85Y2ZjqEDXMNwjQ+x1Vep8+1IVf3VzOhy1bn1Tnz9nZOV7agvfN DPvxspkdA0K2vJ8T0P/KpE/WJzNqSdq4JVo2GeaVYZdJp6SDAwyGQ9G/y03S0SevCos7 EuHbZATadZ8gL4hPAyD4XdomDt1ORjaRnhiHig7SkoQB0VGxPaIAn0RvH2dBfA/8MuBu Vucg== X-Gm-Message-State: APjAAAVsyletWnqd9KQPlEkpGyLEHRvyd4D8RFs4dAWHoYWzOkSsDmna wOnZglgjvR7qcfQAUtevHB9QsP26 X-Google-Smtp-Source: APXvYqwZmB46IhAJ9WIqZdYp58nUDmB1onexFd+C2Vkx62ymYkqeCk82hxDXxLNFSsJFrhWhy2AuIQ== X-Received: by 2002:a6b:7109:: with SMTP id q9mr8930285iog.30.1560354515857; Wed, 12 Jun 2019 08:48:35 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id m68sm124371itm.1.2019.06.12.08.48.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2019 08:48:35 -0700 (PDT) From: npostavs@gmail.com To: Drew Adams Subject: Re: bug#26242: 25.1; `dired-shrink-to-fit' warning References: <0159673c-b125-422a-b192-09e16132afa9@default> <87imtavo2j.fsf@mouse.gnus.org> <21a73189-b234-410a-b93d-07129bfed981@default> <85wohqakdi.fsf@gmail.com> <81f3c127-0080-49c4-8f17-c78cfc022570@default> Date: Wed, 12 Jun 2019 11:48:35 -0400 In-Reply-To: <81f3c127-0080-49c4-8f17-c78cfc022570@default> (Drew Adams's message of "Wed, 12 Jun 2019 08:40:56 -0700 (PDT)") Message-ID: <85tvcuajos.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26242 Cc: Lars Ingebrigtsen , 26242@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > Don't issue that byte-compiler warning, but > instead do one or more of the things I suggested. > What we should do is just restore the definition of > `dired-shrink-to-fit' (perhaps even making it a constant with value > `t'), or just replace occurrences of it with `t' and declare it obsolete > but without such a silly warning that tells you to customize > `display-buffer-alist'. So something like this (I don't see the benefit of replacing occurrences with `t' before actually removing it completely)? --- i/lisp/dired.el +++ w/lisp/dired.el @@ -299,9 +299,7 @@ dired-shrink-to-fit ;; (> baud-rate search-slow-speed) "Non-nil means Dired shrinks the display buffer to fit the marked files.") (make-obsolete-variable 'dired-shrink-to-fit - "use the Customization interface to add a new rule -to `display-buffer-alist' where condition regexp is \"^ \\*Marked Files\\*$\", -action argument symbol is `window-height' and its value is nil." "24.3") + "stop using it." "24.3") (defvar dired-file-version-alist) From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 12:16:22 2019 Received: (at 26242) by debbugs.gnu.org; 12 Jun 2019 16:16:22 +0000 Received: from localhost ([127.0.0.1]:33957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5vB-0003wY-Nc for submit@debbugs.gnu.org; Wed, 12 Jun 2019 12:16:21 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:56746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5v9-0003wK-Ed for 26242@debbugs.gnu.org; Wed, 12 Jun 2019 12:16:20 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5CGFPuE163343; Wed, 12 Jun 2019 16:16:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=p5GFGlKXaTrdzm2l+BdlAw2kIlO8Jshbh1KJ3JTDv9c=; b=H0AclekLqSqWYK0VO9wmt7ViTtcVD3JfVZsA7j/CNescfiDoXqtFH5R1WeJIPnlbgKlC +HR2LjUGFYlXBQK/A9ACz/lEdvkiGgi6ReucwcevtVjOl4sQXCPvpJL113wctwCpyUu+ EW6xo0nLjJ5w+cLqu7KpnsoPfeaazsVGm7FOB/HD7ja8S19o1qXT4qMFIbgrJtpLBMW1 nmQsnz6HKQTOC36IRoyGZ35xtLBvt2xSn0MMf5mJxromdHYgRLBl0E0M8xU3CVg2G22i hwG1X5bgYayoZb5WZiP975xsRsdcaTSppbW877Ga9XiaGhbhahz2EtJAU3P+DaYfMDyy 4w== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2t05nqvhwu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2019 16:16:13 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5CGGCUb067559; Wed, 12 Jun 2019 16:16:12 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2t0p9ry34r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2019 16:16:12 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5CGG9B6006670; Wed, 12 Jun 2019 16:16:09 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 12 Jun 2019 09:16:08 -0700 (PDT) From: Drew Adams To: npostavs@gmail.com Subject: RE: bug#26242: 25.1; `dired-shrink-to-fit' warning References: <0159673c-b125-422a-b192-09e16132afa9@default> <87imtavo2j.fsf@mouse.gnus.org> <21a73189-b234-410a-b93d-07129bfed981@default> <85wohqakdi.fsf@gmail.com> <81f3c127-0080-49c4-8f17-c78cfc022570@default> <85tvcuajos.fsf@gmail.com> In-Reply-To: <85tvcuajos.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9286 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=932 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120109 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9286 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=984 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120109 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26242 Cc: Lars Ingebrigtsen , 26242@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > Don't issue that byte-compiler warning, but > > instead do one or more of the things I suggested. >=20 > > What we should do is just restore the definition of > > `dired-shrink-to-fit' (perhaps even making it a constant with value > > `t'), or just replace occurrences of it with `t' and declare it obsolet= e > > but without such a silly warning that tells you to customize > > `display-buffer-alist'. >=20 > So something like this (I don't see the benefit of replacing occurrences > with `t' before actually removing it completely)? > > +=09=09=09"stop using it." "24.3") Better, yes. From unknown Fri Aug 15 14:14:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 Jul 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator