GNU bug report logs - #26239
[PATCH] packages: Use "@" as version separator.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#26264: closed ([PATCH 0/1] Use '@' to separate name, version
 in package-full-name)
Date: Tue, 28 Mar 2017 15:23:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 28 Mar 2017 17:23:05 +0200
with message-id <0b8b37ec-f665-1a91-34d1-bce407520415 <at> tobias.gr>
and subject line Re: bug#26239: Acknowledgement ([PATCH] packages: Use "@" as version separator.)
has caused the debbugs.gnu.org bug report #26239,
regarding [PATCH 0/1] Use '@' to separate name, version in package-full-name
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
26239: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26239
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alex Sassmannshausen <alex.sassmannshausen <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Alex Sassmannshausen <alex <at> pompo.co>
Subject: [PATCH 0/1] Use '@' to separate name, version in package-full-name
Date: Sun, 26 Mar 2017 14:25:54 +0200

Hello,

Currently, when `guix refresh -l` is used, package names are emitted with a
'-' separator.

This means the output from guix refresh -l cannot be used to issue guix
commands.  This patch addresses the issue by adding an optional parameter
`for-ui` to `package-full-name`, which, when passed, results in package names
being emitted with the '@' separator.

There are several other approaches that could be taken:

* change the behaviour of package-full-name by default to use '@'.  This would
  result in significant semantic changes in different places in Guix, where
  '-' is expected.

* Don't use package-full-name in guix refresh -l's `list-dependents`.  Instead
  just emit the package name, not the full name, or manually concatenate name
  '@' version.

I prefer adding the optional parameter to full-name as `package-full-name` is
used in different places for emitting UI package names, and we probably want
to switch all of those to the '@' semantics over time.

WDYT?

Alex

Alex Sassmannshausen (1):
  packages: Add optional `for-ui` param to `package-full-name`.

 guix/packages.scm        | 9 +++++----
 guix/scripts/refresh.scm | 6 +++---
 tests/packages.scm       | 4 ++++
 3 files changed, 12 insertions(+), 7 deletions(-)

-- 
2.12.1

[Message part 3 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 26239-done <at> debbugs.gnu.org
Subject: Re: bug#26239: Acknowledgement ([PATCH] packages: Use "@" as version
 separator.)
Date: Tue, 28 Mar 2017 17:23:05 +0200

[Message part 4 (text/plain, inline)]

‘package-full-name’ is also used to construct store path names, to this
change alone isn't enough.

Closing this bug. Discussion continued at #26264.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.