GNU bug report logs - #26239
[PATCH] packages: Use "@" as version separator.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Subject: bug#26239: closed (Re: bug#26239: Acknowledgement ([PATCH]
 packages: Use "@" as version separator.))
Date: Tue, 28 Mar 2017 15:23:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#26239: [PATCH] packages: Use "@" as version separator.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 26239 <at> debbugs.gnu.org.

-- 
26239: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26239
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 26239-done <at> debbugs.gnu.org
Subject: Re: bug#26239: Acknowledgement ([PATCH] packages: Use "@" as version
 separator.)
Date: Tue, 28 Mar 2017 17:23:05 +0200

[Message part 3 (text/plain, inline)]

‘package-full-name’ is also used to construct store path names, to this
change alone isn't enough.

Closing this bug. Discussion continued at #26264.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: guix-patches <at> gnu.org
Subject: [PATCH] packages: Use "@" as version separator.
Date: Fri, 24 Mar 2017 17:33:44 +0100

* guix/packages.scm (package-full-name): Use "@" instead of "-" to separate
PACKAGE-NAME and PACKAGE-VERSION.
---

Guix,

This is so trivial that I'm mainly posting it to find out *which* obvious
thing I've completely missed. 

Meanwhile, it won't get lost (again) before core-updates reopens for
business.

Kind regards,

T G-R

guix/packages.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/packages.scm b/guix/packages.scm
index 4bc4b01..34bbc5e 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -382,8 +382,8 @@ object."
 
 
 (define (package-full-name package)
-  "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
-  (string-append (package-name package) "-" (package-version package)))
+  "Return the full name of PACKAGE--i.e., `NAME <at> VERSION'."
+  (string-append (package-name package) "@" (package-version package)))
 
 (define (%standard-patch-inputs)
   (let* ((canonical (module-ref (resolve-interface '(gnu packages base))
-- 
2.9.3

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.