GNU bug report logs - #26225
[PATCH] guix: Compress and decompress xz archives in parallel.

Previous Next

Full log

Message #16 received at 26225 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: efraim <at> flashner.co.il, 26225 <at> debbugs.gnu.org
Subject: Re: bug#26225: [PATCH] guix: Compress and decompress xz archives in
 parallel.
Date: Fri, 31 Mar 2017 13:56:37 -0400

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> Efraim Flashner wrote:
>> * guix/scripts/pack.scm (%compressors): Add flag '-T0' when calling "xz".
>> * guix/utils.scm (decompressed-port, compressed-port,
>> compressed-output-port): Same.
>
>> --- a/guix/utils.scm
>> +++ b/guix/utils.scm
>> @@ -154,7 +155,7 @@ a symbol such as 'xz."
>>    (match compression
>>      ((or #f 'none) (values input '()))
>>      ('bzip2        (filtered-port `(,%bzip2 "-dc") input))
>> -    ('xz           (filtered-port `(,%xz "-dc") input))
>> +    ('xz           (filtered-port `(,%xz "-dc -T0") input))
>>      ('gzip         (filtered-port `(,%gzip "-dc") input))
>>      (else          (error "unsupported compression scheme" compression))))
>
> Parallel decompression isn't implemented yet, but the extra '-T0' option
> doesn't seem to break anything.
>
> The changes LGTM.
>
> I sent a companion patch to <https://bugs.gnu.org/26316> that enables
> threaded compression when building source tarballs.

LGTM as well.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.