From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 22 22:36:10 2017 Received: (at submit) by debbugs.gnu.org; 23 Mar 2017 02:36:10 +0000 Received: from localhost ([127.0.0.1]:39980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqsbi-0002pg-J7 for submit@debbugs.gnu.org; Wed, 22 Mar 2017 22:36:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqsbh-0002pT-Fm for submit@debbugs.gnu.org; Wed, 22 Mar 2017 22:36:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqsbb-0003wO-DB for submit@debbugs.gnu.org; Wed, 22 Mar 2017 22:36:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60063) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cqsbb-0003wI-2P for submit@debbugs.gnu.org; Wed, 22 Mar 2017 22:36:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqsbZ-00065D-Vc for guix-patches@gnu.org; Wed, 22 Mar 2017 22:36:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqsbU-0003un-V7 for guix-patches@gnu.org; Wed, 22 Mar 2017 22:36:01 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:38877 helo=mail.openmailbox.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cqsbU-0003uX-Gf for guix-patches@gnu.org; Wed, 22 Mar 2017 22:35:56 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 04F10517EF2; Thu, 23 Mar 2017 03:35:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1490236554; bh=mOuoCTVFlnhtJ/V9B+VYGh568yOq7+vbiFUDbTBuw9o=; h=From:To:Cc:Subject:Date:From; b=STT5Mmc52BwZ+zlunJ1SJRVxLV7LXbpbTdAxFOcOw1SlbV9rBV7dqiyFTOeeI6Zht w8cZE8Fuvchh81A1ZGn9y8mqsB5YKj94CWR1ukFRBiaJUkRYkEtdUDjr5CdS8xi2hT Tk3aEhNONrOc8Iu/LMXOICPYl/0bSO1xB9wSjvJM= From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1490236553; bh=mOuoCTVFlnhtJ/V9B+VYGh568yOq7+vbiFUDbTBuw9o=; h=From:To:Cc:Subject:Date:From; b=eijPt7/9EvVY+w0cGrQmzRbKKRm8VUQ/trsra23YtEWWuG4EgYYXCxGvBbb6V9b3R 2DTYyRLUPqB1hQAkLWe0oNjC+yJXkUk2Txv1d0TY66YH8HXaHHyJbXZJrCYvaF+MJ5 aLG9xPAFJPZzmfquchDSPsSP92oEramGS8kwIz84= To: guix-patches@gnu.org Subject: [PATCH] gnu: freedoom: Avoid the need to propagate prboom-plus. Date: Wed, 22 Mar 2017 22:35:39 -0400 Message-Id: <20170323023539.23855-1-kei@openmailbox.org> X-Mailer: git-send-email 2.12.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Kei Kebreau X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * gnu/packages/games.scm (freedoom)[arguments]: Substitute shell variable assignment in start script for a direct engine launch. --- gnu/packages/games.scm | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index 67fcb7b49..401ba4444 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -162,14 +162,19 @@ (("freedoom2.png") "-define png:exclude-chunks=date freedoom2.png")) ;; Make sure that the install scripts know where to find - ;; the appropriate WAD files. + ;; the appropriate WAD files and Doom engine. + ;; Do this by turning a shell variable assignment into a + ;; direct engine launch and exit. (substitute* "dist/freedoom" - (("IWAD=freedm.wad") - (string-append "IWAD=" wad-dir "/freedm.wad")) - (("IWAD=freedoom1.wad") - (string-append "IWAD=" wad-dir "/freedoom1.wad")) - (("IWAD=freedoom2.wad") - (string-append "IWAD=" wad-dir "/freedoom2.wad"))) + (("IWAD=") + (string-append (assoc-ref inputs "prboom-plus") + "/bin/prboom-plus -iwad ")) + (("freedm.wad") + (string-append wad-dir "/freedm.wad \"$@\"; exit $?")) + (("freedoom1.wad") + (string-append wad-dir "/freedoom1.wad \"$@\"; exit $?")) + (("freedoom2.wad") + (string-append wad-dir "/freedoom2.wad \"$@\"; exit $?"))) #t)))))) (native-inputs `(("asciidoc" ,asciidoc) -- 2.12.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 13:49:17 2017 Received: (at 26222) by debbugs.gnu.org; 23 Mar 2017 17:49:17 +0000 Received: from localhost ([127.0.0.1]:41225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cr6rM-0003cL-Hv for submit@debbugs.gnu.org; Thu, 23 Mar 2017 13:49:17 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:37056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cr6rK-0003cE-Nw for 26222@debbugs.gnu.org; Thu, 23 Mar 2017 13:49:15 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 38C2620966; Thu, 23 Mar 2017 13:49:14 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Thu, 23 Mar 2017 13:49:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=cAKaGTT4RW2YospWfUIA0X0FxUQzwkK3GZizpm6ar Nk=; b=wtuVNTXbTLCWrRNzgNtvFClwL8wpmDdgrAi98KZmw2NM5N1Pi4BhHXMsu 8CxKAFNZHo2ilKWYlpSBfHy1hWlEr2TbHgrxD/+gkDc8xfCUYFqT8LCs6L9WCi77 g/N7nCOxX33e+lwHvhG3gJIlKGPb02FxzzCGs/lYhZ+5exEinCwICt3fGIBqofTP viarC9KuDu1KAVOkTZvAoF80ok+d63TklK3pu3gVVpo6JRvcR9LHSvvOIywesBaW UgBGpU+ewxksDvJlHt0rvtUwxmycTv6L8pTG2JEovrfJpEtmh0e3FE4unIKcF8bE cUp0ASBvXc50AJEbfC4UjfWgVIB9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=cAKaGTT4RW2YospWfU IA0X0FxUQzwkK3GZizpm6arNk=; b=g1vCFfiv751mCcB1DViQYha7ECA77Tu25+ wV/9VE7FYvS9tLHKmIclG4BMxQDrxdrFJvqtpCW1XsC62gkDK2LqplNZSZqC+U01 O5PYbrnksQqA3QaaZH+wChZQmj3L6MG8AyuTwKP+MsXh/9jj8JW+LIZjqcOZuRlS Pxe5TPC/bnv6E9aTQMCwNRWRTNuqpkuPjrad1TQ1cBPEo0zhQYcRmk/ZXP4zGFwl 6hC7e4IU/xHIozu/KH9rPyXYNpFtGifCt2qKtVn9aG6tMcnuDfEjuMMDLopn7NXp mcYXW/ES43a/71re9FL0k8nlDCb1Ec+NMmcgfb+72sE+zwQS5MRA== X-ME-Sender: X-Sasl-enc: zp7vWMzhYQ7OxAHHjCSRnBQHaX3vrBaWYtVob559hoOk 1490291353 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id C092D244DA; Thu, 23 Mar 2017 13:49:13 -0400 (EDT) From: Marius Bakke To: Kei Kebreau , 26222@debbugs.gnu.org Subject: Re: bug#26222: [PATCH] gnu: freedoom: Avoid the need to propagate prboom-plus. In-Reply-To: <20170323023539.23855-1-kei@openmailbox.org> References: <20170323023539.23855-1-kei@openmailbox.org> User-Agent: Notmuch/0.24 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) Date: Thu, 23 Mar 2017 18:49:12 +0100 Message-ID: <877f3f6fzb.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26222 Cc: Kei Kebreau X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Kei Kebreau writes: > * gnu/packages/games.scm (freedoom)[arguments]: Substitute shell > variable assignment in start script for a direct engine launch. > --- > gnu/packages/games.scm | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > index 67fcb7b49..401ba4444 100644 > --- a/gnu/packages/games.scm > +++ b/gnu/packages/games.scm > @@ -162,14 +162,19 @@ > (("freedoom2.png") > "-define png:exclude-chunks=3Ddate freedoom2.png= ")) > ;; Make sure that the install scripts know where to= find > - ;; the appropriate WAD files. > + ;; the appropriate WAD files and Doom engine. > + ;; Do this by turning a shell variable assignment i= nto a > + ;; direct engine launch and exit. > (substitute* "dist/freedoom" > - (("IWAD=3Dfreedm.wad") > - (string-append "IWAD=3D" wad-dir "/freedm.wad")) > - (("IWAD=3Dfreedoom1.wad") > - (string-append "IWAD=3D" wad-dir "/freedoom1.wad= ")) > - (("IWAD=3Dfreedoom2.wad") > - (string-append "IWAD=3D" wad-dir "/freedoom2.wad= "))) > + (("IWAD=3D") > + (string-append (assoc-ref inputs "prboom-plus") > + "/bin/prboom-plus -iwad ")) > + (("freedm.wad") > + (string-append wad-dir "/freedm.wad \"$@\"; exi= t $?")) > + (("freedoom1.wad") > + (string-append wad-dir "/freedoom1.wad \"$@\"; = exit $?")) > + (("freedoom2.wad") > + (string-append wad-dir "/freedoom2.wad \"$@\"; e= xit $?"))) From=20reading the "dist/freedoom" shell script, it looks like it tries prboom-plus automatically if it exists in PATH. Does this not work? It also tries a bunch of other engines, so I don't think we should hard code one. > #t)))))) > (native-inputs > `(("asciidoc" ,asciidoc) > --=20 > 2.12.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAljUCpgACgkQoqBt8qM6 VPrH7Af/an2VDAnXQOAJbExgrlGsVzQEC1nxUXeH8KwV7CPr7AupTIV0J1Zzj1KI kXq5x0T4jlErPv1ktIQH68c8C9YUmsix+KmhkGy2tAwRn4f9zDC1u+OiUFysOxSm Lt9xOJCsBBc0ew/tiwa4AhWhsfKNisf9dvAq1EZOapkjeT8Nx2lbCj3oZKdm18J+ Db7N0wJI2JdF1MYuZhgw3HPHKsoTbrImuRBNZLyLeBLaB7vngXCZvsJ8EUavHa1+ YcMaVAqgyTvvdlc1l2Xfh1W5lbREgdNXQ+P7ZIA2demVnD7c0lMTP/dULRuKgz/p oZngLivVkHGin5UAnsl7iY/iqE8rXg== =PIGX -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 22:46:19 2017 Received: (at 26222) by debbugs.gnu.org; 24 Mar 2017 02:46:19 +0000 Received: from localhost ([127.0.0.1]:41589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crFF5-0001Ih-5S for submit@debbugs.gnu.org; Thu, 23 Mar 2017 22:46:19 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:59999 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crFF2-0001IX-Oi for 26222@debbugs.gnu.org; Thu, 23 Mar 2017 22:46:17 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 69F6351801F; Fri, 24 Mar 2017 03:46:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1490323575; bh=29Vp5+6lB/iv8gqLqMT0eBXeE3xUaasRjfWGohndVQ0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=wVCTrTBcdg3dDvWlsVYZ5PA3BczMikZtgUlhxMEDCIyYF1bIt98RgOz5qTYl7Uioo koCMrcoBWCcoGTaK7ac7IAunOlYSYbeliONK3XbyL6orwXVPjwlUL+vsZxTH6Qn3cR SBVPRQkZXnIkHxOV7xdy5mM7E8z+UdDj21BP886w= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR003 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1490323574; bh=29Vp5+6lB/iv8gqLqMT0eBXeE3xUaasRjfWGohndVQ0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=w+9ZPM0+Y45YKxjgHi5n7++uixn6cIACuNr40qpH2Nklbolqh6hKZehPavuTPOpMB Gtnk5J2F0YxIP5Kdk4ztIDmpu8s7r9gyQSOZhYUlNrTLurk8ELxctSu1oWn4lDYu7G 6Z3cg0mSrJHvLrDieNdbifzRq4cCy9sPMbFDh0LQ= To: Marius Bakke Subject: Re: bug#26222: [PATCH] gnu: freedoom: Avoid the need to propagate prboom-plus. References: <20170323023539.23855-1-kei@openmailbox.org> <877f3f6fzb.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Date: Thu, 23 Mar 2017 22:46:03 -0400 In-Reply-To: <877f3f6fzb.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Thu, 23 Mar 2017 18:49:12 +0100") Message-ID: <87poh72xzo.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26222 Cc: 26222@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Marius Bakke writes: > Kei Kebreau writes: > >> * gnu/packages/games.scm (freedoom)[arguments]: Substitute shell >> variable assignment in start script for a direct engine launch. >> --- >> gnu/packages/games.scm | 19 ++++++++++++------- >> 1 file changed, 12 insertions(+), 7 deletions(-) >> >> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm >> index 67fcb7b49..401ba4444 100644 >> --- a/gnu/packages/games.scm >> +++ b/gnu/packages/games.scm >> @@ -162,14 +162,19 @@ >> (("freedoom2.png") >> "-define png:exclude-chunks=3Ddate freedoom2.pn= g")) >> ;; Make sure that the install scripts know where t= o find >> - ;; the appropriate WAD files. >> + ;; the appropriate WAD files and Doom engine. >> + ;; Do this by turning a shell variable assignment = into a >> + ;; direct engine launch and exit. >> (substitute* "dist/freedoom" >> - (("IWAD=3Dfreedm.wad") >> - (string-append "IWAD=3D" wad-dir "/freedm.wad")) >> - (("IWAD=3Dfreedoom1.wad") >> - (string-append "IWAD=3D" wad-dir "/freedoom1.wa= d")) >> - (("IWAD=3Dfreedoom2.wad") >> - (string-append "IWAD=3D" wad-dir "/freedoom2.wa= d"))) >> + (("IWAD=3D") >> + (string-append (assoc-ref inputs "prboom-plus") >> + "/bin/prboom-plus -iwad ")) >> + (("freedm.wad") >> + (string-append wad-dir "/freedm.wad \"$@\"; ex= it $?")) >> + (("freedoom1.wad") >> + (string-append wad-dir "/freedoom1.wad \"$@\";= exit $?")) >> + (("freedoom2.wad") >> + (string-append wad-dir "/freedoom2.wad \"$@\"; = exit $?"))) > > From reading the "dist/freedoom" shell script, it looks like it tries > prboom-plus automatically if it exists in PATH. Does this not work? It > also tries a bunch of other engines, so I don't think we should hard > code one. > In that case, we could instead leave the package as is and have users install prboom-plus (or future engines when they are packaged) manually. Freedoom's package description already mentions that it needs a compatible engine to run. If you think that's enough for a casual user to notice, I'm fine with dropping the patch. >> #t)))))) >> (native-inputs >> `(("asciidoc" ,asciidoc) >> --=20 >> 2.12.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljUiGsACgkQ5qXuPBlG eg0xcA//TIt/oP/FktVIjohce9owitWOGW2aGt51ed3GpSWIoOhr1zO3oh/r9KYl F8D/zqZj814GTdTfN+h5iLvE9cVwiMPkm4O2QMobOmP+O2gR0vNzwgK+pOpBYC7N bKRx3P4wPknTPARmZbsHk51RlplluL8ALTgbziTIDipJ8sa7HXG2FQXxeU49WjDj iEYRJMmIzoO3YzAR22o0nWkF7usRdXCdezsoY7u+SDYE+P1q7EHT2CFr1x/t0arS 69DlPO+O95jox+ER5ow6hMSWHipIcHOPoO91Rl09g91gHv8A7nc70eMOSGpV7j5G 0X8KvAviiwct2d8XXDCicz7hUjhHbl0uYX+ORppiEmavkd40SI4ah18FymnFcE4S 7MN1FhoPlrCZuhPuDwdknqwBrsW7ZA3R56OTXUzVRYkDJNUN5jN9wZ3t0vxZTcgw tlH/ns29XEcgrcloYoYfPmZ3qEvrTzZKyiZT/H3BSp7nK+L6+0m6Gahu7XyFwj/k TmPND64YU+MK49HqGQakMbbKu7Lqc9FnRnR4RjhOK4VXrFnZni5aJSe0Z3fBYoAG GiX1R6QTkzN7Qo5c+StYWw60AM/0oHJSxe+//ttMiVJdF5cxzChHmDSdWx6FLbBU Ru3ml5xshXzFxfNteRkQnzlEFUHw1bE9ZgUdvqnth9KT3L7BZ1o= =WFR1 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 19:19:43 2017 Received: (at 26222-done) by debbugs.gnu.org; 1 Apr 2017 23:19:43 +0000 Received: from localhost ([127.0.0.1]:56072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuSJ5-0008Kv-4w for submit@debbugs.gnu.org; Sat, 01 Apr 2017 19:19:43 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:42613 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuSJ3-0008Kn-Li for 26222-done@debbugs.gnu.org; Sat, 01 Apr 2017 19:19:42 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 770D4513E7B; Sun, 2 Apr 2017 01:19:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1491088780; bh=+eMaBNGO3bhfgE0GoesPDK/19oHgUVLQOxKhyS++ZCE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SX8h4bUyy+oc/BrGip9N/0o1jrmSE0K2r0nXIgH0gs2HMWA5xmAxgNf7WmB0xnGJP cMO47A1pcf8xUOuHSzyXFkCWRKS6NkkG6VID7FME7dCzDHEuBbkROfS59jnD969Di/ YXWoLYFmxJxm2n/5LJeDXJcP5dNvVpGfe6VuMLCw= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR003 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1491088779; bh=+eMaBNGO3bhfgE0GoesPDK/19oHgUVLQOxKhyS++ZCE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=L/fUHCKR3PmSVTkgJ1Q+Nw9YLlxL9RaJhU8vNQNCp7TPZhMWoin22e7eEHXHQuTf2 l4iiH4+yFU5+v8rlNihfmdtY3d+nxpUvxg9X6PnsZgY63m25v6xTb9/HCD28seDX0E +jX0MHMNB0jdeGYwgD261+dYPcIQmM1+c+S0RQf4= To: Marius Bakke Subject: Re: bug#26222: [PATCH] gnu: freedoom: Avoid the need to propagate prboom-plus. References: <20170323023539.23855-1-kei@openmailbox.org> <877f3f6fzb.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87poh72xzo.fsf@openmailbox.org> Date: Sat, 01 Apr 2017 19:19:26 -0400 In-Reply-To: <87poh72xzo.fsf@openmailbox.org> (Kei Kebreau's message of "Thu, 23 Mar 2017 22:46:03 -0400") Message-ID: <874ly767i9.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26222-done Cc: 26222-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Kei Kebreau writes: > Marius Bakke writes: > >> Kei Kebreau writes: >> >> From reading the "dist/freedoom" shell script, it looks like it tries >> prboom-plus automatically if it exists in PATH. Does this not work? It >> also tries a bunch of other engines, so I don't think we should hard >> code one. >> > > In that case, we could instead leave the package as is and have users > install prboom-plus (or future engines when they are packaged) > manually. Freedoom's package description already mentions that it needs > a compatible engine to run. If you think that's enough for a casual user > to notice, I'm fine with dropping the patch. > I've decided against this patch, as we may have other Doom engines available in the future. Thank you for your time, Marius. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljgNX8ACgkQ5qXuPBlG eg1Z0Q//bN0GXF7iyG5fsNOO6kOzPp2583VsTSIlteYOieDhYBS8xUXDEjCgEV83 eArEjVFu6rBrEiomjMck3UpWREyLKIuy41LWCy8opIIlpsPhd84unvt8tpxYCaUb r+juXcAwNlAQI7V01OaWf5DG68hPyJDSa8TV7slqxQAnn85TmlQjqitb6Pr+wfni +DHfbhjc8bkIz2eaZdbdjFMYld+BIzQx3ZMRc8VlQ1/rbhXrP1HuhT9FUm49/KOX xcMp1b2ONmHj91l6Mgr6XHrsgzex+3mjseBQrSlA7bbj3IBh2SLmDe6Bqlqp1m13 ZMzqNwYor9PWzII94Ils9JUq/FYgptoYjwAy8ENj0w8SUb3y2YIbl3g/Cg11TeSH qxxh2bon8U4IfUuwUjjySIjZKWpP73cWFaqVq0yagnwcKpgywRIk3T+8mNzAhigT 8OypxZDioHTwxibjJ76/ph39V8Wz4M07eZDCYmb62XvLoH4+bpc8hvn0+OX6y4Zf em89zaY7HShf3ZKZsTV9vf49xfG9+HVv28jyP6JbV7aNJaLYBVUNgtVyrXo30vWe xuqCc7Ur8UlDous80Xs5iGrmFyJ7A159fi8yDnep0eWciptmxrKNaLM650bsZXlh fSOdkS1cF88dNQHzXhDmn2byreC9ImcCLPlhAJHu0en6tS0g4iA= =1s1O -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 17 22:08:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 30 Apr 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator