GNU bug report logs - #26203
[PATCH] gnu: Add swaks.

Previous Next

Package: guix-patches;

Reported by: Arun Isaac <arunisaac <at> systemreboot.net>

Date: Tue, 21 Mar 2017 12:05:02 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 26203 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26203 <at> debbugs.gnu.org
Subject: Re: bug#26203: [PATCH] gnu: Add swaks.
Date: Tue, 21 Mar 2017 19:13:42 +0530

[Message part 1 (text/plain, inline)]
>> +         (add-after 'install 'wrap-program
>> +                    (lambda _
>> +                      (wrap-program (string-append (assoc-ref %outputs "out")
>> +                                                   "/bin/swaks")

It would be nice if the perl-build-system did this wrapping
automatically just like the python-build-system does. Is there some
reason the perl-build-system doesn't do wrapping automatically?

> Otherwise this LGTM, sorry for the nit-picks! Can you send an updated
> patch? :)

No problem. :-) "Nitpicking" and critical feedback is part of the patch
review process.

I'll send a new patch soon.

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 8 years and 61 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.