From unknown Sat Sep 20 12:49:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#26185 <26185@debbugs.gnu.org> To: bug#26185 <26185@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add freedoom. Reply-To: bug#26185 <26185@debbugs.gnu.org> Date: Sat, 20 Sep 2025 19:49:29 +0000 retitle 26185 [PATCH] gnu: Add freedoom. reassign 26185 guix-patches submitter 26185 Kei Kebreau severity 26185 normal tag 26185 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 23:10:45 2017 Received: (at submit) by debbugs.gnu.org; 20 Mar 2017 03:10:45 +0000 Received: from localhost ([127.0.0.1]:35757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpniW-0007oY-RO for submit@debbugs.gnu.org; Sun, 19 Mar 2017 23:10:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpniV-0007oJ-K5 for submit@debbugs.gnu.org; Sun, 19 Mar 2017 23:10:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpniP-0005Ts-1z for submit@debbugs.gnu.org; Sun, 19 Mar 2017 23:10:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42958) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cpniO-0005TL-V1 for submit@debbugs.gnu.org; Sun, 19 Mar 2017 23:10:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpniN-0001HX-DS for guix-patches@gnu.org; Sun, 19 Mar 2017 23:10:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpniK-0005PC-8A for guix-patches@gnu.org; Sun, 19 Mar 2017 23:10:35 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:53046 helo=mail.openmailbox.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cpniJ-0005OS-Pn for guix-patches@gnu.org; Sun, 19 Mar 2017 23:10:32 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 2EA05525FBE; Mon, 20 Mar 2017 04:10:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489979430; bh=zHPK3G66HKrf6yI648bZuDN93jNL6qHAjzHyav+cw4U=; h=From:To:Cc:Subject:Date:From; b=Dh9Q0S/SkWcOVs48LxsuOL0NQcTcWBWAVzANBmP60kD60X9V0dLI6/0v0vpaw5Uz6 DyCw8y+NI5ZR7NdEwSWkO4RI3XDLm6Q24xFSGxkCL63FIT/Svzp3GYas1xx40whM4d QnWgAyPRLN8dD9Vx/isB3NNFDuDLVuPIw7gm21Ts= From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489979429; bh=zHPK3G66HKrf6yI648bZuDN93jNL6qHAjzHyav+cw4U=; h=From:To:Cc:Subject:Date:From; b=FORS9UCW3cIxnxdeHA2e/qDvNgg7z0p0eqIMd/YZwvE9FwPpwnCkQuTuv+WXQfX8i L5Y+2aF7f0i/0CRQm2PYJU3iCf+Nz+Aha4xbDCDtNwOhF39YiaeBEbsA7mOymg/f8n ilc4gQeNJHpHz9hcQ6bQNPTwY5YSlcVItvOb+F4Q= To: guix-patches@gnu.org Subject: [PATCH] gnu: Add freedoom. Date: Sun, 19 Mar 2017 23:09:47 -0400 Message-Id: <20170320030947.9295-1-kei@openmailbox.org> X-Mailer: git-send-email 2.12.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Kei Kebreau X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * gnu/packages/games.scm (freedoom): New variable. --- gnu/packages/games.scm | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 72 insertions(+) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index f264ef206..95a13b8c4 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -58,6 +58,7 @@ #:use-module (gnu packages audio) #:use-module (gnu packages avahi) #:use-module (gnu packages boost) + #:use-module (gnu packages documentation) #:use-module (gnu packages fltk) #:use-module (gnu packages fribidi) #:use-module (gnu packages game-development) @@ -69,6 +70,7 @@ #:use-module (gnu packages gperf) #:use-module (gnu packages gtk) #:use-module (gnu packages guile) + #:use-module (gnu packages imagemagick) #:use-module (gnu packages libcanberra) #:use-module (gnu packages libunwind) #:use-module (gnu packages haskell) @@ -113,6 +115,76 @@ #:use-module (guix build-system cmake) #:use-module (guix build-system trivial)) +(define-public freedoom + (package + (name "freedoom") + (version "0.11.1") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/" name "/" name + "/archive/v" version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "060dqppd9fi079yw6c82klsjaslcabq6xan67wf9hs0cy39i0kpv")))) + (build-system gnu-build-system) + (arguments + '(#:make-flags `(,(string-append "prefix=" (assoc-ref %outputs "out"))) + #:parallel-build? #f + #:tests? #f ; no check target + #:phases + (modify-phases %standard-phases + (add-before 'unpack 'no (lambda _ #t)) + (replace 'configure + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((dejavu (assoc-ref inputs "font-dejavu")) + (freedoom (assoc-ref outputs "out")) + (wad-dir (string-append freedoom "/share/games/doom"))) + ;; Replace the font-searching function in a shell + ;; script with a direct path to the required font. + ;; This is necessary because ImageMagick can only find the + ;; most basic fonts while in the build environment. + (substitute* "graphics/titlepic/create_caption" + (("font=\\$\\(find_font.*$") + (string-append + "font=" dejavu + "/share/fonts/truetype/DejaVuSansCondensed-Bold.ttf\n"))) + ;; Make icon creation reproducible. + (substitute* "dist/Makefile" + (("freedm.png") + "-define png:exclude-chunks=date freedm.png") + (("freedoom1.png") + "-define png:exclude-chunks=date freedoom1.png") + (("freedoom2.png") + "-define png:exclude-chunks=date freedoom2.png")) + ;; Make sure that the install scripts know where to find + ;; the appropriate WAD files. + (substitute* "dist/freedoom" + (("IWAD=freedm.wad") + (string-append "IWAD=" wad-dir "/freedm.wad")) + (("IWAD=freedoom1.wad") + (string-append "IWAD=" wad-dir "/freedoom1.wad")) + (("IWAD=freedoom2.wad") + (string-append "IWAD=" wad-dir "/freedoom2.wad"))) + #t)))))) + (native-inputs + `(("asciidoc" ,asciidoc) + ("deutex" ,deutex) + ("font-dejavu" ,font-dejavu) + ("imagemagick" ,imagemagick) + ("python" ,python-2))) + (inputs + `(("prboom-plus" ,prboom-plus))) + (home-page "https://freedoom.github.io/") + (synopsis "Free content game based on the Doom engine") + (description + "The Freedoom project aims to create a complete free content first person +shooter game. But Freedoom by itself is just the raw material for a game: it +must be paired with a compatible game engine to be played. Freedoom +complements the Doom engine with free levels, artwork, sound effects and music +to make a completely free game.") + (license license:bsd-3))) + (define-public gnubg (package (name "gnubg") -- 2.12.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 13:07:08 2017 Received: (at 26185) by debbugs.gnu.org; 20 Mar 2017 17:07:08 +0000 Received: from localhost ([127.0.0.1]:36562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cq0lv-0004eg-Or for submit@debbugs.gnu.org; Mon, 20 Mar 2017 13:07:08 -0400 Received: from dustycloud.org ([50.116.34.160]:34126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cq0lu-0004eX-Ls for 26185@debbugs.gnu.org; Mon, 20 Mar 2017 13:07:07 -0400 Received: from oolong (localhost [127.0.0.1]) by dustycloud.org (Postfix) with ESMTPS id 875182664A; Mon, 20 Mar 2017 13:07:03 -0400 (EDT) References: <20170320030947.9295-1-kei@openmailbox.org> User-agent: mu4e 0.9.18; emacs 25.1.1 From: Christopher Allan Webber To: Kei Kebreau Subject: Re: bug#26185: [PATCH] gnu: Add freedoom. In-reply-to: <20170320030947.9295-1-kei@openmailbox.org> Date: Mon, 20 Mar 2017 12:07:02 -0500 Message-ID: <87mvcfswqx.fsf@dustycloud.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26185 Cc: 26185@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Ooooooh! I love freedoom. Kei Kebreau writes: > * gnu/packages/games.scm (freedoom): New variable. > --- > gnu/packages/games.scm | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 72 insertions(+) > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > index f264ef206..95a13b8c4 100644 > --- a/gnu/packages/games.scm > +++ b/gnu/packages/games.scm > @@ -58,6 +58,7 @@ > #:use-module (gnu packages audio) > #:use-module (gnu packages avahi) > #:use-module (gnu packages boost) > + #:use-module (gnu packages documentation) > #:use-module (gnu packages fltk) > #:use-module (gnu packages fribidi) > #:use-module (gnu packages game-development) > @@ -69,6 +70,7 @@ > #:use-module (gnu packages gperf) > #:use-module (gnu packages gtk) > #:use-module (gnu packages guile) > + #:use-module (gnu packages imagemagick) > #:use-module (gnu packages libcanberra) > #:use-module (gnu packages libunwind) > #:use-module (gnu packages haskell) > @@ -113,6 +115,76 @@ > #:use-module (guix build-system cmake) > #:use-module (guix build-system trivial)) > > +(define-public freedoom > + (package > + (name "freedoom") > + (version "0.11.1") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/" name "/" name > + "/archive/v" version ".tar.gz")) > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "060dqppd9fi079yw6c82klsjaslcabq6xan67wf9hs0cy39i0kpv")))) > + (build-system gnu-build-system) > + (arguments > + '(#:make-flags `(,(string-append "prefix=" (assoc-ref %outputs "out"))) > + #:parallel-build? #f > + #:tests? #f ; no check target > + #:phases > + (modify-phases %standard-phases > + (add-before 'unpack 'no (lambda _ #t)) > + (replace 'configure > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((dejavu (assoc-ref inputs "font-dejavu")) > + (freedoom (assoc-ref outputs "out")) > + (wad-dir (string-append freedoom "/share/games/doom"))) > + ;; Replace the font-searching function in a shell > + ;; script with a direct path to the required font. > + ;; This is necessary because ImageMagick can only find the > + ;; most basic fonts while in the build environment. > + (substitute* "graphics/titlepic/create_caption" > + (("font=\\$\\(find_font.*$") > + (string-append > + "font=" dejavu > + "/share/fonts/truetype/DejaVuSansCondensed-Bold.ttf\n"))) > + ;; Make icon creation reproducible. > + (substitute* "dist/Makefile" > + (("freedm.png") > + "-define png:exclude-chunks=date freedm.png") > + (("freedoom1.png") > + "-define png:exclude-chunks=date freedoom1.png") > + (("freedoom2.png") > + "-define png:exclude-chunks=date freedoom2.png")) > + ;; Make sure that the install scripts know where to find > + ;; the appropriate WAD files. > + (substitute* "dist/freedoom" > + (("IWAD=freedm.wad") > + (string-append "IWAD=" wad-dir "/freedm.wad")) > + (("IWAD=freedoom1.wad") > + (string-append "IWAD=" wad-dir "/freedoom1.wad")) > + (("IWAD=freedoom2.wad") > + (string-append "IWAD=" wad-dir "/freedoom2.wad"))) > + #t)))))) > + (native-inputs > + `(("asciidoc" ,asciidoc) > + ("deutex" ,deutex) > + ("font-dejavu" ,font-dejavu) > + ("imagemagick" ,imagemagick) > + ("python" ,python-2))) > + (inputs > + `(("prboom-plus" ,prboom-plus))) > + (home-page "https://freedoom.github.io/") > + (synopsis "Free content game based on the Doom engine") > + (description > + "The Freedoom project aims to create a complete free content first person > +shooter game. But Freedoom by itself is just the raw material for a game: it I think the "But" can be removed here. > +must be paired with a compatible game engine to be played. Freedoom How about saying "(such as prboom-plus)" ? That way people know what to install. > +complements the Doom engine with free levels, artwork, sound effects and music > +to make a completely free game.") > + (license license:bsd-3))) > + > (define-public gnubg > (package > (name "gnubg") Otherwise, looks good! I booted it up and it worked great. Lost 15 minutes into shooting up zombified soldiers... One comment about the submission: maybe it would be better in the future to post a patch formatted using git format-patch? It would be easier to apply and push. But it looks like you have commit access, so with the couple of description nits adjusted, I think it's okay to push! Nice work! Freedoooooooom! From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 14:32:56 2017 Received: (at 26185-done) by debbugs.gnu.org; 20 Mar 2017 18:32:56 +0000 Received: from localhost ([127.0.0.1]:36636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cq26x-0006k2-Np for submit@debbugs.gnu.org; Mon, 20 Mar 2017 14:32:56 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:56707 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cq26v-0006ju-L6 for 26185-done@debbugs.gnu.org; Mon, 20 Mar 2017 14:32:54 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 610F450AE6C; Mon, 20 Mar 2017 19:32:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1490034772; bh=BsIwiT9eR1zl2gyG+Eqw6PJubpESevwFBoaTf6lgIIc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lRXgRG4KJZcj76CZFiVdvyTrtw2VXh+e/7Eum/GHwzquvsbBcTFubt6QgedvW1JJs hrDA4jZ0eh5sPB1fHZgLN54rBBbTZ1uOknCRE6vERyqSA5ggKhjssLeexKiktx0qs6 Xibx9qgD9V6rhTXhG+dqVFTliZHgFmQdllBSgq40= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR002 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1490034771; bh=BsIwiT9eR1zl2gyG+Eqw6PJubpESevwFBoaTf6lgIIc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ejTnK5nNu487BNRv4PssK90fkBa7DeXBdbouzTt3VC45yRGRr6DQ+jMYVKOvfr+nG lcmWPu8+LcqdSiLUvFOvvkaIZrSgRuJINO9qj2ttU9kjBlNmIv17Hlky8b+9MZvIeB c32ht1BBOhxmTI/G4MyuHN7/SfWJTCL4Bp54AuGI= To: Christopher Allan Webber Subject: Re: bug#26185: [PATCH] gnu: Add freedoom. References: <20170320030947.9295-1-kei@openmailbox.org> <87mvcfswqx.fsf@dustycloud.org> Date: Mon, 20 Mar 2017 14:32:47 -0400 In-Reply-To: <87mvcfswqx.fsf@dustycloud.org> (Christopher Allan Webber's message of "Mon, 20 Mar 2017 12:07:02 -0500") Message-ID: <871str6bow.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26185-done Cc: 26185-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Christopher Allan Webber writes: > Ooooooh! I love freedoom. > > Kei Kebreau writes: > >> * gnu/packages/games.scm (freedoom): New variable. >> --- >> gnu/packages/games.scm | 72 +++++++++++++++++++++++++++++++++++++++++++= +++++++ >> 1 file changed, 72 insertions(+) >> >> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm >> index f264ef206..95a13b8c4 100644 >> --- a/gnu/packages/games.scm >> +++ b/gnu/packages/games.scm >> @@ -58,6 +58,7 @@ >> #:use-module (gnu packages audio) >> #:use-module (gnu packages avahi) >> #:use-module (gnu packages boost) >> + #:use-module (gnu packages documentation) >> #:use-module (gnu packages fltk) >> #:use-module (gnu packages fribidi) >> #:use-module (gnu packages game-development) >> @@ -69,6 +70,7 @@ >> #:use-module (gnu packages gperf) >> #:use-module (gnu packages gtk) >> #:use-module (gnu packages guile) >> + #:use-module (gnu packages imagemagick) >> #:use-module (gnu packages libcanberra) >> #:use-module (gnu packages libunwind) >> #:use-module (gnu packages haskell) >> @@ -113,6 +115,76 @@ >> #:use-module (guix build-system cmake) >> #:use-module (guix build-system trivial)) >>=20=20 >> +(define-public freedoom >> + (package >> + (name "freedoom") >> + (version "0.11.1") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "https://github.com/" name "/" name >> + "/archive/v" version ".tar.gz")) >> + (file-name (string-append name "-" version ".tar.gz")) >> + (sha256 >> + (base32 >> + "060dqppd9fi079yw6c82klsjaslcabq6xan67wf9hs0cy39i0kpv")))) >> + (build-system gnu-build-system) >> + (arguments >> + '(#:make-flags `(,(string-append "prefix=3D" (assoc-ref %outputs "o= ut"))) >> + #:parallel-build? #f >> + #:tests? #f ; no check target >> + #:phases >> + (modify-phases %standard-phases >> + (add-before 'unpack 'no (lambda _ #t)) >> + (replace 'configure >> + (lambda* (#:key inputs outputs #:allow-other-keys) >> + (let* ((dejavu (assoc-ref inputs "font-dejavu")) >> + (freedoom (assoc-ref outputs "out")) >> + (wad-dir (string-append freedoom "/share/game= s/doom"))) >> + ;; Replace the font-searching function in a shell >> + ;; script with a direct path to the required font. >> + ;; This is necessary because ImageMagick can only = find the >> + ;; most basic fonts while in the build environment. >> + (substitute* "graphics/titlepic/create_caption" >> + (("font=3D\\$\\(find_font.*$") >> + (string-append >> + "font=3D" dejavu >> + "/share/fonts/truetype/DejaVuSansCondensed-Bol= d.ttf\n"))) >> + ;; Make icon creation reproducible. >> + (substitute* "dist/Makefile" >> + (("freedm.png") >> + "-define png:exclude-chunks=3Ddate freedm.png") >> + (("freedoom1.png") >> + "-define png:exclude-chunks=3Ddate freedoom1.pn= g") >> + (("freedoom2.png") >> + "-define png:exclude-chunks=3Ddate freedoom2.pn= g")) >> + ;; Make sure that the install scripts know where t= o find >> + ;; the appropriate WAD files. >> + (substitute* "dist/freedoom" >> + (("IWAD=3Dfreedm.wad") >> + (string-append "IWAD=3D" wad-dir "/freedm.wad")) >> + (("IWAD=3Dfreedoom1.wad") >> + (string-append "IWAD=3D" wad-dir "/freedoom1.wa= d")) >> + (("IWAD=3Dfreedoom2.wad") >> + (string-append "IWAD=3D" wad-dir "/freedoom2.wa= d"))) >> + #t)))))) >> + (native-inputs >> + `(("asciidoc" ,asciidoc) >> + ("deutex" ,deutex) >> + ("font-dejavu" ,font-dejavu) >> + ("imagemagick" ,imagemagick) >> + ("python" ,python-2))) >> + (inputs >> + `(("prboom-plus" ,prboom-plus))) >> + (home-page "https://freedoom.github.io/") >> + (synopsis "Free content game based on the Doom engine") >> + (description >> + "The Freedoom project aims to create a complete free content first = person >> +shooter game. But Freedoom by itself is just the raw material for a ga= me: it > > I think the "But" can be removed here. > Removed. >> +must be paired with a compatible game engine to be played. Freedoom > > How about saying "(such as prboom-plus)" ? That way people know what to = install. > Added, using @code{prboom-plus}. >> +complements the Doom engine with free levels, artwork, sound effects an= d music >> +to make a completely free game.") >> + (license license:bsd-3))) >> + >> (define-public gnubg >> (package >> (name "gnubg") > > Otherwise, looks good! I booted it up and it worked great. Lost 15 > minutes into shooting up zombified soldiers... > > One comment about the submission: maybe it would be better in the future > to post a patch formatted using git format-patch? It would be easier to > apply and push. > If I recall correctly, I did use `git format-patch -1` to make the patch and `git send-mail` to send it. Perhaps something went wrong in the process? > But it looks like you have commit access, so with the couple of > description nits adjusted, I think it's okay to push! Nice work! > > Freedoooooooom! Thanks for the review! Just pushed to master as 0b5d078f8ba7953a51343fde087e157fbc4a0308. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljQIE8ACgkQ5qXuPBlG eg2YlxAAmZxQl3ikjf8cukpadTjjhSPIKJuIFpbHBwBcJVbm3dSuenNR/a/g58a8 R77nfRhx9p2LCrLLdPnzi2yfL+vldVG8tdjUNH39yrpkkJo4WxdBF4aixm7XxOIp YZgaZelsQzOQmUXr4yJX591ifND7sVHsWDAgOER7mYPZ3xuAYamrUZqMP2LJpa41 6UQDTZn+x3xtrBsog3N4Dq55veHAmlqq2vkUxaxDBO4qxdb8j6KUbba6rECaQlbt Qc8Iup45Mh7Kc7Bq+3E9fqNnciu0bptQffrOb7Esf0ry6fX4iFKl/rAIhU0kDHfh FSFqFcxwI5ltkkHuPgs8AQ1bCczQZh+RTqb/poQ30NaaMGSw7PlfcpOYkswHbXSN ntSdyN04qdy8JLYpE/FrY1S52qG8G4I5k0DL4Io5iuIG6r3U4oB0d8xpFzx5onfy phBuzHURQmJ7OSZGknQUg23IhDsjFSsMGAtmxNPxgsCdIZEm8PN/IeMaSyuWarSG kwD8SHiRv5faKC2Lidz1UqBEsT5HPnV2Zwn9gHEhbX07jK8kJkwUx2wB6Hb/VaAf RF2wChK1uC37bCqVwuScQgxOFDjToJxkqmpi6WX+R09fVKPfAtSjwAwY884NmVUt CK4vrDP9Jny+cfG+ca1a6gYN6hFpq55HEooC5M/X928NIgqY2js= =IBQA -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 20 12:49:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 18 Apr 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator