GNU bug report logs - #26163
time-difference doesn't detect error of differing time types

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Zefram <zefram <at> fysh.org>
Subject: bug#26163: closed (Re: bug#26163: time-difference doesn't detect
 error of differing time types)
Date: Sun, 21 Oct 2018 23:46:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#26163: time-difference doesn't detect error of differing time types

which was filed against the guile package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 26163 <at> debbugs.gnu.org.

-- 
26163: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26163
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mark H Weaver <mhw <at> netris.org>
To: Zefram <zefram <at> fysh.org>
Cc: 26163-done <at> debbugs.gnu.org
Subject: Re: bug#26163: time-difference doesn't detect error of differing time
 types
Date: Sun, 21 Oct 2018 19:45:14 -0400

Zefram <zefram <at> fysh.org> writes:

> scheme@(guile-user)> (use-modules (srfi srfi-19))
> scheme@(guile-user)> (time-difference (make-time time-tai 0 1) (make-time time-utc 0 1))
> $1 = #<time type: time-duration nanosecond: 0 second: 0>
>
> SRFI-19 is explicit that it "is an error" if the arguments to
> time-difference are of different time types, and correspondingly the
> Guile documentation says the arguments "must be" of the same type.
> It would be very easy for time-difference to detect and signal this error.
> It's not absolutely a bug that it currently doesn't, but it would be a
> useful improvement if it did.

Agreed.  Fixed in commit c9d903b6e4f8cc1d8382b20a2f0502c4ce8ffe0a on the
stable-2.2 branch.  I'm closing this bug, but feel free to reopen if
appropriate.

     Thanks!
       Mark

[Message part 3 (message/rfc822, inline)]

From: Zefram <zefram <at> fysh.org>
To: bug-guile <at> gnu.org
Subject: time-difference doesn't detect error of differing time types
Date: Sat, 18 Mar 2017 22:23:36 +0000

scheme@(guile-user)> (use-modules (srfi srfi-19))
scheme@(guile-user)> (time-difference (make-time time-tai 0 1) (make-time time-utc 0 1))
$1 = #<time type: time-duration nanosecond: 0 second: 0>

SRFI-19 is explicit that it "is an error" if the arguments to
time-difference are of different time types, and correspondingly the
Guile documentation says the arguments "must be" of the same type.
It would be very easy for time-difference to detect and signal this error.
It's not absolutely a bug that it currently doesn't, but it would be a
useful improvement if it did.

-zefram

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.