From unknown Wed Jun 18 23:16:27 2025
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
Content-Type: text/plain; charset=utf-8
From: bug#26163 <26163@debbugs.gnu.org>
To: bug#26163 <26163@debbugs.gnu.org>
Subject: Status: time-difference doesn't detect error of differing time types
Reply-To: bug#26163 <26163@debbugs.gnu.org>
Date: Thu, 19 Jun 2025 06:16:27 +0000

retitle 26163 time-difference doesn't detect error of differing time types
reassign 26163 guile
submitter 26163 Zefram <zefram@fysh.org>
severity 26163 normal

thanks


From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 18:23:49 2017
Received: (at submit) by debbugs.gnu.org; 18 Mar 2017 22:23:49 +0000
Received: from localhost ([127.0.0.1]:34392 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1cpMlJ-0003Zk-I3
	for submit@debbugs.gnu.org; Sat, 18 Mar 2017 18:23:49 -0400
Received: from eggs.gnu.org ([208.118.235.92]:51845)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zefram@fysh.org>) id 1cpMlH-0003ZY-NS
 for submit@debbugs.gnu.org; Sat, 18 Mar 2017 18:23:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <zefram@fysh.org>) id 1cpMlB-0001HC-Oh
 for submit@debbugs.gnu.org; Sat, 18 Mar 2017 18:23:42 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID
 autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:50357)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <zefram@fysh.org>) id 1cpMlB-0001H8-LP
 for submit@debbugs.gnu.org; Sat, 18 Mar 2017 18:23:41 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42804)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <zefram@fysh.org>) id 1cpMlA-0005Zx-Jo
 for bug-guile@gnu.org; Sat, 18 Mar 2017 18:23:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <zefram@fysh.org>) id 1cpMl9-0001Gj-Sv
 for bug-guile@gnu.org; Sat, 18 Mar 2017 18:23:40 -0400
Received: from river6.fysh.org ([2001:41d0:d:20da::2]:55224
 helo=river.fysh.org)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <zefram@fysh.org>) id 1cpMl9-0001GY-NG
 for bug-guile@gnu.org; Sat, 18 Mar 2017 18:23:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fysh.org;
 s=20170316; 
 h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date;
 bh=GLuotTTPbUhgvDoybvbG1LncXOU+YhDLL1COpIsCnx4=; 
 b=1OldtUv4a7FeCvq/CxmivPpFMw/Suvpa1RTqo90cchKYGkjpp+LTWmkr0P20cPJvtyPLouPJCB9HbIGUUtU0cDedO6gSetj4K09GjWTBUpxvvRgh+6J5VlgvmlnQA698MFEEquZLnXyAbMYwmEMNyRub7sXn3NTEcht09SInJl8=;
Received: from zefram by river.fysh.org with local (Exim 4.84_2 #1 (Debian))
 id 1cpMl6-0004Xd-Qn; Sat, 18 Mar 2017 22:23:36 +0000
Date: Sat, 18 Mar 2017 22:23:36 +0000
From: Zefram <zefram@fysh.org>
To: bug-guile@gnu.org
Subject: time-difference doesn't detect error of differing time types
Message-ID: <20170318222336.GJ6518@fysh.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
 recognized.
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -4.0 (----)

scheme@(guile-user)> (use-modules (srfi srfi-19))
scheme@(guile-user)> (time-difference (make-time time-tai 0 1) (make-time time-utc 0 1))
$1 = #<time type: time-duration nanosecond: 0 second: 0>

SRFI-19 is explicit that it "is an error" if the arguments to
time-difference are of different time types, and correspondingly the
Guile documentation says the arguments "must be" of the same type.
It would be very easy for time-difference to detect and signal this error.
It's not absolutely a bug that it currently doesn't, but it would be a
useful improvement if it did.

-zefram




From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 19 14:12:15 2017
Received: (at 26163) by debbugs.gnu.org; 19 Apr 2017 18:12:15 +0000
Received: from localhost ([127.0.0.1]:57333 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1d0u5N-0007Mf-VU
	for submit@debbugs.gnu.org; Wed, 19 Apr 2017 14:12:15 -0400
Received: from river.fysh.org ([87.98.248.19]:52666 ident=Debian-exim)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zefram@fysh.org>) id 1d0u5L-0007MW-KO
 for 26163@debbugs.gnu.org; Wed, 19 Apr 2017 14:12:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fysh.org;
 s=20170316; 
 h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date;
 bh=BrUe0znNjO1I2VgPA1I9J6ziw4H1IEyJSwbrb3QI/8o=; 
 b=iwDXKX0eGHtdcE/aTTLUJ6+TSt296I6Ho54FzBWPRQvHxeZVvt9pioSdPtoqbLVUu8j4Dpfk3oQtqLGafh5VlW9ZQ5cBR6XvR3/zojcDTzu6EfOfV3CIiIBPRYF0WNt1F7eMi8zj/qd2QOmzYcOJPi0rsEiehLPRPDL+I+Y3kJM=;
Received: from zefram by river.fysh.org with local (Exim 4.84_2 #1 (Debian))
 id 1d0u5I-0000yF-Kl; Wed, 19 Apr 2017 19:12:08 +0100
Date: Wed, 19 Apr 2017 19:12:08 +0100
From: Zefram <zefram@fysh.org>
To: 26163@debbugs.gnu.org
Subject: Re: bug#26163: time-difference doesn't detect error of differing
 time types
Message-ID: <20170419181208.GA912@fysh.org>
References: <20170318222336.GJ6518@fysh.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="jRHKVT23PllUwdXP"
Content-Disposition: inline
In-Reply-To: <20170318222336.GJ6518@fysh.org>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 26163
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: 0.0 (/)


--jRHKVT23PllUwdXP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Patch attached.

-zefram

--jRHKVT23PllUwdXP
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="0001-signal-error-of-time-difference-on-differing-types.patch"

>From 6f9d9b355233b578eb3ce13549c8fdc9d7fb8364 Mon Sep 17 00:00:00 2001
From: Zefram <zefram@fysh.org>
Date: Wed, 19 Apr 2017 19:02:13 +0100
Subject: [PATCH] signal error of time-difference on differing types

It is an error to apply SRFI-19's time-difference to time structures of
differing time types.  Detect and signal the error.
---
 module/srfi/srfi-19.scm | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/module/srfi/srfi-19.scm b/module/srfi/srfi-19.scm
index c6a55a2..8da711f 100644
--- a/module/srfi/srfi-19.scm
+++ b/module/srfi/srfi-19.scm
@@ -413,12 +413,14 @@
 ;; -- Time arithmetic
 
 (define (time-difference! time1 time2)
-  (let ((sec-diff (- (time-second time1) (time-second time2)))
-        (nsec-diff (- (time-nanosecond time1) (time-nanosecond time2))))
-    (set-time-type! time1 time-duration)
-    (set-time-second! time1 sec-diff)
-    (set-time-nanosecond! time1 nsec-diff)
-    (time-normalize! time1)))
+  (if (not (eq? (time-type time1) (time-type time2)))
+      (time-error 'time-difference 'incompatible-time-types time2)
+      (let ((sec-diff (- (time-second time1) (time-second time2)))
+	    (nsec-diff (- (time-nanosecond time1) (time-nanosecond time2))))
+	(set-time-type! time1 time-duration)
+	(set-time-second! time1 sec-diff)
+	(set-time-nanosecond! time1 nsec-diff)
+	(time-normalize! time1))))
 
 (define (time-difference time1 time2)
   (let ((result (copy-time time1)))
-- 
2.1.4


--jRHKVT23PllUwdXP--




From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 21 19:45:36 2018
Received: (at 26163-done) by debbugs.gnu.org; 21 Oct 2018 23:45:36 +0000
Received: from localhost ([127.0.0.1]:34895 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gENPb-0008IF-PU
	for submit@debbugs.gnu.org; Sun, 21 Oct 2018 19:45:35 -0400
Received: from world.peace.net ([64.112.178.59]:38550)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mhw@netris.org>) id 1gENPa-0008Hx-KY
 for 26163-done@debbugs.gnu.org; Sun, 21 Oct 2018 19:45:35 -0400
Received: from mhw by world.peace.net with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)
 (envelope-from <mhw@netris.org>)
 id 1gENPU-0003sn-NR; Sun, 21 Oct 2018 19:45:28 -0400
From: Mark H Weaver <mhw@netris.org>
To: Zefram <zefram@fysh.org>
Subject: Re: bug#26163: time-difference doesn't detect error of differing time
 types
References: <20170318222336.GJ6518@fysh.org>
Date: Sun, 21 Oct 2018 19:45:14 -0400
In-Reply-To: <20170318222336.GJ6518@fysh.org> (Zefram's message of "Sat, 18
 Mar 2017 22:23:36 +0000")
Message-ID: <87tvleyid1.fsf@netris.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 26163-done
Cc: 26163-done@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Zefram <zefram@fysh.org> writes:

> scheme@(guile-user)> (use-modules (srfi srfi-19))
> scheme@(guile-user)> (time-difference (make-time time-tai 0 1) (make-time time-utc 0 1))
> $1 = #<time type: time-duration nanosecond: 0 second: 0>
>
> SRFI-19 is explicit that it "is an error" if the arguments to
> time-difference are of different time types, and correspondingly the
> Guile documentation says the arguments "must be" of the same type.
> It would be very easy for time-difference to detect and signal this error.
> It's not absolutely a bug that it currently doesn't, but it would be a
> useful improvement if it did.

Agreed.  Fixed in commit c9d903b6e4f8cc1d8382b20a2f0502c4ce8ffe0a on the
stable-2.2 branch.  I'm closing this bug, but feel free to reopen if
appropriate.

     Thanks!
       Mark




From unknown Wed Jun 18 23:16:27 2025
Received: (at fakecontrol) by fakecontrolmessage;
To: internal_control@debbugs.gnu.org
From: Debbugs Internal Request <help-debbugs@gnu.org>
Subject: Internal Control
Message-Id: bug archived.
Date: Mon, 19 Nov 2018 12:24:07 +0000
User-Agent: Fakemail v42.6.9

# This is a fake control message.
#
# The action:
# bug archived.
thanks
# This fakemail brought to you by your local debbugs
# administrator