Subject: bug#26160: closed (Re: bug#26160: [PATCH] gnu: Add deutex.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 20 Mar 2017 01:49:02 +0000

Your bug report

#26160: [PATCH] gnu: Add deutex.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
26160: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26160
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#26160: [PATCH] gnu: Add deutex.
From: Kei Kebreau <[email-masked]>
To: Leo Famulari <[email-masked]>
Cc: [email-masked]
Date: Sun, 19 Mar 2017 21:48:40 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Leo Famulari <[email-masked]> writes:

> On Sat, Mar 18, 2017 at 04:24:48PM -0400, Kei Kebreau wrote:
>> gnu/packages/game-development.scm (deutex): New variable.
>
>> +        ;; "make install" is broken for this package.
>
> It's helpful to say how it's broken. That will make it easier to know
> if `make install` is fixed in future versions of DeuTex.
>

A copy of the updated explanation:

"make install" is broken for this package.
Notably, the binaries overrwrite one another upon installation as
they are all installed to the "bin" file in the output directory,
and the manual page fails to install because the directory for the
manual page is not created.

>> +        (replace 'install
>> +                 (lambda* (#:key outputs #:allow-other-keys)
>> +                   (let* ((out (assoc-ref %outputs "out"))
>> +                          (bin (string-append out "/bin"))
>> +                          (share (string-append out "/share")))
>> +                     (mkdir-p bin)
>
> This procedure is redundant; (install-file) will create the directory.
>

Redundant procedure removed.

> Otherwise, LGTM.

Pushed to master as 1a0c4437abbe3a1dd9622cc8a7926b9add74bf79. Thanks for
the review.

Subject: [PATCH] gnu: Add deutex.
From: Kei Kebreau <[email-masked]>
To: [email-masked]
Cc: Kei Kebreau <[email-masked]>
Date: Sat, 18 Mar 2017 16:24:48 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

gnu/packages/game-development.scm (deutex): New variable.
---
 gnu/packages/game-development.scm | 48 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 47 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 908ce4834..74cac0be9 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -5,7 +5,7 @@
 ;;; Copyright © 2015 Alex Kost <[email-masked]>
 ;;; Copyright © 2015, 2016 David Thompson <[email-masked]>
 ;;; Copyright © 2016 Efraim Flashner <[email-masked]>
-;;; Copyright © 2016 Kei Kebreau <[email-masked]>
+;;; Copyright © 2016, 2017 Kei Kebreau <[email-masked]>
 ;;; Copyright © 2016 Ricardo Wurmus <[email-masked]>
 ;;; Copyright © 2016 Julian Graham <[email-masked]>
 ;;;
@@ -95,6 +95,52 @@
 is used in some video games and movies.")
     (license license:zlib)))
 
+(define-public deutex
+  (package
+   (name "deutex")
+   (version "4.4.902")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "https://github.com/Doom-Utils/" name
+                                "/archive/v" version ".tar.gz"))
+            (file-name (string-append name "-" version ".tar.gz"))
+            (sha256
+             (base32
+              "0rwz1yzgd539x4h25kzhar4q02xyxjwfrcpz4m8ixi312a82p7cn"))))
+   (build-system gnu-build-system)
+   (arguments
+    '(#:tests? #f ; no check target
+      #:phases
+      (modify-phases %standard-phases
+        ;; The provided configure script takes a restricted number of arguments.
+        (replace 'configure
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (zero? (system* "./configure" "--prefix"
+                                   (assoc-ref %outputs "out")))))
+        ;; "make install" is broken for this package.
+        (replace 'install
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (let* ((out (assoc-ref %outputs "out"))
+                          (bin (string-append out "/bin"))
+                          (share (string-append out "/share")))
+                     (mkdir-p bin)
+                     (install-file "deusf" bin)
+                     (install-file "deutex" bin)
+                     (install-file "deutex.6" (string-append share "/man/man6")))
+                   #t)))))
+   (home-page "https://github.com/Doom-Utils/deutex")
+   (synopsis "WAD file composer for Doom and related games")
+   (description
+    "DeuTex is a wad composer for Doom, Heretic, Hexen and Strife. It can be
+used to extract the lumps of a wad and save them as individual files.
+Conversely, it can also build a wad from separate files.  When extracting a
+lump to a file, it does not just copy the raw data, it converts it to an
+appropriate format (such as PPM for graphics, Sun audio for samples, etc.).
+Conversely, when it reads files for inclusion in pwads, it does the necessary
+conversions (for example, from PPM to Doom picture format).  In addition,
+DeuTex has functions such as merging wads, etc.")
+   (license license:gpl2+)))
+
 (define-public gzochi
   (package
     (name "gzochi")
-- 
2.12.0