GNU bug report logs - #26155
Test brief-vs-stat-zero-kernel-lies fails if /proc/cmdline exists but is not readable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26155 in the body.
You can then email your comments to 26155 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: julama <at> fake-box.com
To: submit <at> debbugs.gnu.org
Subject: Test brief-vs-stat-zero-kernel-lies fails if /proc/cmdline exists but
 is not readable
Date: Sat, 18 Mar 2017 15:56:29 +0100

[Message part 1 (text/plain, inline)]

Package: diffutilsVersion: 3.5HiThe test tests/brief-vs-stat-zero-kernel-lies fails with    cat: /proc/cmdline: Permission deniedif /proc/cmdline exists but is not readable. This is for example the case on a Linux kernel with grsecurity patchset and option GRKERNSEC_PROC_USER enabled.The fix is easy. The script tests/brief-vs-stat-zero-kernel-lies checks in line 13 only for exists (test -f) of $boot (= /proc/cmdline):    test -f $boot || skip_ no $boot filemaking it check for readability (test -r) solves the problem (as the test is now correctly skipped):    test -r $boot || skip_ file $boot not readableKind regardsjulama

[Message part 2 (text/html, inline)]

Message #10 received at 26155 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 26155 <at> debbugs.gnu.org
Cc: julama <at> fake-box.com
Subject: Re: bug#26155: Test brief-vs-stat-zero-kernel-lies fails if
 /proc/cmdline exists but is not readable
Date: Sun, 19 Mar 2017 19:01:36 -0400

This bug ended up in the wrong package due to missing line breaks.
I've reassigned it to diffutils.

julama <at> fake-box.com wrote:

> Package: diffutilsVersion: 3.5HiThe test
> tests/brief-vs-stat-zero-kernel-lies fails with&nbsp;&nbsp;&nbsp; cat:
> /proc/cmdline: Permission deniedif /proc/cmdline exists but is not
> readable. This is for example the case on a Linux kernel with
> grsecurity patchset and option GRKERNSEC_PROC_USER enabled.The fix is
> easy. The script tests/brief-vs-stat-zero-kernel-lies checks in line
> 13 only for exists (test -f) of $boot (=
> /proc/cmdline):&nbsp;&nbsp;&nbsp; test -f $boot || skip_ no $boot
> filemaking it check for readability (test -r) solves the problem (as
> the test is now correctly skipped):&nbsp;&nbsp;&nbsp; test -r $boot ||
> skip_ file $boot not readableKind regardsjulama

Message #13 received at 26155 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: julama <at> fake-box.com
Cc: 26155 <at> debbugs.gnu.org
Subject: Re: bug#26155: Test brief-vs-stat-zero-kernel-lies fails if
 /proc/cmdline exists but is not readable
Date: Wed, 22 Mar 2017 21:43:16 -0700

[Message part 1 (text/plain, inline)]

On Sat, Mar 18, 2017 at 7:56 AM,  <julama <at> fake-box.com> wrote:
> Package: diffutils
> Version: 3.5
>
> The test tests/brief-vs-stat-zero-kernel-lies fails with
>
>     cat: /proc/cmdline: Permission denied
>
> if /proc/cmdline exists but is not readable. This is for example the case on
> a Linux kernel with grsecurity patchset and option GRKERNSEC_PROC_USER
> enabled.
>
> The fix is easy. The script tests/brief-vs-stat-zero-kernel-lies checks in
> line 13 only for exists (test -f) of $boot (= /proc/cmdline):
>
>     test -f $boot || skip_ no $boot file
>
> making it check for readability (test -r) solves the problem (as the test is
> now correctly skipped):
>
>     test -r $boot || skip_ file $boot not readable

Thank you for the report and fix.

I propose to push this commit in your name. Since all I have for your
"real name" is "julama", that's what I've used in the commit "author:"
header. If you'd prefer something else, or a different email address,
let me know.

[diff-vs-unreadable-proc-cmdline.diff (text/plain, attachment)]

Message #16 received at 26155 <at> debbugs.gnu.org (full text, mbox):

From: julama <at> fake-box.com
To: 26155 <at> debbugs.gnu.org
Subject: Re: bug#26155: Test brief-vs-stat-zero-kernel-lies fails if
 /proc/cmdline exists but is not readable
Date: Fri, 24 Mar 2017 19:58:37 +0100

[Message part 1 (text/plain, inline)]

That's fine with me. Also thanks to you for your quick response and effort. Keep up the good work! Best, julama.

[Message part 2 (text/html, inline)]

Message #21 received at 26155-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: julama <at> fake-box.com
Cc: 26155-done <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#26155: Test brief-vs-stat-zero-kernel-lies
 fails if /proc/cmdline exists but is not readable
Date: Fri, 24 Mar 2017 12:45:03 -0700

On Fri, Mar 24, 2017 at 11:58 AM,  <julama <at> fake-box.com> wrote:
> That's fine with me. Also thanks to you for your quick response and effort.
> Keep up the good work! Best, julama.

Pushed as http://git.sv.gnu.org/cgit/diffutils.git/commit/?id=7c636563c2498

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.