Subject: Re: bug#26154: [PATCH 3/3] gnu: Add megaglest.

From: Leo Famulari <[email-masked]>
Date: Sun, 19 Mar 2017 19:25:50 -0400

On Sat, Mar 18, 2017 at 09:37:39PM +0530, Arun Isaac wrote:
> * gnu/packages/games.scm (megaglest): New variable.

> +       (uri (string-append
> +             "https://github.com/MegaGlest/megaglest-source/releases/download/3.13.0/megaglest-source-"

This line is way toooooo long :)

> +    (inputs
> +     `(("curl" ,curl)
> +       ("freetype" ,freetype)
> +       ("ftgl" ,ftgl)
> +       ("glew" ,glew)
> +       ("libjpeg-turbo" ,libjpeg-turbo)
> +       ("megaglest-data" ,megaglest-data)
> +       ("mesa" ,mesa)
> +       ("miniupnpc" ,miniupnpc)
> +       ("openal" ,openal)
> +       ("libircclient" ,libircclient)
> +       ("libpng" ,libpng)
> +       ("libvorbis" ,libvorbis)
> +       ("libxml2" ,libxml2)
> +       ("lua" ,lua)
> +       ("sdl2" ,sdl2)
> +       ("wxwidgets" ,wxwidgets)))

Please double-check that the build package keeps references to all these
inputs with $(guix gc --reference $(./pre-inst-env guix build
megaglest)).

> +    (synopsis "3D real-time strategy (RTS) game")
> +    (description "MegaGlest is an entertaining free and open source
> +cross-platform 3D real-time strategy (RTS) game, where you control the
> +armies of one of seven different factions: Tech, Magic, Egypt,
> +Indians, Norsemen, Persian or Romans.")

We can leave out the phrase "entertaining free and open source". Games
are expected to be entertaining, and all Guix packages are free
software, so we don't mention it.

Overall LGTM pending the change to the data file source tarball and the
reference check for megaglest.