GNU bug report logs - #26140
Tests for obnam

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26140 in the body.
You can then email your comments to 26140 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Subject: Tests for obnam
Date: Fri, 17 Mar 2017 19:19:13 +0530

[Message part 1 (text/plain, inline)]

I've almost finished packaging tests for obnam in backup.scm. I'll send
patches in a few hours.

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 1/7] gnu: Add python-astroid.
Date: Sat, 18 Mar 2017 02:44:24 +0530

* gnu/packages/python.scm (python-astroid, python2-astroid): New variables.
---
 gnu/packages/python.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 9b9c5ff99..98328c97b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13680,3 +13680,45 @@ users' sessions over extended periods of time.")
 
 (define-public python2-flask-login
   (package-with-python2 python-flask-login))
+
+(define-public python-astroid
+  (package
+    (name "python-astroid")
+    (version "1.4.9")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/PyCQA/astroid/archive/astroid-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0j0wgy54d13a470vm4b9rdjk99n1hmdxpf34x9k3pbmi9w9b566z"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-lazy-object-proxy" ,python-lazy-object-proxy)
+       ("python-six" ,python-six)
+       ("python-wrapt" ,python-wrapt)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+                  (lambda _
+                    (zero? (system* "python" "-m" "unittest" "discover"
+                                    "-p" "unittest*.py")))))))
+    (home-page "https://github.com/PyCQA/astroid")
+    (synopsis "Common base representation of python source code for pylint and
+other projects")
+    (description "@code{python-astroid} provides a common base representation
+of python source code for projects such as pychecker, pyreverse, pylint, etc.
+
+It provides a compatible representation which comes from the _ast module.  It
+rebuilds the tree generated by the builtin _ast module by recursively walking
+down the AST and building an extended ast.  The new node classes have
+additional methods and attributes for different usages.  They include some
+support for static inference and local name scopes.  Furthermore, astroid
+builds partial trees by inspecting living objects.")
+   (license license:lgpl2.1)))
+
+(define-public python2-astroid
+  (package-with-python2 python-astroid))
-- 
2.11.0

Message #11 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 2/7] gnu: Add python-isort.
Date: Sat, 18 Mar 2017 02:44:25 +0530

* gnu/packages/python.scm (python-isort, python2-isort): New variables.
---
 gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 98328c97b..597b4ecba 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13722,3 +13722,33 @@ builds partial trees by inspecting living objects.")
 
 (define-public python2-astroid
   (package-with-python2 python-astroid))
+
+(define-public python-isort
+  (package
+    (name "python-isort")
+    (version "4.2.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/timothycrosley/isort/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0zsrgkb0krn5476yncy5dd56k7dk34zqb4bnlvwy44ixgilyjmfh"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-mock" ,python-mock)
+       ("python-pytest" ,python-pytest)))
+    (home-page "https://github.com/timothycrosley/isort")
+    (synopsis "Python utility/library to sort python imports")
+    (description "@code{python-isort} is a python utility/library to sort
+imports alphabetically, and automatically separated into sections.  It
+provides a command line utility, a python library and plugins for various
+editors.  It currently cleanly supports Python 2.6 - 3.5 using pies to achieve
+this without ugly hacks and/or py2to3.")
+    (license license:expat)))
+
+(define-public python2-isort
+  (package-with-python2 python-isort))
-- 
2.11.0

Message #14 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 3/7] gnu: Add python2-backports-functools-lru-cache.
Date: Sat, 18 Mar 2017 02:44:26 +0530

* gnu/packages/python.scm (python2-backports-functools-lru-cache): New variable.
---
 gnu/packages/python.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 597b4ecba..22a80e883 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13752,3 +13752,26 @@ this without ugly hacks and/or py2to3.")
 
 (define-public python2-isort
   (package-with-python2 python-isort))
+
+(define-public python2-backports-functools-lru-cache
+  (package
+    (name "python2-backports-functools-lru-cache")
+    (version "1.3")
+    (source
+     (origin
+       (method url-fetch)
+       ;; only the pypi tarballs contain the necessary metadata
+       (uri (pypi-uri "backports.functools_lru_cache" version))
+       (sha256
+        (base32
+         "158ysf2hb0q4p4695abfiym9x1ywg0dgh8a3apd7gqaaxjy22jj4"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python2-setuptools-scm" ,python2-setuptools-scm)))
+    (arguments
+     `(#:python ,python-2))
+    (home-page "https://github.com/jaraco/backports.functools_lru_cache")
+    (synopsis "Backport of functools.lru_cache from Python 3.3")
+    (description "@code{python2-backports-functools-lru-cache} is a backport
+of functools.lru_cache from python 3.3.")
+    (license license:expat)))
-- 
2.11.0

Message #17 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 4/7] gnu: Add python-configparser.
Date: Sat, 18 Mar 2017 02:44:27 +0530

* gnu/packages/python.scm (python-configparser, python2-configparser): New variables.
---
 gnu/packages/python.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 22a80e883..f7bdae75c 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13775,3 +13775,27 @@ this without ugly hacks and/or py2to3.")
     (description "@code{python2-backports-functools-lru-cache} is a backport
 of functools.lru_cache from python 3.3.")
     (license license:expat)))
+
+(define-public python-configparser
+  (package
+    (name "python-configparser")
+    (version "3.5.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://bitbucket.org/ambv/configparser/get/"
+             version ".tar.bz2"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0waq40as14abwzbb321hfz4vr1fi363nscy32ga14qvfygrg96wa"))))
+    (build-system python-build-system)
+    (home-page "http://docs.python.org/py3k/library/configparser.html")
+    (synopsis "Backport of configparser from python 3.5")
+    (description "@code{python-configparser} is a backport of configparser
+from python 3.5 so that it can be used directly in python 2.6 - 3.5.")
+    (license license:expat)))
+
+(define-public python2-configparser
+  (package-with-python2 python-configparser))
-- 
2.11.0

Message #20 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 5/7] gnu: Add python2-coverage-test-runner.
Date: Sat, 18 Mar 2017 02:44:28 +0530

* gnu/packages/python.scm (python2-coverage-test-runner): New variable.
---
 gnu/packages/python.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index f7bdae75c..065327db6 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13799,3 +13799,28 @@ from python 3.5 so that it can be used directly in python 2.6 - 3.5.")
 
 (define-public python2-configparser
   (package-with-python2 python-configparser))
+
+(define-public python2-coverage-test-runner
+  (package
+    (name "python2-coverage-test-runner")
+    (version "1.11")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://git.liw.fi/cgi-bin/cgit/cgit.cgi/coverage-test-runner/snapshot/coverage-test-runner-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0y1m7z3dl63kmhcmydl1mwg0hacnf6ghrx9dah17j9iasssfa3g7"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2))
+    (propagated-inputs
+     `(("python2-coverage" ,python2-coverage)))
+    (home-page "https://liw.fi/coverage-test-runner/")
+    (synopsis "Python module for running unit tests")
+    (description "CoverageTestRunner is a python module for running unit tests
+and failing them if the unit test module does not excercise all statements in
+the module it tests.")
+    (license license:gpl3+)))
-- 
2.11.0

Message #23 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 6/7] gnu: Add python-pylint.
Date: Sat, 18 Mar 2017 02:44:29 +0530

* gnu/packages/python.scm (python-pylint, python2-pylint): New variables.
---
 gnu/packages/python.scm | 59 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 065327db6..9bb7754d5 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13824,3 +13824,62 @@ from python 3.5 so that it can be used directly in python 2.6 - 3.5.")
 and failing them if the unit test module does not excercise all statements in
 the module it tests.")
     (license license:gpl3+)))
+
+(define-public python-pylint
+  (package
+    (name "python-pylint")
+    (version "1.6.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/PyCQA/pylint/archive/pylint-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "08pmgflmq2zrzrn9nkfadzwa5vybz46wvwxhrsd2mjlcgsh4rzbm"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-tox" ,python-tox)))
+    (propagated-inputs
+     `(("python-astroid" ,python-astroid)
+       ("python-isort" ,python-isort)
+       ("python-mccabe" ,python-mccabe)
+       ("python-six" ,python-six)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+                  (lambda _
+                    ;; Somehow, tests for python2-pylint
+                    ;; fail if run from the build directory
+                    (let ((work "/tmp/work"))
+                      (mkdir-p work)
+                      (setenv "PYTHONPATH"
+                              (string-append (getenv "PYTHONPATH") ":" work))
+                      (copy-recursively "." work)
+                      (with-directory-excursion "/tmp"
+                        (zero? (system* "python" "-m" "unittest" "discover"
+                                        "-s" (string-append work "/pylint/test")
+                                        "-p" "*test_*.py")))))))))
+    (home-page "https://github.com/PyCQA/pylint")
+    (synopsis "Python source code analyzer which looks for coding standard
+errors")
+    (description "Pylint is a Python source code analyzer which looks
+for programming errors, helps enforcing a coding standard and sniffs
+for some code smells (as defined in Martin Fowler's Refactoring book).
+
+Pylint has many rules enabled by default, way too much to silence them
+all on a minimally sized program.  It's highly configurable and handle
+pragmas to control it from within your code.  Additionally, it is
+possible to write plugins to add your own checks.")
+    (license license:gpl2)))
+
+(define-public python2-pylint
+  (let ((pylint (package-with-python2 python-pylint)))
+    (package (inherit pylint)
+             (propagated-inputs
+              `(("python2-backports-functools-lru-cache"
+                 ,python2-backports-functools-lru-cache)
+                ("python2-configparser" ,python2-configparser)
+                ,@(package-propagated-inputs pylint))))))
-- 
2.11.0

Message #26 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 7/7] gnu: obnam: Enable tests.
Date: Sat, 18 Mar 2017 02:44:30 +0530

* gnu/packages/backup.scm (obnam)[arguments]: Replace 'check' phase with
  custom function.
---
 gnu/packages/backup.scm | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index 97ab70e65..7e9ae18f3 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -644,7 +644,23 @@ NTFS volumes using @code{ntfs-3g}, preserving NTFS-specific attributes.")
          "0qlipsq50hca71zc0dp1mg9zs12qm0sbblw7qfzl0hj6mk2rv1by"))))
     (build-system python-build-system)
     (arguments
-     `(#:python ,python-2))
+     `(#:python ,python-2
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'check
+                  (lambda _
+                    (substitute* "obnamlib/vfs_local_tests.py"
+                      ;; Check for the nobody user instead of root
+                      (("self.fs.get_username\\(0\\), 'root'")
+                       "self.fs.get_username(65534), 'nobody'")
+                      ;; Disable tests checking for root group
+                      (("self.fs.get_groupname\\(0\\)") "'root'"))
+                    (substitute* "obnamlib/vfs_local.py"
+                      ;; Don't cover get_groupname function
+                      (("def get_groupname\\(self, gid\\):")
+                       "def get_groupname(self, gid):  # pragma: no cover"))
+                    ;; Can't run network tests
+                    (zero? (system* "./check" "--unit-tests")))))))
     (inputs
      `(("python2-cliapp" ,python2-cliapp)
        ("python2-larch" ,python2-larch)
@@ -652,6 +668,12 @@ NTFS volumes using @code{ntfs-3g}, preserving NTFS-specific attributes.")
        ("python2-pyaml" ,python2-pyaml)
        ("python2-tracing" ,python2-tracing)
        ("python2-ttystatus" ,python2-ttystatus)))
+    (native-inputs
+     `(("gnupg" ,gnupg)
+       ("python2-coverage" ,python2-coverage)
+       ("python2-coverage-test-runner" ,python2-coverage-test-runner)
+       ("python2-pep8" ,python2-pep8)
+       ("python2-pylint" ,python2-pylint)))
     (home-page "https://obnam.org/")
     (synopsis "Easy and secure backup program")
     (description "Obnam is an easy, secure backup program.  Features
-- 
2.11.0

Message #29 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Subject: Re: [PATCH 7/7] gnu: obnam: Enable tests.
Date: Sat, 18 Mar 2017 02:56:54 +0530

[Message part 1 (text/plain, inline)]

> +         (replace 'check
> +                  (lambda _
> +                    (substitute* "obnamlib/vfs_local_tests.py"
> +                      ;; Check for the nobody user instead of root
> +                      (("self.fs.get_username\\(0\\), 'root'")
> +                       "self.fs.get_username(65534), 'nobody'")
> +                      ;; Disable tests checking for root group
> +                      (("self.fs.get_groupname\\(0\\)") "'root'"))
> +                    (substitute* "obnamlib/vfs_local.py"
> +                      ;; Don't cover get_groupname function
> +                      (("def get_groupname\\(self, gid\\):")
> +                       "def get_groupname(self, gid):  # pragma: no cover"))

In the build environment, is there a "nogroup" group or some other
standard group just like there is a "nobody" user? If such a group
exists, I could check for that group instead of disabling the group
checking tests altogether.

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Subject: Long URLs
Date: Sat, 18 Mar 2017 02:57:28 +0530

[Message part 1 (text/plain, inline)]

The URLs for some packages are very long. `guix lint' complains that
those lines are "way too long". How could I rewrite those lines?

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 26140 <at> debbugs.gnu.org
Subject: Re: bug#26140: [PATCH 7/7] gnu: obnam: Enable tests.
Date: Fri, 17 Mar 2017 23:56:09 +0100

Hi Arun,

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

>> +         (replace 'check
>> +                  (lambda _
>> +                    (substitute* "obnamlib/vfs_local_tests.py"
>> +                      ;; Check for the nobody user instead of root
>> +                      (("self.fs.get_username\\(0\\), 'root'")
>> +                       "self.fs.get_username(65534), 'nobody'")
>> +                      ;; Disable tests checking for root group
>> +                      (("self.fs.get_groupname\\(0\\)") "'root'"))
>> +                    (substitute* "obnamlib/vfs_local.py"
>> +                      ;; Don't cover get_groupname function
>> +                      (("def get_groupname\\(self, gid\\):")
>> +                       "def get_groupname(self, gid):  # pragma: no cover"))
>
> In the build environment, is there a "nogroup" group or some other
> standard group just like there is a "nobody" user? If such a group
> exists, I could check for that group instead of disabling the group
> checking tests altogether.

The manual has details on the available users and groups in the build
environment (info "(guix) Build Environment Setup"):

   • ‘/etc/passwd’ with an entry for the current user and an entry for
     user ‘nobody’;

   • ‘/etc/group’ with an entry for the user’s group;

So you can rely on user “nobody”, but not on “nogroup”.

HTH!

Ludo’.

Message #38 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Subject: Re: bug#26140: [PATCH 7/7] gnu: obnam: Enable tests.
Date: Sat, 18 Mar 2017 11:24:27 +0530

[Message part 1 (text/plain, inline)]

> The manual has details on the available users and groups in the build
> environment (info "(guix) Build Environment Setup"):
>
>    • ‘/etc/passwd’ with an entry for the current user and an entry for
>      user ‘nobody’;
>
>    • ‘/etc/group’ with an entry for the user’s group;
>
> So you can rely on user “nobody”, but not on “nogroup”.

Yes, I did read the manual. But, I found this old thread (
https://lists.gnu.org/archive/html/guix-devel/2014-05/msg00103.html )
about "nogroup". So, I was wondering if it had been added.

Could we add "nogroup" to the build environment? It would certainly make
the obnam check function a little shorter and cleaner. But, other than
that, I don't know how widely useful it would be.

[signature.asc (application/pgp-signature, inline)]

Message #41 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 26140 <at> debbugs.gnu.org
Subject: Re: bug#26140: Long URLs
Date: Sat, 18 Mar 2017 12:51:56 -0400

[Message part 1 (text/plain, inline)]

On Sat, Mar 18, 2017 at 02:57:28AM +0530, Arun Isaac wrote:
> 
> The URLs for some packages are very long. `guix lint' complains that
> those lines are "way too long". How could I rewrite those lines?

You can break them up into pieces, put the pieces on different lines,
and use (string-append) to re-assemble the URL. HTH!

[signature.asc (application/pgp-signature, inline)]

Message #44 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>, 26140 <at> debbugs.gnu.org
Subject: Re: bug#26140: [PATCH 7/7] gnu: obnam: Enable tests.
Date: Sat, 18 Mar 2017 17:55:26 +0100

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> * gnu/packages/backup.scm (obnam)[arguments]: Replace 'check' phase with
>   custom function.

Hi Arun,

Thanks a lot for these! The patches LGTM overall, but will go through
them more thoroughly tomorrow unless someone beats me to it.

> ---
>  gnu/packages/backup.scm | 24 +++++++++++++++++++++++-
>  1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
> index 97ab70e65..7e9ae18f3 100644
> --- a/gnu/packages/backup.scm
> +++ b/gnu/packages/backup.scm
> @@ -644,7 +644,23 @@ NTFS volumes using @code{ntfs-3g}, preserving NTFS-specific attributes.")
>           "0qlipsq50hca71zc0dp1mg9zs12qm0sbblw7qfzl0hj6mk2rv1by"))))
>      (build-system python-build-system)
>      (arguments
> -     `(#:python ,python-2))
> +     `(#:python ,python-2
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +                  (lambda _
> +                    (substitute* "obnamlib/vfs_local_tests.py"
> +                      ;; Check for the nobody user instead of root
> +                      (("self.fs.get_username\\(0\\), 'root'")
> +                       "self.fs.get_username(65534), 'nobody'")
> +                      ;; Disable tests checking for root group
> +                      (("self.fs.get_groupname\\(0\\)") "'root'"))
> +                    (substitute* "obnamlib/vfs_local.py"
> +                      ;; Don't cover get_groupname function
> +                      (("def get_groupname\\(self, gid\\):")
> +                       "def get_groupname(self, gid):  # pragma: no cover"))
> +                    ;; Can't run network tests
> +                    (zero? (system* "./check" "--unit-tests")))))))
>      (inputs
>       `(("python2-cliapp" ,python2-cliapp)
>         ("python2-larch" ,python2-larch)
> @@ -652,6 +668,12 @@ NTFS volumes using @code{ntfs-3g}, preserving NTFS-specific attributes.")
>         ("python2-pyaml" ,python2-pyaml)
>         ("python2-tracing" ,python2-tracing)
>         ("python2-ttystatus" ,python2-ttystatus)))
> +    (native-inputs
> +     `(("gnupg" ,gnupg)
> +       ("python2-coverage" ,python2-coverage)
> +       ("python2-coverage-test-runner" ,python2-coverage-test-runner)
> +       ("python2-pep8" ,python2-pep8)
> +       ("python2-pylint" ,python2-pylint)))
>      (home-page "https://obnam.org/")
>      (synopsis "Easy and secure backup program")
>      (description "Obnam is an easy, secure backup program.  Features
> -- 
> 2.11.0

[signature.asc (application/pgp-signature, inline)]

Message #47 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Subject: Re: bug#26140: Long URLs
Date: Sun, 19 Mar 2017 00:12:55 +0530

[Message part 1 (text/plain, inline)]

>> The URLs for some packages are very long. `guix lint' complains that
>> those lines are "way too long". How could I rewrite those lines?
>
> You can break them up into pieces, put the pieces on different lines,
> and use (string-append) to re-assemble the URL. HTH!

Ok, I'll do this and send another updated patchset. Thanks!

[signature.asc (application/pgp-signature, inline)]

Message #50 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 1/7] gnu: Add python-astroid.
Date: Sun, 19 Mar 2017 00:22:50 +0530

* gnu/packages/python.scm (python-astroid, python2-astroid): New variables.
---
 gnu/packages/python.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 9b9c5ff99..98328c97b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13680,3 +13680,45 @@ users' sessions over extended periods of time.")
 
 (define-public python2-flask-login
   (package-with-python2 python-flask-login))
+
+(define-public python-astroid
+  (package
+    (name "python-astroid")
+    (version "1.4.9")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/PyCQA/astroid/archive/astroid-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0j0wgy54d13a470vm4b9rdjk99n1hmdxpf34x9k3pbmi9w9b566z"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-lazy-object-proxy" ,python-lazy-object-proxy)
+       ("python-six" ,python-six)
+       ("python-wrapt" ,python-wrapt)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+                  (lambda _
+                    (zero? (system* "python" "-m" "unittest" "discover"
+                                    "-p" "unittest*.py")))))))
+    (home-page "https://github.com/PyCQA/astroid")
+    (synopsis "Common base representation of python source code for pylint and
+other projects")
+    (description "@code{python-astroid} provides a common base representation
+of python source code for projects such as pychecker, pyreverse, pylint, etc.
+
+It provides a compatible representation which comes from the _ast module.  It
+rebuilds the tree generated by the builtin _ast module by recursively walking
+down the AST and building an extended ast.  The new node classes have
+additional methods and attributes for different usages.  They include some
+support for static inference and local name scopes.  Furthermore, astroid
+builds partial trees by inspecting living objects.")
+   (license license:lgpl2.1)))
+
+(define-public python2-astroid
+  (package-with-python2 python-astroid))
-- 
2.11.0

Message #53 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 2/7] gnu: Add python-isort.
Date: Sun, 19 Mar 2017 00:22:51 +0530

* gnu/packages/python.scm (python-isort, python2-isort): New variables.
---
 gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 98328c97b..597b4ecba 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13722,3 +13722,33 @@ builds partial trees by inspecting living objects.")
 
 (define-public python2-astroid
   (package-with-python2 python-astroid))
+
+(define-public python-isort
+  (package
+    (name "python-isort")
+    (version "4.2.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/timothycrosley/isort/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0zsrgkb0krn5476yncy5dd56k7dk34zqb4bnlvwy44ixgilyjmfh"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-mock" ,python-mock)
+       ("python-pytest" ,python-pytest)))
+    (home-page "https://github.com/timothycrosley/isort")
+    (synopsis "Python utility/library to sort python imports")
+    (description "@code{python-isort} is a python utility/library to sort
+imports alphabetically, and automatically separated into sections.  It
+provides a command line utility, a python library and plugins for various
+editors.  It currently cleanly supports Python 2.6 - 3.5 using pies to achieve
+this without ugly hacks and/or py2to3.")
+    (license license:expat)))
+
+(define-public python2-isort
+  (package-with-python2 python-isort))
-- 
2.11.0

Message #56 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 3/7] gnu: Add python2-backports-functools-lru-cache.
Date: Sun, 19 Mar 2017 00:22:52 +0530

* gnu/packages/python.scm (python2-backports-functools-lru-cache): New variable.
---
 gnu/packages/python.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 597b4ecba..22a80e883 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13752,3 +13752,26 @@ this without ugly hacks and/or py2to3.")
 
 (define-public python2-isort
   (package-with-python2 python-isort))
+
+(define-public python2-backports-functools-lru-cache
+  (package
+    (name "python2-backports-functools-lru-cache")
+    (version "1.3")
+    (source
+     (origin
+       (method url-fetch)
+       ;; only the pypi tarballs contain the necessary metadata
+       (uri (pypi-uri "backports.functools_lru_cache" version))
+       (sha256
+        (base32
+         "158ysf2hb0q4p4695abfiym9x1ywg0dgh8a3apd7gqaaxjy22jj4"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python2-setuptools-scm" ,python2-setuptools-scm)))
+    (arguments
+     `(#:python ,python-2))
+    (home-page "https://github.com/jaraco/backports.functools_lru_cache")
+    (synopsis "Backport of functools.lru_cache from Python 3.3")
+    (description "@code{python2-backports-functools-lru-cache} is a backport
+of functools.lru_cache from python 3.3.")
+    (license license:expat)))
-- 
2.11.0

Message #59 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 4/7] gnu: Add python-configparser.
Date: Sun, 19 Mar 2017 00:22:53 +0530

* gnu/packages/python.scm (python-configparser, python2-configparser): New variables.
---
 gnu/packages/python.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 22a80e883..f7bdae75c 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13775,3 +13775,27 @@ this without ugly hacks and/or py2to3.")
     (description "@code{python2-backports-functools-lru-cache} is a backport
 of functools.lru_cache from python 3.3.")
     (license license:expat)))
+
+(define-public python-configparser
+  (package
+    (name "python-configparser")
+    (version "3.5.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://bitbucket.org/ambv/configparser/get/"
+             version ".tar.bz2"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0waq40as14abwzbb321hfz4vr1fi363nscy32ga14qvfygrg96wa"))))
+    (build-system python-build-system)
+    (home-page "http://docs.python.org/py3k/library/configparser.html")
+    (synopsis "Backport of configparser from python 3.5")
+    (description "@code{python-configparser} is a backport of configparser
+from python 3.5 so that it can be used directly in python 2.6 - 3.5.")
+    (license license:expat)))
+
+(define-public python2-configparser
+  (package-with-python2 python-configparser))
-- 
2.11.0

Message #62 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 5/7] gnu: Add python2-coverage-test-runner.
Date: Sun, 19 Mar 2017 00:22:54 +0530

* gnu/packages/python.scm (python2-coverage-test-runner): New variable.
---
 gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index f7bdae75c..667edc14b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13799,3 +13799,29 @@ from python 3.5 so that it can be used directly in python 2.6 - 3.5.")
 
 (define-public python2-configparser
   (package-with-python2 python-configparser))
+
+(define-public python2-coverage-test-runner
+  (package
+    (name "python2-coverage-test-runner")
+    (version "1.11")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://git.liw.fi/cgi-bin/cgit/cgit.cgi/"
+             "coverage-test-runner/snapshot/coverage-test-runner-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0y1m7z3dl63kmhcmydl1mwg0hacnf6ghrx9dah17j9iasssfa3g7"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2))
+    (propagated-inputs
+     `(("python2-coverage" ,python2-coverage)))
+    (home-page "https://liw.fi/coverage-test-runner/")
+    (synopsis "Python module for running unit tests")
+    (description "CoverageTestRunner is a python module for running unit tests
+and failing them if the unit test module does not excercise all statements in
+the module it tests.")
+    (license license:gpl3+)))
-- 
2.11.0

Message #65 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 6/7] gnu: Add python-pylint.
Date: Sun, 19 Mar 2017 00:22:55 +0530

* gnu/packages/python.scm (python-pylint, python2-pylint): New variables.
---
 gnu/packages/python.scm | 59 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 667edc14b..5cba0b6ae 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13825,3 +13825,62 @@ from python 3.5 so that it can be used directly in python 2.6 - 3.5.")
 and failing them if the unit test module does not excercise all statements in
 the module it tests.")
     (license license:gpl3+)))
+
+(define-public python-pylint
+  (package
+    (name "python-pylint")
+    (version "1.6.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/PyCQA/pylint/archive/pylint-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "08pmgflmq2zrzrn9nkfadzwa5vybz46wvwxhrsd2mjlcgsh4rzbm"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-tox" ,python-tox)))
+    (propagated-inputs
+     `(("python-astroid" ,python-astroid)
+       ("python-isort" ,python-isort)
+       ("python-mccabe" ,python-mccabe)
+       ("python-six" ,python-six)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+                  (lambda _
+                    ;; Somehow, tests for python2-pylint
+                    ;; fail if run from the build directory
+                    (let ((work "/tmp/work"))
+                      (mkdir-p work)
+                      (setenv "PYTHONPATH"
+                              (string-append (getenv "PYTHONPATH") ":" work))
+                      (copy-recursively "." work)
+                      (with-directory-excursion "/tmp"
+                        (zero? (system* "python" "-m" "unittest" "discover"
+                                        "-s" (string-append work "/pylint/test")
+                                        "-p" "*test_*.py")))))))))
+    (home-page "https://github.com/PyCQA/pylint")
+    (synopsis "Python source code analyzer which looks for coding standard
+errors")
+    (description "Pylint is a Python source code analyzer which looks
+for programming errors, helps enforcing a coding standard and sniffs
+for some code smells (as defined in Martin Fowler's Refactoring book).
+
+Pylint has many rules enabled by default, way too much to silence them
+all on a minimally sized program.  It's highly configurable and handle
+pragmas to control it from within your code.  Additionally, it is
+possible to write plugins to add your own checks.")
+    (license license:gpl2)))
+
+(define-public python2-pylint
+  (let ((pylint (package-with-python2 python-pylint)))
+    (package (inherit pylint)
+             (propagated-inputs
+              `(("python2-backports-functools-lru-cache"
+                 ,python2-backports-functools-lru-cache)
+                ("python2-configparser" ,python2-configparser)
+                ,@(package-propagated-inputs pylint))))))
-- 
2.11.0

Message #68 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 7/7] gnu: obnam: Enable tests.
Date: Sun, 19 Mar 2017 00:22:56 +0530

* gnu/packages/backup.scm (obnam)[arguments]: Replace 'check' phase with
  custom function.
---
 gnu/packages/backup.scm | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index 97ab70e65..7e9ae18f3 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -644,7 +644,23 @@ NTFS volumes using @code{ntfs-3g}, preserving NTFS-specific attributes.")
          "0qlipsq50hca71zc0dp1mg9zs12qm0sbblw7qfzl0hj6mk2rv1by"))))
     (build-system python-build-system)
     (arguments
-     `(#:python ,python-2))
+     `(#:python ,python-2
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'check
+                  (lambda _
+                    (substitute* "obnamlib/vfs_local_tests.py"
+                      ;; Check for the nobody user instead of root
+                      (("self.fs.get_username\\(0\\), 'root'")
+                       "self.fs.get_username(65534), 'nobody'")
+                      ;; Disable tests checking for root group
+                      (("self.fs.get_groupname\\(0\\)") "'root'"))
+                    (substitute* "obnamlib/vfs_local.py"
+                      ;; Don't cover get_groupname function
+                      (("def get_groupname\\(self, gid\\):")
+                       "def get_groupname(self, gid):  # pragma: no cover"))
+                    ;; Can't run network tests
+                    (zero? (system* "./check" "--unit-tests")))))))
     (inputs
      `(("python2-cliapp" ,python2-cliapp)
        ("python2-larch" ,python2-larch)
@@ -652,6 +668,12 @@ NTFS volumes using @code{ntfs-3g}, preserving NTFS-specific attributes.")
        ("python2-pyaml" ,python2-pyaml)
        ("python2-tracing" ,python2-tracing)
        ("python2-ttystatus" ,python2-ttystatus)))
+    (native-inputs
+     `(("gnupg" ,gnupg)
+       ("python2-coverage" ,python2-coverage)
+       ("python2-coverage-test-runner" ,python2-coverage-test-runner)
+       ("python2-pep8" ,python2-pep8)
+       ("python2-pylint" ,python2-pylint)))
     (home-page "https://obnam.org/")
     (synopsis "Easy and secure backup program")
     (description "Obnam is an easy, secure backup program.  Features
-- 
2.11.0

Message #73 received at 26140-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>, 26140-done <at> debbugs.gnu.org
Subject: Re: bug#26140: [PATCH 7/7] gnu: obnam: Enable tests.
Date: Mon, 20 Mar 2017 00:42:27 +0100

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> * gnu/packages/backup.scm (obnam)[arguments]: Replace 'check' phase with
>   custom function.

Thanks for these! I've commited them with some minor changes:

GPL licenses changed to the "or later" variant; isort inputs were
native-inputs; adding a 'check' phase for configparser; and using
@code{} notation where applicable.

Pushed!

[signature.asc (application/pgp-signature, inline)]

Message #76 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 26140 <at> debbugs.gnu.org
Subject: Re: bug#26140: [PATCH 7/7] gnu: obnam: Enable tests.
Date: Mon, 20 Mar 2017 10:44:46 +0530

[Message part 1 (text/plain, inline)]

Marius Bakke writes:

> Arun Isaac <arunisaac <at> systemreboot.net> writes:
>
>> * gnu/packages/backup.scm (obnam)[arguments]: Replace 'check' phase with
>>   custom function.
>
> Thanks for these! I've commited them with some minor changes:
>
> GPL licenses changed to the "or later" variant; isort inputs were
> native-inputs; adding a 'check' phase for configparser; and using
> @code{} notation where applicable.

Thanks for the improvements!

You have changed the licenses of python-pylint and python-astroid to the
"or later" variant. But, I don't think they are of the "or later"
variant. Look at line 9 of
https://github.com/PyCQA/pylint/blob/master/setup.py and line 6 of
https://github.com/PyCQA/astroid/blob/master/setup.py

[signature.asc (application/pgp-signature, inline)]

Message #79 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 26140 <at> debbugs.gnu.org
Subject: Re: bug#26140: [PATCH 7/7] gnu: obnam: Enable tests.
Date: Mon, 20 Mar 2017 07:50:34 +0100

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> Marius Bakke writes:
>
>> Arun Isaac <arunisaac <at> systemreboot.net> writes:
>>
>>> * gnu/packages/backup.scm (obnam)[arguments]: Replace 'check' phase with
>>>   custom function.
>>
>> Thanks for these! I've commited them with some minor changes:
>>
>> GPL licenses changed to the "or later" variant; isort inputs were
>> native-inputs; adding a 'check' phase for configparser; and using
>> @code{} notation where applicable.
>
> Thanks for the improvements!
>
> You have changed the licenses of python-pylint and python-astroid to the
> "or later" variant. But, I don't think they are of the "or later"
> variant. Look at line 9 of
> https://github.com/PyCQA/pylint/blob/master/setup.py and line 6 of
> https://github.com/PyCQA/astroid/blob/master/setup.py

When no version is explicitly specified in the source headers, the "or
later" is assumed. See e.g.:

https://lists.gnu.org/archive/html/guix-devel/2017-02/msg00026.html

In addition, both of these packages ship a "debian/copyright" file that
uses the "or any later version" form:

https://github.com/PyCQA/pylint/blob/master/debian/copyright
https://github.com/PyCQA/astroid/blob/master/debian/copyright

So I believe the current information is correct.

[signature.asc (application/pgp-signature, inline)]

Message #82 received at 26140 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26140 <at> debbugs.gnu.org
Subject: Re: bug#26140: [PATCH 7/7] gnu: obnam: Enable tests.
Date: Mon, 20 Mar 2017 14:06:40 +0530

[Message part 1 (text/plain, inline)]

> When no version is explicitly specified in the source headers, the "or
> later" is assumed. See e.g.:
>
> https://lists.gnu.org/archive/html/guix-devel/2017-02/msg00026.html

Oh, I wasn't aware of this nuance. Very well, then.

> In addition, both of these packages ship a "debian/copyright" file that
> uses the "or any later version" form:
>
> https://github.com/PyCQA/pylint/blob/master/debian/copyright
> https://github.com/PyCQA/astroid/blob/master/debian/copyright

Yeah, this is quite clear.

Thanks.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.