GNU bug report logs - #26135
[PATCH] gnu: znc: Run test suite.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26135 in the body.
You can then email your comments to 26135 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: znc: Run test suite.
Date: Fri, 17 Mar 2017 02:09:29 +0100

* gnu/packages/messaging.scm (znc)[arguments]: Enable tests.  Add an
‘unpack-googletest’ phase and add ‘--with-gtest=’ to #:configure-flags.
[native-inputs]: Add googletest source.
---
 gnu/packages/messaging.scm | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 7aa7b7b..57a62e5 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -398,12 +398,23 @@ compromised.")
                 "1jia6kq6bp8yxfj02d5vj9vqb4pylqcldspyjj6iz82kkka2a0ig"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:tests? #f ; tries to download GoogleTest with wget
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'unpack-googletest
+           (lambda* (#:key inputs #:allow-other-keys)
+             (zero? (system* "tar" "xf"
+                             (assoc-ref inputs "googletest-source"))))))
+       #:test-target "test"
        #:configure-flags '("--enable-python"
                            "--enable-perl"
-                           "--enable-cyrus")))
+                           "--enable-cyrus"
+                           ,(string-append "--with-gtest="
+                                          "googletest-release-"
+                                          (package-version googletest)
+                                          "/googletest"))))
     (native-inputs
-     `(("pkg-config" ,pkg-config)
+     `(("googletest-source" ,(package-source googletest))
+       ("pkg-config" ,pkg-config)
        ("perl" ,perl)
        ("python" ,python)))
     (inputs
-- 
2.9.3

Message #8 received at 26135 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 26135 <at> debbugs.gnu.org
Subject: Re: bug#26135: [PATCH] gnu: znc: Run test suite.
Date: Fri, 17 Mar 2017 02:12:19 +0100

[Message part 1 (text/plain, inline)]

On 17/03/17 02:09, Tobias Geerinckx-Rice wrote:
> +       #:test-target "test"
>         #:configure-flags '("--enable-python"
>                             "--enable-perl"
> -                           "--enable-cyrus")))
> +                           "--enable-cyrus"
> +                           ,(string-append "--with-gtest="
> +                                          "googletest-release-"
> +                                          (package-version googletest)
> +                                          "/googletest"))))

Swap these two.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, attachment)]

Message #11 received at 26135 <at> debbugs.gnu.org (full text, mbox):

From: John Darrington <john <at> darrington.wattle.id.au>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 26135 <at> debbugs.gnu.org
Subject: Re: bug#26135: [PATCH] gnu: znc: Run test suite.
Date: Fri, 17 Mar 2017 06:57:44 +0100

[Message part 1 (text/plain, inline)]

On Fri, Mar 17, 2017 at 02:12:19AM +0100, Tobias Geerinckx-Rice wrote:
     On 17/03/17 02:09, Tobias Geerinckx-Rice wrote:
     > +       #:test-target "test"
     >         #:configure-flags '("--enable-python"
     >                             "--enable-perl"
     > -                           "--enable-cyrus")))
     > +                           "--enable-cyrus"
     > +                           ,(string-append "--with-gtest="
     > +                                          "googletest-release-"
     > +                                          (package-version googletest)
     > +                                          "/googletest"))))
     
     Swap these two.
     

How much does googletest add to the closure size of the package?

J'
     




-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 26135 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: john <at> darrington.wattle.id.au
Cc: 26135 <at> debbugs.gnu.org
Subject: Re: bug#26135: [PATCH] gnu: znc: Run test suite.
Date: Mon, 20 Mar 2017 15:17:50 +0100

[Message part 1 (text/plain, inline)]

John,

On 17/03/17 06:57, John Darrington wrote:
> How much does googletest add to the closure size of the package?

Nothing, I should think, since it's a build-time dependency. ;-)

Kind regards,

T G-R

[signature.asc (application/pgp-signature, attachment)]

Message #19 received at 26135-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 26135-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: znc: Run test suite.
Date: Mon, 20 Mar 2017 22:46:43 +0100

[Message part 1 (text/plain, inline)]

Pushed as 500fc65b5bd28a8f222d2dbff7676ba3ee622f12.

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.