GNU bug report logs - #26113
[PATCH 4/7] gnu: Add maxflow.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26113 in the body.
You can then email your comments to 26113 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Darrington <jmd <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: John Darrington <jmd <at> gnu.org>
Subject: [PATCH 4/7] gnu: Add maxflow.
Date: Wed, 15 Mar 2017 21:05:21 +0100

* gnu/packages/maths.scm (maxflow): New variable.
---
 gnu/packages/maths.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 8e7580c..12a3207 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -1111,6 +1111,30 @@ modules is done either interactively using the graphical user interface or in
 ASCII text files using Gmsh's own scripting language.")
     (license license:gpl2+)))
 
+(define-public maxflow
+  (package
+    (name "maxflow")
+    (version "3.04")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/gerddie/maxflow.git")
+                    (commit "42401fa54823d16b9da47716f04e5d9ef1605875")))
+              (file-name (string-append name "-" version "-checkout"))
+              (sha256
+               (base32
+                "0rll38whw55h0vcjrrwdnh9ascvxby0ph7n1l0d12z17cg215kkb"))))
+    (build-system cmake-build-system)
+    (home-page "http://pub.ist.ac.at/~vnk/software.html")
+    (synopsis "Library implementing Maxflow algorithm")
+    (description "An implementation of the maxflow algorithm described in
+@cite{An Experimental Comparison of Min-Cut/Max-Flow Algorithms for
+Energy Minimization in Computer Vision.\n
+Yuri Boykov and Vladimir Kolmogorov.\n
+In IEEE Transactions on Pattern Analysis and Machine Intelligence,\n
+September 2004}")
+    (license license:gpl3+)))
+
 (define-public petsc
   (package
     (name "petsc")
-- 
2.1.4

Message #8 received at 26113 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: John Darrington <jmd <at> gnu.org>
Cc: 26113 <at> debbugs.gnu.org
Subject: Re: bug#26113: [PATCH 4/7] gnu: Add maxflow.
Date: Fri, 17 Mar 2017 17:38:53 -0400

[Message part 1 (text/plain, inline)]

John Darrington <jmd <at> gnu.org> writes:

> * gnu/packages/maths.scm (maxflow): New variable.
> ---
>  gnu/packages/maths.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index 8e7580c..12a3207 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -1111,6 +1111,30 @@ modules is done either interactively using the graphical user interface or in
>  ASCII text files using Gmsh's own scripting language.")
>      (license license:gpl2+)))
>  
> +(define-public maxflow
> +  (package
> +    (name "maxflow")
> +    (version "3.04")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/gerddie/maxflow.git")
> +                    (commit "42401fa54823d16b9da47716f04e5d9ef1605875")))
> +              (file-name (string-append name "-" version "-checkout"))
> +              (sha256
> +               (base32
> +                "0rll38whw55h0vcjrrwdnh9ascvxby0ph7n1l0d12z17cg215kkb"))))
> +    (build-system cmake-build-system)
> +    (home-page "http://pub.ist.ac.at/~vnk/software.html")
> +    (synopsis "Library implementing Maxflow algorithm")
> +    (description "An implementation of the maxflow algorithm described in
> +@cite{An Experimental Comparison of Min-Cut/Max-Flow Algorithms for
> +Energy Minimization in Computer Vision.\n
> +Yuri Boykov and Vladimir Kolmogorov.\n
> +In IEEE Transactions on Pattern Analysis and Machine Intelligence,\n
> +September 2004}")

These aren't showing up as new lines. I tried replacing the newline
characters with the appropriate Texinfo substitute, @*, but that gave me
a parsing error. We might have to dive into some source code to fix this
(but hopefully not).

> +    (license license:gpl3+)))
> +
>  (define-public petsc
>    (package
>      (name "petsc")

Otherwise LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 26113 <at> debbugs.gnu.org (full text, mbox):

From: John Darrington <john <at> darrington.wattle.id.au>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 26113 <at> debbugs.gnu.org, John Darrington <jmd <at> gnu.org>
Subject: Re: bug#26113: [PATCH 4/7] gnu: Add maxflow.
Date: Sat, 18 Mar 2017 00:39:55 +0100

[Message part 1 (text/plain, inline)]

On Fri, Mar 17, 2017 at 05:38:53PM -0400, Kei Kebreau wrote:
     > +    (description "An implementation of the maxflow algorithm described in
     > +@cite{An Experimental Comparison of Min-Cut/Max-Flow Algorithms for
     > +Energy Minimization in Computer Vision.\n
     > +Yuri Boykov and Vladimir Kolmogorov.\n
     > +In IEEE Transactions on Pattern Analysis and Machine Intelligence,\n
     > +September 2004}")
     
     These aren't showing up as new lines. I tried replacing the newline
     characters with the appropriate Texinfo substitute, @*, but that gave me
     a parsing error. We might have to dive into some source code to fix this
     (but hopefully not).


I think that would be in the Guile source and not the Guix source :(
I don't know what the answer is here.  Does anyone else have an idea?


-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 26113-done <at> debbugs.gnu.org (full text, mbox):

From: John Darrington <john <at> darrington.wattle.id.au>
To: 26113-done <at> debbugs.gnu.org
Subject: Done
Date: Sat, 18 Mar 2017 10:40:38 +0100

I pushed this.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.