From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 15 16:06:14 2017 Received: (at submit) by debbugs.gnu.org; 15 Mar 2017 20:06:14 +0000 Received: from localhost ([127.0.0.1]:57521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coFBR-00074Q-L5 for submit@debbugs.gnu.org; Wed, 15 Mar 2017 16:06:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coFBO-00072z-Om for submit@debbugs.gnu.org; Wed, 15 Mar 2017 16:06:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coFBI-0008Ns-Ae for submit@debbugs.gnu.org; Wed, 15 Mar 2017 16:06:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58216) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1coFBH-0008NI-VL for submit@debbugs.gnu.org; Wed, 15 Mar 2017 16:06:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coFBG-0003FS-Lu for guix-patches@gnu.org; Wed, 15 Mar 2017 16:05:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coFBD-0008H8-8G for guix-patches@gnu.org; Wed, 15 Mar 2017 16:05:58 -0400 Received: from de.cellform.com ([88.217.224.109]:60813 helo=jocasta.intra) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1coFBC-0007uD-QW; Wed, 15 Mar 2017 16:05:55 -0400 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.14.4/8.14.4/Debian-8+deb8u1) with ESMTP id v2FK5SZm023691 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Mar 2017 21:05:28 +0100 Received: (from john@localhost) by jocasta.intra (8.14.4/8.14.4/Submit) id v2FK5Sa6023690; Wed, 15 Mar 2017 21:05:28 +0100 From: John Darrington To: guix-patches@gnu.org Subject: [PATCH 2/7] gnu: Add niftilib. Date: Wed, 15 Mar 2017 21:05:19 +0100 Message-Id: <1489608324-23632-2-git-send-email-jmd@gnu.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1489608324-23632-1-git-send-email-jmd@gnu.org> References: <1489608324-23632-1-git-send-email-jmd@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by jocasta.intra id v2FK5SZm023691 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit Cc: John Darrington X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.9 (/) * gnu/packages/image.scm (niftilib): New variable. --- gnu/packages/image.scm | 58 ++++++++++++++++++++++++++++++++++++++++++++= +++++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm index 53ed69a..82ea89c 100644 --- a/gnu/packages/image.scm +++ b/gnu/packages/image.scm @@ -6,7 +6,7 @@ ;;; Copyright =C2=A9 2014, 2016 Ricardo Wurmus ;;; Copyright =C2=A9 2015 Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer ;;; Copyright =C2=A9 2015 Amirouche Boubekki -;;; Copyright =C2=A9 2014 John Darrington +;;; Copyright =C2=A9 2014, 2017 John Darrington ;;; Copyright =C2=A9 2016 Leo Famulari ;;; Copyright =C2=A9 2016, 2017 Leo Famulari ;;; Copyright =C2=A9 2016, 2017 Efraim Flashner @@ -1114,3 +1114,59 @@ interface. It supports color space extensions tha= t allow it to compress from and decompress to 32-bit and big-endian pixel buffers (RGBX, XBGR, etc.)= .") (license (list license:bsd-3 ; jsimd*.[ch] and most of simd/ license:ijg)))) ; the rest + +(define-public niftilib + (package + (name "niftilib") + (version "2.0.0") + (source (origin + (method url-fetch) + (uri (list (string-append "mirror://sourceforge/niftilib/" + "nifticlib/nifticlib_2_0_0/" + "/nifticlib-" version ".tar.gz"))) + (sha256 + (base32 "123z9bwzgin5y8gi5ni8j217k7n683whjsvg0lrpii9flgk8is= d3")))) + (build-system gnu-build-system) + (arguments + '(#:tests? #f + #:parallel-build? #f + #:phases + (modify-phases %standard-phases + (replace 'install + (lambda _ + (for-each + (lambda (dir) + (let ((directory (assoc-ref %outputs "out"))) + (mkdir-p (string-append directory "/" dir)) + (zero? (system* "cp" "-a" dir directory)))) + '("bin" "lib" "include")))) + (replace 'configure + (lambda _ + (substitute* "Makefile" + (("^SHELL[ \t]*=3D[ \t]*csh") + (string-append "SHELL =3D " + (assoc-ref %build-inputs "bash") + "/bin/sh")) + + (("^CFLAGS[ \t]*=3D[ \t]\\$\\(ANSI_FLAGS\\)") + "CFLAGS =3D $(ANSI_FLAGS) -fPIC") + + (("^ZLIB_INC[ \t]*=3D[ \t]*-I/usr/include") + (string-append "ZLIB_INC =3D -I" + (assoc-ref %build-inputs "zlib") + "/include")) + + (("^CP[ \t]*=3D[ \t]*cp") + (string-append "CP =3D " + (assoc-ref %build-inputs "coreutils= ") + "/bin/cp"))) + #t))))) + (inputs + `(("zlib" ,zlib))) + (synopsis "Library for reading and writing files in the nifti-1 forma= t") + (description "Niftilib is a set of i/o libraries for reading and wr= iting +files in the nifti-1 data format - a binary file format for storing +medical image data, e.g. magnetic resonance image (MRI) and functional M= RI +(fMRI) brain images.") + (home-page "http://niftilib.sourceforge.net") + (license license:public-domain))) --=20 2.1.4 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 17 16:19:00 2017 Received: (at 26112) by debbugs.gnu.org; 17 Mar 2017 20:19:00 +0000 Received: from localhost ([127.0.0.1]:32915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coyKy-0000UD-3M for submit@debbugs.gnu.org; Fri, 17 Mar 2017 16:19:00 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:37581 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coyKv-0000U3-Km for 26112@debbugs.gnu.org; Fri, 17 Mar 2017 16:18:59 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 86A9150C765; Fri, 17 Mar 2017 21:18:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489781935; bh=86tNx9AC/D0ig78HnHPEEcdHj3OP2bLL30Zsnl4uqPs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ThLklu4JVuj/jXrbb+Er868QYJCO93MEVT7HWnnEz3lP3EU8GCjm3WlBmmk8/eiSP NxrWq6qIkDDwJSx110Cob3bomHPZRhDcLmy3csHYfNh5LgY3+UVOg5hWPHo3XxcGaT UttKCw9eVS1Cy4FCGUnMsTDOAoUi67kdCQL0XWDU= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR002 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489781932; bh=86tNx9AC/D0ig78HnHPEEcdHj3OP2bLL30Zsnl4uqPs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XuMUrdfLtPhGPfKCyO34BUEbPDXVurRgO1SfQKFBli/Xe//0QUwIuHngadvF8bLxE hGeW/0EAJNlphNuOowpCx54/0yJNaY/Ol6P9f06Dbk8rrso5kd4gYi1HRy/BdkRcCg 70GCH18B2uQya8GHuUQI1jLxiqWhYK1/OkLVOQ/s= To: John Darrington Subject: Re: bug#26112: [PATCH 2/7] gnu: Add niftilib. References: <1489608324-23632-1-git-send-email-jmd@gnu.org> <1489608324-23632-2-git-send-email-jmd@gnu.org> Date: Fri, 17 Mar 2017 16:18:31 -0400 In-Reply-To: <1489608324-23632-2-git-send-email-jmd@gnu.org> (John Darrington's message of "Wed, 15 Mar 2017 21:05:19 +0100") Message-ID: <874lyr7j3c.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26112 Cc: 26112@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable John Darrington writes: > * gnu/packages/image.scm (niftilib): New variable. > --- > gnu/packages/image.scm | 58 ++++++++++++++++++++++++++++++++++++++++++++= +++++- > 1 file changed, 57 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm > index 53ed69a..82ea89c 100644 > --- a/gnu/packages/image.scm > +++ b/gnu/packages/image.scm > @@ -6,7 +6,7 @@ > ;;; Copyright =C2=A9 2014, 2016 Ricardo Wurmus > ;;; Copyright =C2=A9 2015 Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer > ;;; Copyright =C2=A9 2015 Amirouche Boubekki > -;;; Copyright =C2=A9 2014 John Darrington > +;;; Copyright =C2=A9 2014, 2017 John Darrington > ;;; Copyright =C2=A9 2016 Leo Famulari > ;;; Copyright =C2=A9 2016, 2017 Leo Famulari > ;;; Copyright =C2=A9 2016, 2017 Efraim Flashner > @@ -1114,3 +1114,59 @@ interface. It supports color space extensions tha= t allow it to compress from > and decompress to 32-bit and big-endian pixel buffers (RGBX, XBGR, etc.)= .") > (license (list license:bsd-3 ; jsimd*.[ch] and most of simd/ > license:ijg)))) ; the rest > + > +(define-public niftilib > + (package > + (name "niftilib") > + (version "2.0.0") > + (source (origin > + (method url-fetch) > + (uri (list (string-append "mirror://sourceforge/niftilib/" > + "nifticlib/nifticlib_2_0_0/" Instead of 2_0_0, you could use the trusty (string-join (string-split version #\.) "_") trick. It's less error-prone when updates come around. > + "/nifticlib-" version ".tar.gz"))) > + (sha256 > + (base32 "123z9bwzgin5y8gi5ni8j217k7n683whjsvg0lrpii9flgk8is= d3")))) > + (build-system gnu-build-system) > + (arguments > + '(#:tests? #f > + #:parallel-build? #f > + #:phases > + (modify-phases %standard-phases > + (replace 'install > + (lambda _ > + (for-each > + (lambda (dir) > + (let ((directory (assoc-ref %outputs "out"))) > + (mkdir-p (string-append directory "/" dir)) > + (zero? (system* "cp" "-a" dir directory)))) > + '("bin" "lib" "include")))) > + (replace 'configure > + (lambda _ > + (substitute* "Makefile" > + (("^SHELL[ \t]*=3D[ \t]*csh") > + (string-append "SHELL =3D " > + (assoc-ref %build-inputs "bash") > + "/bin/sh")) > + > + (("^CFLAGS[ \t]*=3D[ \t]\\$\\(ANSI_FLAGS\\)") > + "CFLAGS =3D $(ANSI_FLAGS) -fPIC") > + > + (("^ZLIB_INC[ \t]*=3D[ \t]*-I/usr/include") > + (string-append "ZLIB_INC =3D -I" > + (assoc-ref %build-inputs "zlib") > + "/include")) > + > + (("^CP[ \t]*=3D[ \t]*cp") > + (string-append "CP =3D " > + (assoc-ref %build-inputs "coreutils= ") > + "/bin/cp"))) > + #t))))) > + (inputs > + `(("zlib" ,zlib))) > + (synopsis "Library for reading and writing files in the nifti-1 forma= t") > + (description "Niftilib is a set of i/o libraries for reading and wr= iting Why is there a triple space between "description" and the double quote? Am I correct in assuming that it's accidental? > +files in the nifti-1 data format - a binary file format for storing > +medical image data, e.g. magnetic resonance image (MRI) and functional M= RI > +(fMRI) brain images.") > + (home-page "http://niftilib.sourceforge.net") > + (license license:public-domain))) Other than that, LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljMRJcACgkQ5qXuPBlG eg3PyhAAwZLVAVTXLD7zQw32F2lUGIIYLJmXKQSk2Woc3x+QTdS/ANydAUuhRGhw OtiOEioeSsUxT7e1qKkzVDUNEn7Lh0z2L4N/WRvixQ8SB2p30HSeb0RYgtQxGpuw 8AOS8RAulSZT2TmFwBfvXMjvWDSj12EoGam6paGZ3Hqx2mmqO1dgSQI+GPJBcD+K W7/Rog08pTbiV6f+HAQNc9IA5F/uKVGEPNujet8yQRzZF4dOenkvDeN2bm6AclXe 8H4onmZbdkp6jYMUfX18y3kbHq/H2tTbbDH33I8e1RFhXGJg8pvZGMgVdrR5XLmK xcruybAf+GDkCERVTK3GzvVbLCiFtKOwLP5nVTCxFAHCQOvTTeQkQtbKf9oju2VO hz4yzisaNaj3sBOlCoU/xsfChAJB4lYjFw8xQx0Uu9HEWBeQYQkwpYlSXUUwQw13 5J9Mng40Uq05LZJ4eVPnyHsRRw4NJ4hqAoicdsL3MxXu7fgGnYnEA5JIdZSvKyMb tz4D4eKyNYhc5lQsabja2F1N9mXr/ocGpnQ4uMOeZ6A5aI8K4FZmWe4WzDMxpBnV Uftr5nYLXNDxgiqGwZ9kRHN1ynsdmiqvQnswC+Yo4jIi55dCoWajOR1x7yz6ukjo Ml4SRVHgksyeUyea8RcbFhsvxuVcxZ8A9XduKji+jWUdJlVvWwA= =DrNG -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 10:35:43 2017 Received: (at 26112-done) by debbugs.gnu.org; 18 Mar 2017 14:35:44 +0000 Received: from localhost ([127.0.0.1]:34052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpFSJ-0006SC-Nj for submit@debbugs.gnu.org; Sat, 18 Mar 2017 10:35:43 -0400 Received: from de.cellform.com ([88.217.224.109]:51665 helo=jocasta.intra) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpFSH-0006S2-AR for 26112-done@debbugs.gnu.org; Sat, 18 Mar 2017 10:35:42 -0400 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.14.4/8.14.4/Debian-8+deb8u1) with ESMTP id v2IEZd8h017333 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <26112-done@debbugs.gnu.org>; Sat, 18 Mar 2017 15:35:39 +0100 Received: (from john@localhost) by jocasta.intra (8.14.4/8.14.4/Submit) id v2IEZdHY017331 for 26112-done@debbugs.gnu.org; Sat, 18 Mar 2017 15:35:39 +0100 From: John Darrington Message-Id: <201703181435.v2IEZdHY017331@jocasta.intra> Date: Sat, 18 Mar 2017 15:35:38 +0100 To: 26112-done@debbugs.gnu.org Subject: Done User-Agent: Heirloom mailx 12.5 6/20/10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26112-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) I pushed this. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 09:12:00 2017 Received: (at 26112) by debbugs.gnu.org; 19 Mar 2017 13:12:00 +0000 Received: from localhost ([127.0.0.1]:34608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpacp-00023y-TW for submit@debbugs.gnu.org; Sun, 19 Mar 2017 09:12:00 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpaco-00023q-Df for 26112@debbugs.gnu.org; Sun, 19 Mar 2017 09:11:58 -0400 Received: from localhost (x4d0c9b73.dyn.telefonica.de [77.12.155.115]) by mx.zohomail.com with SMTPS id 1489929114263389.09736237342383; Sun, 19 Mar 2017 06:11:54 -0700 (PDT) References: <1489608324-23632-1-git-send-email-jmd@gnu.org> <1489608324-23632-2-git-send-email-jmd@gnu.org> User-agent: mu4e 0.9.18; emacs 25.1.1 From: Ricardo Wurmus To: John Darrington Subject: Re: bug#26112: [PATCH 2/7] gnu: Add niftilib. In-reply-to: <1489608324-23632-2-git-send-email-jmd@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Sun, 19 Mar 2017 14:11:51 +0100 Message-ID: <8760j5wgvc.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 26112 Cc: 26112@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Hi John, thanks for the contribution. > * gnu/packages/image.scm (niftilib): New variable. I realize this has been pushed already, but here are some comments for the future. > + > +(define-public niftilib > + (package > + (name "niftilib") > + (version "2.0.0") > + (source (origin > + (method url-fetch) > + (uri (list (string-append "mirror://sourceforge/niftilib/" > + "nifticlib/nifticlib_2_0_0/" > + "/nifticlib-" version ".tar.gz"))) > + (sha256 > + (base32 "123z9bwzgin5y8gi5ni8j217k7n683whjsvg0lrpii9flgk8isd3")))) > + (build-system gnu-build-system) > + (arguments > + '(#:tests? #f > + #:parallel-build? #f Please add simple comments explaining why this is required. > + #:phases > + (modify-phases %standard-phases > + (replace 'install > + (lambda _ > + (for-each > + (lambda (dir) > + (let ((directory (assoc-ref %outputs "out"))) > + (mkdir-p (string-append directory "/" dir)) > + (zero? (system* "cp" "-a" dir directory)))) > + '("bin" "lib" "include")))) Instead of starting a shell process to copy things please use “copy-recursively” or “install-file” instead. It’s also better style to pull the let binding out of the lambda. Finally, please end the phase on “#t”. > + (replace 'configure > + (lambda _ > + (substitute* "Makefile" > + (("^SHELL[ \t]*=[ \t]*csh") > + (string-append "SHELL = " > + (assoc-ref %build-inputs "bash") > + "/bin/sh")) > + > + (("^CFLAGS[ \t]*=[ \t]\\$\\(ANSI_FLAGS\\)") > + "CFLAGS = $(ANSI_FLAGS) -fPIC") > + > + (("^ZLIB_INC[ \t]*=[ \t]*-I/usr/include") > + (string-append "ZLIB_INC = -I" > + (assoc-ref %build-inputs "zlib") > + "/include")) > + > + (("^CP[ \t]*=[ \t]*cp") > + (string-append "CP = " > + (assoc-ref %build-inputs "coreutils") > + "/bin/cp"))) > + #t))))) It is preferrable to use #:make-flags instead of patching the Makefile. When referencing inputs, please use “lambda* (#:key inputs #:allow-other-keys)” instead of “lambda _” and “%build-inputs”. It would also be good to check the indentation, which can be done with “etc/indent-code.el”. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 09:33:23 2017 Received: (at 26112) by debbugs.gnu.org; 19 Mar 2017 13:33:23 +0000 Received: from localhost ([127.0.0.1]:34615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpaxW-0002Zn-OQ for submit@debbugs.gnu.org; Sun, 19 Mar 2017 09:33:23 -0400 Received: from de.cellform.com ([88.217.224.109]:51691 helo=jocasta.intra) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpaxU-0002Zd-92 for 26112@debbugs.gnu.org; Sun, 19 Mar 2017 09:33:21 -0400 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.14.4/8.14.4/Debian-8+deb8u1) with ESMTP id v2JDXIqp004182 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 19 Mar 2017 14:33:18 +0100 Received: (from john@localhost) by jocasta.intra (8.14.4/8.14.4/Submit) id v2JDXHvO004181; Sun, 19 Mar 2017 14:33:17 +0100 Date: Sun, 19 Mar 2017 14:33:17 +0100 From: John Darrington To: Ricardo Wurmus Subject: Re: bug#26112: [PATCH 2/7] gnu: Add niftilib. Message-ID: <20170319133317.GA4118@jocasta.intra> References: <1489608324-23632-1-git-send-email-jmd@gnu.org> <1489608324-23632-2-git-send-email-jmd@gnu.org> <8760j5wgvc.fsf@elephly.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gBBFr7Ir9EOA20Yy" Content-Disposition: inline In-Reply-To: <8760j5wgvc.fsf@elephly.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26112 Cc: 26112@debbugs.gnu.org, John Darrington X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --gBBFr7Ir9EOA20Yy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thanks for the heads up. =20 I'm not sure that all your suggestions will work, but I will try what you s= uggest and push follow-up commit. Regarding indentation - I normally let emacs handle it. Shouldn't that get = everything correct? J' On Sun, Mar 19, 2017 at 02:11:51PM +0100, Ricardo Wurmus wrote: =20 Hi John, =20 thanks for the contribution. =20 > * gnu/packages/image.scm (niftilib): New variable. =20 I realize this has been pushed already, but here are some comments for the future. =20 > + > +(define-public niftilib > + (package > + (name "niftilib") > + (version "2.0.0") > + (source (origin > + (method url-fetch) > + (uri (list (string-append "mirror://sourceforge/niftili= b/" > + "nifticlib/nifticlib_2_0_0/" > + "/nifticlib-" version ".tar.g= z"))) > + (sha256 > + (base32 "123z9bwzgin5y8gi5ni8j217k7n683whjsvg0lrpii9fl= gk8isd3")))) > + (build-system gnu-build-system) > + (arguments > + '(#:tests? #f > + #:parallel-build? #f =20 Please add simple comments explaining why this is required. =20 > + #:phases > + (modify-phases %standard-phases > + (replace 'install > + (lambda _ > + (for-each > + (lambda (dir) > + (let ((directory (assoc-ref %outputs "out"))) > + (mkdir-p (string-append directory "/" dir)) > + (zero? (system* "cp" "-a" dir directory)))) > + '("bin" "lib" "include")))) =20 Instead of starting a shell process to copy things please use ???copy-recursively??? or ???install-file??? instead. It???s also bet= ter style to pull the let binding out of the lambda. =20 Finally, please end the phase on ???#t???. =20 > + (replace 'configure > + (lambda _ > + (substitute* "Makefile" > + (("^SHELL[ \t]*=3D[ \t]*csh") > + (string-append "SHELL =3D " > + (assoc-ref %build-inputs "bash= ") > + "/bin/sh")) > + > + (("^CFLAGS[ \t]*=3D[ \t]\\$\\(ANSI_FLAGS\\)") > + "CFLAGS =3D $(ANSI_FLAGS) -fPIC") > + > + (("^ZLIB_INC[ \t]*=3D[ \t]*-I/usr/include") > + (string-append "ZLIB_INC =3D -I" > + (assoc-ref %build-inputs "zlib= ") > + "/include")) > + > + (("^CP[ \t]*=3D[ \t]*cp") > + (string-append "CP =3D " > + (assoc-ref %build-inputs "core= utils") > + "/bin/cp"))) > + #t))))) =20 It is preferrable to use #:make-flags instead of patching the Makefile. When referencing inputs, please use ???lambda* (#:key inputs #:allow-other-keys)??? instead of ???lambda _??? and ???%build-inputs?= ??. =20 It would also be good to check the indentation, which can be done with ???etc/indent-code.el???. =20 -- Ricardo =20 GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --gBBFr7Ir9EOA20Yy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAljOiJ0ACgkQimdxnC3oJ7M6FwCeMLCoo/KuKoEdhwJhW1L/CZuY lmgAn12MowHxFIXOKbUJURyVdcU9JTp7 =Tefz -----END PGP SIGNATURE----- --gBBFr7Ir9EOA20Yy-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 10:03:15 2017 Received: (at 26112) by debbugs.gnu.org; 19 Mar 2017 14:03:15 +0000 Received: from localhost ([127.0.0.1]:35317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpbQR-0003TF-AI for submit@debbugs.gnu.org; Sun, 19 Mar 2017 10:03:15 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpbQP-0003T8-JX for 26112@debbugs.gnu.org; Sun, 19 Mar 2017 10:03:14 -0400 Received: from localhost (x4d0c9b73.dyn.telefonica.de [77.12.155.115]) by mx.zohomail.com with SMTPS id 1489932191296710.2109295196099; Sun, 19 Mar 2017 07:03:11 -0700 (PDT) References: <1489608324-23632-1-git-send-email-jmd@gnu.org> <1489608324-23632-2-git-send-email-jmd@gnu.org> <8760j5wgvc.fsf@elephly.net> <20170319133317.GA4118@jocasta.intra> User-agent: mu4e 0.9.18; emacs 25.1.1 From: Ricardo Wurmus To: John Darrington Subject: Re: bug#26112: [PATCH 2/7] gnu: Add niftilib. In-reply-to: <20170319133317.GA4118@jocasta.intra> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Sun, 19 Mar 2017 15:03:08 +0100 Message-ID: <874lypwehv.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 26112 Cc: 26112@debbugs.gnu.org, John Darrington X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) John Darrington writes: > I'm not sure that all your suggestions will work, but I will try what you suggest > and push follow-up commit. I’ve already done that with commit f729a4d8b274aebd578f45b2ca55cded31001b85. It builds fine for me. > Regarding indentation - I normally let emacs handle it. Shouldn't that get everything > correct? We give a couple of hints to Emacs to indent our special forms differently. This requires use of the “emacs-guix” package, if I’m not mistaken. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 10:47:29 2017 Received: (at 26112) by debbugs.gnu.org; 19 Mar 2017 14:47:29 +0000 Received: from localhost ([127.0.0.1]:35341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpc7F-0004WF-Hc for submit@debbugs.gnu.org; Sun, 19 Mar 2017 10:47:29 -0400 Received: from de.cellform.com ([88.217.224.109]:51696 helo=jocasta.intra) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpc7C-0004W4-5k for 26112@debbugs.gnu.org; Sun, 19 Mar 2017 10:47:28 -0400 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.14.4/8.14.4/Debian-8+deb8u1) with ESMTP id v2JElNsL004934 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 19 Mar 2017 15:47:23 +0100 Received: (from john@localhost) by jocasta.intra (8.14.4/8.14.4/Submit) id v2JElMMi004933; Sun, 19 Mar 2017 15:47:22 +0100 Date: Sun, 19 Mar 2017 15:47:22 +0100 From: John Darrington To: Ricardo Wurmus Subject: Re: bug#26112: [PATCH 2/7] gnu: Add niftilib. Message-ID: <20170319144722.GA4892@jocasta.intra> References: <1489608324-23632-1-git-send-email-jmd@gnu.org> <1489608324-23632-2-git-send-email-jmd@gnu.org> <8760j5wgvc.fsf@elephly.net> <20170319133317.GA4118@jocasta.intra> <874lypwehv.fsf@elephly.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ibTvN161/egqYuK8" Content-Disposition: inline In-Reply-To: <874lypwehv.fsf@elephly.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26112 Cc: 26112@debbugs.gnu.org, John Darrington , John Darrington X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 19, 2017 at 03:03:08PM +0100, Ricardo Wurmus wrote: =20 John Darrington writes: =20 > I'm not sure that all your suggestions will work, but I will try wha= t you suggest > and push follow-up commit. =20 I???ve already done that with commit f729a4d8b274aebd578f45b2ca55cded31001b85. It builds fine for me. Hmm ok. I have a nasty feeling that this may have broken some of my yet-to= -be-committed,=20 dependent packages. But if it has, we'll cross that bridge when we come to= it. Thanks for the fixup anyway. =20 > Regarding indentation - I normally let emacs handle it. Shouldn't th= at get everything > correct? =20 We give a couple of hints to Emacs to indent our special forms differently. This requires use of the ???emacs-guix??? package, if I?= ??m not mistaken. =20 Ok I will install that. Thanks for the hint. J' --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --ibTvN161/egqYuK8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAljOmfoACgkQimdxnC3oJ7PbYACfWQfqI88UjPTpsf6VlshEcM6u kvkAniIMP2K5ry5O+KCsr8JyCI5hO+4j =2N8B -----END PGP SIGNATURE----- --ibTvN161/egqYuK8-- From unknown Sun Jun 22 17:12:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 17 Apr 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator