From unknown Mon Jun 23 11:25:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#26108 <26108@debbugs.gnu.org> To: bug#26108 <26108@debbugs.gnu.org> Subject: Status: [PATCH 6/7] gnu: Add mia. Reply-To: bug#26108 <26108@debbugs.gnu.org> Date: Mon, 23 Jun 2025 18:25:08 +0000 retitle 26108 [PATCH 6/7] gnu: Add mia. reassign 26108 guix-patches submitter 26108 John Darrington severity 26108 normal tag 26108 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 15 16:06:01 2017 Received: (at submit) by debbugs.gnu.org; 15 Mar 2017 20:06:01 +0000 Received: from localhost ([127.0.0.1]:57508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coFBJ-00072l-0f for submit@debbugs.gnu.org; Wed, 15 Mar 2017 16:06:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coFBG-00072W-Mg for submit@debbugs.gnu.org; Wed, 15 Mar 2017 16:05:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coFBA-0008Cp-4a for submit@debbugs.gnu.org; Wed, 15 Mar 2017 16:05:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1coFBA-0008Ca-1N for submit@debbugs.gnu.org; Wed, 15 Mar 2017 16:05:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coFB7-00039z-EW for guix-patches@gnu.org; Wed, 15 Mar 2017 16:05:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coFB4-00087Z-AH for guix-patches@gnu.org; Wed, 15 Mar 2017 16:05:49 -0400 Received: from de.cellform.com ([88.217.224.109]:60821 helo=jocasta.intra) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1coFB3-0007uZ-RA; Wed, 15 Mar 2017 16:05:46 -0400 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.14.4/8.14.4/Debian-8+deb8u1) with ESMTP id v2FK5UDO023707 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Mar 2017 21:05:30 +0100 Received: (from john@localhost) by jocasta.intra (8.14.4/8.14.4/Submit) id v2FK5U8J023706; Wed, 15 Mar 2017 21:05:30 +0100 From: John Darrington To: guix-patches@gnu.org Subject: [PATCH 6/7] gnu: Add mia. Date: Wed, 15 Mar 2017 21:05:23 +0100 Message-Id: <1489608324-23632-6-git-send-email-jmd@gnu.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1489608324-23632-1-git-send-email-jmd@gnu.org> References: <1489608324-23632-1-git-send-email-jmd@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit Cc: John Darrington X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) * gnu/packages/image-processing.scm (mia): New variable. --- gnu/packages/image-processing.scm | 75 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 74 insertions(+), 1 deletion(-) diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm index e1ad93e..e080569 100644 --- a/gnu/packages/image-processing.scm +++ b/gnu/packages/image-processing.scm @@ -21,12 +21,25 @@ #:use-module (guix packages) #:use-module (guix utils) #:use-module (guix download) + #:use-module (guix git-download) #:use-module (guix build-system gnu) + #:use-module (guix build-system cmake) #:use-module (gnu packages) + #:use-module (gnu packages algebra) + #:use-module (gnu packages boost) #:use-module (gnu packages compression) #:use-module (gnu packages documentation) + #:use-module (gnu packages gnome) + #:use-module (gnu packages graphics) + #:use-module (gnu packages graphviz) + #:use-module (gnu packages maths) + #:use-module (gnu packages xml) #:use-module (gnu packages image) - #:use-module (gnu packages perl)) + #:use-module (gnu packages perl) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages python) + #:use-module (gnu packages tbb) + #:use-module (gnu packages vtk)) (define-public dcmtk (package @@ -73,3 +86,63 @@ demonstrative image storage and worklist servers.") "file://COPYRIGHT" "A union of the Apache 2.0 licence and various non-copyleft licences similar to the Modified BSD licence.")))) + + +(define-public mia + (package + (name "mia") + (version "2.4.3") + (source (origin + ;; There are too many issues with the released version which + ;; prevent a clean build and test under Guix. So until the next + ;; release I suggest we use this git checkout. + (method git-fetch) + (uri (git-reference + (url "https://git.code.sf.net/p/mia/mia2") + (commit "d91cade30a10f179bba8c8e48b84983a296d2c33"))) + (sha256 + (base32 + "0y8ihqbliqy21fph3dm5h6k2nvjbajx4y0mn351x990r9y0767vz")) + (file-name (string-append name "-" version)))) + (build-system cmake-build-system) + (arguments `(#:configure-flags `("-DMIA_CREATE_NIPYPE_INTERFACES=0" + ,(string-append "-DCMAKE_INSTALL_LIBDIR=" + (assoc-ref %outputs "out") + "/lib") + ;; According to upstream this is necessary + ;; with g++-4.9.x because the std::regex + ;; library doesn't work reliably. + "-DMIA_USE_BOOST_REGEX=ON" + "-DCMAKE_CXX_FLAGS=-fpermissive"))) + (inputs `(("boost" ,boost) + ("dcmtk" ,dcmtk) + ("doxygen" ,doxygen) + ("eigen" ,eigen) + ("fftw" ,fftw) + ("fftwf" ,fftwf) + ("gsl" ,gsl) + ("gts" ,gts) + ("hdf5" ,hdf5) + ("itpp" ,itpp) + ("libjpeg" ,libjpeg) + ("libpng" ,libpng) + ("libtiff" ,libtiff) + ("libxml" ,libxml2) + ("libxml++" ,libxml++) + ("maxflow" ,maxflow) + ("niftilib" ,niftilib) + ("nlopt" ,nlopt) + ("openexr" ,openexr) + ("python-lxml" ,python2-lxml) + ("vtk" ,vtk@6.3))) + (native-inputs `(("pkg-config" ,pkg-config) + ("python" ,python-2))) + (synopsis "Toolkit for gray scale medical image analysis") + (description "MIA provides a combination of command line tools, plug-ins, +and libraries that make it possible run image processing tasks interactively +in a command shell and to prototype using the shell's scripting +language. It is built around a plug-in structure that makes it easy to add +functionality without compromising the original code base and it makes use of a +wide variety of external libraries that provide additional functionality.") + (home-page "http://mia.sourceforge.net") + (license license:gpl3+))) -- 2.1.4 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 01:54:02 2017 Received: (at 26108) by debbugs.gnu.org; 18 Mar 2017 05:54:02 +0000 Received: from localhost ([127.0.0.1]:33143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cp7JS-0006UP-Gr for submit@debbugs.gnu.org; Sat, 18 Mar 2017 01:54:02 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:48273 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cp7JP-0006Ty-1l for 26108@debbugs.gnu.org; Sat, 18 Mar 2017 01:53:59 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id D365250C6B9; Sat, 18 Mar 2017 06:53:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489816437; bh=+QTm743Bqmt/Eudlyzi3SwqtEi8gZmBiufZWOB7M1z0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=McG7KbWGyNKE9JPLk5QWmTAIEWSkt6nle/2tnZWszxq9TDMHE0jX2uNiFbVdOCWJX yP5bHkHMMso8yWiD8QR/3WEUqWqdQFt5MfwFc39BW8cvrkeGmfLyyP5VSJ0L5gRC1Z 30N0o343gHtyov2y8QYbGslif3GW7uU8lTNHVaao= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR002 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489816436; bh=+QTm743Bqmt/Eudlyzi3SwqtEi8gZmBiufZWOB7M1z0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kIi0ldPTuspQPeIuaQyyIy6LSjgeLB75xV0nRRooqHFt/E4V6lYNY55BdPlKsTmJ4 ush0vrffWMUdxIZMEGPEv3YmnmpvxkrsupzIjbiNlYZjHgJJ1+bGSE/WShLje4Lk2h DOwbfwb1Mx1Tr1Bz6v9iE/1JsvJp3I7fjWuB+LsU= To: John Darrington Subject: Re: bug#26108: [PATCH 6/7] gnu: Add mia. References: <1489608324-23632-1-git-send-email-jmd@gnu.org> <1489608324-23632-6-git-send-email-jmd@gnu.org> Date: Sat, 18 Mar 2017 01:53:42 -0400 In-Reply-To: <1489608324-23632-6-git-send-email-jmd@gnu.org> (John Darrington's message of "Wed, 15 Mar 2017 21:05:23 +0100") Message-ID: <87r31v5dw9.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26108 Cc: 26108@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable John Darrington writes: > * gnu/packages/image-processing.scm (mia): New variable. > --- > gnu/packages/image-processing.scm | 75 +++++++++++++++++++++++++++++++++= +++++- > 1 file changed, 74 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-proce= ssing.scm > index e1ad93e..e080569 100644 > --- a/gnu/packages/image-processing.scm > +++ b/gnu/packages/image-processing.scm > @@ -21,12 +21,25 @@ > #:use-module (guix packages) > #:use-module (guix utils) > #:use-module (guix download) > + #:use-module (guix git-download) > #:use-module (guix build-system gnu) > + #:use-module (guix build-system cmake) > #:use-module (gnu packages) > + #:use-module (gnu packages algebra) > + #:use-module (gnu packages boost) > #:use-module (gnu packages compression) > #:use-module (gnu packages documentation) > + #:use-module (gnu packages gnome) > + #:use-module (gnu packages graphics) > + #:use-module (gnu packages graphviz) > + #:use-module (gnu packages maths) > + #:use-module (gnu packages xml) > #:use-module (gnu packages image) > - #:use-module (gnu packages perl)) > + #:use-module (gnu packages perl) > + #:use-module (gnu packages pkg-config) > + #:use-module (gnu packages python) > + #:use-module (gnu packages tbb) > + #:use-module (gnu packages vtk)) >=20=20 > (define-public dcmtk > (package > @@ -73,3 +86,63 @@ demonstrative image storage and worklist servers.") > "file://COPYRIGHT" > "A union of the Apache 2.0 licence and various non-copyleft > licences similar to the Modified BSD licence.")))) > + > + > +(define-public mia > + (package > + (name "mia") > + (version "2.4.3") > + (source (origin > + ;; There are too many issues with the released version whi= ch > + ;; prevent a clean build and test under Guix. So until th= e next > + ;; release I suggest we use this git checkout. > + (method git-fetch) > + (uri (git-reference > + (url "https://git.code.sf.net/p/mia/mia2") > + (commit "d91cade30a10f179bba8c8e48b84983a296d2c33"))) > + (sha256 > + (base32 > + "0y8ihqbliqy21fph3dm5h6k2nvjbajx4y0mn351x990r9y0767vz")) > + (file-name (string-append name "-" version)))) > + (build-system cmake-build-system) > + (arguments `(#:configure-flags `("-DMIA_CREATE_NIPYPE_INTERFACES=3D0" > + ,(string-append "-DCMAKE_INSTALL_LI= BDIR=3D" > + (assoc-ref %outputs= "out") > + "/lib") > + ;; According to upstream this is ne= cessary > + ;; with g++-4.9.x because the std::= regex > + ;; library doesn't work reliably. > + "-DMIA_USE_BOOST_REGEX=3DON" > + "-DCMAKE_CXX_FLAGS=3D-fpermissive")= )) > + (inputs `(("boost" ,boost) > + ("dcmtk" ,dcmtk) > + ("doxygen" ,doxygen) > + ("eigen" ,eigen) > + ("fftw" ,fftw) > + ("fftwf" ,fftwf) > + ("gsl" ,gsl) > + ("gts" ,gts) > + ("hdf5" ,hdf5) > + ("itpp" ,itpp) > + ("libjpeg" ,libjpeg) > + ("libpng" ,libpng) > + ("libtiff" ,libtiff) > + ("libxml" ,libxml2) > + ("libxml++" ,libxml++) > + ("maxflow" ,maxflow) > + ("niftilib" ,niftilib) > + ("nlopt" ,nlopt) > + ("openexr" ,openexr) > + ("python-lxml" ,python2-lxml) > + ("vtk" ,vtk@6.3))) > + (native-inputs `(("pkg-config" ,pkg-config) > + ("python" ,python-2))) > + (synopsis "Toolkit for gray scale medical image analysis") > + (description "MIA provides a combination of command line tools, plug= -ins, > +and libraries that make it possible run image processing tasks interacti= vely > +in a command shell and to prototype using the shell's scripting > +language. It is built around a plug-in structure that makes it easy to = add > +functionality without compromising the original code base and it makes u= se of a > +wide variety of external libraries that provide additional functionality= .") > + (home-page "http://mia.sourceforge.net") > + (license license:gpl3+))) My machine doesn't have the hardware to build this package in a reasonable amount of time, but it lints file and looks good! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljMy2cACgkQ5qXuPBlG eg0HAxAAs69QQ91KY9+VQoNoA2MKy0BylIIf3MkLKv2RvMwmZrYEifthOEHsf13j yN4Sd7nARWl96k+0KV6XMi3cVxGqCBFjFj5moYO+PIC4gg36fCogx09qvOGonzvr 8/ecQtuqHoXap1eFEI5DegoH5k1GgWuIwWbIscmjAyO9pcr2LQMDa+Yta1DI8mfh tS8rvBxTMTIeXBriW54AyxFvJc/CxVDgtmJlpT8y+ccsKWiAdSlK1EX4Z00YRtiD jauCNEgQX/rzFH3EKtX5F2f93T6j25Z115zlDQwmipAojm7GNe5Cp3PnhhchO5x5 9kre9MeGbWPb0sD4U4IyIx+OzFjREbFvsezBJizXe1KudObrSb9t9sE4suhsV5PW Ec3g1g4vB7+FrjUrIDEweyL9U7IEmCnIp3TVEuY9t3laL+P+IOQZHFAvZZLHtyjG LZ9/yITzNrhfvi78iCABV1MwrJf5ye0hiwEcDQmyzDXVTlX8mgKbezUS6l6MxxTx Ez/jdhX+R/c1bzEAEoIya5HgECWvAxs+BIO3N2i5BEa0GXuxfugoG5Whc3pSZ3uv JAKwu5dphrdGOapXXlumis4DIj5vIkXMoAKMoUqZTOvtbCXy1EWcLClFZ0UN4wXv RQ8pijbQrttbVOyz3poXfTM1cJNqT0ycS1jOJKcvxq8thE+UnjY= =kCan -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 02:17:28 2017 Received: (at 26108) by debbugs.gnu.org; 18 Mar 2017 06:17:28 +0000 Received: from localhost ([127.0.0.1]:33158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cp7g7-00076W-9A for submit@debbugs.gnu.org; Sat, 18 Mar 2017 02:17:28 -0400 Received: from de.cellform.com ([88.217.224.109]:51639 helo=jocasta.intra) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cp7g5-00076N-5l for 26108@debbugs.gnu.org; Sat, 18 Mar 2017 02:17:26 -0400 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.14.4/8.14.4/Debian-8+deb8u1) with ESMTP id v2I6HNlu011891 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 Mar 2017 07:17:23 +0100 Received: (from john@localhost) by jocasta.intra (8.14.4/8.14.4/Submit) id v2I6HNLp011890; Sat, 18 Mar 2017 07:17:23 +0100 Date: Sat, 18 Mar 2017 07:17:23 +0100 From: John Darrington To: Kei Kebreau Subject: Re: bug#26108: [PATCH 6/7] gnu: Add mia. Message-ID: <20170318061723.GA11846@jocasta.intra> References: <1489608324-23632-1-git-send-email-jmd@gnu.org> <1489608324-23632-6-git-send-email-jmd@gnu.org> <87r31v5dw9.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VS++wcV0S1rZb1Fb" Content-Disposition: inline In-Reply-To: <87r31v5dw9.fsf@openmailbox.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26108 Cc: 26108@debbugs.gnu.org, John Darrington X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --VS++wcV0S1rZb1Fb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 18, 2017 at 01:53:42AM -0400, Kei Kebreau wrote: =20 My machine doesn't have the hardware to build this package in a reasonable amount of time, but it lints file and looks good! Yeah. It takes about an hour for me. Thanks for the reviews anyway. J' --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --VS++wcV0S1rZb1Fb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAljM0PMACgkQimdxnC3oJ7NTqgCfQwVOEpcrlsWwGWH5wIqD2K76 KjUAn1QVqCF4IWY4WH68WQ+n0SAGxFUR =urjD -----END PGP SIGNATURE----- --VS++wcV0S1rZb1Fb-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 30 08:44:42 2017 Received: (at 26108) by debbugs.gnu.org; 30 Mar 2017 12:44:42 +0000 Received: from localhost ([127.0.0.1]:52019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctZRS-0008FN-Ap for submit@debbugs.gnu.org; Thu, 30 Mar 2017 08:44:42 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctZRQ-0008FF-7C for 26108@debbugs.gnu.org; Thu, 30 Mar 2017 08:44:40 -0400 Received: from localhost (141.80.148.164 [141.80.148.164]) by mx.zohomail.com with SMTPS id 1490877874504948.7056534517935; Thu, 30 Mar 2017 05:44:34 -0700 (PDT) References: <1489608324-23632-1-git-send-email-jmd@gnu.org> <1489608324-23632-6-git-send-email-jmd@gnu.org> User-agent: mu4e 0.9.18; emacs 25.1.1 From: Ricardo Wurmus To: John Darrington Subject: Re: bug#26108: [PATCH 6/7] gnu: Add mia. In-reply-to: <1489608324-23632-6-git-send-email-jmd@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 30 Mar 2017 15:15:51 +0200 Message-ID: <87inmq52ig.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 26108 Cc: 26108@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) John Darrington writes: > * gnu/packages/image-processing.scm (mia): New variable. […] > + > +(define-public mia > + (package > + (name "mia") > + (version "2.4.3") > + (source (origin > + ;; There are too many issues with the released version which > + ;; prevent a clean build and test under Guix. So until the next > + ;; release I suggest we use this git checkout. That’s okay. Could you please wrap the “(package …)“ expression in a let expression where ‘commit’ is bound to "d91cade30a10f179bba8c8e48b84983a296d2c33" and ‘revision’ to "1". Then the version field should be changed to (string-append "2.4.3-" revision "." (string-take commit 7)) because this is not exactly version "2.4.3”. > + (method git-fetch) > + (uri (git-reference > + (url "https://git.code.sf.net/p/mia/mia2") > + (commit > "d91cade30a10f179bba8c8e48b84983a296d2c33"))) After wrapping the thing in a let binding you can use “(commit commit)” here. > + (sha256 > + (base32 > + "0y8ihqbliqy21fph3dm5h6k2nvjbajx4y0mn351x990r9y0767vz")) > + (file-name (string-append name "-" version)))) Usually, we append “-checkout” to git clones. > + (build-system cmake-build-system) > + (arguments `(#:configure-flags `("-DMIA_CREATE_NIPYPE_INTERFACES=0" > + ,(string-append "-DCMAKE_INSTALL_LIBDIR=" > + (assoc-ref %outputs "out") > + "/lib") > + ;; According to upstream this is necessary > + ;; with g++-4.9.x because the std::regex > + ;; library doesn't work reliably. > + "-DMIA_USE_BOOST_REGEX=ON" > + > "-DCMAKE_CXX_FLAGS=-fpermissive"))) I have a slight preference to adding a line break after “arguments”. > + (inputs `(("boost" ,boost) > + ("dcmtk" ,dcmtk) > + ("doxygen" ,doxygen) I think this should be a native input. Please also add a line break after “inputs”. > + ("eigen" ,eigen) > + ("fftw" ,fftw) > + ("fftwf" ,fftwf) > + ("gsl" ,gsl) > + ("gts" ,gts) > + ("hdf5" ,hdf5) > + ("itpp" ,itpp) > + ("libjpeg" ,libjpeg) > + ("libpng" ,libpng) > + ("libtiff" ,libtiff) > + ("libxml" ,libxml2) > + ("libxml++" ,libxml++) > + ("maxflow" ,maxflow) > + ("niftilib" ,niftilib) > + ("nlopt" ,nlopt) > + ("openexr" ,openexr) > + ("python-lxml" ,python2-lxml) > + ("vtk" ,vtk@6.3))) > + (native-inputs `(("pkg-config" ,pkg-config) > + ("python" ,python-2))) Please add a line break after “native-inputs” (for consistency). Please also collapse the spaces after "pkg-config". > + (synopsis "Toolkit for gray scale medical image analysis") > + (description "MIA provides a combination of command line tools, plug-ins, > +and libraries that make it possible run image processing tasks interactively > +in a command shell and to prototype using the shell's scripting > +language. It is built around a plug-in structure that makes it easy to add > +functionality without compromising the original code base and it makes use of a > +wide variety of external libraries that provide additional functionality.") > + (home-page "http://mia.sourceforge.net") > + (license license:gpl3+))) The rest looks good to me (I did not check the license). Would you like to push an updated version or would you like me to make the changes myself? -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 31 01:28:07 2017 Received: (at 26108) by debbugs.gnu.org; 31 Mar 2017 05:28:07 +0000 Received: from localhost ([127.0.0.1]:53499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctp6V-00088n-2r for submit@debbugs.gnu.org; Fri, 31 Mar 2017 01:28:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctp6S-00088G-Qh for 26108@debbugs.gnu.org; Fri, 31 Mar 2017 01:28:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctp6M-0000LD-NK for 26108@debbugs.gnu.org; Fri, 31 Mar 2017 01:27:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctp6J-0000Ix-EE; Fri, 31 Mar 2017 01:27:55 -0400 Received: from jmd by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ctp6J-0006Qn-0f; Fri, 31 Mar 2017 01:27:55 -0400 Date: Fri, 31 Mar 2017 01:27:54 -0400 From: John Darrington To: Ricardo Wurmus Subject: Re: bug#26108: [PATCH 6/7] gnu: Add mia. Message-ID: <20170331052754.GA24198@gnu.org> References: <1489608324-23632-1-git-send-email-jmd@gnu.org> <1489608324-23632-6-git-send-email-jmd@gnu.org> <87inmq52ig.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87inmq52ig.fsf@elephly.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26108 Cc: 26108@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On Thu, Mar 30, 2017 at 03:15:51PM +0200, Ricardo Wurmus wrote: > > > + (synopsis "Toolkit for gray scale medical image analysis") > > + (description "MIA provides a combination of command line tools, plug-ins, > > +and libraries that make it possible run image processing tasks interactively > > +in a command shell and to prototype using the shell's scripting > > +language. It is built around a plug-in structure that makes it easy to add > > +functionality without compromising the original code base and it makes use of a > > +wide variety of external libraries that provide additional functionality.") > > + (home-page "http://mia.sourceforge.net") > > + (license license:gpl3+))) > > The rest looks good to me (I did not check the license). Would you like > to push an updated version or would you like me to make the changes > myself? Feel free to make any changes you think necessary and commit it if appropriate. J' From debbugs-submit-bounces@debbugs.gnu.org Mon May 15 17:09:29 2017 Received: (at 26108-done) by debbugs.gnu.org; 15 May 2017 21:09:29 +0000 Received: from localhost ([127.0.0.1]:47017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dANFB-0000Jv-6d for submit@debbugs.gnu.org; Mon, 15 May 2017 17:09:29 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dANF9-0000Jn-Ed for 26108-done@debbugs.gnu.org; Mon, 15 May 2017 17:09:27 -0400 Received: from localhost (x2f7fa94.dyn.telefonica.de [2.247.250.148]) by mx.zohomail.com with SMTPS id 1494882565341293.9197567806009; Mon, 15 May 2017 14:09:25 -0700 (PDT) References: <1489608324-23632-1-git-send-email-jmd@gnu.org> <1489608324-23632-6-git-send-email-jmd@gnu.org> <87inmq52ig.fsf@elephly.net> <20170331052754.GA24198@gnu.org> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Ricardo Wurmus To: John Darrington Subject: Re: bug#26108: [PATCH 6/7] gnu: Add mia. In-reply-to: <20170331052754.GA24198@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Mon, 15 May 2017 23:09:19 +0200 Message-ID: <87fug56d4w.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 26108-done Cc: 26108-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) John Darrington writes: > On Thu, Mar 30, 2017 at 03:15:51PM +0200, Ricardo Wurmus wrote: >> >> > + (synopsis "Toolkit for gray scale medical image analysis") >> > + (description "MIA provides a combination of command line tools, plug-ins, >> > +and libraries that make it possible run image processing tasks interactively >> > +in a command shell and to prototype using the shell's scripting >> > +language. It is built around a plug-in structure that makes it easy to add >> > +functionality without compromising the original code base and it makes use of a >> > +wide variety of external libraries that provide additional functionality.") >> > + (home-page "http://mia.sourceforge.net") >> > + (license license:gpl3+))) >> >> The rest looks good to me (I did not check the license). Would you like >> to push an updated version or would you like me to make the changes >> myself? > > Feel free to make any changes you think necessary and commit it if appropriate. I made some changes, updated to the latest version, and pushed it to master. Thank you, John, for the patch, and my apologies for letting it sit here for so long! (It was impossible to build it on my laptop, so I had to arrange for a different machine.) -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From unknown Mon Jun 23 11:25:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 13 Jun 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator