From unknown Sun Jun 15 08:55:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26105: Group parameters can't set non-list values Resent-From: Tim Landscheidt Original-Sender: "Debbugs-submit" Resent-CC: bugs@gnus.org Resent-Date: Wed, 15 Mar 2017 10:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 26105 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: 26105@debbugs.gnu.org X-Debbugs-Original-To: submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys) Received: via spool by submit@debbugs.gnu.org id=B.148957406823565 (code B ref -1); Wed, 15 Mar 2017 10:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Mar 2017 10:34:28 +0000 Received: from localhost ([127.0.0.1]:56312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1co6GB-000680-U1 for submit@debbugs.gnu.org; Wed, 15 Mar 2017 06:34:28 -0400 Received: from mezzogiorno.tim-landscheidt.de ([78.47.87.37]:41686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1co6G9-00067s-UO for submit@debbugs.gnu.org; Wed, 15 Mar 2017 06:34:26 -0400 Received: from x4e36830a.dyn.telefonica.de ([78.54.131.10]:44078 helo=passepartout.tim-landscheidt.de) by mezzogiorno.tim-landscheidt.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1co6G8-0006bS-Jg for submit@debbugs.gnu.org; Wed, 15 Mar 2017 10:34:24 +0000 From: Tim Landscheidt Organization: http://www.tim-landscheidt.de/ Date: Wed, 15 Mar 2017 10:34:18 +0000 Message-ID: <87zigmygk5.fsf@passepartout.tim-landscheidt.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) With Gnus v5.13/GNU Emacs 25.1.1, I want to customize for example gnus-summary-thread-gathering-function to gnus-gather-threads-by-references for one specific group. When I use either of: | (gnus-summary-thread-gathering-function . gnus-gather-threads-by-referenc= es) or: | (gnus-summary-thread-gathering-function gnus-gather-threads-by-references) in G p, the variable gnus-summary-thread-gathering-function is unchanged in the summary buffer, i. e. the customization is ignored. When I use the syntax: | (gnus-summary-thread-gathering-function | '(gnus-gather-threads-by-references))) on trying to enter the group, Gnus fails with "gnus-summary-prepare: Invalid function: (gnus-gather-threads-by-references)". This is due to: a) gnus-summary-prepare calling gnus-summary-thread-gathering-function with: | (funcall gnus-summary-thread-gathering-function | (gnus-sort-threads | (gnus-cut-threads (gnus-make-threads)))) i. e. it expects gnus-summary-thread-gathering-function to be a single function, and b) gnus-summary-set-local-parameters only setting variables in group parameters if the value is a list and silently ignoring non-list values: | (dolist (elem (gnus-group-find-parameter group)) | (and (consp elem) ; Has to be a cons. | (consp (cdr elem)) ; The cdr has to be a list. | (symbolp (car elem)) ; Has to be a symbol in there. | (not (memq (car elem) vars)) | [=E2=80=A6] AFAICT, this requirement has been introduced by Lars with commit eec82323c2e3610907cf66ece372b1920318d460 ("Initial revision" :-)). This is only alluded to in info's "2.10 Group Parameters": | We see that each element consists of a =E2=80=9Cdotted pair=E2=80=9D= =E2=80=94the thing before | the dot is the key, while the thing after the dot is the value. All the | parameters have this form _except_ local variable specs, which are not | dotted pairs, but proper lists. IMHO this behaviour is surprising and makes customizing non- list variables for groups unnecessarily complicated; it should be changed so that all values can be set. If Gnus differentiates between two types of parameters as the info suggests, IMHO this would be better done by compar- ing (car elem) to a white-list of parameters to be treated differently. From unknown Sun Jun 15 08:55:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26105: Acknowledgement (Group parameters can't set non-list values) Resent-From: Tim Landscheidt Original-Sender: "Debbugs-submit" Resent-CC: bugs@gnus.org Resent-Date: Thu, 16 Mar 2017 01:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26105 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: 26105@debbugs.gnu.org Received: via spool by 26105-submit@debbugs.gnu.org id=B26105.148962847426338 (code B ref 26105); Thu, 16 Mar 2017 01:42:01 +0000 Received: (at 26105) by debbugs.gnu.org; 16 Mar 2017 01:41:14 +0000 Received: from localhost ([127.0.0.1]:57735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coKPi-0006qk-Dh for submit@debbugs.gnu.org; Wed, 15 Mar 2017 21:41:14 -0400 Received: from mezzogiorno.tim-landscheidt.de ([78.47.87.37]:41687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coKPg-0006qc-M9 for 26105@debbugs.gnu.org; Wed, 15 Mar 2017 21:41:13 -0400 Received: from x4e36830a.dyn.telefonica.de ([78.54.131.10]:55988 helo=passepartout.tim-landscheidt.de) by mezzogiorno.tim-landscheidt.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1coKPd-0000Kv-Os for 26105@debbugs.gnu.org; Thu, 16 Mar 2017 01:41:09 +0000 From: Tim Landscheidt Organization: http://www.tim-landscheidt.de/ References: <87zigmygk5.fsf@passepartout.tim-landscheidt.de> Date: Thu, 16 Mar 2017 01:41:04 +0000 In-Reply-To: (GNU bug Tracking System's message of "Wed, 15 Mar 2017 10:35:02 +0000") Message-ID: <87r31yxakv.fsf@passepartout.tim-landscheidt.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) It is possible to work around this issue by: | (gnus-summary-thread-gathering-function | (lambda | (threads) | (gnus-gather-threads-by-references threads))) From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 15 21:59:16 2017 Received: (at control) by debbugs.gnu.org; 16 Mar 2017 01:59:16 +0000 Received: from localhost ([127.0.0.1]:57740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coKhA-0007Is-0Z for submit@debbugs.gnu.org; Wed, 15 Mar 2017 21:59:16 -0400 Received: from mezzogiorno.tim-landscheidt.de ([78.47.87.37]:41688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coKh9-0007Il-6F for control@debbugs.gnu.org; Wed, 15 Mar 2017 21:59:15 -0400 Received: from x4e36830a.dyn.telefonica.de ([78.54.131.10]:56272 helo=passepartout.tim-landscheidt.de) by mezzogiorno.tim-landscheidt.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1coKh8-0000No-5q for control@debbugs.gnu.org; Thu, 16 Mar 2017 01:59:14 +0000 From: Tim Landscheidt To: control@debbugs.gnu.org Subject: none Organization: http://www.tim-landscheidt.de/ Date: Thu, 16 Mar 2017 01:59:08 +0000 Message-ID: <87mvcmx9qr.fsf@passepartout.tim-landscheidt.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) reassign 26105 emacs,gnus reassign 26064 emacs,gnus From unknown Sun Jun 15 08:55:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26105: Group parameters can't set non-list values Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 12 Apr 2018 19:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26105 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: To: Tim Landscheidt Cc: 26105@debbugs.gnu.org Received: via spool by 26105-submit@debbugs.gnu.org id=B26105.152356137524523 (code B ref 26105); Thu, 12 Apr 2018 19:30:03 +0000 Received: (at 26105) by debbugs.gnu.org; 12 Apr 2018 19:29:35 +0000 Received: from localhost ([127.0.0.1]:48518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6huZ-0006NS-6g for submit@debbugs.gnu.org; Thu, 12 Apr 2018 15:29:35 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:37123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6huX-0006NC-C8 for 26105@debbugs.gnu.org; Thu, 12 Apr 2018 15:29:33 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f6huT-0006vK-Iq; Thu, 12 Apr 2018 21:29:32 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f6huN-0005u0-Oi; Thu, 12 Apr 2018 21:29:23 +0200 From: Lars Ingebrigtsen References: <87zigmygk5.fsf@passepartout.tim-landscheidt.de> Date: Thu, 12 Apr 2018 21:29:23 +0200 In-Reply-To: <87zigmygk5.fsf@passepartout.tim-landscheidt.de> (Tim Landscheidt's message of "Wed, 15 Mar 2017 10:34:18 +0000") Message-ID: <871sfknrzg.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tim Landscheidt writes: > | We see that each element consists of a =E2=80=9Cdotted pair=E2=80=9D= =E2=80=94the thing before > | the dot is the key, while the thing after the dot is the value. All the > | parameters have this form _except_ local variable specs, which are not > | dotted pairs, but proper lists. > > IMHO this behaviour is surprising and makes customizing non- > list variables for groups unnecessarily complicated; it > should be changed so that all values can be set. > > If Gnus differentiates between two types of parameters as > the info suggests, IMHO this would be better done by compar- > ing (car elem) to a white-list of parameters to be treated > differently. Yeah, but changing this would break the parameters that people may be using. If we remove the distinction between parameters and local variables, then things will break for users. I agree that the current state isn't optimal, but I don't see any way to fix this in an intuitive and backwards-compatible way. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 12 15:29:35 2018 Received: (at control) by debbugs.gnu.org; 12 Apr 2018 19:29:35 +0000 Received: from localhost ([127.0.0.1]:48520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6huZ-0006NU-Eb for submit@debbugs.gnu.org; Thu, 12 Apr 2018 15:29:35 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:37126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6huX-0006NF-Pm for control@debbugs.gnu.org; Thu, 12 Apr 2018 15:29:34 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f6huV-0006wf-Je for control@debbugs.gnu.org; Thu, 12 Apr 2018 21:29:33 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f6huP-0005u3-Qf for control@debbugs.gnu.org; Thu, 12 Apr 2018 21:29:25 +0200 To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #26105 Message-Id: Date: Thu, 12 Apr 2018 21:29:25 +0200 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 26105 wontfix close 26105