GNU bug report logs - #26076
[PATCH] gnu: Add zlib-minizip.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26076 in the body.
You can then email your comments to 26076 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: guix-patches <at> gnu.org
Cc: Marius Bakke <mbakke <at> fastmail.com>
Subject: [PATCH] gnu: Add zlib-minizip.
Date: Sun, 12 Mar 2017 19:37:36 +0100

* gnu/packages/compression.scm (zlib-minizip): New variable.
---
 gnu/packages/compression.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index 88f8f0d84..393871e09 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -97,6 +97,33 @@ independent of the input data and can be reduced, if necessary, at some cost
 in compression.")
     (license license:zlib)))
 
+(define-public zlib-minizip
+  (package
+    (name "zlib-minizip")
+    (version (package-version zlib))
+    (source (package-source zlib))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'enter-source
+           (lambda _ (chdir "contrib/minizip") #t))
+         (add-before 'configure 'autoreconf
+           (lambda _
+             (zero? (system* "autoreconf" "-vif")))))))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("libtool" ,libtool)))
+    (propagated-inputs `(("zlib" ,zlib)))
+    (home-page (package-home-page zlib))
+    (synopsis "Zip Compression library")
+    (description
+     "Minizip is a minimalistic library that supports compressing,
+extracting and viewing ZIP archives.  This version is extracted from
+the @code{zlib} source.")
+    (license (package-license zlib))))
+
 (define-public fastjar
   (package
    (name "fastjar")
-- 
2.12.0

Message #8 received at 26076 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26076 <at> debbugs.gnu.org
Subject: Re: bug#26076: [PATCH] gnu: Add zlib-minizip.
Date: Sun, 12 Mar 2017 23:54:19 -0400

On Sun, Mar 12, 2017 at 07:37:36PM +0100, Marius Bakke wrote:
> * gnu/packages/compression.scm (zlib-minizip): New variable.

If this is the only minizip, then I'd just call it minizip. LGTM

Message #11 received at 26076 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 26076 <at> debbugs.gnu.org
Subject: Re: bug#26076: [PATCH] gnu: Add zlib-minizip.
Date: Mon, 13 Mar 2017 16:44:17 +0100

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Sun, Mar 12, 2017 at 07:37:36PM +0100, Marius Bakke wrote:
>> * gnu/packages/compression.scm (zlib-minizip): New variable.
>
> If this is the only minizip, then I'd just call it minizip. LGTM

There is a more active fork of this library[0], but it seems the most
important fixes trickle their way upstream[1].

I'll rename it to minizip before pushing, thanks for checking.

0: https://github.com/nmoinvaz/minizip
1: https://github.com/madler/zlib/blob/master/ChangeLog

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 26076-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 26076-done <at> debbugs.gnu.org
Subject: Re: bug#26076: [PATCH] gnu: Add zlib-minizip.
Date: Mon, 13 Mar 2017 19:20:58 +0100

[Message part 1 (text/plain, inline)]

On Sun, Mar 12, 2017 at 07:37:36PM +0100, Marius Bakke wrote:
> * gnu/packages/compression.scm (zlib-minizip): New variable.

Pushed as "minizip".

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.