Subject: Re: bug#26074: [PATCH 1/3] gnu: Add python-htmlmin

From: Marius Bakke <[email-masked]>
Date: Sun, 12 Mar 2017 19:28:34 +0100

Catonano <[email-masked]> writes:

> * gnu/packages/python.scm (python-flask-login): New variable.

Thanks for this!

> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 8b50b2909..077150ee9 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -13640,3 +13640,27 @@ It comes with safe defaults and an easily configurable set options.")
>      (synopsis "Add the capability to minify responses while using Flask")
>      (description "This package implements minification support for Flask responses.")
>      (license license:bsd-3)))
> +
> +(define-public python-flask-login
> +  (package
> +    (name "python-flask-login")
> +    (version "0.4.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "Flask-Login" version))
> +       (sha256
> +        (base32
> +         "19w2f33lglkyvxqnj3qghhxa4pr8mp13235k1bd557x52imkapnj"))))
> +    (arguments
> +     `(#:tests? #f))
> +    ;starting phase `check'
> +    ;running "python setup.py" with command "test" and parameters ()
> +    ;make: *** No rule to make target 'check'.  Stop.
> +    ;phase `check' failed after 0.5 seconds

Some projects remove tests before uploading to PyPi which seems to be
the case here. :(

Can you try downloading the source from
https://github.com/maxcountryman/flask-login/releases instead?

> +    (build-system python-build-system)
> +    (home-page
> +     "https://github.com/maxcountryman/flask-login")
> +    (synopsis "User session management for Flask")
> +    (description "Flask does not provide user session management facilities so you are required to either roll your own or use an extension.")

This line is too long (`./pre-inst-env guix lint python-flask-login`
should warn about this).

> +    (license license:expat)))

Other than this the three patches LGTM, except for one detail: we
normally add python2 variants when possible, like so:

(define-public python2-flask-login
  (package-with-python2 python-flask-login))

Can you add that for all three packages and send an updated series?
Please also add a copyright line for yourself at the top of the file.
You can create a single attachment with all patches with this command:
`git format-patch -n origin/master --stdout > series.patch`.

Thanks in advance!