GNU bug report logs - #26074
[PATCH 1/3] gnu: Add python-htmlmin

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26074 in the body.
You can then email your comments to 26074 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/3] gnu: Add python-htmlmin
Date: Sun, 12 Mar 2017 15:34:33 +0100

[Message part 1 (text/plain, inline)]

I have been thinking to package pgAdmin4

I gave up soon, too many deps

But these 3 are the ones I had already packaged

So I submit them anyway

There's no point in throwing them away

[Message part 2 (text/html, inline)]

[0001-gnu-Add-python-htmlmin.patch (text/x-patch, attachment)]

Message #8 received at 26074 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: 26074 <at> debbugs.gnu.org
Subject: Re: bug#26074: [PATCH 1/3] gnu: Add python-htmlmin
Date: Sun, 12 Mar 2017 15:37:44 +0100

[Message part 1 (text/plain, inline)]

This is the second one

The package in this depends on the package in the previous one

[Message part 2 (text/html, inline)]

[0002-gnu-Add-python-flask-htmlmin.patch (text/x-patch, attachment)]

Message #11 received at 26074 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: 26074 <at> debbugs.gnu.org
Subject: Re: bug#26074: [PATCH 1/3] gnu: Add python-htmlmin
Date: Sun, 12 Mar 2017 15:41:56 +0100

[Message part 1 (text/plain, inline)]

this is the last one

This one doesn't depend on any prevoius one

2017-03-12 15:37 GMT+01:00 Catonano <catonano <at> gmail.com>:

> This is the second one
>
> The package in this depends on the package in the previous one
>

[Message part 2 (text/html, inline)]

[0003-gnu-Add-python-flask-login.patch (text/x-patch, attachment)]

Message #14 received at 26074 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Catonano <catonano <at> gmail.com>, 26074 <at> debbugs.gnu.org
Subject: Re: bug#26074: [PATCH 1/3] gnu: Add python-htmlmin
Date: Sun, 12 Mar 2017 19:28:34 +0100

[Message part 1 (text/plain, inline)]

Catonano <catonano <at> gmail.com> writes:

> * gnu/packages/python.scm (python-flask-login): New variable.

Thanks for this!

> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 8b50b2909..077150ee9 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -13640,3 +13640,27 @@ It comes with safe defaults and an easily configurable set options.")
>      (synopsis "Add the capability to minify responses while using Flask")
>      (description "This package implements minification support for Flask responses.")
>      (license license:bsd-3)))
> +
> +(define-public python-flask-login
> +  (package
> +    (name "python-flask-login")
> +    (version "0.4.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "Flask-Login" version))
> +       (sha256
> +        (base32
> +         "19w2f33lglkyvxqnj3qghhxa4pr8mp13235k1bd557x52imkapnj"))))
> +    (arguments
> +     `(#:tests? #f))
> +    ;starting phase `check'
> +    ;running "python setup.py" with command "test" and parameters ()
> +    ;make: *** No rule to make target 'check'.  Stop.
> +    ;phase `check' failed after 0.5 seconds

Some projects remove tests before uploading to PyPi which seems to be
the case here. :(

Can you try downloading the source from
https://github.com/maxcountryman/flask-login/releases instead?

> +    (build-system python-build-system)
> +    (home-page
> +     "https://github.com/maxcountryman/flask-login")
> +    (synopsis "User session management for Flask")
> +    (description "Flask does not provide user session management facilities so you are required to either roll your own or use an extension.")

This line is too long (`./pre-inst-env guix lint python-flask-login`
should warn about this).

> +    (license license:expat)))

Other than this the three patches LGTM, except for one detail: we
normally add python2 variants when possible, like so:

(define-public python2-flask-login
  (package-with-python2 python-flask-login))

Can you add that for all three packages and send an updated series?
Please also add a copyright line for yourself at the top of the file.
You can create a single attachment with all patches with this command:
`git format-patch -n origin/master --stdout > series.patch`.

Thanks in advance!

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 26074 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26074 <at> debbugs.gnu.org
Subject: Re: bug#26074: [PATCH 1/3] gnu: Add python-htmlmin
Date: Sun, 12 Mar 2017 19:40:38 +0100

[Message part 1 (text/plain, inline)]

Marius,

thank you for reviewing !

2017-03-12 19:28 GMT+01:00 Marius Bakke <mbakke <at> fastmail.com>:

> Catonano <catonano <at> gmail.com> writes:
>
> > * gnu/packages/python.scm (python-flask-login): New variable.
>
>

> +    (arguments
> > +     `(#:tests? #f))
> > +    ;starting phase `check'
> > +    ;running "python setup.py" with command "test" and parameters ()
> > +    ;make: *** No rule to make target 'check'.  Stop.
> > +    ;phase `check' failed after 0.5 seconds
>
> Some projects remove tests before uploading to PyPi which seems to be
> the case here. :(
>
> Can you try downloading the source from
> https://github.com/maxcountryman/flask-login/releases instead?
>

Sure, thanks for the suggestion !


>
> > +    (build-system python-build-system)
> > +    (home-page
> > +     "https://github.com/maxcountryman/flask-login")
> > +    (synopsis "User session management for Flask")
> > +    (description "Flask does not provide user session management
> facilities so you are required to either roll your own or use an
> extension.")
>
> This line is too long (`./pre-inst-env guix lint python-flask-login`
> should warn about this).
>

I just realized that I hadn't edited a description so I did that after
having run the linter. I didn't think to run it again.
Sorry


>
> > +    (license license:expat)))
>
> Other than this the three patches LGTM, except for one detail: we
> normally add python2 variants when possible, like so:
>
> (define-public python2-flask-login
>   (package-with-python2 python-flask-login))
>
> Can you add that for all three packages and send an updated series?
> Please also add a copyright line for yourself at the top of the file.
> You can create a single attachment with all patches with this command:
> `git format-patch -n origin/master --stdout > series.patch`.
>
> Thanks in advance!
>

Sure, thanks for your suggestions !

[Message part 2 (text/html, inline)]

Message #20 received at 26074 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26074 <at> debbugs.gnu.org
Subject: Re: bug#26074: [PATCH 1/3] gnu: Add python-htmlmin
Date: Sun, 12 Mar 2017 21:40:57 +0100

[Message part 1 (text/plain, inline)]

2017-03-12 19:40 GMT+01:00 Catonano <catonano <at> gmail.com>:

> Marius,
>
> thank you for reviewing !
>

I'm almost ready.

The only problem now is that python-flask-logins tests fail

starting phase `check'
running "python setup.py" with command "test" and parameters ()
Checking pep8 compliance...
flask_login/login_manager.py:409:29: E122 continuation line missing
indentation or outdented
make: *** [Makefile:23: pep8] Error 1
phase `check' failed after 1.5 seconds


I don't know what pep8 compliance is, it seems something similar to Guix
linting for packages

This is a released version, though. It seems strange that they overlooked
this

I submitted an issue here
https://github.com/maxcountryman/flask-login/issues/340

What do we do ? Do we skip the tests ? Or do we skip the whole package ?

[Message part 2 (text/html, inline)]

Message #23 received at 26074 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26074 <at> debbugs.gnu.org
Subject: Re: bug#26074: [PATCH 1/3] gnu: Add python-htmlmin
Date: Sun, 12 Mar 2017 22:21:16 +0100

[Message part 1 (text/plain, inline)]

2017-03-12 21:40 GMT+01:00 Catonano <catonano <at> gmail.com>:

> <https://github.com/maxcountryman/flask-login/issues/340>
>
>
What do we do ? Do we skip the tests ? Or do we skip the whole package ?
>

Anyway, I attach them again as they are now. So you can see yourself

[Message part 2 (text/html, inline)]

[series.patch (text/x-patch, attachment)]

Message #26 received at 26074 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Catonano <catonano <at> gmail.com>
Cc: 26074 <at> debbugs.gnu.org
Subject: Re: bug#26074: [PATCH 1/3] gnu: Add python-htmlmin
Date: Mon, 13 Mar 2017 17:22:15 +0100

[Message part 1 (text/plain, inline)]

Catonano <catonano <at> gmail.com> writes:

> 2017-03-12 19:40 GMT+01:00 Catonano <catonano <at> gmail.com>:
>
>> Marius,
>>
>> thank you for reviewing !
>>
>
> I'm almost ready.
>
> The only problem now is that python-flask-logins tests fail
>
> starting phase `check'
> running "python setup.py" with command "test" and parameters ()
> Checking pep8 compliance...
> flask_login/login_manager.py:409:29: E122 continuation line missing
> indentation or outdented
> make: *** [Makefile:23: pep8] Error 1
> phase `check' failed after 1.5 seconds
>
>
> I don't know what pep8 compliance is, it seems something similar to Guix
> linting for packages

Yes, it's purely a style checker. Note that the "pep8" package has been
deprecated for "python-pycodestyle". Can you see if that works? If not,
we can probably skip those tests.

Thanks for working on it! Can you also add a copyright line with one of
the commits? Pseudonyms are fine :-)

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 26074 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26074 <at> debbugs.gnu.org
Subject: Re: bug#26074: [PATCH 1/3] gnu: Add python-htmlmin
Date: Mon, 13 Mar 2017 19:20:40 +0100

[Message part 1 (text/plain, inline)]

2017-03-13 17:22 GMT+01:00 Marius Bakke <mbakke <at> fastmail.com>:

> Catonano <catonano <at> gmail.com> writes:
>
> > 2017-03-12 19:40 GMT+01:00 Catonano <catonano <at> gmail.com>:
> >
> >> Marius,
> >>
> >> thank you for reviewing !
> >>
> >
> > I'm almost ready.
> >
> > The only problem now is that python-flask-logins tests fail
> >
> > starting phase `check'
> > running "python setup.py" with command "test" and parameters ()
> > Checking pep8 compliance...
> > flask_login/login_manager.py:409:29: E122 continuation line missing
> > indentation or outdented
> > make: *** [Makefile:23: pep8] Error 1
> > phase `check' failed after 1.5 seconds
> >
> >
> > I don't know what pep8 compliance is, it seems something similar to Guix
> > linting for packages
>
> Yes, it's purely a style checker. Note that the "pep8" package has been
> deprecated for "python-pycodestyle". Can you see if that works? If not,
> we can probably skip those tests.
>

I tried with pycodestyle but it claims that the pep8 command can't be found.
So I got it rolled back


>
> Thanks for working on it! Can you also add a copyright line with one of
> the commits? Pseudonyms are fine :-)
>

Sorry, I forgot :-/

I added a line for the copyright in a single commit so now they are 4
patches

Thanks for reviewing !

[Message part 2 (text/html, inline)]

[series.patch (text/x-patch, attachment)]

Message #34 received at 26074-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Catonano <catonano <at> gmail.com>
Cc: 26074-done <at> debbugs.gnu.org
Subject: Re: bug#26074: [PATCH 1/3] gnu: Add python-htmlmin
Date: Mon, 13 Mar 2017 19:50:22 +0100

[Message part 1 (text/plain, inline)]

Catonano <catonano <at> gmail.com> writes:

> 2017-03-13 17:22 GMT+01:00 Marius Bakke <mbakke <at> fastmail.com>:
>
>> Catonano <catonano <at> gmail.com> writes:
>>
>> > 2017-03-12 19:40 GMT+01:00 Catonano <catonano <at> gmail.com>:
>> >
>> >> Marius,
>> >>
>> >> thank you for reviewing !
>> >>
>> >
>> > I'm almost ready.
>> >
>> > The only problem now is that python-flask-logins tests fail
>> >
>> > starting phase `check'
>> > running "python setup.py" with command "test" and parameters ()
>> > Checking pep8 compliance...
>> > flask_login/login_manager.py:409:29: E122 continuation line missing
>> > indentation or outdented
>> > make: *** [Makefile:23: pep8] Error 1
>> > phase `check' failed after 1.5 seconds
>> >
>> >
>> > I don't know what pep8 compliance is, it seems something similar to Guix
>> > linting for packages
>>
>> Yes, it's purely a style checker. Note that the "pep8" package has been
>> deprecated for "python-pycodestyle". Can you see if that works? If not,
>> we can probably skip those tests.
>>
>
> I tried with pycodestyle but it claims that the pep8 command can't be found.
> So I got it rolled back
>
>
>>
>> Thanks for working on it! Can you also add a copyright line with one of
>> the commits? Pseudonyms are fine :-)
>>
>
> Sorry, I forgot :-/
>
> I added a line for the copyright in a single commit so now they are 4
> patches

Thanks!

I changed the commit messages to match what we usually do for Python
packages. Also did minor edits to synopses and descriptions to please
`guix lint` and be slightly more user friendly (mostly copy-paste of
upstream descriptions), and changed the PEP8 comment to mention the bug
report you opened.

Also squashed the copyright commit into the first one. Pushed!

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 26074-done <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26074-done <at> debbugs.gnu.org
Subject: Re: bug#26074: [PATCH 1/3] gnu: Add python-htmlmin
Date: Mon, 13 Mar 2017 20:19:59 +0100

[Message part 1 (text/plain, inline)]

2017-03-13 19:50 GMT+01:00 Marius Bakke <mbakke <at> fastmail.com>:

>
> Thanks!
>
> I changed the commit messages to match what we usually do for Python
> packages. Also did minor edits to synopses and descriptions to please
> `guix lint` and be slightly more user friendly (mostly copy-paste of
> upstream descriptions), and changed the PEP8 comment to mention the bug
> report you opened.
>
> Also squashed the copyright commit into the first one. Pushed!
>

About your corrections: notes taken !
Thank you Marius !

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.