Subject: bug#26072: closed (Re: bug#26072: [PATCH 35/35] gnu: Add r-seurat.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 16 Mar 2017 13:08:02 +0000

Your bug report

#26072: [PATCH 35/35] gnu: Add r-seurat.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
26072: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26072
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#26072: [PATCH 35/35] gnu: Add r-seurat.
From: Ricardo Wurmus <[email-masked]>
To: Ben Woodcroft <[email-masked]>
Cc: [email-masked], [email-masked], [email-masked]
Date: Thu, 16 Mar 2017 14:07:39 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

> Seurat seems to have it's last release as v1.4.0, and the usual
> approach would be to package that release. Is there some reason why a
> specific commit was used?

The latest version is 1.4.0.12, which appears to be 8 commits after the
commit selected for this patch.  The downloadable archive, however, does
not contain the sources.

The source archive for version 1.4.0 is from Oct 4, 2016.  The selected
commit probably was the latest version at the time.

I’ll add a comment to the top of this package expression and update the
commit to fccb77d, which is equivalent to the binary release 1.4.0.12.

Thanks for the patches, and thank you Ben for the review! 

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Subject: Re: [PATCH 35/35] gnu: Add r-seurat.
From: Ben Woodcroft <[email-masked]>
To: Raoul Bonnal <[email-masked]>, [email-masked], [email-masked]
Date: Sun, 12 Mar 2017 21:42:58 +1000
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Raoul,

On 20/01/17 04:55, Raoul Bonnal wrote:
> +
> +(define-public r-seurat
> +  (let ((commit "e1eae2da82ada2211e84fbc471615e8d3921b539"))
> +    (package
> +      (name "r-seurat")
> +      (version (string-append "1.4." (string-take commit 7)))
Apologies for the long delay on getting these recipes reviewed. I've 
pushed the rest of them to master now after some minor changes, patch 
reordering and updating, except for this final one.

Seurat seems to have it's last release as v1.4.0, and the usual approach 
would be to package that release. Is there some reason why a specific 
commit was used?

Thanks, ben.