From unknown Fri Jun 20 19:57:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26072: [PATCH 35/35] gnu: Add r-seurat. Resent-From: Ben Woodcroft Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Mar 2017 11:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 26072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ilpuccio.febo@gmail.com, guix-devel@gnu.org, 26072@debbugs.gnu.org X-Debbugs-Original-To: Raoul Bonnal , guix-devel@gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14893190052881 (code B ref -1); Sun, 12 Mar 2017 11:44:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Mar 2017 11:43:25 +0000 Received: from localhost ([127.0.0.1]:52012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn1uH-0000kO-Jy for submit@debbugs.gnu.org; Sun, 12 Mar 2017 07:43:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn1uF-0000k9-HG for submit@debbugs.gnu.org; Sun, 12 Mar 2017 07:43:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cn1u9-0002Tn-GQ for submit@debbugs.gnu.org; Sun, 12 Mar 2017 07:43:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43401) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cn1u9-0002TX-DC for submit@debbugs.gnu.org; Sun, 12 Mar 2017 07:43:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cn1u8-0007Fs-6M for guix-patches@gnu.org; Sun, 12 Mar 2017 07:43:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cn1u1-0002P7-Hw for guix-patches@gnu.org; Sun, 12 Mar 2017 07:43:16 -0400 Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:56599 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cn1u0-0002Oo-VL; Sun, 12 Mar 2017 07:43:09 -0400 Received: from smtp2.soe.uq.edu.au (smtp2.soe.uq.edu.au [10.138.113.41]) by newmailhub.uq.edu.au (8.14.5/8.14.5) with ESMTP id v2CBh10Z013251; Sun, 12 Mar 2017 21:43:01 +1000 Received: from [192.168.1.105] (static.customers.nuskope.com.au [103.25.181.216] (may be forged)) (authenticated bits=0) by smtp2.soe.uq.edu.au (8.14.5/8.14.5) with ESMTP id v2CBgxAl023147 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 12 Mar 2017 21:43:00 +1000 References: <20170119185530.35824-1-ilpuccio.febo@gmail.com> <20170119185530.35824-35-ilpuccio.febo@gmail.com> From: Ben Woodcroft Message-ID: <14cac63b-88fb-5edb-e8cc-87f515ba5881@uq.edu.au> Date: Sun, 12 Mar 2017 21:42:58 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170119185530.35824-35-ilpuccio.febo@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-UQ-FilterTime: 1489318982 X-Scanned-By: MIMEDefang 2.73 on UQ Mailhub X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi Raoul, On 20/01/17 04:55, Raoul Bonnal wrote: > + > +(define-public r-seurat > + (let ((commit "e1eae2da82ada2211e84fbc471615e8d3921b539")) > + (package > + (name "r-seurat") > + (version (string-append "1.4." (string-take commit 7))) Apologies for the long delay on getting these recipes reviewed. I've pushed the rest of them to master now after some minor changes, patch reordering and updating, except for this final one. Seurat seems to have it's last release as v1.4.0, and the usual approach would be to package that release. Is there some reason why a specific commit was used? Thanks, ben. From unknown Fri Jun 20 19:57:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ben Woodcroft Subject: bug#26072: closed (Re: bug#26072: [PATCH 35/35] gnu: Add r-seurat.) Message-ID: References: <87r31xv084.fsf@elephly.net> <14cac63b-88fb-5edb-e8cc-87f515ba5881@uq.edu.au> X-Gnu-PR-Message: they-closed 26072 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 26072@debbugs.gnu.org Date: Thu, 16 Mar 2017 13:08:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1489669682-19006-1" This is a multi-part message in MIME format... ------------=_1489669682-19006-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #26072: [PATCH 35/35] gnu: Add r-seurat. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 26072@debbugs.gnu.org. --=20 26072: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26072 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1489669682-19006-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 26072-done) by debbugs.gnu.org; 16 Mar 2017 13:07:48 +0000 Received: from localhost ([127.0.0.1]:58174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coV88-0004w8-0x for submit@debbugs.gnu.org; Thu, 16 Mar 2017 09:07:48 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coV86-0004vx-9O for 26072-done@debbugs.gnu.org; Thu, 16 Mar 2017 09:07:47 -0400 Received: from localhost (141.80.148.144 [141.80.148.144]) by mx.zohomail.com with SMTPS id 1489669660276132.5592187581202; Thu, 16 Mar 2017 06:07:40 -0700 (PDT) References: <20170119185530.35824-1-ilpuccio.febo@gmail.com> <20170119185530.35824-35-ilpuccio.febo@gmail.com> <14cac63b-88fb-5edb-e8cc-87f515ba5881@uq.edu.au> User-agent: mu4e 0.9.18; emacs 25.1.1 From: Ricardo Wurmus To: Ben Woodcroft Subject: Re: bug#26072: [PATCH 35/35] gnu: Add r-seurat. In-reply-to: <14cac63b-88fb-5edb-e8cc-87f515ba5881@uq.edu.au> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 16 Mar 2017 14:07:39 +0100 Message-ID: <87r31xv084.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 26072-done Cc: guix-devel@gnu.org, 26072-done@debbugs.gnu.org, ilpuccio.febo@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) > Seurat seems to have it's last release as v1.4.0, and the usual > approach would be to package that release. Is there some reason why a > specific commit was used? The latest version is 1.4.0.12, which appears to be 8 commits after the commit selected for this patch. The downloadable archive, however, does not contain the sources. The source archive for version 1.4.0 is from Oct 4, 2016. The selected commit probably was the latest version at the time. I’ll add a comment to the top of this package expression and update the commit to fccb77d, which is equivalent to the binary release 1.4.0.12. Thanks for the patches, and thank you Ben for the review! -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net ------------=_1489669682-19006-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Mar 2017 11:43:25 +0000 Received: from localhost ([127.0.0.1]:52012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn1uH-0000kO-Jy for submit@debbugs.gnu.org; Sun, 12 Mar 2017 07:43:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn1uF-0000k9-HG for submit@debbugs.gnu.org; Sun, 12 Mar 2017 07:43:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cn1u9-0002Tn-GQ for submit@debbugs.gnu.org; Sun, 12 Mar 2017 07:43:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43401) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cn1u9-0002TX-DC for submit@debbugs.gnu.org; Sun, 12 Mar 2017 07:43:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cn1u8-0007Fs-6M for guix-patches@gnu.org; Sun, 12 Mar 2017 07:43:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cn1u1-0002P7-Hw for guix-patches@gnu.org; Sun, 12 Mar 2017 07:43:16 -0400 Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:56599 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cn1u0-0002Oo-VL; Sun, 12 Mar 2017 07:43:09 -0400 Received: from smtp2.soe.uq.edu.au (smtp2.soe.uq.edu.au [10.138.113.41]) by newmailhub.uq.edu.au (8.14.5/8.14.5) with ESMTP id v2CBh10Z013251; Sun, 12 Mar 2017 21:43:01 +1000 Received: from [192.168.1.105] (static.customers.nuskope.com.au [103.25.181.216] (may be forged)) (authenticated bits=0) by smtp2.soe.uq.edu.au (8.14.5/8.14.5) with ESMTP id v2CBgxAl023147 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 12 Mar 2017 21:43:00 +1000 Subject: Re: [PATCH 35/35] gnu: Add r-seurat. To: Raoul Bonnal , guix-devel@gnu.org, guix-patches@gnu.org References: <20170119185530.35824-1-ilpuccio.febo@gmail.com> <20170119185530.35824-35-ilpuccio.febo@gmail.com> From: Ben Woodcroft Message-ID: <14cac63b-88fb-5edb-e8cc-87f515ba5881@uq.edu.au> Date: Sun, 12 Mar 2017 21:42:58 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170119185530.35824-35-ilpuccio.febo@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-UQ-FilterTime: 1489318982 X-Scanned-By: MIMEDefang 2.73 on UQ Mailhub X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi Raoul, On 20/01/17 04:55, Raoul Bonnal wrote: > + > +(define-public r-seurat > + (let ((commit "e1eae2da82ada2211e84fbc471615e8d3921b539")) > + (package > + (name "r-seurat") > + (version (string-append "1.4." (string-take commit 7))) Apologies for the long delay on getting these recipes reviewed. I've pushed the rest of them to master now after some minor changes, patch reordering and updating, except for this final one. Seurat seems to have it's last release as v1.4.0, and the usual approach would be to package that release. Is there some reason why a specific commit was used? Thanks, ben. ------------=_1489669682-19006-1-- From unknown Fri Jun 20 19:57:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26072: [PATCH 35/35] gnu: Add r-seurat. Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Mar 2017 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ben Woodcroft Cc: guix-devel@gnu.org, 26072-done@debbugs.gnu.org, ilpuccio.febo@gmail.com Received: via spool by 26072-done@debbugs.gnu.org id=D26072.148967366626030 (code D ref 26072); Thu, 16 Mar 2017 14:15:02 +0000 Received: (at 26072-done) by debbugs.gnu.org; 16 Mar 2017 14:14:26 +0000 Received: from localhost ([127.0.0.1]:58989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coWAc-0006lm-Gx for submit@debbugs.gnu.org; Thu, 16 Mar 2017 10:14:26 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coWAa-0006ld-JU for 26072-done@debbugs.gnu.org; Thu, 16 Mar 2017 10:14:25 -0400 Received: from localhost (141.80.148.144 [141.80.148.144]) by mx.zohomail.com with SMTPS id 1489673659326375.6647399120119; Thu, 16 Mar 2017 07:14:19 -0700 (PDT) References: <20170119185530.35824-1-ilpuccio.febo@gmail.com> <20170119185530.35824-35-ilpuccio.febo@gmail.com> <14cac63b-88fb-5edb-e8cc-87f515ba5881@uq.edu.au> <87r31xv084.fsf@elephly.net> User-agent: mu4e 0.9.18; emacs 25.1.1 From: Ricardo Wurmus In-reply-to: <87r31xv084.fsf@elephly.net> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 16 Mar 2017 15:14:18 +0100 Message-ID: <87shmdia11.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.8 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Ricardo Wurmus writes: > I’ll add a comment to the top of this package expression and update the > commit to fccb77d, which is equivalent to the binary release 1.4.0.12. I also deleted the bundled jar and added a build phase to build it from source. It’s now in master: 2441c284140ddbd354b61c9d1606af1357f95c1f. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net