From unknown Thu Jun 19 14:03:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#26070 <26070@debbugs.gnu.org> To: bug#26070 <26070@debbugs.gnu.org> Subject: Status: 26.0.50; js-mode slash insertion bug Reply-To: bug#26070 <26070@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:03:29 +0000 retitle 26070 26.0.50; js-mode slash insertion bug reassign 26070 emacs submitter 26070 Richard Copley severity 26070 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 12 06:24:12 2017 Received: (at submit) by debbugs.gnu.org; 12 Mar 2017 10:24:12 +0000 Received: from localhost ([127.0.0.1]:51982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn0fb-0005W7-Lc for submit@debbugs.gnu.org; Sun, 12 Mar 2017 06:24:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn0fa-0005Vt-Fs for submit@debbugs.gnu.org; Sun, 12 Mar 2017 06:24:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cn0fT-0005i3-Th for submit@debbugs.gnu.org; Sun, 12 Mar 2017 06:24:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43730) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cn0fT-0005ht-QP for submit@debbugs.gnu.org; Sun, 12 Mar 2017 06:24:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cn0fS-00050S-HL for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2017 06:24:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cn0fR-0005fw-CA for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2017 06:24:02 -0400 Received: from mail-ua0-x230.google.com ([2607:f8b0:400c:c08::230]:36050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cn0fR-0005fP-7S for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2017 06:24:01 -0400 Received: by mail-ua0-x230.google.com with SMTP id 72so139739979uaf.3 for ; Sun, 12 Mar 2017 03:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=Lwvzdrr2FJyfiamCXbguvXLMJ2TKv4VtFa3iZIekkHU=; b=nyfQX0Z6d74vfINp+aEOyAxsUHQFoHrR4wA/tkPiuyricjMpHg4N1LmExdWRRkm39R 5irYVOXNUxX+8EMDc8lz/DQCeK2kz8k0Nls7JGJI5falSMxoecECJQvoY4Bv8/gIo+C8 83bLQsC2oaVzu7I4mJtBXOe2C510oqjZGjfBE2uftp4hIf8GnzQrl0M2rB3Tc22X9Wgv URrlESGG+iAeDu5OdmliqFMswyzJ5XVt48GhQsb5ycXdcu+ifWiuIGqd4wcfKpNzRNwx QOztBNTcLtzg5dBgDJtuckl7ha+aUnVeSgYitdVaIC2SpHkWVHMyHIJHYWD75+gbVYlQ BzSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Lwvzdrr2FJyfiamCXbguvXLMJ2TKv4VtFa3iZIekkHU=; b=WbEHC6pEUwWhuy/YNoiu8x+VTZe5HvD9Gtf6Mv9rCX9BWDhv/jtFw7HlIhWYvWobXT VcXrLvWkCanXE51XoNHqd/R9QM4PK36wx//ZEBHKUInwcWRd3CLIPHIu+Vx8D0OPLuxf +zHNPOrgj+IIcjU15uKYAFckKaM5/rGnaZh8Kjpd332aV2uofUHyzZLNyHlQ/3BUnb4/ D5+7vSDIyqDHUzf4XtmNwkYgAwQgwgnVIKyuSTU25cnIKHZB0iPC1n4EGOE7kZ/h9dlm nmMHUwy+JbL1jwT5/D8nt/ifGFKTAuegIi66FVGIYJL3ft+/d/NXkTpKjsSKlDHzL9Fp vapQ== X-Gm-Message-State: AMke39lvRJrKpsdwWwqnFXZHu2g1gQ2kIAZHP1RyaDRr9I8EQfZnt0q0OwC2B7FRUtTRKLIvtFZUXvlHLhiy8w== X-Received: by 10.176.82.8 with SMTP id i8mr12101448uaa.77.1489314238938; Sun, 12 Mar 2017 03:23:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.71.214 with HTTP; Sun, 12 Mar 2017 03:23:28 -0700 (PDT) From: Richard Copley Date: Sun, 12 Mar 2017 10:23:28 +0000 Message-ID: Subject: 26.0.50; js-mode slash insertion bug To: "bug-gnu-emacs@gnu.org" , tom@tromey.com Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) After inserting a slash before other text in a js-mode buffer, typing more characters has no effect, until you type C-g to quit. Recipe to reproduce from 'emacs -Q': M-x js-mode RET x ;; inserts "x" C-b ;; backward char / ;; inserts "/" x ;; --- no effect! --- C-g ;; quit I couldn't see what code is running, because C-g doesn't enter the debugger in this situation even when debug-on-quit is true, but I bisected it to this commit: commit 862d6438cfa6c6c035033697751f3d002357b024 Author: Tom Tromey Date: Sun Feb 5 11:40:18 2017 -0700 Recognize JS regexp literals more correctly In GNU Emacs 26.0.50 (build 6, x86_64-w64-mingw32) of 2017-03-12 built on MACHINE Repository revision: 026c2cbf354fab138a65ad7093f17fbb23edb23c Windowing system distributor 'Microsoft Corp.', version 10.0.14393 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --prefix=/mingw64 --with-modules --enable-locallisppath=/c/emacs/site-lisp 'CFLAGS=-O0 -g -ggdb'' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS MODULES Important settings: value of $LANG: ENG locale-coding-system: cp1252 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message puny seq byte-opt subr-x gv bytecomp byte-compile cl-extra help-mode cconv cl-loaddefs pcase cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote w32notify dbusbind w32 multi-tty make-network-process emacs) Memory information: ((conses 16 99056 6862) (symbols 56 20091 1) (miscs 48 48 87) (strings 32 19084 4910) (string-bytes 1 584358) (vectors 16 14743) (vector-slots 8 478865 4018) (floats 8 54 62) (intervals 56 230 0) (buffers 976 11)) From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 09:51:53 2017 Received: (at submit) by debbugs.gnu.org; 13 Mar 2017 13:51:54 +0000 Received: from localhost ([127.0.0.1]:53366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnQO7-0006hP-5G for submit@debbugs.gnu.org; Mon, 13 Mar 2017 09:51:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnQO5-0006hD-CD for submit@debbugs.gnu.org; Mon, 13 Mar 2017 09:51:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnQNz-0007WT-6l for submit@debbugs.gnu.org; Mon, 13 Mar 2017 09:51:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51383) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cnQNz-0007WN-3Y for submit@debbugs.gnu.org; Mon, 13 Mar 2017 09:51:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnQNx-00038g-Op for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2017 09:51:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnQNt-0007QD-Q1 for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2017 09:51:41 -0400 Received: from gproxy2-pub.mail.unifiedlayer.com ([69.89.18.3]:39387) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1cnQNt-0007AY-BE for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2017 09:51:37 -0400 Received: (qmail 16478 invoked by uid 0); 13 Mar 2017 13:51:06 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy2.mail.unifiedlayer.com with SMTP; 13 Mar 2017 13:51:06 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id vRr21u00v2f2jeq01Rr5G8; Mon, 13 Mar 2017 07:51:06 -0600 X-Authority-Analysis: v=2.1 cv=Ath9goNP c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=6Iz7jQTuP9IA:10 a=7vox6WFfMepEhlYO6NgA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5GkDMrFwB5DJRolUxabHTeHa6ON1JQpKwNAqXD7P3H8=; b=wvvoGOVsqbQ1IvzKl4GVRiEV/r UygusOhVKDAZt2kM2uZPFn0x83Zo1p65tlJRmeRH0lnpkLn5tF3/tYmnIfcHwUAp5QTYf+te238uV FLFjThTG8ABU0UEJlkwe0Kqjy; Received: from [89.202.203.52] (port=1737 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cnQNJ-0000Bi-D7; Mon, 13 Mar 2017 07:51:02 -0600 From: Tom Tromey To: Richard Copley Subject: Re: 26.0.50; js-mode slash insertion bug References: X-Attribution: Tom Date: Mon, 13 Mar 2017 14:50:56 +0100 In-Reply-To: (Richard Copley's message of "Sun, 12 Mar 2017 10:23:28 +0000") Message-ID: <87wpbt8ev3.fsf@pokyo> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 89.202.203.52 X-Exim-ID: 1cnQNJ-0000Bi-D7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (pokyo) [89.202.203.52]:1737 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: "bug-gnu-emacs@gnu.org" , tom@tromey.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Richard> I couldn't see what code is running, because C-g doesn't enter the Richard> debugger in this situation even when debug-on-quit is true, but I Richard> bisected it to this commit: Thanks for finding this and bisecting it. At first I thought the problem was that the regexp literal matching code in js-syntax-propertize should leave point after the construct. However, the call to js-syntax-propertize really ought to do that... but this code is always requiring the trailing "/", which is what is going wrong. I think once js-syntax-propertize is called, the regexp should always succeed, so this patch makes the trailing "/" optional. Can you try this and let me know if it works for you? Tom diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index 84c9111..fa865db 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -1714,7 +1714,7 @@ js--syntax-propertize-regexp-regexp (not (any ?\] ?\\)) (and "\\" not-newline))) "]"))) - (group "/")) + (group (zero-or-one "/"))) "Regular expression matching a JavaScript regexp literal.") (defun js-syntax-propertize-regexp (end) @@ -1724,8 +1724,8 @@ js-syntax-propertize-regexp (goto-char (nth 8 ppss)) (when (and (looking-at js--syntax-propertize-regexp-regexp) ;; Don't touch text after END. - (<= (match-end 1) end)) - (put-text-property (match-beginning 1) (match-end 1) + (or (not (match-end 1)) (<= (match-end 1) end))) + (put-text-property (match-beginning 1) (or (match-end 1) (match-end 0)) 'syntax-table (string-to-syntax "\"/")) (goto-char (match-end 0)))))) From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 15:13:13 2017 Received: (at submit) by debbugs.gnu.org; 13 Mar 2017 19:13:13 +0000 Received: from localhost ([127.0.0.1]:54300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnVP6-0006K6-Qv for submit@debbugs.gnu.org; Mon, 13 Mar 2017 15:13:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnVP5-0006Jt-59 for submit@debbugs.gnu.org; Mon, 13 Mar 2017 15:13:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnVOz-0007Pt-Dp for submit@debbugs.gnu.org; Mon, 13 Mar 2017 15:13:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59021) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cnVOz-0007Pp-As for submit@debbugs.gnu.org; Mon, 13 Mar 2017 15:13:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnVOy-00074A-Fp for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2017 15:13:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnVOx-0007Pd-Op for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2017 15:13:04 -0400 Received: from mail-ua0-x22c.google.com ([2607:f8b0:400c:c08::22c]:35882) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cnVOx-0007PT-Kj for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2017 15:13:03 -0400 Received: by mail-ua0-x22c.google.com with SMTP id 72so157787356uaf.3 for ; Mon, 13 Mar 2017 12:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=p7HziaRt+QzLDgpKUJsdAruWeXDxuasH9pd5mzOSHjk=; b=pWECI6UpiqqO1TsUwet9jrEwT6may++408lrY4OiuvbAPv4Ja6BLiDEzFWTuGnGHkm rBAboBZemtxFzcOCsQ6uiMnMoCZ1+HiAEsMaNh3tiJGIj5o6Tpi7RKILCTYhQCrzvrG4 0S/iNOXViwTaMJo4alEdpWTRCl2HAV3+zZQg6RdsXU/7VBG0QXoTNXBxD+ptbuiWerLW dyC+SGEyA9cpHlIwkQxmpa9j9XgVyFfbAJZv0ZPmxuuO5p/Yj1+9GfLfY00P7C/Woxj0 SWvimNE1SbXDispzDurVIAEecNWpS+2aBZVQWEWQKV3LOeLe7iOzAE4xvWZZiSRvD2ud ajyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=p7HziaRt+QzLDgpKUJsdAruWeXDxuasH9pd5mzOSHjk=; b=s1za9QHf5+xzPfeLJPLHMxuUzu7UOP/dvL3YTKGy0krcWIUITaXWlo/8QT4ulAJ5VR HCpaK6OLpnWwYfA7ukLNIBBXmHGvb0ymQPUUWwvoouzS8i35c5dF9hSKMkWof9Co8aCO rudL85YrYmZnElfPuAwjTWEE0H8Cnt6J3TETyfhRQKqRf5H9blV3IOwbQmzaXf08nGeo ntiLeccfWGP67OWJ+3Aay15LDlZRJ9dcTLxKttEqUZAufF/x0w0e4DpbtSyA1rll/hVx oW/GMcGw2JMQoG3udpzXhIZTS/SaF9MMUuKyp/2zpIiD10i5vpU96ff0u2MxbKXiSh/y R9pg== X-Gm-Message-State: AMke39mqA+idEAQOu66vBe3eBl2uHaHumhtPLr6s1UkQTiR+FfAYoo0pReYXxYjAR9bHRPyVYlUGOVXt6ryxAg== X-Received: by 10.159.48.147 with SMTP id j19mr16733844uab.6.1489432381551; Mon, 13 Mar 2017 12:13:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.71.214 with HTTP; Mon, 13 Mar 2017 12:12:31 -0700 (PDT) In-Reply-To: <87wpbt8ev3.fsf@pokyo> References: <87wpbt8ev3.fsf@pokyo> From: Richard Copley Date: Mon, 13 Mar 2017 19:12:31 +0000 Message-ID: Subject: Re: 26.0.50; js-mode slash insertion bug To: Tom Tromey Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: "bug-gnu-emacs@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) > Can you try this and let me know if it works for you? Thanks! I had a very quick play around and it seems to work. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 14 01:56:46 2017 Received: (at 26070) by debbugs.gnu.org; 14 Mar 2017 05:56:46 +0000 Received: from localhost ([127.0.0.1]:54648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnfRu-00058h-Lb for submit@debbugs.gnu.org; Tue, 14 Mar 2017 01:56:46 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnfRs-00058U-D0 for 26070@debbugs.gnu.org; Tue, 14 Mar 2017 01:56:44 -0400 Received: by mail-wm0-f68.google.com with SMTP id z63so13048244wmg.2 for <26070@debbugs.gnu.org>; Mon, 13 Mar 2017 22:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4KWu7fjsCJqCN90GYPjsCB8KfsY+afJXFksPnsE3ilo=; b=qZYLtvkJSfLnYQTwUOiD1uYAYiC1Z8XhOvRmvF9Rm2LbgRbrjlK5HjFH5sAYjBQkJg EWAbQvXDbikz5bPLzXtmmO5peymT2cjYcP6bn+1yCG0tVglIXVQGBkvHnPWxnt5HPsRX yQr+kO+sthKcGyJEo6Fp1wgcdXFI7LARpZz3VvxSL6122v11SuyxNBYQE4bqi0HLp4Q4 poDrWcHullfsBIQFPn7Zs0U1xe1G9NmhlSWuAm6z+urIdCTlXSOkpQ84SAcE+JtX0Zha hWP2F7y3tL6P7nyvFFPoGjFsKTtWM1vXVArlzU9V+xgl36vVnhMqZmOMaQ6xqGT+TYnr J8nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4KWu7fjsCJqCN90GYPjsCB8KfsY+afJXFksPnsE3ilo=; b=YuICNhquD2ICVwuZ/pZofge7Afu0P9yguJXm4hO1PMC4D93XPaubi2UcVD9l9oi6NG uFSwZ6rceIEAowxNX8mm16REqu3PCS2WX4yZKGQQ31GFTMqARqunWYakY0gn47FHB9G9 R3ZUGqkTZUliAL96STdPBkdRujU5lgpyanEb4eaKoZ2vX6XdEqQTAYWjQFzGIzZnZ1ij Woqgwe+ZMwtG6alNhA94HX6VfdZbzEU3toq+Ma5hnlY1E6ViMRhlnisIw+Y5xatf7iSq TTA+FhJc4XzmWRL8nvq4tFOROuzd9cVE7BcvPkUUzrU6cPUs9GHysIkQn591BmE42T13 CM7w== X-Gm-Message-State: AFeK/H28t4yOH4AJxKCLH6EQ4PJXN3rKuEEH+dEqFUr0oZeAozalQtbUf47QAQk6m4Qi/g== X-Received: by 10.28.94.2 with SMTP id s2mr11951599wmb.127.1489470998420; Mon, 13 Mar 2017 22:56:38 -0700 (PDT) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id l41sm27602521wre.23.2017.03.13.22.56.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Mar 2017 22:56:37 -0700 (PDT) Subject: Re: bug#26070: 26.0.50; js-mode slash insertion bug To: Tom Tromey , Richard Copley References: <87wpbt8ev3.fsf@pokyo> From: Dmitry Gutov Message-ID: Date: Tue, 14 Mar 2017 07:56:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <87wpbt8ev3.fsf@pokyo> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 26070 Cc: 26070@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On 13.03.2017 15:50, Tom Tromey wrote: > I think once js-syntax-propertize is called, the regexp should always > succeed, so this patch makes the trailing "/" optional. Does it solve the infloop in the case like: /x[ as well? If not, I think the following is a better patch (could use some tweaking, probably): diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index aed42a8..d9e6ef3 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -1721,12 +1721,14 @@ js-syntax-propertize-regexp (when (eq (nth 3 ppss) ?/) ;; A /.../ regexp. (goto-char (nth 8 ppss)) - (when (and (looking-at js--syntax-propertize-regexp-regexp) - ;; Don't touch text after END. - (<= (match-end 1) end)) - (put-text-property (match-beginning 1) (match-end 1) - 'syntax-table (string-to-syntax "\"/")) - (goto-char (match-end 0)))))) + (if (and (looking-at js--syntax-propertize-regexp-regexp) + ;; Don't touch text after END. + (<= (match-end 1) end)) + (progn + (put-text-property (match-beginning 1) (match-end 1) + 'syntax-table (string-to-syntax "\"/")) + (goto-char (match-end 0))) + (goto-char (1+ (match-beginning 0))))))) (defun js-syntax-propertize (start end) ;; JavaScript allows immediate regular expression objects, written /.../. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 14 07:06:25 2017 Received: (at 26070) by debbugs.gnu.org; 14 Mar 2017 11:06:25 +0000 Received: from localhost ([127.0.0.1]:54876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnkHY-00018d-Tt for submit@debbugs.gnu.org; Tue, 14 Mar 2017 07:06:25 -0400 Received: from gproxy2-pub.mail.unifiedlayer.com ([69.89.18.3]:41738) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cnkHW-00018O-OF for 26070@debbugs.gnu.org; Tue, 14 Mar 2017 07:06:23 -0400 Received: (qmail 23040 invoked by uid 0); 14 Mar 2017 11:06:14 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy2.mail.unifiedlayer.com with SMTP; 14 Mar 2017 11:06:14 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id vn691u01H2f2jeq01n6CtJ; Tue, 14 Mar 2017 05:06:14 -0600 X-Authority-Analysis: v=2.1 cv=R4+QR7hX c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=6Iz7jQTuP9IA:10 a=vaJtXVxTAAAA:8 a=b2b5UPML6h4R81YIn78A:9 a=hCt-GehETBxEYQOojhlW:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cre9tHKxSVWquT7xU7Zhqc42gbed+o9HNciBluMoDyg=; b=ypKOQJPAICe7NMhmbwnW8cKj5f hCkhBmhBNYEPMZx9/QzBEORSrjsq9TuC1S0f4QR4YDiFaagYGb3lf0J4NhbLGjrpFmc1YivGJwyNl mfaMJrAaNg7h5rk5HkvxGlcYj; Received: from [89.202.203.52] (port=26241 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cnkHJ-0007GT-4z; Tue, 14 Mar 2017 05:06:09 -0600 From: Tom Tromey To: Dmitry Gutov Subject: Re: bug#26070: 26.0.50; js-mode slash insertion bug References: <87wpbt8ev3.fsf@pokyo> X-Attribution: Tom Date: Tue, 14 Mar 2017 12:06:02 +0100 In-Reply-To: (Dmitry Gutov's message of "Tue, 14 Mar 2017 07:56:35 +0200") Message-ID: <87fuig86ed.fsf@pokyo> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 89.202.203.52 X-Exim-ID: 1cnkHJ-0007GT-4z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (pokyo) [89.202.203.52]:26241 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26070 Cc: Richard Copley , 26070@debbugs.gnu.org, Tom Tromey X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) >>>>> "Dmitry" == Dmitry Gutov writes: >> I think once js-syntax-propertize is called, the regexp should always >> succeed, so this patch makes the trailing "/" optional. Dmitry> Does it solve the infloop in the case like: Dmitry> /x[ Dmitry> as well? Yes, with the patch I don't get an infloop no matter which way I insert those characters. Tom From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 07:23:11 2017 Received: (at 26070) by debbugs.gnu.org; 19 Mar 2017 11:23:11 +0000 Received: from localhost ([127.0.0.1]:34587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpYvX-00060O-17 for submit@debbugs.gnu.org; Sun, 19 Mar 2017 07:23:11 -0400 Received: from mail-ua0-f171.google.com ([209.85.217.171]:35025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpYvU-00060A-86 for 26070@debbugs.gnu.org; Sun, 19 Mar 2017 07:23:09 -0400 Received: by mail-ua0-f171.google.com with SMTP id q7so63595625uaf.2 for <26070@debbugs.gnu.org>; Sun, 19 Mar 2017 04:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MikGyCiYPuNcN8wmdtL3wrziS2azup1UvuCLgEELc+Y=; b=fqpFqRTtwK3Svc6blSorAUNqx/h/a6r6oy0UD42PkT230kJ2KG8/iz7Wawh0QGAi3G h3QnGk+JxKafMdCLHOetJj3IbPbXeD0YQ7MjPGF+MnI8JbNQk4yLSnzEhg3CTE2acQHt IPYb5rAs5/DQE25s4gP+Z3kBYXQLQdoRZvURyCgHn5bE0wIbqdqo2tMc2puCzbp4+lur aKjHS0wlTJi2T30RmAgVU0XsvXuCrnp/WPE5F1MwuEqD2lbKIctlscYzOuZZwcDiF6nk DoQQsFWaHHmEDR2GDI0DjvzkpXMcvZjD3Fiy48fw9VVbjLlSBJst5oUR4Wm3sWs5knep gaVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MikGyCiYPuNcN8wmdtL3wrziS2azup1UvuCLgEELc+Y=; b=s03ebE3S6EkjaLO9AJ90nQUUeySNAQGcugrasDe2t/WfzrK1/FwN2uT9TkFjBUFQFC J1ITii5080Jxm6vB1fGi4Vxba3UVmvJUU7Lweg/Jlzuu6UjupnXVmCdeSAo6Z4poJx17 pkKdkN8eAokacDB4C6qrCyznwg24xJ4RxlnNN/0EHBQ96GO8uivUEHmAXx7Asklj3qAB UgdGud4y1SVCc0zKZ1B67KwZ2+JwDYnHhZQ7HY/bcU55Xh7ZGy6tkt672F2LfHTofvng InmnRAcUnMf3wvYccJVqN4kMMeJAMlL6oZEtUcsz1kKsV7ajippUQHe5BKnkKEGnY3wZ Zocw== X-Gm-Message-State: AFeK/H3fvsaUgWMSu72HpoCcK8AVw/rqL1NH1sWg5YxdI9k2fGze0i3LglKdO9LTNhSmhrRisSLJnLTk3k6sFw== X-Received: by 10.176.85.26 with SMTP id t26mr8295108uaa.7.1489922582516; Sun, 19 Mar 2017 04:23:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.71.214 with HTTP; Sun, 19 Mar 2017 04:22:32 -0700 (PDT) In-Reply-To: <87fuig86ed.fsf@pokyo> References: <87wpbt8ev3.fsf@pokyo> <87fuig86ed.fsf@pokyo> From: Richard Copley Date: Sun, 19 Mar 2017 11:22:32 +0000 Message-ID: Subject: Re: bug#26070: 26.0.50; js-mode slash insertion bug To: Tom Tromey Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26070 Cc: 26070@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 14 March 2017 at 11:06, Tom Tromey wrote: >>>>>> "Dmitry" == Dmitry Gutov writes: > >>> I think once js-syntax-propertize is called, the regexp should always >>> succeed, so this patch makes the trailing "/" optional. > > Dmitry> Does it solve the infloop in the case like: > Dmitry> /x[ > Dmitry> as well? > > Yes, with the patch I don't get an infloop no matter which way I insert > those characters. > > Tom Caught one! Insert the text below in a JS-mode buffer, go to the beginning of the blank first line in function h() and type "/". There is an infloop. The infloop doesn't happen if the "/" in function g() is changed to a different operator. You can replace the 0s with other stuff, but you need at least that many characters (delete a 0 or a space and there is no infloop). function f() { function g() { 1 / 2; } function h() { 00000000000000000000000000000000000000000000000000; 00000000000000000000000000000000000000000000000000; 00000000000000000000000000000000000000000000000000; 00000000000000000000000000000000000000000000000000; 00000000000000000000000000000000000000000000000000; 00000000000000000000000000000000000000000000000000; 00000000000000000000000000000000000000000000000000; 00000000000000000000000000000000000000000000000000; 00; } } From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 22 18:18:44 2017 Received: (at 26070) by debbugs.gnu.org; 22 Mar 2017 22:18:44 +0000 Received: from localhost ([127.0.0.1]:39876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqoaZ-0005D9-Uh for submit@debbugs.gnu.org; Wed, 22 Mar 2017 18:18:44 -0400 Received: from gproxy8-pub.mail.unifiedlayer.com ([67.222.33.93]:43071) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cqoaY-0005Cx-Ox for 26070@debbugs.gnu.org; Wed, 22 Mar 2017 18:18:43 -0400 Received: (qmail 24092 invoked by uid 0); 22 Mar 2017 22:18:31 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy8.mail.unifiedlayer.com with SMTP; 22 Mar 2017 22:18:31 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id zAJS1u00S2f2jeq01AJVca; Wed, 22 Mar 2017 16:18:31 -0600 X-Authority-Analysis: v=2.1 cv=WOnsABcR c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=6Iz7jQTuP9IA:10 a=WiVod9pSvdkA:10 a=pGLkceISAAAA:8 a=YIav_BNCZuY3VWfh3wwA:9 a=6kGIvZw6iX1k4Y-7sg4_:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=41bBYHIPdfBdjlq+fpZoFj+qxGXWaz4ZsMRdbFLwAGI=; b=PBSpGWaX+RATDBw9yRRrjuwyoM tCNLtHyHm6XC6xExDKLS1/qZ+YqvCQpdohSR/bbsCshu1RDh11zlz567AujRw1xWMIEmwTfsd0u6l Jxk5xKPIfRuWL4PgSxdc3eXu4; Received: from 97-118-172-192.hlrn.qwest.net ([97.118.172.192]:52446 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cqoaI-0007cA-45; Wed, 22 Mar 2017 16:18:26 -0600 From: Tom Tromey To: Richard Copley Subject: Re: bug#26070: 26.0.50; js-mode slash insertion bug References: <87wpbt8ev3.fsf@pokyo> <87fuig86ed.fsf@pokyo> X-Attribution: Tom Date: Wed, 22 Mar 2017 16:18:22 -0600 In-Reply-To: (Richard Copley's message of "Sun, 19 Mar 2017 11:22:32 +0000") Message-ID: <87lgrx0xch.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.172.192 X-Exim-ID: 1cqoaI-0007cA-45 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-172-192.hlrn.qwest.net (bapiya) [97.118.172.192]:52446 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26070 Cc: 26070@debbugs.gnu.org, Tom Tromey , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) >>>>> "Richard" == Richard Copley writes: Richard> Caught one! Thank you. Richard> Insert the text below in a JS-mode buffer, go to the beginning of the Richard> blank first line in function h() and type "/". There is an infloop. How did you find this? I'm very curious. Anyway, please try this patch on top of the previous one I sent. Or if you'd prefer I can send a combined patch. Tom diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index fa865db..c220353 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -1722,12 +1722,13 @@ js-syntax-propertize-regexp (when (eq (nth 3 ppss) ?/) ;; A /.../ regexp. (goto-char (nth 8 ppss)) - (when (and (looking-at js--syntax-propertize-regexp-regexp) - ;; Don't touch text after END. - (or (not (match-end 1)) (<= (match-end 1) end))) - (put-text-property (match-beginning 1) (or (match-end 1) (match-end 0)) + (when (looking-at js--syntax-propertize-regexp-regexp) + ;; Don't touch text after END. + (when (> end (match-end 1)) + (setq end (match-end 1))) + (put-text-property (match-beginning 1) end 'syntax-table (string-to-syntax "\"/")) - (goto-char (match-end 0)))))) + (goto-char end))))) (defun js-syntax-propertize (start end) ;; JavaScript allows immediate regular expression objects, written /.../. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 03:01:36 2017 Received: (at 26070) by debbugs.gnu.org; 23 Mar 2017 07:01:36 +0000 Received: from localhost ([127.0.0.1]:40072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqwkZ-0001O7-R1 for submit@debbugs.gnu.org; Thu, 23 Mar 2017 03:01:35 -0400 Received: from mail-ua0-f178.google.com ([209.85.217.178]:33136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqwkY-0001Nv-3M for 26070@debbugs.gnu.org; Thu, 23 Mar 2017 03:01:34 -0400 Received: by mail-ua0-f178.google.com with SMTP id u30so89008410uau.0 for <26070@debbugs.gnu.org>; Thu, 23 Mar 2017 00:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AaHOlGjVqhjB32IQZGsEez50hnMVSMZH6x26GnYzE54=; b=mcQfoRyGSuRljzEhII5JWSCogil6jsX/ulG2Y0rB/EfCq9qwQmlqjpk+VnjaWp/oiL VOUkpGCiyA2peMJguShFQKsDHS7AF6jngtJwD6ND0GYamAZgNiNbrvIObiMEbyffcRaq bH/6z+yZwZZIiEy3rcxYFE5IiX1W92oCA375Q4aYBI1OEuS2bwxJdwuqXMdV+kw8J9nT 6uC9ZorT7+8yzeAIz3PxoGuBWOhrbN+CTTQ2n2GC4kAJiDhMbuLhfNkw4O3DdZyaDGyV ui6pRZksLKLvYSih4Q5q5d3UYmm3NL+cCc1GzWBobx4NpeYjm7W74yWltZspGCGhNJlT YkXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AaHOlGjVqhjB32IQZGsEez50hnMVSMZH6x26GnYzE54=; b=fRQqm/VzwzZjqF0+p/aqufnfe4hMJNyKbmI9jBqCBv/WSo3CjavDfmIDXHiP8CAYYA OBkV6Yc22p8aOydQCY/8XXe6jgjB68XCL2lu7jUtQygajBKpFclH6ns6vvNZAybcDzmO 4mU205OTrtPcXZU185sFg9XQX8WAnLFCARCp0sDDmONqCQULNxA7AETdpb1ynXz50RdG 4JfC+MGsmK7XFG3ODZbLBIixlwlCdPG6f5R8IwTSxISz5JAI7PsZd4XmivuoC7CbSnNS PdKJJ8A8psktQ1OH+13SyulI+yt+UPoviqOEeuku+RkOGJoiiqLPuRVlMXsUm0hdAQa4 Ti1w== X-Gm-Message-State: AFeK/H1120La5XWVDlXHjtdNzCJ3EnlMcANYPwvI21pkNR14eHRRSoRk28s5b6DujlYFRWVwTUH3GhkwuWNv6Q== X-Received: by 10.159.48.87 with SMTP id i23mr463180uab.52.1490252488335; Thu, 23 Mar 2017 00:01:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.71.214 with HTTP; Thu, 23 Mar 2017 00:00:58 -0700 (PDT) In-Reply-To: <87lgrx0xch.fsf@tromey.com> References: <87wpbt8ev3.fsf@pokyo> <87fuig86ed.fsf@pokyo> <87lgrx0xch.fsf@tromey.com> From: Richard Copley Date: Thu, 23 Mar 2017 07:00:58 +0000 Message-ID: Subject: Re: bug#26070: 26.0.50; js-mode slash insertion bug To: Tom Tromey Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26070 Cc: 26070@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 22 March 2017 at 22:18, Tom Tromey wrote: >>>>>> "Richard" == Richard Copley writes: > > Richard> Caught one! > > Thank you. > > Richard> Insert the text below in a JS-mode buffer, go to the beginning of the > Richard> blank first line in function h() and type "/". There is an infloop. > > How did you find this? I'm very curious. I didn't go looking. The recipe is reduced from a program I was writing. The infloop happened when I went to comment out a line. Would have happened to somebody sooner or later :) > Anyway, please try this patch on top of the previous one I sent. Seems good, thanks very much. > Or if you'd prefer I can send a combined patch. > > Tom > > diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el > index fa865db..c220353 100644 > --- a/lisp/progmodes/js.el > +++ b/lisp/progmodes/js.el > @@ -1722,12 +1722,13 @@ js-syntax-propertize-regexp > (when (eq (nth 3 ppss) ?/) > ;; A /.../ regexp. > (goto-char (nth 8 ppss)) > - (when (and (looking-at js--syntax-propertize-regexp-regexp) > - ;; Don't touch text after END. > - (or (not (match-end 1)) (<= (match-end 1) end))) > - (put-text-property (match-beginning 1) (or (match-end 1) (match-end 0)) > + (when (looking-at js--syntax-propertize-regexp-regexp) > + ;; Don't touch text after END. > + (when (> end (match-end 1)) > + (setq end (match-end 1))) > + (put-text-property (match-beginning 1) end > 'syntax-table (string-to-syntax "\"/")) > - (goto-char (match-end 0)))))) > + (goto-char end))))) > > (defun js-syntax-propertize (start end) > ;; JavaScript allows immediate regular expression objects, written /.../. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 23:53:35 2017 Received: (at 26070) by debbugs.gnu.org; 24 Mar 2017 03:53:35 +0000 Received: from localhost ([127.0.0.1]:41614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crGIB-0006O9-9r for submit@debbugs.gnu.org; Thu, 23 Mar 2017 23:53:35 -0400 Received: from gproxy5-pub.mail.unifiedlayer.com ([67.222.38.55]:37049) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1crGI9-0006Nv-4g for 26070@debbugs.gnu.org; Thu, 23 Mar 2017 23:53:33 -0400 Received: (qmail 20967 invoked by uid 0); 24 Mar 2017 03:53:19 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy5.mail.unifiedlayer.com with SMTP; 24 Mar 2017 03:53:19 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id zftC1u0062f2jeq01ftF4b; Thu, 23 Mar 2017 21:53:19 -0600 X-Authority-Analysis: v=2.1 cv=R4+QR7hX c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=6Iz7jQTuP9IA:10 a=WiVod9pSvdkA:10 a=zstS-IiYAAAA:8 a=GM1t2KiBM_GhJYaLIXUA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Dryo2szjwOASZ8F88ckgZbj5ZjMn+belqyP119k3o9w=; b=vY1MgK5qSN1kuYbUfLMFsfokAW dX0EC7SHiOPw0R+lteGPxSNZkOso6QdQa1etrKR0p9RoTb34fLCO0FBcxRmbsddIq3Nr+KzGJo4hg psyAa9hreblG0kOibNY2fGrcj; Received: from 75-166-14-202.hlrn.qwest.net ([75.166.14.202]:35822 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1crGHo-0006LI-DZ; Thu, 23 Mar 2017 21:53:12 -0600 From: Tom Tromey To: Richard Copley Subject: Re: bug#26070: 26.0.50; js-mode slash insertion bug References: <87wpbt8ev3.fsf@pokyo> <87fuig86ed.fsf@pokyo> <87lgrx0xch.fsf@tromey.com> X-Attribution: Tom Date: Thu, 23 Mar 2017 21:53:11 -0600 In-Reply-To: (Richard Copley's message of "Thu, 23 Mar 2017 07:00:58 +0000") Message-ID: <87d1d71gbc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.14.202 X-Exim-ID: 1crGHo-0006LI-DZ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-14-202.hlrn.qwest.net (bapiya) [75.166.14.202]:35822 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26070 Cc: 26070@debbugs.gnu.org, Tom Tromey , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Richard> Seems good, thanks very much. Thanks for giving it a try. Here's the latest version of these two patches, with test cases. Dmitry, please let me know what you think. Tom commit ff870ef0324a3e5c43cf2d183df5db72e824efca Author: Tom Tromey Date: Mon Mar 13 21:53:59 2017 +0100 fix two js-mode syntax propertization bugs Bug#26070: * lisp/progmodes/js.el (js--syntax-propertize-regexp-regexp): Add zero-or-one to regular expression. (js-syntax-propertize-regexp): Update. Propertize body of regexp literal up to END. * test/lisp/progmodes/js-tests.el (js-mode-propertize-bug-1) (js-mode-propertize-bug-2): New tests. diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index aed42a8..3c720c0 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -1713,7 +1713,7 @@ js--syntax-propertize-regexp-regexp (not (any ?\] ?\\)) (and "\\" not-newline))) "]"))) - (group "/")) + (group (zero-or-one "/"))) "Regular expression matching a JavaScript regexp literal.") (defun js-syntax-propertize-regexp (end) @@ -1721,12 +1721,13 @@ js-syntax-propertize-regexp (when (eq (nth 3 ppss) ?/) ;; A /.../ regexp. (goto-char (nth 8 ppss)) - (when (and (looking-at js--syntax-propertize-regexp-regexp) - ;; Don't touch text after END. - (<= (match-end 1) end)) - (put-text-property (match-beginning 1) (match-end 1) + (when (looking-at js--syntax-propertize-regexp-regexp) + ;; Don't touch text after END. + (when (> end (match-end 1)) + (setq end (match-end 1))) + (put-text-property (match-beginning 1) end 'syntax-table (string-to-syntax "\"/")) - (goto-char (match-end 0)))))) + (goto-char end))))) (defun js-syntax-propertize (start end) ;; JavaScript allows immediate regular expression objects, written /.../. diff --git a/test/lisp/progmodes/js-tests.el b/test/lisp/progmodes/js-tests.el index e030675..8e1bac1 100644 --- a/test/lisp/progmodes/js-tests.el +++ b/test/lisp/progmodes/js-tests.el @@ -140,6 +140,43 @@ (font-lock-ensure) (should (eq (get-text-property (point) 'face) (caddr test)))))) +(ert-deftest js-mode-propertize-bug-1 () + (with-temp-buffer + (js-mode) + (save-excursion (insert "x")) + (insert "/") + ;; The bug was a hang. + (should t))) + +(ert-deftest js-mode-propertize-bug-2 () + (with-temp-buffer + (js-mode) + (insert "function f() { + function g() + { + 1 / 2; + } + + function h() { +") + (save-excursion + (insert " + 00000000000000000000000000000000000000000000000000; + 00000000000000000000000000000000000000000000000000; + 00000000000000000000000000000000000000000000000000; + 00000000000000000000000000000000000000000000000000; + 00000000000000000000000000000000000000000000000000; + 00000000000000000000000000000000000000000000000000; + 00000000000000000000000000000000000000000000000000; + 00000000000000000000000000000000000000000000000000; + 00; + } +} +")) + (insert "/") + ;; The bug was a hang. + (should t))) + (provide 'js-tests) ;;; js-tests.el ends here From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 31 03:53:48 2017 Received: (at 26070) by debbugs.gnu.org; 31 Mar 2017 07:53:48 +0000 Received: from localhost ([127.0.0.1]:53524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctrNU-000387-N5 for submit@debbugs.gnu.org; Fri, 31 Mar 2017 03:53:48 -0400 Received: from mail-wr0-f182.google.com ([209.85.128.182]:33077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctrNS-00037t-Qu for 26070@debbugs.gnu.org; Fri, 31 Mar 2017 03:53:47 -0400 Received: by mail-wr0-f182.google.com with SMTP id w43so93411092wrb.0 for <26070@debbugs.gnu.org>; Fri, 31 Mar 2017 00:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FqZf5Nt7//XdSLTE6zNq46Xanfdcej4J7UCXfvww4iw=; b=XCd0Cu/9jaFxFhVtb8PxuJemC7rQUfsP/cCpd3W7pad7U9PnNKaI3sGtIf5axCQx+q a7MivYUfG0ym0kUG+iSm5AIxOS6UQgOsY4b1da6irv5yKqkoIhBuACanVmlCcNxSUj4N brgw/+bUBatBQkE1ocxyUTX1/DnmLqFaYFSxSDqFAwFbx7gdk5loVZ09SlHDvi92jrHR gUBD5IAqFFjaLzgCXVJG48WLN189ETcZo0OpHP+iYsrEsdIo/Gy6HPZ0zYG+0oJS9T1+ JKqEhWuQjm6vbYufYxMawM301WQM0dDN4O2LVqYnU/oZjGP6pYYfOmloa/j8y3Z8tW/h WTsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FqZf5Nt7//XdSLTE6zNq46Xanfdcej4J7UCXfvww4iw=; b=UWcTvzCqIU3/Mows7Ym5gg7S7ZFAhNGaXM39fsDxE+wcUXXCxEh2h4WAWzCNXV88ke 7GjBv030PqfkeBBkB/VzYJnZ28ZovlpX4Ssg8Kd6Hp3xF+Jqvy9ltv53DZ//LdbBayhZ /BWH0Pil9lgpr/qE0PVxoyt1+WDgdLROHFL0FgUHNVQw/2zy79p8YkXtEXqMWKXfNbN2 s24qJrnnRM4eUQq0kedYuC/C0epAOMdKYgDpJIE6kwHu13R7RO4nPVyh8UFMIFRvcH3h WAISKZAgYpaBTDbNg0llfDKsnzl3ppcnfDhiVi4157jFV/HMEqCYBhx7aKZXhEwHCD0k YHsQ== X-Gm-Message-State: AFeK/H1QMNlQ3e93DecrQ0vG5y4kqflp3kSc2XFYCZUW5CLAx08L8TCjpPUaXu3OKwUgyw== X-Received: by 10.28.13.65 with SMTP id 62mr1439140wmn.1.1490946820912; Fri, 31 Mar 2017 00:53:40 -0700 (PDT) Received: from [192.168.1.3] ([185.105.173.156]) by smtp.googlemail.com with ESMTPSA id i133sm1852643wmg.26.2017.03.31.00.53.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Mar 2017 00:53:40 -0700 (PDT) Subject: Re: bug#26070: 26.0.50; js-mode slash insertion bug To: Tom Tromey , Richard Copley References: <87wpbt8ev3.fsf@pokyo> <87fuig86ed.fsf@pokyo> <87lgrx0xch.fsf@tromey.com> <87d1d71gbc.fsf@tromey.com> From: Dmitry Gutov Message-ID: Date: Fri, 31 Mar 2017 10:53:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <87d1d71gbc.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 26070 Cc: 26070@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 24.03.2017 05:53, Tom Tromey wrote: > Here's the latest version of these two patches, with test cases. > Dmitry, please let me know what you think. It's okay with me, thanks. As long as we're sure that js--syntax-propertize-regexp-regexp will always match. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 17:15:42 2017 Received: (at 26070-done) by debbugs.gnu.org; 1 Apr 2017 21:15:43 +0000 Received: from localhost ([127.0.0.1]:55997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuQN4-0001t6-OE for submit@debbugs.gnu.org; Sat, 01 Apr 2017 17:15:42 -0400 Received: from gproxy9-pub.mail.unifiedlayer.com ([69.89.20.122]:53194 helo=gproxy9.mail.unifiedlayer.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuQN3-0001sg-0K for 26070-done@debbugs.gnu.org; Sat, 01 Apr 2017 17:15:41 -0400 Received: from cmgw3 (unknown [10.0.90.84]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id 075F01E09B4 for <26070-done@debbugs.gnu.org>; Sat, 1 Apr 2017 15:15:34 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id 39FV1v00i2f2jeq019FYsc; Sat, 01 Apr 2017 15:15:34 -0600 X-Authority-Analysis: v=2.2 cv=VKStp5HX c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=AzvcPWV-tVgA:10 a=h0JqVpTDDR_UVJJZ95UA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9royt92FP4AiUfH1Q0/qmoU6DplYlZ3auJzrx6XZSSU=; b=Z1dg6UVKQYctdlKlWBZEjidcK9 qYVzKNb1oDPzbz9vQjdJig7vWngtUeg4RBK4QbxOjgsulvomfOQwmgREf0m8E45IJD0qE1+HICbJy xPrb3U/OfGm/smt/HcqiD1w3X; Received: from 75-166-65-226.hlrn.qwest.net ([75.166.65.226]:54148 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cuQMr-0004b5-Gu; Sat, 01 Apr 2017 15:15:29 -0600 From: Tom Tromey To: 26070-done@debbugs.gnu.org Subject: fixed X-Attribution: Tom Date: Sat, 01 Apr 2017 15:15:28 -0600 Message-ID: <87d1cv3k3z.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.65.226 X-Exim-ID: 1cuQMr-0004b5-Gu X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-65-226.hlrn.qwest.net (bapiya) [75.166.65.226]:54148 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26070-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) I've checked in the patch. Tom From unknown Thu Jun 19 14:03:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 30 Apr 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator